kibi-cli 0.19.0 → 2.0.0

package/src/public/impact/coverage-depth-quality.ts

@@ -136,7 +136,7 @@ function isReviewableCoverageDepth(
   );
 }
 
-function uniqueStrings(values: readonly string[]): readonly string[] {
+export function uniqueStrings(values: readonly string[]): readonly string[] {
   return [...new Set(values)].toSorted((left, right) =>
     left.localeCompare(right),
   );
@@ -153,10 +153,24 @@ function coverageDepthSuggestion(
 
 function createDiagnostic(
   coverage: RequirementCoverage,
+  proofEvidence:
+    | Readonly<{
+        readonly proofStatus?: string;
+        readonly passingE2eStatus?: string;
+        readonly passingE2eTests?: readonly string[];
+        readonly receiptGapCodes?: readonly string[];
+      }>
+    | undefined,
 ): QualityDiagnostic | undefined {
   const coverageDepth = classifyCoverageDepth(coverage);
   if (!isReviewableCoverageDepth(coverageDepth)) return undefined;
 
+  // Structural coverage and conservative proof are separate lanes. A current
+  // scenario-backed E2E receipt is strong execution evidence even when the
+  // requirement remains unresolved for ontology, symbol, or coordinate gaps.
+  // Do not emit a contradictory weak-depth review in that case.
+  if (proofEvidence?.passingE2eStatus === "passed") return undefined;
+
   const allTests = uniqueEntities([
     ...coverage.directTests,
     ...coverage.scenarioTests,
@@ -180,6 +194,18 @@ function createDiagnostic(
       scenarioTests: coverage.scenarioTests.map((test) => test.id),
       testStatuses: uniqueStrings(allTests.map((test) => test.status)),
       verificationScopes: uniqueStrings(allTests.map(testScope)),
+      ...(proofEvidence?.proofStatus !== undefined
+        ? { proofStatus: proofEvidence.proofStatus }
+        : {}),
+      ...(proofEvidence?.passingE2eStatus !== undefined
+        ? { passingE2eStatus: proofEvidence.passingE2eStatus }
+        : {}),
+      ...(proofEvidence?.passingE2eTests !== undefined
+        ? { passingE2eTests: [...proofEvidence.passingE2eTests] }
+        : {}),
+      ...(proofEvidence?.receiptGapCodes !== undefined
+        ? { receiptGapCodes: [...proofEvidence.receiptGapCodes] }
+        : {}),
     },
   };
 }
@@ -252,6 +278,15 @@ function coverageForRequirement(
 
 export function createCoverageDepthQualityDiagnostics(
   manifestResults: readonly ExtractionResult[],
+  proofByRequirement: ReadonlyMap<
+    string,
+    Readonly<{
+      readonly proofStatus?: string;
+      readonly passingE2eStatus?: string;
+      readonly passingE2eTests?: readonly string[];
+      readonly receiptGapCodes?: readonly string[];
+    }>
+  > = new Map(),
 ): readonly QualityDiagnostic[] {
   const entities = entitiesById(manifestResults);
   return manifestResults
@@ -259,6 +294,7 @@ export function createCoverageDepthQualityDiagnostics(
     .flatMap((result) => {
       const diagnostic = createDiagnostic(
         coverageForRequirement(result, manifestResults, entities),
+        proofByRequirement.get(result.entity.id),
       );
       return diagnostic === undefined ? [] : [diagnostic];
     })

package/src/public/impact/diagnostics.ts

@@ -7,6 +7,7 @@ import {
   extractSymbolsFromStagedFile,
 } from "../../traceability/symbol-extract.js";
 import {
+  ALLOWED_GRANULARITY_REASONS_PROSE,
   getBehavioralSymbolNames,
   getNonBehavioralSymbolNames,
   isAllowedGranularityReason,
@@ -151,7 +152,7 @@ export function createSymbolGranularityDiagnostics(
       files: [result.entity.source, result.sourceFile],
       docs: ["docs/symbol-traceability-taxonomy.md"],
       message: `Symbol ${result.entity.id} links ${result.sourceFile} coarsely while granular symbols are available (behavioral only): ${behavioralNames.join(", ")}`,
-      suggestion: `Move ownership/coverage/test relationships to the narrow behavioral symbol, add a manifest behavioral anchor, or add granularity_reason with config-artifact, module-level-behavior, extractor-miss, or legacy-link when the coarse symbol is intentional.${ignoredSymbolsSuggestion}`,
+      suggestion: `Move ownership/coverage/test relationships to the narrow behavioral symbol, add a manifest behavioral anchor, or add granularity_reason with ${ALLOWED_GRANULARITY_REASONS_PROSE} when the coarse symbol is intentional.${ignoredSymbolsSuggestion}`,
     });
   }
 

package/src/public/impact/diff-meaning.ts

@@ -1,3 +1,13 @@
+export function isTrailingCommaBeforeCloser(
+  character: string,
+  nextCharacter: string | undefined,
+): boolean {
+  return (
+    character === "," &&
+    (nextCharacter === ")" || nextCharacter === "]" || nextCharacter === "}")
+  );
+}
+
 function normalizeDiffContent(line: string): string {
   let normalized = "";
   let quote: '"' | "'" | "`" | null = null;
@@ -62,10 +72,7 @@ function removeSyntacticTrailingCommas(content: string): string {
     }
 
     const nextCharacter = content[index + 1];
-    if (
-      character === "," &&
-      (nextCharacter === ")" || nextCharacter === "]" || nextCharacter === "}")
-    ) {
+    if (isTrailingCommaBeforeCloser(character, nextCharacter)) {
       continue;
     }