keystone-cli 0.4.0 → 0.4.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "keystone-cli",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "description": "A local-first, declarative, agentic workflow orchestrator built on Bun",
   "type": "module",
   "bin": {
@@ -58,4 +58,4 @@
   "engines": {
     "bun": ">=1.0.0"
   }
-}
+}

package/src/runner/llm-executor.ts

@@ -237,7 +237,7 @@ export async function executeLlmStep(
         if (step.schema && typeof output === 'string') {
           try {
             const { extractJson } = await import('../utils/json-parser');
-            output = extractJson(output);
+            output = extractJson(output) as typeof output;
           } catch (e) {
             throw new Error(
               `Failed to parse LLM output as JSON matching schema: ${e instanceof Error ? e.message : String(e)}\nOutput: ${output}`

package/src/runner/mcp-server.test.ts

@@ -81,7 +81,7 @@ describe('MCPServer', () => {
       },
     });
 
-    expect(JSON.parse(response.result.content[0].text).status).toBe('success');
+    expect(JSON.parse(response?.result?.content?.[0]?.text || '{}').status).toBe('success');
   });
 
   it('should handle run_workflow failure', async () => {
@@ -130,7 +130,7 @@ describe('MCPServer', () => {
       },
     });
 
-    const result = JSON.parse(response?.result?.content?.[0]?.text);
+    const result = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(result.status).toBe('paused');
     expect(result.run_id).toBe('run123');
     expect(result.message).toBe('Input needed');
@@ -163,7 +163,7 @@ describe('MCPServer', () => {
       },
     });
 
-    expect(JSON.parse(response.result.content[0].text).status).toBe('success');
+    expect(JSON.parse(response?.result?.content?.[0]?.text || '{}').status).toBe('success');
 
     // Verify DB was updated
     const steps = db.getStepsByRun(runId);
@@ -187,7 +187,7 @@ describe('MCPServer', () => {
       params: { name: 'get_run_logs', arguments: { run_id: runId } },
     });
 
-    const summary = JSON.parse(response?.result?.content?.[0]?.text);
+    const summary = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(summary.workflow).toBe('test-wf');
     expect(summary.steps).toHaveLength(1);
     expect(summary.steps[0].step).toBe('s1');
@@ -276,7 +276,7 @@ describe('MCPServer', () => {
       },
     });
 
-    const result = JSON.parse(response?.result?.content?.[0]?.text);
+    const result = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(result.status).toBe('running');
     expect(result.run_id).toBe('async-run-123');
     expect(result.hint).toContain('get_run_status');
@@ -294,7 +294,7 @@ describe('MCPServer', () => {
       params: { name: 'get_run_status', arguments: { run_id: runId } },
     });
 
-    const status = JSON.parse(response?.result?.content?.[0]?.text);
+    const status = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(status.run_id).toBe(runId);
     expect(status.workflow).toBe('test-wf');
     expect(status.status).toBe('running');
@@ -313,7 +313,7 @@ describe('MCPServer', () => {
       params: { name: 'get_run_status', arguments: { run_id: runId } },
     });
 
-    const status = JSON.parse(response?.result?.content?.[0]?.text);
+    const status = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(status.status).toBe('completed');
     expect(status.outputs).toEqual({ output: 'done' });
     expect(status.hint).toBeUndefined();
@@ -331,7 +331,7 @@ describe('MCPServer', () => {
       params: { name: 'get_run_status', arguments: { run_id: runId } },
     });
 
-    const status = JSON.parse(response?.result?.content?.[0]?.text);
+    const status = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(status.status).toBe('failed');
     expect(status.error).toBe('Something went wrong');
   });
@@ -348,7 +348,7 @@ describe('MCPServer', () => {
       params: { name: 'get_run_status', arguments: { run_id: runId } },
     });
 
-    const status = JSON.parse(response?.result?.content?.[0]?.text);
+    const status = JSON.parse(response?.result?.content?.[0]?.text || '{}');
     expect(status.status).toBe('paused');
     expect(status.hint).toContain('answer_human_input');
   });

package/src/templates/agents/keystone-architect.md

@@ -54,6 +54,14 @@ Markdown files with YAML frontmatter:
 - **Clarification**: Enable `allowClarification` in `llm` steps if the agent should be able to ask the user for missing info.
 - **Discovery**: Use `mcpServers` in `llm` steps when the agent needs access to external tools or systems. `mcpServers` can be a list of server names or configuration objects `{ name, command, args, env }`.
 
+# Seeking Clarification
+If you have access to an `ask` tool and the user requirements are unclear, **use it** before generating output. Ask about:
+- Ambiguous scope or missing details (e.g., "Should this workflow support multiple file formats?")
+- Integration points (e.g., "Which MCP servers should be available to the agent?")
+- Error handling preferences (e.g., "Should the workflow retry on failure or fail fast?")
+
+Only ask **essential** questions. Don't over-clarify obvious requirements.
+
 # Output Instructions
 When asked to design a feature:
 1. Provide the necessary Keystone files (Workflows and Agents).

package/src/templates/scaffold-feature.yaml

@@ -11,6 +11,7 @@ steps:
     type: llm
     agent: keystone-architect
     needs: [get_requirements]
+    allowClarification: true
     prompt: |
       The user wants to build the following:
       <user_requirements>