keybase-proofs 2.3.28 → 2.3.29

package/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.3.29 (2024-07-22)
+
+- Fix Twitter scraper to handle empty result list case.
+
 ## 2.3.28 (2024-07-19)
 
 - Use version 2 API for X (formerly known as Twitter) hunting.

package/lib/scrapers/twitter.js

@@ -133,19 +133,23 @@
         });
       })(this)((function(_this) {
         return function() {
-          var _i, _len, _ref1, _ref2;
+          var _i, _len, _ref1, _ref2, _ref3;
           _this.log("| search index " + u + " -> " + rc);
           if (rc !== v_codes.OK) {
 
           } else if ((typeof json === "undefined" || json === null) || (json.length === 0)) {
             rc = v_codes.EMPTY_JSON;
           } else if (json.data == null) {
-            rc = v_codes.INVALID_JSON;
+            if (((_ref1 = json.meta) != null ? _ref1.result_count : void 0) === 0) {
+              rc = v_codes.NOT_FOUND;
+            } else {
+              rc = v_codes.INVALID_JSON;
+            }
           } else {
             rc = v_codes.NOT_FOUND;
-            _ref1 = json.data;
-            for (i = _i = 0, _len = _ref1.length; _i < _len; i = ++_i) {
-              _ref2 = _ref1[i], text = _ref2.text, id = _ref2.id;
+            _ref2 = json.data;
+            for (i = _i = 0, _len = _ref2.length; _i < _len; i = ++_i) {
+              _ref3 = _ref2[i], text = _ref3.text, id = _ref3.id;
               if ((_this.find_sig_in_tweet({
                 inside: text,
                 proof_text_check: proof_text_check
@@ -231,7 +235,7 @@
                       return json = arguments[2];
                     };
                   })(),
-                  lineno: 123
+                  lineno: 129
                 }));
                 __iced_deferrals._fulfill();
               })(function() {
@@ -265,7 +269,7 @@
                                     funcname: "TwitterScraper.users_lookup"
                                   });
                                   setTimeout(__iced_deferrals.defer({
-                                    lineno: 137
+                                    lineno: 143
                                   }), cursor_wait);
                                   __iced_deferrals._fulfill();
                                 })(__iced_k);
@@ -360,7 +364,7 @@
                       return json = arguments[2];
                     };
                   })(),
-                  lineno: 175
+                  lineno: 181
                 }));
                 __iced_deferrals._fulfill();
               })(function() {
@@ -397,7 +401,7 @@
                                     funcname: "TwitterScraper.get_follower_ids"
                                   });
                                   setTimeout(__iced_deferrals.defer({
-                                    lineno: 191
+                                    lineno: 197
                                   }), cursor_wait);
                                   __iced_deferrals._fulfill();
                                 })(__iced_k);
@@ -513,7 +517,7 @@
                 return body_obj = arguments[2];
               };
             })(),
-            lineno: 282
+            lineno: 288
           }));
           __iced_deferrals._fulfill();
         });
@@ -596,7 +600,7 @@
                 return tok = arguments[1];
               };
             })(),
-            lineno: 343
+            lineno: 349
           }));
           __iced_deferrals._fulfill();
         });
@@ -629,7 +633,7 @@
                 return tok = arguments[2];
               };
             })(),
-            lineno: 352
+            lineno: 358
           }));
           __iced_deferrals._fulfill();
         });
@@ -662,7 +666,7 @@
                       return body = arguments[2];
                     };
                   })(),
-                  lineno: 363
+                  lineno: 369
                 }));
                 __iced_deferrals._fulfill();
               })(__iced_k);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "keybase-proofs",
-  "version": "2.3.28",
+  "version": "2.3.29",
   "description": "Publicly-verifiable proofs of identity",
   "main": "lib/main.js",
   "scripts": {

package/src/scrapers/twitter.iced

@@ -75,7 +75,13 @@ exports.TwitterScraper = class TwitterScraper extends BaseScraper
     @log "| search index #{u} -> #{rc}"
     if rc isnt v_codes.OK then #noop
     else if not json? or (json.length is 0) then rc = v_codes.EMPTY_JSON
-    else if not json.data? then rc = v_codes.INVALID_JSON
+    else if not json.data?
+      if json.meta?.result_count is 0
+        # No results.
+        rc = v_codes.NOT_FOUND
+      else
+        # Unknown JSON structure.
+        rc = v_codes.INVALID_JSON
     else
       rc = v_codes.NOT_FOUND
       for {text, id},i in json.data