kenaz 0.3.22 → 0.3.24

package/vendor/install-kenaz-cli.js

@@ -14,7 +14,7 @@ const fs = require('fs');
 const os = require('os');
 const path = require('path');
 const http = require('http');
-const { spawnSync } = require('child_process');
+const { spawnSync, spawn } = require('child_process');
 
 const ENV_KEY = 'CLAUDE_CODE_PLUGIN_DIRS';
 const BACKUP = 'settings.json.bak-kenaz-peer'; // shared with the Rust path on purpose: one backup of the pristine file
@@ -22,6 +22,9 @@ const MIN_CLI = [2, 1, 287];
 const SEP = process.platform === 'win32' ? ';' : ':';
 const TASK_NAME = 'KenazServer';
 const LABEL = 'ai.kenaz.server';
+const RUN_KEY = 'HKCU\\Software\\Microsoft\\Windows\\CurrentVersion\\Run';
+const BATTERY_PS = '$s = New-ScheduledTaskSettingsSet -AllowStartIfOnBatteries -DontStopIfGoingOnBatteries -ExecutionTimeLimit ([TimeSpan]::Zero); Set-ScheduledTask -TaskName ' + TASK_NAME + ' -Settings $s';
+const linuxUser = () => { try { return os.userInfo().username; } catch (_) { return process.env.USER || ''; } };
 
 const norm = (e) => {
   const s = String(e).trim().replace(/\\/g, '/').replace(/\/+$/, '');
@@ -113,9 +116,14 @@ function unregisterStatusline(file, dry) {
 // agent-flow curl/node posts) duplicate what plugins/kenaz/hooks/hooks.json now runs. Single owner = the plugin, so
 // once it is registered these are removed (first write backs up the pristine file to settings.json.bak-kenaz-peer).
 const DASH_HOOK = /_user-scope\.js|[\\/]\.claude[\\/]hooks[\\/][\w.-]+\.js|\/api\/rust\/agent-flow\/hook/;
+// Field report 2026-10-19: Kenaz never wrote hooks into the user's own ~/.claude/hooks, so a hook there is the user's.
+const HOME_HOOKS = /(^|["'\s])(~|\$\{?HOME\}?|%USERPROFILE%)[\\/]\.claude[\\/]hooks[\\/]/i;
+const slashLower = (s) => s.replace(/\\/g, '/').toLowerCase();
 /** @returns number of hook commands retired */
 function retireDashboardHooks(file, dry) {
   if (!fs.existsSync(file)) return 0;
+  const homeHooks = slashLower(path.join(path.dirname(file), 'hooks')) + '/';
+  const isDash = (c) => DASH_HOOK.test(c) && !HOME_HOOKS.test(c) && !slashLower(c).includes(homeHooks);
   const v = loadSettings(file);
   if (!v.hooks || typeof v.hooks !== 'object' || Array.isArray(v.hooks)) return 0;
   let n = 0;
@@ -124,7 +132,7 @@ function retireDashboardHooks(file, dry) {
     const groups = [];
     for (const g of v.hooks[ev]) {
       if (!g || !Array.isArray(g.hooks)) { groups.push(g); continue; }
-      const kept = g.hooks.filter((h) => !(h && typeof h.command === 'string' && DASH_HOOK.test(h.command)));
+      const kept = g.hooks.filter((h) => !(h && typeof h.command === 'string' && isDash(h.command)));
       n += g.hooks.length - kept.length;
       if (kept.length) groups.push(kept.length === g.hooks.length ? g : { ...g, hooks: kept });
     }
@@ -136,20 +144,22 @@ function retireDashboardHooks(file, dry) {
 
 function claudeVersion() {
   const r = process.platform === 'win32' // one string with shell (.cmd shim): args + shell:true is deprecated (DEP0190)
-    ? spawnSync('claude --version', { encoding: 'utf8', shell: true, timeout: 15000 })
-    : spawnSync('claude', ['--version'], { encoding: 'utf8', timeout: 15000 });
+    ? spawnSync('claude --version', { windowsHide: true, encoding: 'utf8', shell: true, timeout: 15000 })
+    : spawnSync('claude', ['--version'], { windowsHide: true, encoding: 'utf8', timeout: 15000 });
   return r.status === 0 ? parseVersion(r.stdout) : null;
 }
 
 // ---- service definitions (pure; the OS calls are in service* below) ----
 function launcherPaths(home) {
   const d = path.join(home, '.kenaz');
-  return { dir: d, vbs: path.join(d, 'kenaz-server.vbs'), log: path.join(d, 'kenaz-server.log') };
+  return { dir: d, log: path.join(d, 'kenaz-server.log') };
 }
 const q = (s) => '"' + s + '"';
-function winVbs(bin, core) { // hidden window, env for task tools; server binds loopback by default
-  return 'Set sh = WScript.CreateObject("WScript.Shell")\r\nsh.Environment("Process")("KENAZ_SOURCE_DIR") = "' + core + '"\r\n' +
-    'sh.Run """' + bin + '""", 0, False\r\n';
+// TASK_2478: kenaz-server is a no-console binary on Windows and takes the core dir as an argument (no launcher script).
+function winRunCmd(bin, core) { return q(bin) + ' --source-dir ' + q(core); }
+// TASK_2478 migration: the old script-host launchers (antivirus flagged them); removed on install and uninstall.
+function legacyLaunchers(home, roaming) {
+  return [path.join(home, '.kenaz', 'kenaz-server.vbs'), path.join(roaming, 'Microsoft', 'Windows', 'Start Menu', 'Programs', 'Startup', 'KenazServer.vbs')]; // legacy-vbs-cleanup
 }
 // launchd and systemd start the server with a bare PATH (/usr/bin:/bin...), so `node` from Homebrew,
 // nvm or /usr/local was not found and every MCP tool that runs a node script failed with
@@ -195,8 +205,7 @@ function servicePlan(home, bin, core, platform = process.platform, caps = { syst
   const L = launcherPaths(home);
   if (platform === 'win32') {
     const roaming = home === os.homedir() && process.env.APPDATA ? process.env.APPDATA : path.join(home, 'AppData', 'Roaming');
-    const startup = path.join(roaming, 'Microsoft', 'Windows', 'Start Menu', 'Programs', 'Startup', 'KenazServer.vbs');
-    return { kind: 'windows', files: [[L.vbs, winVbs(bin, core)]], fallbackFile: startup };
+    return { kind: 'windows', files: [], bin, core, runCmd: winRunCmd(bin, core), legacy: legacyLaunchers(home, roaming) };
   }
   if (platform === 'darwin') {
     const p = path.join(home, 'Library', 'LaunchAgents', LABEL + '.plist');
@@ -208,7 +217,7 @@ function servicePlan(home, bin, core, platform = process.platform, caps = { syst
   const p = path.join(home, '.config', 'systemd', 'user', 'kenaz-server.service');
   return { kind: 'systemd', files: [[p, systemdUnit(bin, core)]], unit: p };
 }
-const sh = (cmd, args, opts) => spawnSync(cmd, args, { encoding: 'utf8', ...(opts || {}) });
+const sh = (cmd, args, opts) => spawnSync(cmd, args, { windowsHide: true, encoding: 'utf8', ...(opts || {}) });
 
 // crontab -l: null = no crontab binary; '' = binary present, no crontab yet. All through the injected `run`.
 function readCron(run) {
@@ -239,8 +248,7 @@ function restartHint(plan, uid = defaultUid()) {
   if (plan.kind === 'launchd') return 'launchctl kickstart -k gui/' + uid + '/' + LABEL;
   if (plan.kind === 'systemd') return 'systemctl --user restart kenaz-server';
   if (plan.kind === 'cron' || plan.kind === 'manual') return stopCmd(plan) + '; ' + detachedStartCmd(plan);
-  // the launcher works for both the scheduled task and the Startup-folder fallback (no admin rights needed)
-  return 'end kenaz-server.exe in Task Manager, then run: wscript.exe ' + q(plan.files && plan.files[0] ? plan.files[0][0] : 'kenaz-server.vbs');
+  return 'end kenaz-server.exe in Task Manager, then run: ' + plan.runCmd;
 }
 function serviceRestart(plan, dry, log, run = sh, uid = defaultUid()) {
   if (plan.kind === 'cron' || plan.kind === 'manual') { // no supervisor: start it (stopOwnServer freed the old one)
@@ -295,22 +303,28 @@ async function verifyRuntime(plan, expected, log, opts = {}) {
   return 'unreachable';
 }
 
-function serviceInstall(plan, dry, log, run = sh, uid) {
+function serviceInstall(plan, dry, log, run = sh, uid, spawnFn = spawn) {
   const sh = run; // injectable for tests; shadows the module-level spawnSync wrapper inside this function
   for (const [f, body] of plan.files) { log('write ' + f); if (!dry) { fs.mkdirSync(path.dirname(f), { recursive: true }); fs.writeFileSync(f, body); } }
   if (plan.kind === 'windows') {
-    const tr = 'wscript.exe ' + q(plan.files[0][0]);
-    log('schtasks /Create /TN ' + TASK_NAME + ' /SC ONLOGON /TR ' + tr + ' /F  (fallback: ' + plan.fallbackFile + ')');
+    const tr = plan.runCmd;
+    log('schtasks /Create /TN ' + TASK_NAME + ' /SC ONLOGON /TR ' + tr + ' /F  (fallback: ' + RUN_KEY + '\\' + TASK_NAME + ')');
+    removeLegacy(plan, dry, log);
     if (dry) return;
     const r = sh('schtasks', ['/Create', '/TN', TASK_NAME, '/SC', 'ONLOGON', '/TR', tr, '/F']);
-    if (r.status === 0) sh('schtasks', ['/Run', '/TN', TASK_NAME]);
-    else { // ONLOGON tasks can need elevation: a Startup-folder launcher is the per-user equivalent
-      fs.mkdirSync(path.dirname(plan.fallbackFile), { recursive: true });
-      fs.copyFileSync(plan.files[0][0], plan.fallbackFile);
-      sh('wscript.exe', [plan.files[0][0]]);
+    if (r.status === 0) {
+      // Task Scheduler defaults refuse to start on battery and stop the task when going on battery:
+      // a laptop unplugged at logon never got the server (TASK_2468). Re-running install fixes an old task.
+      const b = sh('powershell.exe', ['-NoProfile', '-NonInteractive', '-Command', BATTERY_PS]);
+      if (b.status !== 0) log('WARNING: could not set the task to run on battery (exit ' + b.status + '); on a laptop the server may not start unplugged. Run in PowerShell: ' + BATTERY_PS);
+      sh('schtasks', ['/Run', '/TN', TASK_NAME]);
+    } else { // ONLOGON tasks can need elevation: an HKCU Run value is the per-user equivalent
+      sh('reg', ['add', RUN_KEY, '/v', TASK_NAME, '/t', 'REG_SZ', '/d', plan.runCmd, '/f']);
+      const c = spawnFn(plan.bin, ['--source-dir', plan.core], { detached: true, stdio: 'ignore', windowsHide: true });
+      c.on('error', () => {}); c.unref();
       // schtasks' stderr is in the console's OEM code page (garbled when echoed); the usual cause is
-      // missing admin rights for /SC ONLOGON. The Startup-folder launcher starts at logon the same way.
-      log('schtasks needs administrator rights here (exit ' + r.status + '); installed the Startup-folder launcher instead (also starts at logon)');
+      // missing admin rights for /SC ONLOGON. The Run value starts the server at logon the same way.
+      log('schtasks needs administrator rights here (exit ' + r.status + '); registered the HKCU Run value instead (also starts at logon)');
     }
   } else if (plan.kind === 'launchd') {
     log('launchctl load -w ' + plan.unit); if (!dry) sh('launchctl', ['load', '-w', plan.unit]);
@@ -326,14 +340,23 @@ function serviceInstall(plan, dry, log, run = sh, uid) {
   } else {
     log('systemctl --user enable --now kenaz-server');
     if (!dry) { sh('systemctl', ['--user', 'daemon-reload']); sh('systemctl', ['--user', 'enable', '--now', 'kenaz-server']); }
+    // Without linger the user service starts only at login (headless boxes: never). Best effort.
+    const u = linuxUser();
+    log('loginctl enable-linger ' + u);
+    if (!dry && sh('loginctl', ['enable-linger', u]).status !== 0) log('WARNING: could not enable linger; the server starts at boot only after you log in. Run: loginctl enable-linger ' + u + ' (may need sudo)');
     serviceRestart(plan, dry, log, sh, uid);
   }
 }
+function removeLegacy(plan, dry, log) {
+  for (const f of plan.legacy || []) if (fs.existsSync(f)) { log('remove ' + f + ' (old launcher)'); if (!dry) fs.rmSync(f, { force: true }); }
+}
 function serviceUninstall(plan, dry, log, run = sh) {
   if (plan.kind === 'windows') {
     log('schtasks /End + /Delete /TN ' + TASK_NAME);
     if (!dry) { run('schtasks', ['/End', '/TN', TASK_NAME]); run('schtasks', ['/Delete', '/TN', TASK_NAME, '/F']); }
-    if (fs.existsSync(plan.fallbackFile)) { log('remove ' + plan.fallbackFile); if (!dry) fs.rmSync(plan.fallbackFile, { force: true }); }
+    log('reg delete ' + RUN_KEY + ' /v ' + TASK_NAME);
+    if (!dry) run('reg', ['delete', RUN_KEY, '/v', TASK_NAME, '/f']); // not-found is fine
+    removeLegacy(plan, dry, log);
   } else if (plan.kind === 'launchd') {
     log('launchctl unload ' + plan.unit); if (!dry) run('launchctl', ['unload', '-w', plan.unit]);
   } else if (plan.kind === 'cron' || plan.kind === 'manual') {
@@ -347,7 +370,7 @@ function serviceUninstall(plan, dry, log, run = sh) {
 function serviceStatus(plan, run = sh) {
   if (plan.kind === 'cron') { const c = readCron(run); return c && c.includes(CRON_MARK) ? 'cron @reboot entry present' : 'not installed'; }
   if (plan.kind === 'manual') return 'manual (no systemd user session, no crontab)';
-  if (plan.kind === 'windows') return run('schtasks', ['/Query', '/TN', TASK_NAME]).status === 0 ? 'scheduled task present' : (fs.existsSync(plan.fallbackFile) ? 'startup launcher present' : 'not installed');
+  if (plan.kind === 'windows') return run('schtasks', ['/Query', '/TN', TASK_NAME]).status === 0 ? 'scheduled task present' : (run('reg', ['query', RUN_KEY, '/v', TASK_NAME]).status === 0 ? 'Run key present' : 'not installed');
   if (plan.kind === 'systemd') return run('systemctl', ['--user', 'is-active', 'kenaz-server']).stdout.trim() || 'not installed';
   return fs.existsSync(plan.unit) ? 'plist present' : 'not installed';
 }
@@ -355,17 +378,20 @@ function serviceStatus(plan, run = sh) {
 /** Which mechanism keeps the server running on this machine (for `kenaz doctor`). Read-only, all via `run`. */
 function detectServiceMode(home, core, run = sh, platform = process.platform) {
   if (platform === 'win32') {
-    const plan = servicePlan(home, '', core, 'win32');
     if (run('schtasks', ['/Query', '/TN', TASK_NAME]).status === 0) return { mode: 'windows task', detail: 'scheduled task ' + TASK_NAME };
-    if (fs.existsSync(plan.fallbackFile)) return { mode: 'startup launcher', detail: plan.fallbackFile };
-    return { mode: 'manual', detail: 'no scheduled task or Startup launcher; run `kenaz install`' };
+    if (run('reg', ['query', RUN_KEY, '/v', TASK_NAME]).status === 0) return { mode: 'run key', detail: RUN_KEY + '\\' + TASK_NAME };
+    return { mode: 'manual', detail: 'no scheduled task or Run key; run `kenaz install`' };
   }
   if (platform === 'darwin') {
     const p = servicePlan(home, '', core, 'darwin').unit;
     return fs.existsSync(p) ? { mode: 'launchd', detail: p } : { mode: 'manual', detail: 'no launchd agent; run `kenaz install`' };
   }
   const unit = servicePlan(home, '', core, 'linux').unit;
-  if (fs.existsSync(unit) && probeLinux(run).systemd) return { mode: 'systemd', detail: unit };
+  if (fs.existsSync(unit) && probeLinux(run).systemd) {
+    const u = linuxUser();
+    const off = /Linger=no/.test(run('loginctl', ['show-user', u, '-p', 'Linger']).stdout || '');
+    return off ? { mode: 'systemd', detail: unit + '; linger is off, the server starts only after login: run loginctl enable-linger ' + u, warn: true } : { mode: 'systemd', detail: unit };
+  }
   const c = readCron(run);
   if (c && c.includes(CRON_MARK)) return { mode: 'cron', detail: '@reboot crontab entry (no systemd user session)' };
   return { mode: 'manual', detail: 'no systemd unit or cron entry; run `kenaz install`' };
@@ -453,4 +479,4 @@ function main(argv, out = console.log, getVersion = claudeVersion, deps = {}) {
 }
 
 if (require.main === module) process.exit(main(process.argv.slice(2)));
-module.exports = { main, verifyRuntime, healthOnce, serviceInstall, serviceRestart, restartHint, claudeVersion, loadSettings, entriesOf, norm, MIN_CLI, registerPlugin, unregisterPlugin, registerStatusline, unregisterStatusline, retireDashboardHooks, servicePlan, detectServiceMode, probeLinux, cronLine, CRON_MARK, winVbs, launchdPlist, systemdUnit, parseVersion, cmpVersion };
+module.exports = { main, verifyRuntime, healthOnce, serviceInstall, serviceUninstall, serviceRestart, restartHint, claudeVersion, loadSettings, entriesOf, norm, MIN_CLI, registerPlugin, unregisterPlugin, registerStatusline, unregisterStatusline, retireDashboardHooks, servicePlan, detectServiceMode, probeLinux, cronLine, CRON_MARK, winRunCmd, RUN_KEY, launchdPlist, systemdUnit, parseVersion, cmpVersion };