kayvee 3.16.0 → 3.18.0

package/build/test/context_logger.js

@@ -2,27 +2,27 @@ var assert = require("assert");
 var sinon = require("sinon");
 var middleware = require("../lib/middleware");
 var KayveeLogger = require("../lib/logger/logger");
-describe("ContextLogger", function () {
-    var fake_req = { key1: "val1" };
-    var fake_handler = function (req) { return ({ log_key1: req.key1, key2: "val2" }); };
-    var _loop_1 = function(level) {
-        it("correctly adds context to " + level + " calls", function () {
-            var spy = sinon.spy();
-            var stub_logger = {};
-            stub_logger[(level + "D")] = spy;
-            var log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
+describe("ContextLogger", () => {
+    const fake_req = { key1: "val1" };
+    const fake_handler = (req) => ({ log_key1: req.key1, key2: "val2" });
+    for (const level of KayveeLogger.LEVELS) {
+        it(`correctly adds context to ${level} calls`, () => {
+            const spy = sinon.spy();
+            const stub_logger = {};
+            stub_logger[`${level}D`] = spy;
+            const log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
             log[level]("test_title");
-            var expected_context = { log_key1: "val1", key2: "val2" };
+            const expected_context = { log_key1: "val1", key2: "val2" };
             assert(spy.calledWithExactly("test_title", expected_context));
             assert.equal(spy.callCount, 1);
         });
-        it("correctly adds context to " + level + "D calls", function () {
-            var spy = sinon.spy();
-            var stub_logger = {};
-            stub_logger[(level + "D")] = spy;
-            var log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
-            log[(level + "D")]("test_title", { key2: "new_value", key3: "val3" });
-            var expected_data = {
+        it(`correctly adds context to ${level}D calls`, () => {
+            const spy = sinon.spy();
+            const stub_logger = {};
+            stub_logger[`${level}D`] = spy;
+            const log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
+            log[`${level}D`]("test_title", { key2: "new_value", key3: "val3" });
+            const expected_data = {
                 log_key1: "val1",
                 key2: "new_value",
                 key3: "val3",
@@ -30,29 +30,25 @@ describe("ContextLogger", function () {
             assert(spy.calledWithExactly("test_title", expected_data));
             assert.equal(spy.callCount, 1);
         });
-    };
-    for (var _i = 0, _a = KayveeLogger.LEVELS; _i < _a.length; _i++) {
-        var level = _a[_i];
-        _loop_1(level);
     }
-    var _loop_2 = function(metric) {
-        it("correctly adds context to " + metric + " calls", function () {
-            var spy = sinon.spy();
-            var stub_logger = {};
-            stub_logger[(metric + "D")] = spy;
-            var log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
+    for (const metric of KayveeLogger.METRICS) {
+        it(`correctly adds context to ${metric} calls`, () => {
+            const spy = sinon.spy();
+            const stub_logger = {};
+            stub_logger[`${metric}D`] = spy;
+            const log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
             log[metric]("test_title", 3);
-            var expected_context = { log_key1: "val1", key2: "val2" };
+            const expected_context = { log_key1: "val1", key2: "val2" };
             assert(spy.calledWithExactly("test_title", 3, expected_context));
             assert.equal(spy.callCount, 1);
         });
-        it("correctly adds context to " + metric + "D calls", function () {
-            var spy = sinon.spy();
-            var stub_logger = {};
-            stub_logger[(metric + "D")] = spy;
-            var log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
-            log[(metric + "D")]("test_title", 3, { key2: "new_value", key3: "val3" });
-            var expected_data = {
+        it(`correctly adds context to ${metric}D calls`, () => {
+            const spy = sinon.spy();
+            const stub_logger = {};
+            stub_logger[`${metric}D`] = spy;
+            const log = new middleware.ContextLogger(stub_logger, [fake_handler], fake_req);
+            log[`${metric}D`]("test_title", 3, { key2: "new_value", key3: "val3" });
+            const expected_data = {
                 log_key1: "val1",
                 key2: "new_value",
                 key3: "val3",
@@ -60,17 +56,13 @@ describe("ContextLogger", function () {
             assert(spy.calledWithExactly("test_title", 3, expected_data));
             assert.equal(spy.callCount, 1);
         });
-    };
-    for (var _b = 0, _c = KayveeLogger.METRICS; _b < _c.length; _b++) {
-        var metric = _c[_b];
-        _loop_2(metric);
     }
-    it("correctly handles being instantiated with empty list of handlers", function () {
-        var spy = sinon.spy();
-        var stub_logger = { infoD: spy };
-        var log = new middleware.ContextLogger(stub_logger, [], fake_req);
+    it("correctly handles being instantiated with empty list of handlers", () => {
+        const spy = sinon.spy();
+        const stub_logger = { infoD: spy };
+        const log = new middleware.ContextLogger(stub_logger, [], fake_req);
         log.info("test_title");
-        var expected_context = {};
+        const expected_context = {};
         assert(spy.calledWithExactly("test_title", expected_context));
         assert.equal(spy.callCount, 1);
     });

package/build/test/kayvee.js

@@ -2,21 +2,21 @@ var kv = require("../lib/kayvee");
 var assert = require("assert");
 var _ = require("underscore");
 var fs = require("fs");
-describe("kayvee", function () {
-    var tests = JSON.parse(fs.readFileSync("test/tests.json"));
-    describe(".format", function () {
-        _.each(tests.format, function (spec) {
-            it(spec.title, function () {
-                var actual = kv.format(spec.input.data);
-                var expected = spec.output;
+describe("kayvee", () => {
+    const tests = JSON.parse(fs.readFileSync("test/tests.json"));
+    describe(".format", () => {
+        _.each(tests.format, (spec) => {
+            it(spec.title, () => {
+                const actual = kv.format(spec.input.data);
+                const expected = spec.output;
                 assert.deepEqual(JSON.parse(actual), _.extend({ deploy_env: "testing", wf_id: "abc" }, JSON.parse(expected)));
             });
         });
     });
-    describe(".format with Errors", function () {
-        it("encodes Error objects", function () {
-            var actual = kv.format({ err: Error("An Error Message") });
-            var expected = {
+    describe(".format with Errors", () => {
+        it("encodes Error objects", () => {
+            const actual = kv.format({ err: Error("An Error Message") });
+            const expected = {
                 deploy_env: "testing",
                 wf_id: "abc",
                 err: "Error: An Error Message",
@@ -24,11 +24,11 @@ describe("kayvee", function () {
             assert.deepEqual(JSON.parse(actual), expected);
         });
     });
-    describe(".formatLog", function () {
-        _.each(tests.formatLog, function (spec) {
-            it(spec.title, function () {
-                var actual = kv.formatLog(spec.input.source, spec.input.level, spec.input.title, spec.input.data);
-                var expected = spec.output;
+    describe(".formatLog", () => {
+        _.each(tests.formatLog, (spec) => {
+            it(spec.title, () => {
+                const actual = kv.formatLog(spec.input.source, spec.input.level, spec.input.title, spec.input.data);
+                const expected = spec.output;
                 assert.deepEqual(JSON.parse(actual), _.extend({ deploy_env: "testing", wf_id: "abc" }, JSON.parse(expected)));
             });
         });

package/build/test/logger_test.js

@@ -1,138 +1,145 @@
 var KayveeLogger = require("../lib/logger/logger");
 var assert = require("assert");
-var sample = "";
+let sample = "";
 function outputFunc(text) {
     sample = text;
     return sample;
 }
-describe("logger_test", function () {
-    var logObj = null;
-    var logObj2 = null;
-    beforeEach(function () {
+describe("logger_test", () => {
+    let logObj = null;
+    let logObj2 = null;
+    beforeEach(() => {
         logObj = new KayveeLogger("logger-tester");
         sample = "";
         return logObj.setOutput(outputFunc);
     });
-    describe(".constructor", function () {
-        it("passing in parameters to constructor", function () {
-            var formatter = function (data) { return (data.level + "." + data.source + "." + data.title); };
+    describe(".constructor", () => {
+        it("passing in parameters to constructor", () => {
+            const formatter = (data) => `${data.level}.${data.source}.${data.title}`;
             logObj = new KayveeLogger("logger-test", KayveeLogger.Info, formatter, outputFunc);
             logObj.debug("testlogdebug");
-            var expected = "";
+            let expected = "";
             assert.equal(sample, expected);
             logObj.info("testloginfo");
-            expected = KayveeLogger.Info + ".logger-test.testloginfo";
+            expected = `${KayveeLogger.Info}.logger-test.testloginfo`;
             assert.equal(sample, expected);
         });
     });
-    describe(".validateloglvl", function () {
+    describe(".validateloglvl", () => {
         // Explicit validation checks
-        it("is case-insensitive in log level name", function () {
-            var logLvl = logObj._validateLogLvl("debug");
+        it("is case-insensitive in log level name", () => {
+            let logLvl = logObj._validateLogLvl("debug");
             assert.equal(logLvl, KayveeLogger.Debug);
             logLvl = logObj._validateLogLvl("Debug");
             assert.equal(logLvl, KayveeLogger.Debug);
         });
-        it("sets non-default log levels", function () {
-            var logLvl = logObj._validateLogLvl("info");
+        it("sets non-default log levels", () => {
+            let logLvl = logObj._validateLogLvl("info");
             assert.equal(logLvl, KayveeLogger.Info);
             // TODO: for each possible log level ...
             logLvl = logObj._validateLogLvl("critical");
             assert.equal(logLvl, KayveeLogger.Critical);
         });
-        it("sets level to Debug, if given an invalid log level", function () {
-            var logLvl = logObj._validateLogLvl("sometest");
+        it("sets level to Debug, if given an invalid log level", () => {
+            const logLvl = logObj._validateLogLvl("sometest");
             assert.equal(logLvl, KayveeLogger.Debug);
         });
     });
-    describe(".invalidlog", function () {
-        it("check valid debug level JSON output of invalid log level", function () {
+    describe(".invalidlog", () => {
+        it("check valid debug level JSON output of invalid log level", () => {
             // Invalid log levels will default to debug
             logObj.setLogLevel("invalidloglevel");
             logObj.debug("testlogdebug");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Debug + "\", \"title\": \"testlogdebug\"}";
+            let expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Debug}", "title": "testlogdebug"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
             logObj.setLogLevel("sometest");
             logObj.info("testloginfo");
-            expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloginfo\"}";
+            expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Info}", "title": "testloginfo"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".debug", function () {
-        it("test debug function", function () {
+    describe(".debug", () => {
+        it("test debug function", () => {
             logObj.debug("testlogdebug");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Debug + "\", \"title\": \"testlogdebug\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Debug}", "title": "testlogdebug"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test debugD function", function () {
+        it("test debugD function", () => {
             logObj.debugD("testlogdebug", { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Debug + "\", \"title\": \"testlogdebug\",\"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Debug}", "title": "testlogdebug","key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".info", function () {
-        it("test info function", function () {
+    describe(".info", () => {
+        it("test info function", () => {
             logObj.info("testloginfo");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloginfo\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Info}", "title": "testloginfo"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test infoD function", function () {
+        it("test infoD function", () => {
             logObj.infoD("testloginfo", { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloginfo\",\"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Info}", "title": "testloginfo","key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".warning", function () {
-        it("test warn function", function () {
+    describe(".warning", () => {
+        it("test warn function", () => {
             logObj.warn("testlogwarning");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Warning + "\", \"title\": \"testlogwarning\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Warning}", "title": "testlogwarning"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test warnD function", function () {
+        it("test warnD function", () => {
             logObj.warnD("testlogwarning", { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Warning + "\", \"title\": \"testlogwarning\",\"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Warning}", "title": "testlogwarning","key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".error", function () {
-        it("test error function", function () {
+    describe(".error", () => {
+        it("test error function", () => {
             logObj.error("testlogerror");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Error + "\", \"title\": \"testlogerror\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Error}", "title": "testlogerror"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test errorD function", function () {
+        it("test errorD function", () => {
             logObj.errorD("testlogerror", { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Error + "\", \"title\": \"testlogerror\",\"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Error}", "title": "testlogerror","key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".critical", function () {
-        it("test critical function", function () {
+    describe(".critical", () => {
+        it("test critical function", () => {
             logObj.critical("testlogcritical");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Critical + "\", \"title\": \"testlogcritical\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Critical}", "title": "testlogcritical"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test criticalD function", function () {
+        it("test criticalD function", () => {
             logObj.criticalD("testlogcritical", { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Critical + "\", \"title\": \"testlogcritical\",\"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Critical}", "title": "testlogcritical","key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
     });
-    describe(".counter", function () {
-        it("test counter function", function () {
+    describe(".counter", () => {
+        it("test counter function", () => {
             logObj.counter("testlogcounter");
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testlogcounter\", \"type\": \"counter\", \"value\": 1}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Info}", "title": "testlogcounter", "type": "counter", "value": 1}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test counterD function", function () {
+        it("test counterD function", () => {
             logObj.counterD("testlogcounter", 2, { key1: "val1", key2: "val2" });
-            var expected = ("{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testlogcounter\",\"type\": \"counter\", \"value\": 2,\"key1\": \"val1\",") +
-                " \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Info}", "title": "testlogcounter","type": "counter", "value": 2,"key1": "val1",` +
+                ' "key2": "val2"}';
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test counterD function with overrides", function () {
+        it("test counterD function with overrides", () => {
             logObj.counterD("testlogcounter", 2, { key1: "val1", key2: "val2", value: 18 });
-            var expected = {
+            const expected = {
                 deploy_env: "testing",
                 wf_id: "abc",
                 source: "logger-tester",
@@ -146,20 +153,22 @@ describe("logger_test", function () {
             assert.deepEqual(JSON.parse(sample), expected);
         });
     });
-    describe(".gauge", function () {
-        it("test gauge function", function () {
+    describe(".gauge", () => {
+        it("test gauge function", () => {
             logObj.gauge("testloggauge", 0);
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloggauge\", \"type\": \"gauge\", \"value\": 0}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Info}", "title": "testloggauge", "type": "gauge", "value": 0}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test gaugeD function", function () {
+        it("test gaugeD function", () => {
             logObj.gaugeD("testloggauge", 4, { key1: "val1", key2: "val2" });
-            var expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\",\n\"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloggauge\", \"type\": \"gauge\", \"value\": 4, \"key1\": \"val1\", \"key2\": \"val2\"}";
+            const expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester",
+"level": "${KayveeLogger.Info}", "title": "testloggauge", "type": "gauge", "value": 4, "key1": "val1", "key2": "val2"}`;
             assert.deepEqual(JSON.parse(sample), JSON.parse(expected));
         });
-        it("test gaugeD function with overrids", function () {
+        it("test gaugeD function with overrids", () => {
             logObj.gaugeD("testloggauge", 4, { key1: "val1", key2: "val2", value: 18 });
-            var expected = {
+            const expected = {
                 deploy_env: "testing",
                 wf_id: "abc",
                 source: "logger-tester",
@@ -173,12 +182,12 @@ describe("logger_test", function () {
             assert.deepEqual(JSON.parse(sample), expected);
         });
     });
-    describe(".diffoutput", function () {
-        it("output to different output functions using same logger", function () {
+    describe(".diffoutput", () => {
+        it("output to different output functions using same logger", () => {
             logObj.info("testloginfo");
-            var infoLog = sample;
-            var output2 = "";
-            var outputFunc2 = function (text) {
+            const infoLog = sample;
+            let output2 = "";
+            const outputFunc2 = (text) => {
                 output2 = text;
                 return output2;
             };
@@ -188,12 +197,12 @@ describe("logger_test", function () {
             assert.notDeepEqual(JSON.parse(output2), JSON.parse(sample));
         });
     });
-    describe(".nomodifydata", function () {
-        before(function () {
+    describe(".nomodifydata", () => {
+        before(() => {
             logObj.setOutput(outputFunc);
         });
-        it("does not modify data", function () {
-            var data = {
+        it("does not modify data", () => {
+            const data = {
                 str: "modify",
                 obj: {
                     key: "value",
@@ -202,7 +211,7 @@ describe("logger_test", function () {
             };
             // not using deepClone since that's what we are
             // somewhat testing
-            var dataCopy = {
+            const dataCopy = {
                 str: "modify",
                 obj: {
                     key: "value",
@@ -211,7 +220,7 @@ describe("logger_test", function () {
             };
             logObj.infoD("testInfoWithData", data);
             assert.deepEqual(data, dataCopy);
-            var output = {
+            const output = {
                 deploy_env: "testing",
                 wf_id: "abc",
                 fun: "boo",
@@ -226,16 +235,16 @@ describe("logger_test", function () {
             assert.deepEqual(JSON.parse(sample), output);
         });
     });
-    describe(".hiddenlog", function () {
-        describe(".logwarning", function () {
-            beforeEach(function () { return logObj.setLogLevel(KayveeLogger.Warning); });
-            it("empty cases due to log level", function () {
+    describe(".hiddenlog", () => {
+        describe(".logwarning", () => {
+            beforeEach(() => logObj.setLogLevel(KayveeLogger.Warning));
+            it("empty cases due to log level", () => {
                 logObj.debug("testlogdebug");
                 assert.equal(sample, "");
                 logObj.info("testloginfo");
                 assert.equal(sample, "");
             });
-            it("not empty cases due to log level", function () {
+            it("not empty cases due to log level", () => {
                 logObj.warn("testlogwarning");
                 assert.notDeepEqual(JSON.parse(sample), "");
                 logObj.error("testlogerror");
@@ -244,11 +253,11 @@ describe("logger_test", function () {
                 assert.notDeepEqual(JSON.parse(sample), "");
             });
         });
-        return describe(".logcritical", function () {
-            beforeEach(function () {
+        return describe(".logcritical", () => {
+            beforeEach(() => {
                 logObj.setLogLevel(KayveeLogger.Critical);
             });
-            it("empty cases due to log level", function () {
+            it("empty cases due to log level", () => {
                 logObj.debug("testlogdebug");
                 assert.equal(sample, "");
                 logObj.info("testloginfo");
@@ -258,24 +267,24 @@ describe("logger_test", function () {
                 logObj.error("testlogerror");
                 assert.equal(sample, "");
             });
-            it("not empty cases due to log level", function () {
+            it("not empty cases due to log level", () => {
                 logObj.critical("testlogcritical");
                 assert.notDeepEqual(JSON.parse(sample), "");
             });
         });
     });
-    describe(".diffformat", function () {
-        it("use a different formatter than KV", function () {
-            var testFormatter = function () { return "\"This is a test\""; };
+    describe(".diffformat", () => {
+        it("use a different formatter than KV", () => {
+            const testFormatter = () => '"This is a test"';
             logObj.setFormatter(testFormatter);
             logObj.warn("testlogwarning");
             assert.deepEqual(JSON.parse(sample), "This is a test");
         });
     });
-    describe("global overrides", function () {
-        it("what data has source prop", function () {
+    describe("global overrides", () => {
+        it("what data has source prop", () => {
             logObj.warnD("global-override", { source: "overrided" });
-            var output = {
+            const output = {
                 deploy_env: "testing",
                 wf_id: "abc",
                 title: "global-override",
@@ -285,45 +294,47 @@ describe("logger_test", function () {
             assert.deepEqual(JSON.parse(sample), output);
         });
     });
-    return describe(".multipleloggers", function () {
-        before(function () {
+    return describe(".multipleloggers", () => {
+        before(() => {
             logObj2 = new KayveeLogger("logger-tester2");
             return logObj2;
         });
-        it("log to same output buffer", function () {
+        it("log to same output buffer", () => {
             logObj2.setOutput(outputFunc);
             logObj.warn("testlogwarning");
-            var output1 = sample;
+            const output1 = sample;
             logObj2.info("testloginfo");
             assert.notDeepEqual(JSON.parse(sample), JSON.parse(output1));
         });
-        it("log to different output buffer", function () {
-            var output2 = "";
-            var outputFunc2 = function (text) {
+        it("log to different output buffer", () => {
+            let output2 = "";
+            const outputFunc2 = (text) => {
                 output2 = text;
                 return output2;
             };
             logObj2.setOutput(outputFunc2);
             logObj.warn("testlogwarning");
             logObj2.info("testloginfo");
-            var loggerExpected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester\", \"level\": \"" + KayveeLogger.Warning + "\", \"title\": \"testlogwarning\"}";
+            const loggerExpected = `
+      {"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester", "level": "${KayveeLogger.Warning}", "title": "testlogwarning"}
+      `;
             assert.deepEqual(JSON.parse(sample), JSON.parse(loggerExpected));
-            var logger2Expected = "{\"deploy_env\": \"testing\", \"wf_id\": \"abc\", \"source\": \"logger-tester2\", \"level\": \"" + KayveeLogger.Info + "\", \"title\": \"testloginfo\"}";
+            const logger2Expected = `{"deploy_env": "testing", "wf_id": "abc", "source": "logger-tester2", "level": "${KayveeLogger.Info}", "title": "testloginfo"}`;
             assert.deepEqual(JSON.parse(output2), JSON.parse(logger2Expected));
         });
     });
 });
-describe("mockRouting", function () {
-    it("can override routing from setGlobalRouting, and captures routed logs", function () {
-        var logObj = new KayveeLogger("test-source");
-        KayveeLogger.mockRouting(function (kvdone) {
+describe("mockRouting", () => {
+    it("can override routing from setGlobalRouting, and captures routed logs", () => {
+        const logObj = new KayveeLogger("test-source");
+        KayveeLogger.mockRouting((kvdone) => {
             KayveeLogger.setGlobalRouting("test/kvconfig.yml");
             logObj.info("foo-title");
-            var ruleMatches = kvdone();
+            const ruleMatches = kvdone();
             // should match one log
             assert.equal(ruleMatches["rule-two"].length, 1);
             // matched log should look like so
-            var expectedRule = {
+            const expectedRule = {
                 type: "analytics",
                 series: "requests.everything",
                 rule: "rule-two",