karnel-termux 4.17.21 → 4.17.22

package/README.md

@@ -8,7 +8,7 @@
 
 <p align="center">
   <a href="https://github.com/israelmarques1024-dotcom/karnel-termux">
-    <img src="https://img.shields.io/badge/version-4.17.21-0078D4?style=for-the-badge" alt="Version">
+    <img src="https://img.shields.io/badge/version-4.17.22-0078D4?style=for-the-badge" alt="Version">
   </a>
   <a href="https://www.npmjs.com/package/karnel-termux">
     <img src="https://img.shields.io/npm/v/karnel-termux?style=for-the-badge&logo=npm&color=cb3837" alt="npm">
@@ -78,7 +78,7 @@ Why it's great:
 ### Via checksummed GitHub release (recommended)
 
 ```bash
-version=4.17.21
+version=4.17.22
 tmpdir=$(mktemp -d) && trap 'rm -rf "$tmpdir"' EXIT
 base="https://github.com/israelmarques1024-dotcom/karnel-termux/releases/download/v$version"
 curl -fsSL "$base/karnel-termux-install.sh" -o "$tmpdir/karnel-termux-install.sh"

package/docs/CHANGELOG.md

@@ -6,6 +6,14 @@ layout: base
 
 # Documentation Changelog
 
+## 4.17.22
+
+- **Data safety and correctness (8):** restore rejects ambiguous multiple archives; Brain preserves same-day title collisions, uses file paths for AI context, initializes/pushes `main`, detects missing `origin`, and supports editors with arguments; PostgreSQL backup filenames are path-safe; AI-session persistence escapes JSON correctly.
+- **Agent safety (3):** positional prompts retain all words, zero-valued execution/context limits are rejected, and PLAN mode rejects shell syntax plus destructive `find`/in-place operations that bypassed its read-only contract.
+- **Installer reliability (1):** Bun proot installation/update no longer reject safe archives before extraction.
+- **Regression coverage:** added critical CLI contracts and strengthened Brain reciprocal-relation coverage; the isolated full suite passes.
+- Version references bumped to `4.17.22`.
+
 ## 4.17.21
 
 - **Official-site routing:** `karnel open`, npm package metadata, and the GitHub/npm README now point to the Vercel production site, `https://karneltermux.vercel.app`, rather than the secondary GitHub Pages mirror.

package/karnel/RELEASE_COMMIT

@@ -1 +1 @@
-6b13b468f425a13040e4dac77eef1b449a553ea8
+4c9e5da4c38f3c93a5f36809265feb152fd59b27

package/karnel/cli/commands/agent.sh

@@ -255,10 +255,11 @@ agent_parse_args() {
 	AGENT_PROMPT=""
 	AGENT_SHOW_HELP=0
 	AGENT_YES=0
-	local prev=""
+	local prev="" prompt_set=0
+	local -a positional=()
 	for arg in "$@"; do
 		case "$prev" in
-		-p | --prompt) AGENT_PROMPT="$arg"; prev=""; continue ;;
+		-p | --prompt) AGENT_PROMPT="$arg"; prompt_set=1; prev=""; continue ;;
 		-m | --model) AGENT_MODEL="$arg"; prev=""; continue ;;
 		-u | --endpoint) AGENT_ENDPOINT="$arg"; prev=""; continue ;;
 		-t | --temperature) AGENT_TEMPERATURE="$arg"; prev=""; continue ;;
@@ -267,7 +268,7 @@ agent_parse_args() {
 		--max-tokens) AGENT_MAX_TOKENS="$arg"; prev=""; continue ;;
 		esac
 		case "$arg" in
-		-p=* | --prompt=*) AGENT_PROMPT="${arg#*=}" ;;
+		-p=* | --prompt=*) AGENT_PROMPT="${arg#*=}"; prompt_set=1 ;;
 		-m=* | --model=*) AGENT_MODEL="${arg#*=}" ;;
 		-u=* | --endpoint=*) AGENT_ENDPOINT="${arg#*=}" ;;
 		-t=* | --temperature=*) AGENT_TEMPERATURE="${arg#*=}" ;;
@@ -280,9 +281,12 @@ agent_parse_args() {
 		-y | --yes) AGENT_YES=1 ;;
 		-h | --help) AGENT_SHOW_HELP=1 ;;
 		-*) log_warn "Unknown option: $arg" ;;
-		*) [[ -z "$AGENT_PROMPT" ]] && AGENT_PROMPT="$arg" ;;
+		*) positional+=("$arg") ;;
 		esac
 	done
+	if (( ! prompt_set && ${#positional[@]} )); then
+		AGENT_PROMPT="${positional[*]}"
+	fi
 }
 readonly AGENT_ASK_SYSTEM="You are a concise chat assistant. Reply in the SAME LANGUAGE the user writes in. Be direct and practical; use markdown, and put code in fenced blocks. <attached_file path=\"...\">...</attached_file> blocks hold real file contents (action=\"no-read\" = path only). <compacted_summary>...</compacted_summary> blocks are condensed summaries of earlier turns — treat them as ground truth."
 
@@ -846,4 +850,4 @@ agent_run_loop() {
 	_ems=$(agent_timer_ms)
 	echo
 	printf '    %s[context %s]%s\n' "$D_GRAY" "$(agent_context_footer "$AGENT_REPL_HISTORY" "$_ems")" "$NC"
-}
+}

package/karnel/cli/commands/brain.sh

@@ -349,7 +349,7 @@ brain_init() {
 	log_info "Creating private repo: ${D_CYAN}$gh_user/$repo_name${D_NC}..."
 	if gh repo create "$repo_name" --private &>/dev/null; then
 		(
-			git -C "$BRAIN_DIR" init &>/dev/null
+			git -C "$BRAIN_DIR" init -b main &>/dev/null || exit 1
 			echo "# Karnel Brain" >"$BRAIN_DIR/README.md"
 			git -C "$BRAIN_DIR" add -A
 			git -C "$BRAIN_DIR" commit -m "init brain" &>/dev/null
@@ -474,6 +474,10 @@ brain_save() {
 	# ── Write file ──
 	mkdir -p "$BRAIN_DIR/$category"
 	local filepath="$BRAIN_DIR/$category/${date_prefix}_${slug}.md"
+	if [[ -e "$filepath" ]]; then
+		log_error "A memory with this title already exists today: ${date_prefix}_${slug}.md"
+		return 1
+	fi
 
 	{
 		_brain_frontmatter "$title" "$tags_formatted" "$category" "$related_str"
@@ -576,6 +580,10 @@ brain_add() {
 
 	mkdir -p "$BRAIN_DIR/$category"
 	local filepath="$BRAIN_DIR/$category/${date_prefix}_${slug}.md"
+	if [[ -e "$filepath" ]]; then
+		log_error "A memory with this title already exists today: ${date_prefix}_${slug}.md"
+		return 1
+	fi
 
 	{
 		_brain_frontmatter "$title" "$tags_formatted" "$category" ""
@@ -928,7 +936,7 @@ brain_sync() {
 	local branch
 	branch=$(git -C "$BRAIN_DIR" rev-parse --abbrev-ref HEAD 2>/dev/null)
 
-	if ! git -C "$BRAIN_DIR" remote -v &>/dev/null; then
+	if ! git -C "$BRAIN_DIR" remote get-url origin &>/dev/null; then
 		log_info "No remote configured — local commit only"
 		list_item "Set up GitHub sync with: ${D_CYAN}karnel brain init${D_NC}"
 		separator
@@ -1231,22 +1239,18 @@ brain_edit() {
 		return 0
 	fi
 
-	local editor="${EDITOR:-}"
-	local editor_bin
-	editor_bin="${EDITOR:-nano}"
-	editor_bin="${editor_bin%% *}"
-	if command -v "$editor_bin" &>/dev/null; then
-		editor="${EDITOR:-nano}"
-	elif [[ -z "$editor" ]] || ! command -v "$editor" &>/dev/null; then
+	local -a editor_cmd=()
+	read -r -a editor_cmd <<< "${EDITOR:-nano}"
+	if ! command -v "${editor_cmd[0]}" &>/dev/null; then
 		for e in vim nano vi; do
 			if command -v "$e" &>/dev/null; then
-				editor="$e"
+				editor_cmd=("$e")
 				break
 			fi
 		done
 	fi
 
-	if [[ -z "$editor" ]]; then
+	if [[ ${#editor_cmd[@]} -eq 0 ]] || ! command -v "${editor_cmd[0]}" &>/dev/null; then
 		log_error "No editor found"
 		list_item "Install one: ${D_CYAN}karnel install editor${D_NC}"
 		return 1
@@ -1255,7 +1259,7 @@ brain_edit() {
 	echo
 	log_info "Opening: ${D_CYAN}$(_brain_title "$file")${D_NC}"
 
-	"$editor" "$file"
+	"${editor_cmd[@]}" "$file"
 
 	log_success "Memory updated"
 	echo
@@ -1543,7 +1547,7 @@ EOF
 		if [[ -n "$f" ]]; then
 			matching_files+=("$f")
 		fi
-	done < <(_brain_rg -i "$clean_query" | head -n 5 || true)
+	done < <(_brain_rg -l -i "$clean_query" | head -n 5 || true)
 
 	if [[ ${#matching_files[@]} -eq 0 ]]; then
 		local -a words=($clean_query)
@@ -1562,7 +1566,7 @@ EOF
 				if [[ -n "$f" ]]; then
 					matching_files+=("$f")
 				fi
-			done < <(_brain_rg -i -e "$word_regex" | head -n 5 || true)
+			done < <(_brain_rg -l -i -e "$word_regex" | head -n 5 || true)
 		fi
 	fi
 

package/karnel/cli/commands/ia.sh

@@ -420,7 +420,11 @@ PY
 		ts_raw=$(echo "$session" | cut -d'|' -f2)
 		name=$(echo "$session" | cut -d'|' -f3-)
 		local escaped_name
-		escaped_name=$(printf '%s' "$name" | sed 's/"/\\"/g' | sed "s/'/\\\\'/g")
+		escaped_name=${name//\\/\\\\}
+		escaped_name=${escaped_name//\"/\\\"}
+		escaped_name=${escaped_name//$'\n'/\\n}
+		escaped_name=${escaped_name//$'\r'/\\r}
+		escaped_name=${escaped_name//$'\t'/\\t}
 		if [[ $first -eq 1 ]]; then
 			first=0
 		else

package/karnel/cli/commands/pg.sh

@@ -514,7 +514,10 @@ pg_backup() {
 	log_info "Creating compressed backup for '$db_name'..."
 	local backup_dir="$KARNEL_DATA/pg_backups"
 	mkdir -p "$backup_dir"
-	local file_name="${db_name}_$(date +%Y%m%d_%H%M%S).backup.gz"
+	local safe_db_name
+	safe_db_name=$(printf '%s' "$db_name" | tr -c '[:alnum:]_.-' '_')
+	[[ -n "$safe_db_name" ]] || { log_error "Invalid database name"; return 1; }
+	local file_name="${safe_db_name}_$(date +%Y%m%d_%H%M%S).backup.gz"
 	local file_path="$backup_dir/$file_name"
 
 	if loading "Running backup dump" _run_backup_cmd "$db_name" "$file_path"; then
@@ -522,7 +525,7 @@ pg_backup() {
 		log_success "Backup created successfully:"
 		list_item "$file_path"
 		list_item "Checksum generated: $(cat "${file_path}.sha256")"
-		_pg_cleanup_old_backups "$db_name"
+		_pg_cleanup_old_backups "$safe_db_name"
 	else
 		log_error "Failed to create backup"
 		rm -f "$file_path"

package/karnel/cli/commands/restore.sh

@@ -51,6 +51,9 @@ restore_main() {
             log_error "File not found: $arg"
             return 1
           fi
+        else
+          log_error "Restore accepts exactly one backup file"
+          return 1
         fi
         ;;
     esac

package/karnel/cli/commands/voice.sh

@@ -107,7 +107,9 @@ voice_main() {
     fi
   fi
 
-  if ! command -v "${EDITOR:-nano}" &>/dev/null && [[ "$skip_edit" == "false" ]]; then
+  local -a editor_cmd=()
+  read -r -a editor_cmd <<< "${EDITOR:-nano}"
+  if ! command -v "${editor_cmd[0]}" &>/dev/null && [[ "$skip_edit" == "false" ]]; then
     log_warn "${EDITOR:-nano} not installed — falling back to --raw mode"
     skip_edit=true
   fi
@@ -154,7 +156,7 @@ voice_main() {
     tmpfile="$(mktemp "${TMPDIR:-${KARNEL_CACHE:-$HOME/.cache/karnel}}/karnel-XXXXXX")"
     echo "$raw" >"$tmpfile"
     $is_text || log_info "Review the prompt in ${EDITOR:-nano}, fix mistakes, then save and quit"
-    ${EDITOR:-nano} "$tmpfile" </dev/tty >/dev/tty || true
+    "${editor_cmd[@]}" "$tmpfile" </dev/tty >/dev/tty || true
     prompt="$(< "$tmpfile")"
     rm -f "$tmpfile"
   elif [[ "$skip_edit" == "false" ]] && ! { [[ -t 0 ]] && [[ -t 1 ]]; }; then

package/karnel/tools/lang/bun/install.sh

@@ -294,7 +294,7 @@ _install_bun_proot_impl() {
     cd /tmp &&
     curl -fsSL "$1" -o bun.zip &&
     [ "$(sha256sum bun.zip | awk "{print \$1}")" = "$2" ] &&
-    unzip -l bun.zip | awk "NR>3{print \$NF}" | grep -Eq "(\\.\\./|^\\.\\./|^/)" && { echo "Refusing Bun archive with unsafe paths" >&2; exit 1; } &&
+    if unzip -l bun.zip | awk "NR>3{print \$NF}" | grep -Eq "(\\.\\./|^\\.\\./|^/)"; then echo "Refusing Bun archive with unsafe paths" >&2; exit 1; fi &&
     unzip -o bun.zip >/dev/null 2>&1 &&
     mkdir -p /usr/local/bin &&
     mv bun-linux-aarch64/bun /usr/local/bin/bun &&
@@ -408,7 +408,7 @@ _update_bun_proot() {
     cd /tmp &&
     curl -fsSL "$1" -o bun.zip &&
     [ "$(sha256sum bun.zip | awk "{print \$1}")" = "$2" ] &&
-    unzip -l bun.zip | awk "NR>3{print \$NF}" | grep -Eq "(\\.\\./|^\\.\\./|^/)" && { echo "Refusing Bun archive with unsafe paths" >&2; exit 1; } &&
+    if unzip -l bun.zip | awk "NR>3{print \$NF}" | grep -Eq "(\\.\\./|^\\.\\./|^/)"; then echo "Refusing Bun archive with unsafe paths" >&2; exit 1; fi &&
     unzip -o bun.zip >/dev/null 2>&1 &&
     mkdir -p /usr/local/bin &&
     mv bun-linux-aarch64/bun /usr/local/bin/bun &&

package/karnel/utils/agent_actions.sh

@@ -551,11 +551,19 @@ _agent_cmd_is_readonly() {
 	# commands. Anything the write-gate flags, or any command not in this
 	# allowlist (ruby/php/lua/tclsh/expect/sbcl/...), is blocked — so PLAN
 	# mode can never modify the machine or run arbitrary code.
+	# Shell syntax makes a string-level allowlist unsafe: quoted command names,
+	# separators, substitutions and redirects can hide writes from the first token.
+	case "$1" in
+		*';'* | *'&'* | *'|'* | *"'"* | *'"'* | *'`'* | *'\'* | *'<'* | *'>'* | *'$'*) return 1 ;;
+	esac
 	_agent_cmd_is_write "$1" && return 1
 	local first
 	first=$(printf '%s\n' "$1" | sed 's/^[[:space:]]*//' | cut -d' ' -f1)
 	case "$first" in
 		ls | cat | head | tail | grep | rg | find | stat | wc | file | diff | sort | uniq | cut | tr | tree | du | df | which | type | echo | printf | jq | readlink | realpath | date | pwd | whoami | uname | sed)
+			if [[ " $1 " == *" -delete "* || " $1 " == *" -exec "* || " $1 " == *" -execdir "* || " $1 " == *" -ok "* || " $1 " == *" -okdir "* || " $1 " == *" -fprint "* || " $1 " == *" -fls "* || " $1 " == *" -i "* ]]; then
+				return 1
+			fi
 			return 0
 			;;
 		git)

package/karnel/utils/agent_llm.sh

@@ -50,10 +50,10 @@ agent_config_load() {
 	# Reject tampered config (defense-in-depth): numeric/boolean fields
 	# must match the expected shape or they are reset to safe defaults.
 	[[ "$AGENT_TEMPERATURE" =~ ^[0-9]+(\.[0-9]+)?$ ]] || AGENT_TEMPERATURE=0.3
-	[[ "$AGENT_MAX_TOKENS" =~ ^[0-9]+$ ]] || AGENT_MAX_TOKENS=2048
-	[[ "$AGENT_MAX_ITERATIONS" =~ ^[0-9]+$ ]] || AGENT_MAX_ITERATIONS=12
+	[[ "$AGENT_MAX_TOKENS" =~ ^[1-9][0-9]*$ ]] || AGENT_MAX_TOKENS=2048
+	[[ "$AGENT_MAX_ITERATIONS" =~ ^[1-9][0-9]*$ ]] || AGENT_MAX_ITERATIONS=12
 	[[ "$AGENT_CONFIRM_COMMANDS" =~ ^[01]$ ]] || AGENT_CONFIRM_COMMANDS=1
-	[[ "$AGENT_CONTEXT_WINDOW" =~ ^[0-9]+$ ]] || AGENT_CONTEXT_WINDOW=8192
+	[[ "$AGENT_CONTEXT_WINDOW" =~ ^[1-9][0-9]*$ ]] || AGENT_CONTEXT_WINDOW=8192
 }
 
 # ------------------------------------------------------------
@@ -89,16 +89,16 @@ agent_config_set() {
 		[[ "$value" =~ ^[0-9]+(\.[0-9]+)?$ ]] || { log_error "temperature must be a number (e.g. 0.3)"; return 1; }
 		AGENT_TEMPERATURE="$value" ;;
 	max_tokens | maxtokens)
-		[[ "$value" =~ ^[0-9]+$ ]] || { log_error "max_tokens must be a positive integer"; return 1; }
+		[[ "$value" =~ ^[1-9][0-9]*$ ]] || { log_error "max_tokens must be a positive integer"; return 1; }
 		AGENT_MAX_TOKENS="$value" ;;
 	iterations | max_iterations)
-		[[ "$value" =~ ^[0-9]+$ ]] || { log_error "iterations must be a positive integer"; return 1; }
+		[[ "$value" =~ ^[1-9][0-9]*$ ]] || { log_error "iterations must be a positive integer"; return 1; }
 		AGENT_MAX_ITERATIONS="$value" ;;
 	confirm_commands | confirm)
 		[[ "$value" =~ ^[01]$ ]] || { log_error "confirm_commands must be 0 or 1"; return 1; }
 		AGENT_CONFIRM_COMMANDS="$value" ;;
 	context_window | context)
-		[[ "$value" =~ ^[0-9]+$ ]] || { log_error "context_window must be a positive integer"; return 1; }
+		[[ "$value" =~ ^[1-9][0-9]*$ ]] || { log_error "context_window must be a positive integer"; return 1; }
 		AGENT_CONTEXT_WINDOW="$value" ;;
 	server_command | server) AGENT_SERVER_CMD="$value" ;;
 	workspace)
@@ -363,4 +363,4 @@ agent_history_ensure_system() {
 agent_history_drop_system() {
 	local history="$1"
 	echo "$history" | jq -c '[.[] | select(.role != "system")]'
-}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "karnel-termux",
-  "version": "4.17.21",
+  "version": "4.17.22",
   "description": "Modular Dev Environment for Termux — install languages, databases, AI agents, editors, and more with one command",
   "bin": {
     "karnel": "karnel/bin/karnel"