kareem 2.3.2 → 2.3.3

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+<a name="2.3.3"></a>
+## 2.3.3 (2021-12-26)
+
+* fix: handle sync errors in `wrap()`
+
 <a name="2.3.2"></a>
 ## 2.3.2 (2020-12-08)
 

package/index.js

@@ -276,7 +276,12 @@ Kareem.prototype.wrap = function(name, fn, context, args, options) {
 
     const end = (typeof lastArg === 'function' ? args.length - 1 : args.length);
     const numParameters = fn.length;
-    const ret = fn.apply(context, args.slice(0, end).concat(_cb));
+    let ret;
+    try {
+      ret = fn.apply(context, args.slice(0, end).concat(_cb));
+    } catch (err) {
+      return _cb(err);
+    }
 
     if (checkForPromise) {
       if (ret != null && typeof ret.then === 'function') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "kareem",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "Next-generation take on pre/post function hooks",
   "main": "index.js",
   "scripts": {

package/test/wrap.test.js

@@ -319,6 +319,30 @@ describe('wrap()', function() {
       25);
   });
 
+  it('catches sync errors', function(done) {
+    hooks.pre('cook', function(done) {
+      done();
+    });
+
+    hooks.post('cook', function(callback) {
+      callback();
+    });
+
+    var args = [];
+    args.push(function(error) {
+      assert.equal(error.message, 'oops!');
+      done();
+    });
+
+    hooks.wrap(
+      'cook',
+      function() {
+        throw new Error('oops!');
+      },
+      null,
+      args);
+  });
+
   it('sync wrappers', function() {
     var calledPre = 0;
     var calledFn = 0;