karajan-code 4.70.4 → 5.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +2 -2
- package/package.json +6 -14
- package/packages/hu-board/package.json +1 -1
- package/packages/hu-board/public/app.js +4 -18
- package/packages/hu-board/public/index.html +5 -2
- package/packages/hu-board/public/styles.css +26 -0
- package/packages/hu-board/public/utils/api.js +0 -74
- package/packages/hu-board/public/utils/board-tour.js +62 -0
- package/packages/hu-board/public/utils/board-view.js +49 -144
- package/packages/hu-board/public/utils/command-launcher.js +8 -70
- package/packages/hu-board/public/utils/formatters.js +10 -0
- package/packages/hu-board/public/utils/governance-view.js +13 -1
- package/packages/hu-board/public/utils/hu-actions.js +17 -68
- package/packages/hu-board/public/utils/init-listeners.js +7 -8
- package/packages/hu-board/public/utils/log-panel.js +3 -16
- package/packages/hu-board/public/utils/maggle-mode.js +2 -12
- package/packages/hu-board/public/utils/modals.js +7 -0
- package/packages/hu-board/public/utils/project-picker-view.js +1 -1
- package/packages/hu-board/public/utils/server-push.js +3 -22
- package/packages/hu-board/public/utils/shared-board-notice.js +33 -0
- package/packages/hu-board/public/utils/story-detail-view.js +5 -19
- package/packages/hu-board/src/cleanup-zombies.js +0 -1
- package/packages/hu-board/src/command-runner.js +36 -25
- package/packages/hu-board/src/db-connection.js +282 -0
- package/packages/hu-board/src/db-paths.js +113 -0
- package/packages/hu-board/src/db-queries.js +188 -0
- package/packages/hu-board/src/db-tombstones.js +51 -0
- package/packages/hu-board/src/db.js +28 -619
- package/packages/hu-board/src/ephemeral-cleaner.js +2 -3
- package/packages/hu-board/src/hu-zombie-reaper.js +5 -1
- package/packages/hu-board/src/plan-mutations.js +3 -153
- package/packages/hu-board/src/plans-service.js +55 -0
- package/packages/hu-board/src/routes/api/commands.js +122 -0
- package/packages/hu-board/src/routes/api/plans.js +55 -0
- package/packages/hu-board/src/routes/api/projects.js +267 -0
- package/packages/hu-board/src/routes/api/prompts.js +135 -0
- package/packages/hu-board/src/routes/api/sessions.js +95 -0
- package/packages/hu-board/src/routes/api/stories.js +183 -0
- package/packages/hu-board/src/routes/api/system.js +241 -0
- package/packages/hu-board/src/routes/api/tombstones.js +38 -0
- package/packages/hu-board/src/routes/api.js +24 -1371
- package/packages/hu-board/src/routes/governance.js +23 -1
- package/packages/hu-board/src/routes/lanes.js +40 -0
- package/packages/hu-board/src/routes/rag.js +4 -3
- package/packages/hu-board/src/server.js +20 -34
- package/packages/hu-board/src/sync-files.js +318 -0
- package/packages/hu-board/src/sync-project.js +99 -0
- package/packages/hu-board/src/sync.js +22 -566
- package/packages/hu-board/src/zombie-reaper.js +1 -1
- package/scripts/dual-publish.mjs +19 -3
- package/scripts/postinstall.js +15 -2
- package/scripts/verify-pack-mcp.mjs +11 -7
- package/scripts/verify-pack.mjs +4 -4
- package/src/audit/audit-history.js +3 -2
- package/src/audit/dead-exports.js +68 -59
- package/src/audit/deterministic-summary.js +33 -13
- package/src/audit/npm-signatures.js +41 -0
- package/src/audit/sbom.js +35 -0
- package/src/checks/agent-token.js +112 -0
- package/src/checks/dir-setup.js +34 -1
- package/src/checks/native-build.js +21 -39
- package/src/checks/runner.js +128 -142
- package/src/cli/advanced-commands.js +6 -6
- package/src/cli/register-meta.js +42 -82
- package/src/cli/register-pipeline.js +8 -143
- package/src/cli/register-plan.js +9 -100
- package/src/cli/register-roles-skills.js +1 -1
- package/src/cli/retired-commands.js +49 -0
- package/src/cli.js +18 -5
- package/src/commands/agent-run.js +40 -26
- package/src/commands/audit.js +127 -124
- package/src/commands/board.js +5 -9
- package/src/commands/check.js +29 -16
- package/src/commands/doctor.js +2 -0
- package/src/commands/env.js +176 -150
- package/src/commands/go.js +71 -53
- package/src/commands/harden.js +90 -81
- package/src/commands/hu-start.js +52 -0
- package/src/commands/hu.js +288 -221
- package/src/commands/identity.js +111 -78
- package/src/commands/init-atril.js +47 -0
- package/src/commands/init.js +11 -40
- package/src/commands/install-tools.js +70 -85
- package/src/commands/main-guard.js +78 -0
- package/src/commands/policy.js +226 -184
- package/src/commands/qmd.js +27 -21
- package/src/commands/rag.js +121 -55
- package/src/commands/review-gate.js +421 -341
- package/src/commands/skills.js +4 -1
- package/src/commands/start.js +4 -5
- package/src/commands/steward.js +96 -47
- package/src/commands/tournament.js +46 -37
- package/src/commands/worktree.js +107 -26
- package/src/config/defaults.js +1 -0
- package/src/config/loader.js +34 -17
- package/src/config/role-resolver.js +1 -0
- package/src/config/schema.js +1 -0
- package/src/config/secrets.js +36 -0
- package/src/config.js +1 -0
- package/src/environment/adr.js +16 -2
- package/src/git/karajan-label.js +20 -8
- package/src/guards/main-guard.js +54 -0
- package/src/harden/hook-templates.js +16 -1
- package/src/harden/sentinel/posttooluse.mjs +18 -6
- package/src/harden/sentinel/pretooluse-sentinel.mjs +64 -36
- package/src/harden/sentinel/sentinel-lib.mjs +129 -26
- package/src/harden/sentinel/sentinel-shell.mjs +5 -16
- package/src/harden/sentinel/sessionstart.mjs +3 -2
- package/src/harden/sentinel/stop.mjs +5 -4
- package/src/harden/workflow-templates.js +1 -1
- package/src/hu/board-lookup.js +29 -0
- package/src/hu/gh-identity.js +23 -0
- package/src/hu/github-board.js +4 -2
- package/src/hu/lane-prune.js +83 -13
- package/src/hu/lane-setup.js +65 -0
- package/src/hu/lanes.js +66 -0
- package/src/hu/team-board-mirror.js +3 -2
- package/src/infrastructure/command-runner.js +1 -1
- package/src/infrastructure/file-system-service.js +1 -1
- package/src/mcp/handlers/direct-handlers.js +2 -292
- package/src/mcp/handlers/hu-handlers.js +1 -35
- package/src/mcp/handlers/management-handlers.js +2 -42
- package/src/mcp/handlers/rag-handler.js +9 -1
- package/src/mcp/server-handlers.js +16 -22
- package/src/mcp/tools.js +1 -196
- package/src/plan/lane-plans.js +54 -0
- package/src/plan/plan-store.js +7 -4
- package/src/policy/add.js +26 -12
- package/src/policy/adr-number-check.js +31 -0
- package/src/prompts/audit.js +299 -339
- package/src/prompts/card-context.js +10 -5
- package/src/prompts/reviewer.js +5 -2
- package/src/rag/auto-update.js +71 -44
- package/src/rag/bootstrap-index.js +46 -54
- package/src/rag/indexer.js +9 -4
- package/src/rag/migrate.js +1 -1
- package/src/rag/onnx-fallback.js +2 -2
- package/src/rag/pid-lease.js +181 -0
- package/src/rag/project-store.js +2 -12
- package/src/review/card-first.js +57 -46
- package/src/review/gate-gitignore.js +23 -4
- package/src/review/gate-hook.js +12 -4
- package/src/review/one-shot-review.js +45 -35
- package/src/review/publish-pr.js +14 -2
- package/src/review/repo-docs.js +73 -0
- package/src/review/repo-stack.js +59 -0
- package/src/review/reviewer-fallback.js +19 -4
- package/src/review/seal-commit.js +29 -0
- package/src/review/sonar-pregate.js +59 -44
- package/src/review/third-party-review.js +90 -16
- package/src/review/third-party-size.js +43 -0
- package/src/review/third-party-skills.js +54 -0
- package/src/review/verify-pr.js +1 -24
- package/src/roles/audit-role.js +106 -125
- package/src/skills/atril-cli.js +19 -1
- package/src/skills/atril-skills.js +5 -4
- package/src/skills/skills-search.js +72 -0
- package/src/skills/translate.js +62 -0
- package/src/sonar/scanner.js +116 -101
- package/src/steward/invariants.js +5 -4
- package/src/steward/phantom-sweep.js +66 -0
- package/src/tournament/judge.js +60 -53
- package/src/utils/gh-account.js +37 -0
- package/src/utils/git.js +0 -13
- package/src/utils/home-migration.js +7 -1
- package/src/utils/main-checkout.js +53 -0
- package/src/utils/qmd-collection.js +3 -1
- package/src/utils/welcome.js +3 -3
- package/templates/{skills → atril/commands}/kj-architect.md +5 -0
- package/templates/{skills → atril/commands}/kj-audit.md +5 -0
- package/templates/{skills → atril/commands}/kj-board.md +5 -0
- package/templates/{skills → atril/commands}/kj-code.md +5 -0
- package/templates/{skills → atril/commands}/kj-csv-transform.md +5 -0
- package/templates/{skills → atril/commands}/kj-data-report.md +5 -0
- package/templates/{skills → atril/commands}/kj-discover.md +5 -0
- package/templates/{skills → atril/commands}/kj-rag-query.md +5 -0
- package/templates/{skills → atril/commands}/kj-review.md +5 -0
- package/templates/{skills → atril/commands}/kj-security.md +5 -0
- package/templates/{skills → atril/commands}/kj-sonar.md +5 -0
- package/templates/{skills → atril/commands}/kj-sql-analysis.md +5 -0
- package/templates/{skills → atril/commands}/kj-test.md +5 -0
- package/packages/hu-board/public/utils/run-launcher.js +0 -169
- package/packages/hu-board/src/run-tracker.js +0 -121
- package/src/activity-log.js +0 -59
- package/src/agents/host-agent.js +0 -38
- package/src/agents/model-registry.js +0 -142
- package/src/audit/plan-adherence.js +0 -224
- package/src/autonomy/arbiter-role.js +0 -71
- package/src/autonomy/arbiter.js +0 -22
- package/src/autonomy/decider.js +0 -18
- package/src/autonomy/decision-resolver.js +0 -58
- package/src/autonomy/outcome-report.js +0 -55
- package/src/autonomy/stage-ask.js +0 -30
- package/src/brain/decision-tracker.js +0 -125
- package/src/brain/decisor.js +0 -243
- package/src/brain/solomon-consult.js +0 -171
- package/src/brain/standby-scheduler.js +0 -8
- package/src/budget/comparison.js +0 -96
- package/src/canvas/parse-md.js +0 -238
- package/src/canvas/schema.js +0 -101
- package/src/canvas/to-flat.js +0 -85
- package/src/canvas/validate.js +0 -163
- package/src/ci/dispatch.js +0 -99
- package/src/ci/index.js +0 -3
- package/src/ci/pr-diff.js +0 -26
- package/src/cli/register-standby.js +0 -26
- package/src/commands/architect.js +0 -111
- package/src/commands/autorun.js +0 -49
- package/src/commands/researcher.js +0 -54
- package/src/commands/resume.js +0 -72
- package/src/commands/review.js +0 -89
- package/src/commands/run.js +0 -185
- package/src/commands/standby.js +0 -117
- package/src/commands/status.js +0 -36
- package/src/commands/triage.js +0 -78
- package/src/commands/undo.js +0 -62
- package/src/domains/domain-loader.js +0 -245
- package/src/domains/domain-registry.js +0 -140
- package/src/domains/domain-synthesizer.js +0 -129
- package/src/git/automation.js +0 -433
- package/src/git/coder-commit-guard.js +0 -40
- package/src/git/hu-automation.js +0 -243
- package/src/git/hu-snapshot.js +0 -10
- package/src/git/symlink-targets.js +0 -57
- package/src/golden/asserter.js +0 -92
- package/src/golden/loader.js +0 -52
- package/src/golden/runner.js +0 -92
- package/src/golden/schema.js +0 -41
- package/src/guards/duplicate-members.js +0 -86
- package/src/guards/intent-guard.js +0 -161
- package/src/guards/perf-guard.js +0 -126
- package/src/guards/policy-guard.js +0 -90
- package/src/guards/policy-resolver.js +0 -85
- package/src/guards/secret-redactor.js +0 -71
- package/src/hu/acceptance-runner.js +0 -138
- package/src/hu/lazy-planner.js +0 -109
- package/src/hu/parallel-executor.js +0 -94
- package/src/hu/routing-metrics.js +0 -17
- package/src/hu/split-validator.js +0 -143
- package/src/hu/splitting-detector.js +0 -158
- package/src/hu/splitting-generator.js +0 -175
- package/src/hu/store.js +0 -394
- package/src/infrastructure/mocks.js +0 -182
- package/src/mcp/handlers/run-handler.js +0 -318
- package/src/mcp/sovereignty-guard.js +0 -113
- package/src/mcp/tool-arg-normalizers.js +0 -16
- package/src/mutate/reviewer-signal.js +0 -76
- package/src/orchestrator/agent-fallback.js +0 -81
- package/src/orchestrator/brain-coordinator.js +0 -186
- package/src/orchestrator/ci-integration.js +0 -139
- package/src/orchestrator/config-init.js +0 -426
- package/src/orchestrator/direct-actions.js +0 -217
- package/src/orchestrator/drivers/error-recovery.js +0 -287
- package/src/orchestrator/drivers/init-context.js +0 -238
- package/src/orchestrator/drivers/iteration-loop.js +0 -382
- package/src/orchestrator/drivers/iteration-phases/coder-and-refactorer.js +0 -69
- package/src/orchestrator/drivers/iteration-phases/guards.js +0 -91
- package/src/orchestrator/drivers/iteration-phases/handle-approved.js +0 -29
- package/src/orchestrator/drivers/iteration-phases/quality-gates.js +0 -125
- package/src/orchestrator/drivers/iteration-phases/reviewer-gate.js +0 -62
- package/src/orchestrator/drivers/post-loop.js +0 -404
- package/src/orchestrator/drivers/pre-loop-phases/auto-hu-batch.js +0 -137
- package/src/orchestrator/drivers/pre-loop-phases/config-deprecations.js +0 -47
- package/src/orchestrator/drivers/pre-loop-phases/ensure-addyosmani-skills.js +0 -84
- package/src/orchestrator/drivers/pre-loop-phases/inject-loaded-plan.js +0 -393
- package/src/orchestrator/drivers/pre-loop.js +0 -524
- package/src/orchestrator/drivers/run-hu-batch.js +0 -468
- package/src/orchestrator/feedback-enrichment.js +0 -140
- package/src/orchestrator/feedback-queue.js +0 -151
- package/src/orchestrator/flow-control.js +0 -170
- package/src/orchestrator/flow-runner.js +0 -365
- package/src/orchestrator/fs-leak-detector.js +0 -228
- package/src/orchestrator/hu-scheduler.js +0 -114
- package/src/orchestrator/hu-sub-pipeline.js +0 -642
- package/src/orchestrator/iteration-gate.js +0 -73
- package/src/orchestrator/iteration-stages.js +0 -9
- package/src/orchestrator/parallel-limiter.js +0 -74
- package/src/orchestrator/pipeline-context.js +0 -72
- package/src/orchestrator/post-loop-stages.js +0 -468
- package/src/orchestrator/pre-loop-stages.js +0 -11
- package/src/orchestrator/preflight-checks.js +0 -487
- package/src/orchestrator/repair/repair-detector.js +0 -117
- package/src/orchestrator/repair/repair-runner.js +0 -142
- package/src/orchestrator/reviewer-fallback.js +0 -45
- package/src/orchestrator/role-output-compressor.js +0 -189
- package/src/orchestrator/session-journal.js +0 -308
- package/src/orchestrator/solomon-escalation.js +0 -331
- package/src/orchestrator/solomon-rules.js +0 -212
- package/src/orchestrator/stages/acceptance-coverage-stage.js +0 -47
- package/src/orchestrator/stages/architect-stage.js +0 -172
- package/src/orchestrator/stages/coder-stage.js +0 -506
- package/src/orchestrator/stages/domain-curator-stage.js +0 -82
- package/src/orchestrator/stages/format-stage.js +0 -61
- package/src/orchestrator/stages/hu-reviewer-phases/detect-and-apply-splits.js +0 -127
- package/src/orchestrator/stages/hu-reviewer-stage.js +0 -419
- package/src/orchestrator/stages/perf-stage.js +0 -140
- package/src/orchestrator/stages/planner-stage.js +0 -85
- package/src/orchestrator/stages/rag-context-stage.js +0 -80
- package/src/orchestrator/stages/rag-preload-decisor.js +0 -58
- package/src/orchestrator/stages/research-stage.js +0 -69
- package/src/orchestrator/stages/reviewer-stage.js +0 -431
- package/src/orchestrator/stages/sonar-stage.js +0 -439
- package/src/orchestrator/stages/stage-classes.js +0 -84
- package/src/orchestrator/stages/stage-executor.js +0 -155
- package/src/orchestrator/stages/suite-green-stage.js +0 -62
- package/src/orchestrator/stages/tdd-discipline-stage.js +0 -56
- package/src/orchestrator/stages/tool-judge-stage.js +0 -53
- package/src/orchestrator/stages/triage-stage.js +0 -172
- package/src/orchestrator/standby.js +0 -71
- package/src/orchestrator/verification-gate.js +0 -183
- package/src/orchestrator.js +0 -22
- package/src/plan/adr-generator.js +0 -170
- package/src/plan/adr-loader.js +0 -60
- package/src/plan/plan-executor.js +0 -100
- package/src/plan/plan-validation.js +0 -4
- package/src/prompts/acceptance-coverage.js +0 -32
- package/src/prompts/arbiter.js +0 -38
- package/src/prompts/architect.js +0 -103
- package/src/prompts/hu-reviewer.js +0 -244
- package/src/prompts/tool-correctness-judge.js +0 -31
- package/src/prompts/triage.js +0 -57
- package/src/rag/embedder.js +0 -2
- package/src/rag/embedders/_cloud-base.js +0 -2
- package/src/rag/embedders/cohere.js +0 -2
- package/src/rag/embedders/mistral.js +0 -2
- package/src/rag/embedders/onnx.js +0 -2
- package/src/rag/embedders/openai.js +0 -2
- package/src/rag/embedders/voyage.js +0 -2
- package/src/rag/rerank.js +0 -4
- package/src/rag/where-parser.js +0 -4
- package/src/repeat-detector.js +0 -88
- package/src/review/diff-generator.js +0 -112
- package/src/review/git-stash-helper.js +0 -104
- package/src/review/schema.js +0 -31
- package/src/review/scope-filter.js +0 -152
- package/src/review/snapshot-diff.js +0 -122
- package/src/review/tdd-discipline.js +0 -90
- package/src/review/tdd-policy.js +0 -69
- package/src/roles/acceptance-coverage-role.js +0 -78
- package/src/roles/architect-role.js +0 -77
- package/src/roles/coder-role.js +0 -113
- package/src/roles/commiter-role.js +0 -113
- package/src/roles/domain-curator-role.js +0 -134
- package/src/roles/hu-reviewer-role.js +0 -64
- package/src/roles/impeccable-role.js +0 -85
- package/src/roles/index.js +0 -18
- package/src/roles/karajan-brain-role.js +0 -134
- package/src/roles/perf-role.js +0 -122
- package/src/roles/planner-role.js +0 -151
- package/src/roles/refactorer-role.js +0 -30
- package/src/roles/repairer-role.js +0 -181
- package/src/roles/researcher-role.js +0 -70
- package/src/roles/reviewer-role.js +0 -115
- package/src/roles/security-role.js +0 -73
- package/src/roles/solomon-role.js +0 -271
- package/src/roles/sonar-role.js +0 -72
- package/src/roles/tester-role.js +0 -235
- package/src/roles/tool-correctness-judge-role.js +0 -78
- package/src/roles/triage-role.js +0 -99
- package/src/session/journal/decisions-writer.js +0 -200
- package/src/session/journal/iteration-logger.js +0 -194
- package/src/session/journal/summary-writer.js +0 -320
- package/src/session/journal/tree-writer.js +0 -164
- package/src/session/journal/write-all.js +0 -89
- package/src/session-cleanup.js +0 -116
- package/src/skills/semantic-detector.js +0 -167
- package/src/skills/skill-detector.js +0 -385
- package/src/sonar/cloud-scanner.js +0 -78
- package/src/tracker-bootstrap.js +0 -44
- package/src/types/index.js +0 -38
- package/src/types/policy.js +0 -43
- package/src/types/solomon.js +0 -87
- package/src/utils/async-lock.js +0 -31
- package/src/utils/budget.js +0 -229
- package/src/utils/cwd-confirm.js +0 -39
- package/src/utils/display/event-handlers.js +0 -403
- package/src/utils/display/formatters.js +0 -132
- package/src/utils/display/header.js +0 -47
- package/src/utils/display/session-summary.js +0 -118
- package/src/utils/display/solomon.js +0 -42
- package/src/utils/pricing.js +0 -29
- package/src/utils/quota-simulator.js +0 -56
- package/src/utils/role-assigner.js +0 -137
- package/src/utils/rtk-wrapper.js +0 -87
- package/src/utils/run-registry.js +0 -9
- package/src/utils/status-dashboard.js +0 -254
- package/src/utils/tool-call-extractor.js +0 -56
- package/src/webperf/devtools-detect.js +0 -112
- package/src/webperf/webperf-role-integration.js +0 -66
- package/templates/skills/kj-run.md +0 -73
|
@@ -82,6 +82,58 @@ export function groupByScanRoot(files, { root = process.cwd(), exists = existsSy
|
|
|
82
82
|
return groups;
|
|
83
83
|
}
|
|
84
84
|
|
|
85
|
+
// One scan root: scan it, prove its coverage, read its issues (repo-relative).
|
|
86
|
+
async function scanGroup(config, dir, { projectDir, rootCwd, logger }) {
|
|
87
|
+
const prefix = dir ? `${dir}/` : "";
|
|
88
|
+
// KJC-TSK-0838: verbose, so the scanner names every file it indexed.
|
|
89
|
+
const scanCwd = dir ? join(projectDir, dir) : rootCwd;
|
|
90
|
+
const scan = await runSonarScan(config, null, { verbose: true, ...(scanCwd ? { cwd: scanCwd } : {}) });
|
|
91
|
+
if (scan.note) logger?.warn?.(scan.note); // KJC-BUG-0156: precedence is said, never silent
|
|
92
|
+
if (!scan.ok) {
|
|
93
|
+
return { failure: { available: false, reason: (scan.stderr || scan.stdout || "sonar scan failed").trim() } };
|
|
94
|
+
}
|
|
95
|
+
// Coverage is PROVED by the scanner's own index, never inferred from
|
|
96
|
+
// config — a root-scoped properties file let 4 PRs under packages/radar
|
|
97
|
+
// pass as "0 issues on staged files". No index in the log = no proof.
|
|
98
|
+
const own = indexedFilesFrom(scan.stdout);
|
|
99
|
+
if (own.size === 0) {
|
|
100
|
+
return { failure: { available: false, reason: `the scanner log names no indexed file (sonar.verbose) — coverage cannot be proved for ${dir || "the repo root"}` } };
|
|
101
|
+
}
|
|
102
|
+
// The scan above ALWAYS runs before issues are read (single-flight), and
|
|
103
|
+
// it returns once the server has processed it (KJC-BUG-0263: before, the
|
|
104
|
+
// upload returned first and the issues read were the previous analysis).
|
|
105
|
+
const res = await getOpenIssues(config, scan.projectKey);
|
|
106
|
+
return {
|
|
107
|
+
indexed: [...own].map((f) => `${prefix}${f}`),
|
|
108
|
+
projectKey: scan.projectKey,
|
|
109
|
+
total: res.total ?? (res.issues || []).length,
|
|
110
|
+
// Issue components are package-relative: made repo-relative here.
|
|
111
|
+
issues: (res.issues || []).map((i) => ({ ...i, component: `${scan.projectKey}:${prefix}${issueFile(i)}` })),
|
|
112
|
+
};
|
|
113
|
+
}
|
|
114
|
+
|
|
115
|
+
function pregateResult({ config, stagedFiles, touchedLines, indexed, issues, keys, totalProject }) {
|
|
116
|
+
const { sources } = sourceFilesOf(config, stagedFiles);
|
|
117
|
+
const staged = new Set(stagedFiles);
|
|
118
|
+
const onStaged = issues.filter((i) => staged.has(issueFile(i)));
|
|
119
|
+
// KJC-TSK-0795 AC3: with the diff's line map, only issues on lines the PR
|
|
120
|
+
// ADDS can veto — a 3-line PR must not answer for 30 preexisting issues.
|
|
121
|
+
// No line, or an untouched line, is the file's TREND: reported, never a block.
|
|
122
|
+
const isTouched = (i) => !touchedLines || (i.line != null && touchedLines.get(issueFile(i))?.has(Number(i.line)));
|
|
123
|
+
const mine = onStaged.filter(isTouched);
|
|
124
|
+
const isBlocking = (i) => BLOCKING_SEVERITIES.has(String(i.severity).toUpperCase());
|
|
125
|
+
return {
|
|
126
|
+
available: true,
|
|
127
|
+
projectKey: keys.join(","),
|
|
128
|
+
covered: sources.filter((f) => indexed.has(f)),
|
|
129
|
+
uncovered: sources.filter((f) => !indexed.has(f)),
|
|
130
|
+
blocking: mine.filter(isBlocking),
|
|
131
|
+
advisory: mine.filter((i) => !isBlocking(i)),
|
|
132
|
+
preexisting: touchedLines ? onStaged.filter((i) => !isTouched(i)) : [],
|
|
133
|
+
totalProject,
|
|
134
|
+
};
|
|
135
|
+
}
|
|
136
|
+
|
|
85
137
|
// KJC-TSK-1078: projectDir is where the files live (a third-party PR's clone may not be the cwd).
|
|
86
138
|
export async function runSonarPregate({ config, stagedFiles = [], touchedLines = null, logger = null, exists = existsSync, projectDir = process.cwd() }) {
|
|
87
139
|
if (config?.review_gate?.sonar === false) {
|
|
@@ -104,51 +156,14 @@ export async function runSonarPregate({ config, stagedFiles = [], touchedLines =
|
|
|
104
156
|
const keys = [];
|
|
105
157
|
let totalProject = 0;
|
|
106
158
|
for (const dir of groups.keys()) {
|
|
107
|
-
const
|
|
108
|
-
|
|
109
|
-
const
|
|
110
|
-
|
|
111
|
-
|
|
112
|
-
|
|
113
|
-
return { available: false, reason: (scan.stderr || scan.stdout || "sonar scan failed").trim() };
|
|
114
|
-
}
|
|
115
|
-
// Coverage is PROVED by the scanner's own index, never inferred from
|
|
116
|
-
// config — a root-scoped properties file let 4 PRs under packages/radar
|
|
117
|
-
// pass as "0 issues on staged files". No index in the log = no proof.
|
|
118
|
-
const own = indexedFilesFrom(scan.stdout);
|
|
119
|
-
if (own.size === 0) {
|
|
120
|
-
return { available: false, reason: `the scanner log names no indexed file (sonar.verbose) — coverage cannot be proved for ${dir || "the repo root"}` };
|
|
121
|
-
}
|
|
122
|
-
for (const f of own) indexed.add(`${prefix}${f}`);
|
|
123
|
-
keys.push(scan.projectKey);
|
|
124
|
-
// The scan above ALWAYS runs before issues are read (single-flight), and
|
|
125
|
-
// it returns once the server has processed it (KJC-BUG-0263: before, the
|
|
126
|
-
// upload returned first and the issues read were the previous analysis).
|
|
127
|
-
const res = await getOpenIssues(config, scan.projectKey);
|
|
128
|
-
totalProject += res.total ?? (res.issues || []).length;
|
|
129
|
-
// Issue components are package-relative: made repo-relative here.
|
|
130
|
-
for (const i of res.issues || []) issues.push({ ...i, component: `${scan.projectKey}:${prefix}${issueFile(i)}` });
|
|
159
|
+
const group = await scanGroup(config, dir, { projectDir, rootCwd, logger });
|
|
160
|
+
if (group.failure) return group.failure;
|
|
161
|
+
for (const f of group.indexed) indexed.add(f);
|
|
162
|
+
keys.push(group.projectKey);
|
|
163
|
+
totalProject += group.total;
|
|
164
|
+
issues.push(...group.issues);
|
|
131
165
|
}
|
|
132
|
-
|
|
133
|
-
const covered = sources.filter((f) => indexed.has(f));
|
|
134
|
-
const uncovered = sources.filter((f) => !indexed.has(f));
|
|
135
|
-
const staged = new Set(stagedFiles);
|
|
136
|
-
const onStaged = issues.filter((i) => staged.has(issueFile(i)));
|
|
137
|
-
// KJC-TSK-0795 AC3: with the diff's line map, only issues on lines the PR
|
|
138
|
-
// ADDS can veto — a 3-line PR must not answer for 30 preexisting issues.
|
|
139
|
-
// No line, or an untouched line, is the file's TREND: reported, never a block.
|
|
140
|
-
const isTouched = (i) => !touchedLines || (i.line != null && touchedLines.get(issueFile(i))?.has(Number(i.line)));
|
|
141
|
-
const mine = onStaged.filter(isTouched);
|
|
142
|
-
return {
|
|
143
|
-
available: true,
|
|
144
|
-
projectKey: keys.join(","),
|
|
145
|
-
covered,
|
|
146
|
-
uncovered,
|
|
147
|
-
blocking: mine.filter((i) => BLOCKING_SEVERITIES.has(String(i.severity).toUpperCase())),
|
|
148
|
-
advisory: mine.filter((i) => !BLOCKING_SEVERITIES.has(String(i.severity).toUpperCase())),
|
|
149
|
-
preexisting: touchedLines ? onStaged.filter((i) => !isTouched(i)) : [],
|
|
150
|
-
totalProject,
|
|
151
|
-
};
|
|
166
|
+
return pregateResult({ config, stagedFiles, touchedLines, indexed, issues, keys, totalProject });
|
|
152
167
|
} catch (err) {
|
|
153
168
|
logger?.warn?.(`[sonar-pregate] ${err.message}`);
|
|
154
169
|
return { available: false, reason: err.message };
|
|
@@ -14,8 +14,14 @@ import { isGenerated } from "./loc-budget.js";
|
|
|
14
14
|
import { prSecurityChecks } from "./pr-security.js";
|
|
15
15
|
import { sonarCheck } from "./pr-sonar.js";
|
|
16
16
|
import { batchDiff, splitByFile } from "./diff-batches.js";
|
|
17
|
+
import { ceilingOf, isTooLarge, measureCode, tooLargeSummary } from "./third-party-size.js";
|
|
17
18
|
import { lensTask } from "./review-lens.js";
|
|
18
|
-
import { thirdPartyTask } from "./untrusted-context.js";
|
|
19
|
+
import { thirdPartyTask, THIRD_PARTY_INSTRUCTION } from "./untrusted-context.js";
|
|
20
|
+
import { baseOf, readRepoDocs, repoDocsTask } from "./repo-docs.js";
|
|
21
|
+
import { detectStack } from "./repo-stack.js";
|
|
22
|
+
import { thirdPartySkills } from "./third-party-skills.js";
|
|
23
|
+
import { hasAtrilStore } from "../skills/atril-skills.js";
|
|
24
|
+
import { MAX_SKILLS } from "../skills/role-skills.js";
|
|
19
25
|
import { readTaskFile } from "../utils/task-file.js";
|
|
20
26
|
import { DIFF_CLIP_CHARS } from "../prompts/diff-clip.js";
|
|
21
27
|
import { assertCrossFamily, verifyFindings } from "./run-verifier.js";
|
|
@@ -37,13 +43,13 @@ const finding = (i) => ({
|
|
|
37
43
|
});
|
|
38
44
|
|
|
39
45
|
/** The review as data: verdict, findings, suggestions, security checks and, apart, the house requirements. */
|
|
40
|
-
export async function thirdPartyReview({ range, config, projectDir, logger, task = null, gitDiff = gitDiffOf, run = runOneShotReview, requirements = prRequirementChecks, security = prSecurityChecks, sonar = sonarCheck, limit = DIFF_CLIP_CHARS, maxBatches = MAX_REVIEW_BATCHES, sizeLimit = null, verifier = null, verifierModel = null, verify = verifyFindings, reviewers = null }) {
|
|
41
|
-
|
|
42
|
-
const reviewerRole = resolveRole(config, "reviewer");
|
|
43
|
-
if (verifier) assertCrossFamily({ reviewer: reviewerRole.provider, reviewerModel: reviewerRole.model, verifier, verifierModel, logger });
|
|
44
|
-
// KJC-TSK-1248 (#2623): two reviewers of the same family would share their blind spots.
|
|
45
|
-
if (reviewers) assertCrossFamily({ reviewer: reviewers[0].provider, reviewerModel: reviewers[0].model, verifier: reviewers[1].provider, verifierModel: reviewers[1].model, logger, flag: "--reviewers" });
|
|
46
|
+
export async function thirdPartyReview({ range, config, projectDir, logger, task = null, gitDiff = gitDiffOf, run = runOneShotReview, requirements = prRequirementChecks, security = prSecurityChecks, sonar = sonarCheck, limit = DIFF_CLIP_CHARS, maxBatches = MAX_REVIEW_BATCHES, sizeLimit = null, verifier = null, verifierModel = null, verify = verifyFindings, reviewers = null, repoDocs = readRepoDocs, hasStore = hasAtrilStore, stackOf = detectStack, skillsFor = thirdPartySkills }) {
|
|
47
|
+
const reviewerRole = assertPanel({ config, verifier, verifierModel, reviewers, logger });
|
|
46
48
|
const diff = await gitDiff(projectDir, range);
|
|
49
|
+
const budget = () => sizeLimit ?? prSizeLimit({ projectDir, config }).limit;
|
|
50
|
+
// KJC-TSK-1356 (#3027): past the ceiling, no reviewer runs: the size, the ceiling and the split.
|
|
51
|
+
const tooLarge = sizeVerdict({ diff, config, range, budget });
|
|
52
|
+
if (tooLarge) return tooLarge;
|
|
47
53
|
// KJC-TSK-1076/1077: the PR's requirements and its security, with no tokens; they never stop the review.
|
|
48
54
|
// KJC-BUG-0379 (#2263): the house requirements (size, commits, attribution, tests) travel apart:
|
|
49
55
|
// on another repo with other conventions they must not read as findings next to security.
|
|
@@ -54,34 +60,87 @@ export async function thirdPartyReview({ range, config, projectDir, logger, task
|
|
|
54
60
|
const provider = reviewerRole.provider || null;
|
|
55
61
|
const { batches, coverage } = batchDiff(diff, { limit, maxBatches });
|
|
56
62
|
if (coverage.files.total === 0) throw new Error(`nothing to review — ${range} has no file changes`);
|
|
63
|
+
// KJC-TSK-1266 (#2753): the repo's own docs at the base, fenced as untrusted, and named in the output.
|
|
64
|
+
const { repoContext, reviewTask } = await withRepoDocs({ repoDocs, projectDir, range, task, logger });
|
|
65
|
+
// KJC-TSK-1272 (#2753): a repo with no atril store gets skills for its stack; the temporary store goes after the review.
|
|
66
|
+
const stackSkills = await gatherStackSkills({ projectDir, range, config, logger, hasStore, stackOf, skillsFor });
|
|
67
|
+
repoContext.skills = stackSkills.report;
|
|
57
68
|
const reviewWith = async (who, cfg) => {
|
|
58
69
|
const recs = [];
|
|
59
|
-
for (const batch of batches) recs.push(await run({ diff: batch.text, task, config: cfg, logger, projectDir, reviewerOverride: who, persist: false }));
|
|
70
|
+
for (const batch of batches) recs.push(await run({ diff: batch.text, task: reviewTask, config: cfg, logger, projectDir, reviewerOverride: who, persist: false, skills: stackSkills.block }));
|
|
60
71
|
return recs;
|
|
61
72
|
};
|
|
62
|
-
|
|
63
|
-
|
|
64
|
-
|
|
73
|
+
const advice = () => adviceFor(diff, budget());
|
|
74
|
+
try {
|
|
75
|
+
const review = reviewers
|
|
76
|
+
? await dualReview({ reviewers, reviewWith, verify, diff, coverage, config, logger })
|
|
77
|
+
: await singleReview({ provider, reviewWith, verifier, verifierModel, verify, diff, coverage, config, logger });
|
|
78
|
+
return { mode: "third-party", range, ...review, checks, policyChecks, repoContext, advice: advice() };
|
|
79
|
+
} finally {
|
|
80
|
+
stackSkills.cleanup();
|
|
65
81
|
}
|
|
82
|
+
}
|
|
83
|
+
|
|
84
|
+
// Panel checks before any token is spent; returns the configured reviewer role.
|
|
85
|
+
function assertPanel({ config, verifier, verifierModel, reviewers, logger }) {
|
|
86
|
+
// KJC-TSK-1195: a verifier of the reviewer's own family is refused before any token is spent.
|
|
87
|
+
const reviewerRole = resolveRole(config, "reviewer");
|
|
88
|
+
if (verifier) assertCrossFamily({ reviewer: reviewerRole.provider, reviewerModel: reviewerRole.model, verifier, verifierModel, logger });
|
|
89
|
+
// KJC-TSK-1248 (#2623): two reviewers of the same family would share their blind spots.
|
|
90
|
+
if (reviewers) assertCrossFamily({ reviewer: reviewers[0].provider, reviewerModel: reviewers[0].model, verifier: reviewers[1].provider, verifierModel: reviewers[1].model, logger, flag: "--reviewers" });
|
|
91
|
+
return reviewerRole;
|
|
92
|
+
}
|
|
93
|
+
|
|
94
|
+
// KJC-TSK-1266 (#2753): the repo's own docs at the base, fenced as untrusted, and named in the output.
|
|
95
|
+
async function withRepoDocs({ repoDocs, projectDir, range, task, logger }) {
|
|
96
|
+
const docs = await repoDocs({ projectDir, base: baseOf(range) });
|
|
97
|
+
if (docs.error) logger.warn?.(docs.error);
|
|
98
|
+
return {
|
|
99
|
+
repoContext: { files: docs.files, omitted: docs.omitted, ...(docs.error && { error: docs.error }) },
|
|
100
|
+
reviewTask: docs.text ? repoDocsTask(task ?? THIRD_PARTY_INSTRUCTION, docs) : task,
|
|
101
|
+
};
|
|
102
|
+
}
|
|
103
|
+
|
|
104
|
+
async function singleReview({ provider, reviewWith, verifier, verifierModel, verify, diff, coverage, config, logger }) {
|
|
66
105
|
const records = await reviewWith(provider, config);
|
|
67
106
|
const findings = records.flatMap((r) => (r.issues ?? []).map(finding));
|
|
68
107
|
// KJC-TSK-1195 (#2369): with a verifier, the findings are the verified ones and the block says what changed.
|
|
69
108
|
const verified = verifier ? await verify({ findings, diff, verifier, model: verifierModel, config, logger }) : null;
|
|
70
109
|
return {
|
|
71
|
-
mode: "third-party",
|
|
72
|
-
range,
|
|
73
110
|
reviewer: records[0]?.reviewer ?? provider,
|
|
74
111
|
verdict: verdictOf(records, coverage),
|
|
75
112
|
coverage,
|
|
76
113
|
findings: verified ? verified.findings : findings,
|
|
77
114
|
...(verified && { verification: verified.verification }),
|
|
78
115
|
suggestions: records.flatMap((r) => r.suggestions ?? []),
|
|
79
|
-
checks,
|
|
80
|
-
policyChecks,
|
|
81
|
-
advice: adviceFor(diff, sizeLimit ?? prSizeLimit({ projectDir, config }).limit),
|
|
82
116
|
};
|
|
83
117
|
}
|
|
84
118
|
|
|
119
|
+
/**
|
|
120
|
+
* KJC-TSK-1272 (#2753): the skills for the reviewed repo's stack, the prompt block that carries
|
|
121
|
+
* them, what to report and how to remove the temporary store. A repo with its own atril store
|
|
122
|
+
* keeps the usual path; a failure is reported and the review goes on without them.
|
|
123
|
+
*/
|
|
124
|
+
async function gatherStackSkills({ projectDir, range, config, logger, hasStore, stackOf, skillsFor }) {
|
|
125
|
+
const none = { block: null, cleanup: () => {} };
|
|
126
|
+
if (projectDir && hasStore(projectDir)) return { ...none, report: { source: "the reviewed repo's atril store" } };
|
|
127
|
+
try {
|
|
128
|
+
if (!projectDir) throw new Error("no project directory to read the stack from");
|
|
129
|
+
const stack = await stackOf({ projectDir, base: baseOf(range) });
|
|
130
|
+
const max = config?.skills?.max_per_role ?? MAX_SKILLS;
|
|
131
|
+
const found = await skillsFor({ stack, max, catalogs: config?.review?.third_party?.catalogs ?? [] });
|
|
132
|
+
return {
|
|
133
|
+
block: found.skills.length ? { skills: found.skills, dropped: found.dropped, limit: max } : null,
|
|
134
|
+
report: { stack, used: found.skills.map((s) => s.name), installed: found.installed, dropped: found.dropped, ...(found.reason && { reason: found.reason }) },
|
|
135
|
+
cleanup: found.cleanup,
|
|
136
|
+
};
|
|
137
|
+
} catch (e) {
|
|
138
|
+
const error = `the stack's skills could not be gathered: ${e.message}`;
|
|
139
|
+
logger.warn?.(error);
|
|
140
|
+
return { ...none, report: { error } };
|
|
141
|
+
}
|
|
142
|
+
}
|
|
143
|
+
|
|
85
144
|
/**
|
|
86
145
|
* KJC-TSK-1248 (#2623): both reviewers review the whole range on their own, in parallel, each
|
|
87
146
|
* with its model; each one's findings are verified by the other family; one reconciled result.
|
|
@@ -99,6 +158,21 @@ async function dualReview({ reviewers, reviewWith, verify, diff, coverage, confi
|
|
|
99
158
|
return { reviewer: reviewers.map((r) => r.provider).join("+"), ...reconciled, suggestions: records.flat().flatMap((r) => r.suggestions ?? []) };
|
|
100
159
|
}
|
|
101
160
|
|
|
161
|
+
/** KJC-TSK-1356 (#3027): the too_large result, or null when the PR is within the ceiling. */
|
|
162
|
+
function sizeVerdict({ diff, config, range, budget }) {
|
|
163
|
+
const ceiling = ceilingOf(config);
|
|
164
|
+
const files = splitByFile(diff);
|
|
165
|
+
const size = measureCode(files);
|
|
166
|
+
if (!isTooLarge(size, ceiling)) return null;
|
|
167
|
+
const limit = budget();
|
|
168
|
+
return {
|
|
169
|
+
mode: "third-party", range,
|
|
170
|
+
verdict: { status: "too_large", approved: false, summary: tooLargeSummary(size, ceiling, limit) },
|
|
171
|
+
size, threshold: ceiling, findings: [], suggestions: [],
|
|
172
|
+
advice: { split: splitAdvice(files.filter((f) => !isGenerated(f.file)), { limit }) },
|
|
173
|
+
};
|
|
174
|
+
}
|
|
175
|
+
|
|
102
176
|
/** KJC-TSK-1101: over the size budget, how to split the PR; advice only, never a finding. */
|
|
103
177
|
function adviceFor(diff, budget) {
|
|
104
178
|
const files = splitByFile(diff).filter((f) => !isGenerated(f.file));
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
// KJC-TSK-1356 (#3027): how big a third-party PR is, in CODE, and whether it is past the exceptional
|
|
2
|
+
// ceiling past which kj does not review it. Karajan's norm is atomic PRs (the split advice aims at
|
|
3
|
+
// the repo's PR budget); the ceiling is the exception, not the target.
|
|
4
|
+
import { isGenerated } from "./loc-budget.js";
|
|
5
|
+
|
|
6
|
+
export const MAX_CODE_LINES = 800;
|
|
7
|
+
export const MAX_CODE_FILES = 20;
|
|
8
|
+
|
|
9
|
+
// Markdown, docs and JSON never count, nor anything generated (lockfiles, build output...).
|
|
10
|
+
const NOT_CODE = /\.(md|mdx|markdown|txt|rst|adoc|json|jsonc)$/i;
|
|
11
|
+
|
|
12
|
+
/** @param {string} file */
|
|
13
|
+
export const countsAsCode = (file) => Boolean(file) && !isGenerated(file) && !NOT_CODE.test(file);
|
|
14
|
+
|
|
15
|
+
const positive = (value, key) => {
|
|
16
|
+
if (value === undefined) return null;
|
|
17
|
+
if (!Number.isInteger(value) || value <= 0) throw new Error(`review.third_party.${key} must be a positive integer, got ${JSON.stringify(value)}`);
|
|
18
|
+
return value;
|
|
19
|
+
};
|
|
20
|
+
|
|
21
|
+
/** The ceiling: review.third_party.max_lines / max_files, or 800 lines / 20 files. */
|
|
22
|
+
export function ceilingOf(config) {
|
|
23
|
+
const t = config?.review?.third_party ?? {};
|
|
24
|
+
return {
|
|
25
|
+
maxLines: positive(t.max_lines, "max_lines") ?? MAX_CODE_LINES,
|
|
26
|
+
maxFiles: positive(t.max_files, "max_files") ?? MAX_CODE_FILES,
|
|
27
|
+
};
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
/** @param {Array<{file: string, changed: number}>} files from splitByFile */
|
|
31
|
+
export function measureCode(files) {
|
|
32
|
+
const code = files.filter((f) => countsAsCode(f.file));
|
|
33
|
+
return { codeLines: code.reduce((n, f) => n + f.changed, 0), codeFiles: code.length, otherFiles: files.length - code.length };
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
export const isTooLarge = (size, ceiling) => size.codeLines > ceiling.maxLines || size.codeFiles > ceiling.maxFiles;
|
|
37
|
+
|
|
38
|
+
/** What the consumer posts instead of a review. */
|
|
39
|
+
export function tooLargeSummary(size, ceiling, budget) {
|
|
40
|
+
return `Too large to review well: ${size.codeLines} lines of code in ${size.codeFiles} files `
|
|
41
|
+
+ `(ceiling ${ceiling.maxLines} lines / ${ceiling.maxFiles} files, an exception, never the norm). `
|
|
42
|
+
+ `Karajan recommends atomic PRs of about ${budget} lines of code, one purpose each: split it as advised.`;
|
|
43
|
+
}
|
|
@@ -0,0 +1,54 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* KJC-TSK-1271 (#2753): a third-party repo has no atril store, so its reviewer
|
|
3
|
+
* gets skills the way a store-backed project does, through atril's public API,
|
|
4
|
+
* from a temporary store outside the reviewed repo: atril resolves the reviewer's
|
|
5
|
+
* skill for the detected stack (the reviewer's own store, ~/.atril, counts), and
|
|
6
|
+
* when nothing installed fits, the best catalog skill is installed in the
|
|
7
|
+
* temporary store first. The maintainer's choice (2026-10-29): catalogs too,
|
|
8
|
+
* installed in a temporary folder. Nothing is written in the reviewed repo.
|
|
9
|
+
*/
|
|
10
|
+
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
11
|
+
import { tmpdir } from "node:os";
|
|
12
|
+
import { isAbsolute, join } from "node:path";
|
|
13
|
+
import { catalogSync, installFromCatalog, resolve, search } from "@karajan-family/atril";
|
|
14
|
+
import { atrilRoleSkills } from "../skills/atril-skills.js";
|
|
15
|
+
|
|
16
|
+
const ROOT = ".atril";
|
|
17
|
+
const defaultAtril = { resolve, search, installFromCatalog, catalogSync };
|
|
18
|
+
|
|
19
|
+
/**
|
|
20
|
+
* @param {{ stack: {languages: string[], frameworks: string[]}, max: number, catalogs?: string[], atril?: typeof defaultAtril }} opts
|
|
21
|
+
* catalogs: absolute paths of catalog folders or source files, as in atril.json
|
|
22
|
+
* @returns {Promise<{skills: object[], others: object[], dropped: string[], installed: string[], reason?: string, cleanup: () => void}>}
|
|
23
|
+
* cleanup() removes the temporary store once the review has read the skills
|
|
24
|
+
*/
|
|
25
|
+
export async function thirdPartySkills({ stack, max, catalogs = [], atril = defaultAtril }) {
|
|
26
|
+
const relative = catalogs.find((ref) => !isAbsolute(ref));
|
|
27
|
+
if (relative) throw new Error(`catalog "${relative}" must be an absolute path: it would resolve against a temporary folder`);
|
|
28
|
+
const terms = [...stack.frameworks, ...stack.languages];
|
|
29
|
+
if (terms.length === 0) return { skills: [], others: [], dropped: [], installed: [], reason: "no stack detected in the reviewed repo", cleanup: () => {} };
|
|
30
|
+
const dir = mkdtempSync(join(tmpdir(), "kj-3p-skills-"));
|
|
31
|
+
const cleanup = () => rmSync(dir, { recursive: true, force: true });
|
|
32
|
+
try {
|
|
33
|
+
const opts = { projectDir: dir, root: ROOT };
|
|
34
|
+
mkdirSync(join(dir, ROOT), { recursive: true });
|
|
35
|
+
writeFileSync(join(dir, ROOT, "atril.json"), `${JSON.stringify({ catalogs })}\n`);
|
|
36
|
+
if (catalogs.length) atril.catalogSync(opts);
|
|
37
|
+
const task = `${terms.join(" ")} code review`;
|
|
38
|
+
const resolveSkills = () => atrilRoleSkills({ role: "reviewer", task, projectDir: dir, root: ROOT, max, resolveFn: atril.resolve });
|
|
39
|
+
let found = resolveSkills();
|
|
40
|
+
const installed = [];
|
|
41
|
+
if (found.skills.length === 0) {
|
|
42
|
+
const pick = atril.search(task, { ...opts, kind: "skill", plugins: false }).find((hit) => !hit.installed);
|
|
43
|
+
if (pick) {
|
|
44
|
+
atril.installFromCatalog(`skill:${pick.name}`, opts);
|
|
45
|
+
installed.push(pick.name);
|
|
46
|
+
found = resolveSkills();
|
|
47
|
+
}
|
|
48
|
+
}
|
|
49
|
+
return { ...found, installed, cleanup };
|
|
50
|
+
} catch (e) {
|
|
51
|
+
cleanup();
|
|
52
|
+
throw e;
|
|
53
|
+
}
|
|
54
|
+
}
|
package/src/review/verify-pr.js
CHANGED
|
@@ -10,7 +10,7 @@ import { diffHash } from "./verdict-store.js";
|
|
|
10
10
|
import { MARKER, TRUSTED } from "./publish-pr.js";
|
|
11
11
|
import { isCleanMerge } from "./clean-merge.js";
|
|
12
12
|
import { verifiedSupervisorFiles } from "../policy/supervisor-verify.js";
|
|
13
|
-
import {
|
|
13
|
+
import { isSealCommit } from "./seal-commit.js";
|
|
14
14
|
|
|
15
15
|
// The marker of a kj review for any head: what MARKER writes up to the head itself.
|
|
16
16
|
const MARKER_PREFIX = MARKER("\0").split("\0")[0];
|
|
@@ -39,29 +39,6 @@ async function hashesOf(projectDir, sha, run) {
|
|
|
39
39
|
return hashes;
|
|
40
40
|
}
|
|
41
41
|
|
|
42
|
-
// KJC-BUG-0388: kj harden --commit is the human's act, signed from the phone, and no AI
|
|
43
|
-
// reviews it. The proof is the signature, never the message: a commit that only touches
|
|
44
|
-
// files the roster-signed seal vouches for at the head is that act.
|
|
45
|
-
async function isSealCommit(projectDir, sha, run, sealed) {
|
|
46
|
-
if (sealed.signed !== true) return false;
|
|
47
|
-
const res = await run("git", ["-C", projectDir, "diff", "--name-only", `${sha}^`, sha]);
|
|
48
|
-
if (res.exitCode !== 0) throw new Error(`git diff --name-only ${sha.slice(0, 7)} failed: ${(res.stderr || "").trim()}`);
|
|
49
|
-
const files = (res.stdout || "").split("\n").filter(Boolean);
|
|
50
|
-
// KJC-BUG-0438: the seal act writes the signed provenance; a commit without it only touched files.
|
|
51
|
-
if (!files.includes(PROVENANCE_FILE)) return false;
|
|
52
|
-
if (!files.every((f) => sealed.files.has(f) || (f === PROVENANCE_FILE && sealed.complete === true))) return false;
|
|
53
|
-
// What the commit leaves is byte for byte what the signed seal vouches for at the head: a
|
|
54
|
-
// precursor whose provenance or hooks a later commit replaced is not the seal act.
|
|
55
|
-
for (const f of files) if ((await blobAt(projectDir, sha, f, run)) !== (await blobAt(projectDir, "HEAD", f, run))) return false;
|
|
56
|
-
return true;
|
|
57
|
-
}
|
|
58
|
-
|
|
59
|
-
/** The blob id of a file at a revision, or null when the file is absent there. */
|
|
60
|
-
async function blobAt(projectDir, rev, file, run) {
|
|
61
|
-
const res = await run("git", ["-C", projectDir, "rev-parse", "--verify", "--quiet", `${rev}:${file}`]);
|
|
62
|
-
return res.exitCode === 0 ? String(res.stdout || "").trim() : null;
|
|
63
|
-
}
|
|
64
|
-
|
|
65
42
|
/**
|
|
66
43
|
* @returns {Promise<{ok: boolean, commits: number, problems: string[], sealCommits?: string[]}>}
|
|
67
44
|
*/
|