karajan-code 4.49.2 → 4.49.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "karajan-code",
-  "version": "4.49.2",
+  "version": "4.49.3",
   "description": "Local multi-agent coding orchestrator with TDD, SonarQube, and code review pipeline",
   "type": "module",
   "license": "AGPL-3.0",

package/src/agents/claude-agent.js

@@ -289,10 +289,12 @@ export function createStreamJsonFilter(onOutput) {
  *    sessions.  The spawned `claude -p` is a separate non-interactive
  *    invocation, not a true nested session.
  *
- * 2. Detach stdin (stdin: "ignore") — When launched from Node.js (which is
- *    how Claude Code / Karajan MCP runs), the child inherits the parent's
- *    stdin.  `claude -p` then blocks waiting to read from a stdin that the
- *    parent is already consuming.  Ignoring stdin prevents the hang.
+ * 2. Never inherit stdin — When launched from Node.js (which is how Claude
+ *    Code / Karajan MCP runs), an inherited stdin made `claude -p` block
+ *    reading what the parent was consuming. KJC-BUG-0344: the prompt now
+ *    travels ON stdin (input), which also closes it, so there is nothing to
+ *    wait on, and a large prompt no longer hits the kernel's per-argument
+ *    limit (E2BIG).
  *
  * 3. Claude Code 2.x writes all structured output (stream-json, json) to
  *    stderr, NOT stdout.  The agent must read from stderr for the actual
@@ -303,7 +305,7 @@ function cleanExecaOpts(extra = {}) {
   // PAR-H (KJC-TSK-0631): extra.env ADDS to the inherited env (lane slot
   // vars) instead of replacing it wholesale.
   const { env: extraEnv, ...rest } = extra;
-  return { env: extraEnv ? { ...env, ...extraEnv } : env, stdin: "ignore", ...rest };
+  return { env: extraEnv ? { ...env, ...extraEnv } : env, ...rest };
 }
 
 /**
@@ -332,11 +334,12 @@ const ALLOWED_TOOLS = [
  * the volatile block goes in the -p message. Without the split, legacy
  * single-prompt behavior is unchanged.
  */
+// KJC-BUG-0344: the -p message goes on stdin (`input`), never as an argument.
 function buildPromptArgs(task) {
   if (task.stablePrompt && task.volatilePrompt) {
-    return ["-p", task.volatilePrompt, "--append-system-prompt", task.stablePrompt, "--allowedTools", ...ALLOWED_TOOLS];
+    return { args: ["-p", "--append-system-prompt", task.stablePrompt, "--allowedTools", ...ALLOWED_TOOLS], input: task.volatilePrompt };
   }
-  return ["-p", task.prompt, "--allowedTools", ...ALLOWED_TOOLS];
+  return { args: ["-p", "--allowedTools", ...ALLOWED_TOOLS], input: String(task.prompt ?? "") };
 }
 
 export class ClaudeAgent extends BaseAgent {
@@ -353,7 +356,7 @@ export class ClaudeAgent extends BaseAgent {
   }
 
   async _runTaskExec(task, model, _role) {
-    const args = buildPromptArgs(task);
+    const { args, input } = buildPromptArgs(task);
     if (model) args.push("--model", model);
     // PL-C (KJC-TSK-0735): el rol del subproceso viaja en KJ_POLICY_ROLE —
     // si su harness corre hooks (claude -p), el tier A evalúa la policy con
@@ -366,6 +369,7 @@ export class ClaudeAgent extends BaseAgent {
       args.push("--output-format", "stream-json", "--verbose");
       const streamFilter = createStreamJsonFilter(task.onOutput);
       const res = await this.runCommand(resolveBin("claude"), args, cleanExecaOpts({
+        input,
         onOutput: streamFilter,
         silenceTimeoutMs: task.silenceTimeoutMs,
         timeout: task.timeoutMs,
@@ -380,7 +384,7 @@ export class ClaudeAgent extends BaseAgent {
 
     // Without streaming, use json output to get structured response via stderr
     args.push("--output-format", "json");
-    const res = await this.runCommand(resolveBin("claude"), args, cleanExecaOpts({ env: roleEnv, cwd: task.cwd }));
+    const res = await this.runCommand(resolveBin("claude"), args, cleanExecaOpts({ input, env: roleEnv, cwd: task.cwd }));
     const raw = pickOutput(res);
     const output = extractTextFromStreamJson(raw);
     const usage = extractUsageFromStreamJson(raw);
@@ -388,9 +392,11 @@ export class ClaudeAgent extends BaseAgent {
   }
 
   async _reviewTaskExec(task, model) {
-    const args = [...buildPromptArgs(task), "--output-format", "stream-json", "--verbose"];
+    const prompt = buildPromptArgs(task);
+    const args = [...prompt.args, "--output-format", "stream-json", "--verbose"];
     if (model) args.push("--model", model);
     const res = await this.runCommand(resolveBin("claude"), args, cleanExecaOpts({
+      input: prompt.input,
       onOutput: task.onOutput,
       silenceTimeoutMs: task.silenceTimeoutMs,
       timeout: task.timeoutMs,

package/src/environment/contract-commit.js

@@ -32,6 +32,9 @@ export const CONTRACT_PATHS = [
   ".karajan/supervisor-signers.json",
   // KJC-TSK-0995 (HUM-D, ADR 0018): the security level the whole team inherits.
   ".karajan/security-level.json",
+  // KJC-BUG-0346: kj env install wires kj_rag_query as a native tool here; a clone
+  // without it loses the tool. Only committed when kj changed it in this run.
+  ".mcp.json",
 ];
 
 const FRESH_MESSAGE = "chore(bootstrap): el contrato del método, para que quien clone lo herede";

package/src/review/loc-budget.js

@@ -19,8 +19,9 @@
  * unbounded growth there dilutes the signal the agent receives.
  */
 
-const EXEMPT = [
-  // Generated or vendored: nobody typed it.
+// Generated or vendored: nobody typed it. KJC-BUG-0347: also what the review and
+// Solomon prompts summarize instead of pasting whole.
+const GENERATED = [
   /(^|\/)dist\//,
   /(^|\/)build\//,
   /(^|\/)coverage\//,
@@ -35,6 +36,10 @@ const EXEMPT = [
   /(^|\/)tests\/_diet\//,
   // KJC-BUG-0318: the plan `kj plan share` writes, at the project root only.
   /^\.karajan-shared\/plans\/[^/]+\.json$/,
+];
+
+const EXEMPT = [
+  ...GENERATED,
   // Human documentation, wherever the project keeps it. The landing's docs
   // moved into the monorepo (MONO-3) and the old root-anchored `docs/` rule
   // stopped matching them, which is how documenting started costing budget.
@@ -46,6 +51,11 @@ const EXEMPT = [
 // The exceptions to the exception: these ARE the agent's context.
 const AI_RULES = [/^CLAUDE\.md$/, /^AGENTS\.md$/, /^GEMINI\.md$/, /(^|\/)templates\//];
 
+/** Whether nobody typed this file (lockfile, build output, snapshot...). */
+export function isGenerated(file) {
+  return Boolean(file) && GENERATED.some((re) => re.test(file));
+}
+
 /** @param {string} file @returns {boolean} */
 export function countsTowardBudget(file) {
   if (!file) return false;

package/src/review/one-shot-review.js

@@ -15,6 +15,7 @@ import { resolveReviewProfile } from "./profiles.js";
 import { parseMaybeJsonString, normalizeReviewPayload } from "./parser.js";
 import { detectAvailableAgents, detectHostAgent } from "../utils/agent-detect.js";
 import { saveVerdict, diffHash } from "./verdict-store.js";
+import { summarizeGeneratedFiles } from "./prompt-diff.js";
 import { reportUnparseableVerdict } from "./unparseable-verdict.js";
 import { detectWorkspace } from "./workspace.js";
 import { isQuotaExhausted, candidateStatus, pickQuotaFallback, formatCandidateMenu } from "./reviewer-fallback.js";
@@ -69,7 +70,8 @@ export async function runOneShotReview({
   const attempt = async (who, cfg = config) => {
     const prompt = await buildReviewerPrompt({
       task: task || "Review the following diff for correctness, security and maintainability.",
-      diff, reviewRules: rules, mode: "standard", provider: who, projectDir,
+      // KJC-BUG-0347: generated files summarized; the verdict still binds to the full diff.
+      diff: summarizeGeneratedFiles(diff), reviewRules: rules, mode: "standard", provider: who, projectDir,
     });
     logger?.info?.(`kj review: host=${hostAgent || "none"} → reviewer=${who} (cross-AI)`);
     return createAgentFn(who, cfg, logger).reviewTask({ prompt, role: "reviewer" });

package/src/review/prompt-diff.js

@@ -0,0 +1,26 @@
+/**
+ * KJC-BUG-0347 (#2101): the diff a reviewer or Solomon READS. A generated file
+ * (lockfile, build output, snapshot) enters as one summary line instead of its
+ * thousands of lines: the reviewer kept losing the real hunks behind a 4800-line
+ * package-lock.json, and Solomon's prompt blew the argument limit (E2BIG).
+ * The verdict still binds to the full diff; this only shapes the prompt.
+ */
+import { isGenerated } from "./loc-budget.js";
+
+const HEADER = /^diff --git a\/(.+?) b\/(.+)$/;
+
+/** @param {string} diff unified diff @returns {string} */
+export function summarizeGeneratedFiles(diff) {
+  const sections = String(diff).split(/(?=^diff --git )/m);
+  let changed = false;
+  const out = sections.map((sec) => {
+    const file = sec.split("\n", 1)[0].match(HEADER)?.[2];
+    if (!file || !isGenerated(file)) return sec;
+    changed = true;
+    const lines = sec.split("\n");
+    const added = lines.filter((l) => l.startsWith("+") && !l.startsWith("+++")).length;
+    const removed = lines.filter((l) => l.startsWith("-") && !l.startsWith("---")).length;
+    return `diff --git a/${file} b/${file}\n# ${file}: generated file, +${added} -${removed} lines, contents left out of this prompt\n`;
+  });
+  return changed ? out.join("") : diff;
+}

package/src/review/solomon-arbitration.js

@@ -16,6 +16,7 @@ import { createAgent } from "../agents/index.js";
 import { parseMaybeJsonString } from "./parser.js";
 import { detectAvailableAgents, detectHostAgent } from "../utils/agent-detect.js";
 import { diffHash, loadVerdict, saveVerdict } from "./verdict-store.js";
+import { summarizeGeneratedFiles } from "./prompt-diff.js";
 
 const SECURITY_PATTERN = /injection|xss|csrf|secret|credential|password|token leak|auth(entication|orization)?|crypt|session|sanitiz|traversal|rce\b/i;
 
@@ -75,7 +76,8 @@ export async function runSolomonArbitration({
     "", "## Reviewer's blocking issues",
     JSON.stringify(verdict.issues || [], null, 2),
     "", "## Brain's position", position,
-    "", "## The diff under dispute", diff,
+    // KJC-BUG-0347: generated files summarized; the ruling still binds to the full diff.
+    "", "## The diff under dispute", summarizeGeneratedFiles(diff),
   ].join("\n");
 
   logger?.info?.(`kj solomon: brain=${hostAgent || "?"} vs reviewer=${verdict.reviewer} → arbiter=${solomon}`);