karajan-code 3.14.0 → 3.15.0

package/src/rag/where-parser.js

@@ -1,54 +1,4 @@
-// KJC-TSK-0448 — minimal --where filter parser for metadata-aware RAG
-// queries. Grammar (intentionally small):
-//
-//   clause     := pair ( "AND" pair )*
-//   pair       := IDENT "=" VALUE
-//   IDENT      := [A-Za-z_][A-Za-z0-9_.-]*
-//   VALUE      := unquoted token  | "quoted string"
-//
-// Examples:
-//   symbol=loadConfig
-//   hu_id=HU-003 AND kind=plan
-//   "headingPath.0"=Architecture
-//
-// Returns { ok: true, clauses: [["symbol","loadConfig"], ...] } or
-// { ok: false, error: "...explanation..." }. The retriever turns each
-// clause into a `json_extract(c.metadata, '$.<key>') = ?` SQL fragment;
-// the `kind` key is special-cased to filter the column directly.
-
-const IDENT_RE = /^[A-Za-z_][A-Za-z0-9_.-]*$/;
-
-export function parseWhere(input) {
-  if (input == null) return { ok: true, clauses: [] };
-  if (typeof input !== "string") return { ok: false, error: "where: input must be a string" };
-  const s = input.trim();
-  if (!s) return { ok: true, clauses: [] };
-  const parts = s.split(/\s+AND\s+/i);
-  const clauses = [];
-  for (const p of parts) {
-    const eq = p.indexOf("=");
-    if (eq <= 0) return { ok: false, error: `where: bad pair "${p}" — expected key=value` };
-    const key = p.slice(0, eq).trim().replace(/^"|"$/g, "");
-    let val = p.slice(eq + 1).trim();
-    if (!IDENT_RE.test(key)) return { ok: false, error: `where: invalid key "${key}"` };
-    if ((val.startsWith('"') && val.endsWith('"')) || (val.startsWith("'") && val.endsWith("'"))) val = val.slice(1, -1);
-    if (val.length === 0) return { ok: false, error: `where: empty value for key "${key}"` };
-    clauses.push([key, val]);
-  }
-  return { ok: true, clauses };
-}
-
-/**
- * Build a `(sqlFragment, params)` pair to append to a chunks-table query.
- * `kind` filters the column directly; everything else goes through json_extract.
- */
-export function buildWhereSql(clauses) {
-  if (!clauses?.length) return { sql: "", params: [] };
-  const fragments = [];
-  const params = [];
-  for (const [k, v] of clauses) {
-    if (k === "kind") { fragments.push("c.kind = ?"); params.push(v); }
-    else { fragments.push(`json_extract(c.metadata, '$.${k}') = ?`); params.push(v); }
-  }
-  return { sql: ` AND ${fragments.join(" AND ")}`, params };
-}
+// Shim: where-parser now lives in karajan-core/rag so the hu-board
+// workspace can consume it without a relative dep on the CLI src tree.
+// KJC-TSK-0632 PR2.
+export { parseWhere, buildWhereSql } from "karajan-core/rag/where-parser";

package/src/review/diff-generator.js

@@ -105,8 +105,8 @@ export async function generateDiff({ baseRef, stageNewFiles = false, projectDir
   return generateSnapshotDiff(emptySnapshot, null, dir);
 }
 
-export async function getUntrackedFiles() {
-  const result = await run("git", ["ls-files", "--others", "--exclude-standard"]);
+export async function getUntrackedFiles(cwd = null) {
+  const result = await run("git", ["ls-files", "--others", "--exclude-standard"], cwd ? { cwd } : {});
   if (result.exitCode !== 0) return [];
   return result.stdout.trim().split("\n").filter(Boolean);
 }

package/src/roles/agent-role.js

@@ -129,6 +129,10 @@ export class AgentRole extends BaseRole {
 
     const runArgs = { prompt, role: this.name };
     if (onOutput) runArgs.onOutput = onOutput;
+    // PAR-H (KJC-TSK-0631): per-call env additions for the agent
+    // subprocess (lane slot vars). Agents that ignore task.env simply
+    // run without them.
+    if (extracted.env) runArgs.env = extracted.env;
     // Φ1-D (KJC-PCS-0057): roles that build their prompt as a
     // stable/volatile layout forward both buckets so cache-aware agents
     // (ClaudeAgent) can ship the stable block as system prompt. Agents

package/src/roles/coder-role.js

@@ -31,6 +31,7 @@ export class CoderRole extends AgentRole {
         reviewerFeedback: null, sonarSummary: null, deferredContext: null,
         acceptanceTests: null,
         adrs: null, specSection: null, reviewerFindings: null, huId: null,
+        projectDir: null,
         onOutput: null
       };
     }
@@ -52,12 +53,17 @@ export class CoderRole extends AgentRole {
       specSection: input?.specSection || null,
       reviewerFindings: input?.reviewerFindings || null,
       huId: input?.huId || null,
+      // PAR-E2 (KJC-TSK-0629): per-call project root. Worktree lanes pass
+      // their lane dir here; the shared role instance keeps its own config.
+      projectDir: input?.projectDir || null,
+      // PAR-H (KJC-TSK-0631): per-call subprocess env (lane slot vars).
+      env: input?.env || null,
       onOutput: input?.onOutput || null
     };
   }
 
-  async buildPrompt({ task, reviewerFeedback, sonarSummary, deferredContext, acceptanceTests, adrs, specSection, reviewerFindings, huId }) {
-    const projectDir = this.config?.projectDir || null;
+  async buildPrompt({ task, reviewerFeedback, sonarSummary, deferredContext, acceptanceTests, adrs, specSection, reviewerFindings, huId, projectDir: laneProjectDir }) {
+    const projectDir = laneProjectDir || this.config?.projectDir || null;
     // KJC sesgo-de-stack: pasar stack/testFramework al prompt para que
     // el coder no asuma JS/vitest en proyectos Python / Go / Rust /
     // Ruby. audit-role.js y tester-role.js ya lo hacen así.

package/src/spec-review/run-spec-review.js

@@ -70,7 +70,11 @@ export async function runSpecReview({ spec, config, logger, askQuestion, flags =
       if (!askQuestion) return { proceed: true, severity, findings, finalSpec: currentSpec };
       const answer = await askQuestion(
         `Spec review: ${findings.length} finding${findings.length === 1 ? "" : "s"} at severity ${severity}. [c]ontinue / [r]efine / [x]cancel? (default: continue)`,
-        { detail: { severity, findingCount: findings.length, categories: [...new Set(findings.map((f) => f.category))], iteration: iter + 1 } },
+        {
+          detail: { severity, findingCount: findings.length, categories: [...new Set(findings.map((f) => f.category))], iteration: iter + 1 },
+          // KJC-BUG-0109: mirrors the interactive default — --yes presses Enter.
+          defaultAnswer: "continue",
+        },
       );
       if (answer === null) return { proceed: false, cancelled: true, severity, findings };
       const n = String(answer).trim().toLowerCase();

package/src/utils/cli-ask-question.js

@@ -30,6 +30,15 @@ export function createCliAskQuestion(opts = {}) {
     const isInteractive = Boolean(process.stdin?.isTTY) && stdinReadable;
     if (!isInteractive) {
       if (flags?.yes) {
+        // KJC-BUG-0109: a question that declares a safe default is answered
+        // with it — --yes means "press Enter for me", not "abort on any
+        // gate". Questions without a declared default keep failing loud.
+        const fallback = typeof context?.defaultAnswer === "string" && context.defaultAnswer.trim()
+          ? context.defaultAnswer.trim() : null;
+        if (fallback) {
+          process.stderr.write(`\n[non-interactive --yes] Auto-answering with declared default "${fallback}": ${question}\n`);
+          return fallback;
+        }
         process.stderr.write(
           `\n[non-interactive --yes] Pipeline asked a question that cannot be auto-answered:\n`
           + `  ❓ ${question}\n`

package/src/utils/git.js

@@ -167,8 +167,8 @@ export function buildBranchName(prefix, task) {
   return `${prefix}${slugifyTask(task) || "task"}-${stamp}`;
 }
 
-export async function hasChanges() {
-  const status = await runGit(["status", "--porcelain"]);
+export async function hasChanges(cwd = null) {
+  const status = await runGit(["status", "--porcelain"], cwd ? { cwd } : {});
   return status.length > 0;
 }
 
@@ -229,12 +229,13 @@ function isNothingToCommit(message) {
   return NOTHING_TO_COMMIT_PATTERNS.some((re) => re.test(m));
 }
 
-export async function commitAll(message) {
-  await runGit(["add", "-A"]);
-  const changed = await hasChanges();
+export async function commitAll(message, cwd = null) {
+  const opts = cwd ? { cwd } : {};
+  await runGit(["add", "-A"], opts);
+  const changed = await hasChanges(cwd);
   if (!changed) return { committed: false };
   try {
-    await runGit(["commit", "-m", message]);
+    await runGit(["commit", "-m", message], opts);
   } catch (err) {
     // `git status --porcelain` and `git commit` disagreed about whether
     // there was anything to commit. Don't escalate — the only outcome
@@ -245,18 +246,18 @@ export async function commitAll(message) {
     }
     throw err;
   }
-  const raw = await runGit(["log", "-1", "--pretty=format:%H%x1f%s"]);
+  const raw = await runGit(["log", "-1", "--pretty=format:%H%x1f%s"], opts);
   const [hash, commitMessage] = raw.split("\x1f");
   return { committed: true, commit: { hash, message: commitMessage } };
 }
 
-export async function pushBranch(branch) {
-  await runGit(["push", "-u", "origin", branch]);
+export async function pushBranch(branch, cwd = null) {
+  await runGit(["push", "-u", "origin", branch], cwd ? { cwd } : {});
 }
 
-export async function createPullRequest({ baseBranch, branch, title, body }) {
+export async function createPullRequest({ baseBranch, branch, title, body, cwd = null }) {
   const args = ["pr", "create", "--base", baseBranch, "--head", branch, "--title", title, "--body", body];
-  const res = await runCommand("gh", args);
+  const res = await runCommand("gh", args, cwd ? { cwd } : {});
   if (res.exitCode !== 0) {
     throw new Error(`gh ${args.join(" ")} failed: ${res.stderr || res.stdout}`);
   }