karajan-code 2.7.4 → 2.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (192) hide show
  1. package/README.md +1 -1
  2. package/package.json +24 -4
  3. package/scripts/diet-baseline.mjs +170 -0
  4. package/scripts/regen-arch-stats.sh +71 -0
  5. package/src/agents/availability.js +15 -9
  6. package/src/agents/claude-agent.js +143 -45
  7. package/src/agents/model-registry.js +1 -1
  8. package/src/audit/agent-readiness.js +240 -0
  9. package/src/audit/basal-cost.js +92 -9
  10. package/src/audit/deterministic-summary.js +200 -0
  11. package/src/audit/osv-findings.js +162 -0
  12. package/src/audit/semgrep-findings.js +117 -0
  13. package/src/audit/sonar-findings.js +81 -0
  14. package/src/audit/webperf-input.js +90 -0
  15. package/src/bootstrap.js +26 -1
  16. package/src/brain/decision-tracker.js +3 -1
  17. package/src/brain/decisor.js +1 -1
  18. package/src/canvas/parse-md.js +238 -0
  19. package/src/canvas/schema.js +101 -0
  20. package/src/canvas/to-flat.js +85 -0
  21. package/src/canvas/validate.js +163 -0
  22. package/src/checks/binaries.js +3 -3
  23. package/src/checks/ci.js +2 -2
  24. package/src/checks/config-files.js +6 -6
  25. package/src/checks/dir-setup.js +4 -0
  26. package/src/checks/mcp-health.js +6 -0
  27. package/src/checks/ports.js +91 -29
  28. package/src/checks/rtk.js +1 -1
  29. package/src/checks/skills.js +5 -1
  30. package/src/checks/sonar.js +2 -2
  31. package/src/checks/system.js +3 -3
  32. package/src/checks/tokens.js +1 -1
  33. package/src/checks/types.js +0 -12
  34. package/src/cli/_shared.js +30 -0
  35. package/src/cli/register-meta.js +218 -0
  36. package/src/cli/register-pipeline.js +212 -0
  37. package/src/cli/register-plan.js +152 -0
  38. package/src/cli/register-roles-skills.js +38 -0
  39. package/src/cli/register-sonar.js +28 -0
  40. package/src/cli.js +83 -468
  41. package/src/commands/agents.js +18 -6
  42. package/src/commands/architect.js +29 -2
  43. package/src/commands/audit.js +265 -30
  44. package/src/commands/board.js +160 -30
  45. package/src/commands/clean.js +83 -0
  46. package/src/commands/code.js +7 -2
  47. package/src/commands/discover.js +7 -2
  48. package/src/commands/doctor.js +1 -1
  49. package/src/commands/init.js +2 -2
  50. package/src/commands/plan/_shared.js +40 -0
  51. package/src/commands/plan/add-hu.js +21 -0
  52. package/src/commands/plan/delete.js +9 -0
  53. package/src/commands/plan/generate.js +284 -0
  54. package/src/commands/plan/index.js +14 -0
  55. package/src/commands/plan/list.js +21 -0
  56. package/src/commands/plan/ready.js +46 -0
  57. package/src/commands/plan/remove-hu.js +17 -0
  58. package/src/commands/plan/show.js +81 -0
  59. package/src/commands/plan/validate.js +20 -0
  60. package/src/commands/plan.js +14 -291
  61. package/src/commands/researcher.js +7 -2
  62. package/src/commands/resume.js +24 -1
  63. package/src/commands/review.js +7 -2
  64. package/src/commands/run.js +52 -1
  65. package/src/commands/status.js +1 -1
  66. package/src/commands/sync.js +75 -0
  67. package/src/commands/triage.js +7 -2
  68. package/src/commands/undo.js +1 -1
  69. package/src/config/defaults.js +213 -0
  70. package/src/config/loader.js +137 -0
  71. package/src/config/overrides.js +199 -0
  72. package/src/config/role-resolver.js +159 -0
  73. package/src/config/test-harness.js +78 -0
  74. package/src/config.js +30 -632
  75. package/src/git/automation.js +2 -2
  76. package/src/guards/output-guard.js +0 -2
  77. package/src/hu/acceptance-runner.js +52 -10
  78. package/src/hu/store.js +11 -0
  79. package/src/mcp/handlers/direct-handlers.js +2 -5
  80. package/src/mcp/handlers/management-handlers.js +48 -4
  81. package/src/mcp/handlers/run-handler.js +9 -8
  82. package/src/mcp/preflight.js +32 -13
  83. package/src/mcp/server-handlers.js +4 -3
  84. package/src/mcp/suggest-handler.js +3 -2
  85. package/src/mcp/tools.js +15 -0
  86. package/src/orchestrator/agent-fallback.js +1 -1
  87. package/src/orchestrator/ci-integration.js +11 -11
  88. package/src/orchestrator/config-init.js +25 -7
  89. package/src/orchestrator/direct-actions.js +7 -3
  90. package/src/orchestrator/drivers/error-recovery.js +287 -0
  91. package/src/orchestrator/drivers/init-context.js +222 -0
  92. package/src/orchestrator/drivers/iteration-loop.js +301 -0
  93. package/src/orchestrator/drivers/iteration-phases/coder-and-refactorer.js +48 -0
  94. package/src/orchestrator/drivers/iteration-phases/guards.js +84 -0
  95. package/src/orchestrator/drivers/iteration-phases/handle-approved.js +29 -0
  96. package/src/orchestrator/drivers/iteration-phases/quality-gates.js +76 -0
  97. package/src/orchestrator/drivers/iteration-phases/reviewer-gate.js +60 -0
  98. package/src/orchestrator/drivers/post-loop.js +370 -0
  99. package/src/orchestrator/drivers/pre-loop-phases/auto-hu-batch.js +116 -0
  100. package/src/orchestrator/drivers/pre-loop-phases/config-deprecations.js +47 -0
  101. package/src/orchestrator/drivers/pre-loop-phases/ensure-addyosmani-skills.js +84 -0
  102. package/src/orchestrator/drivers/pre-loop-phases/inject-loaded-plan.js +268 -0
  103. package/src/orchestrator/drivers/pre-loop.js +431 -0
  104. package/src/orchestrator/drivers/run-hu-batch.js +367 -0
  105. package/src/orchestrator/feedback-queue.js +0 -1
  106. package/src/orchestrator/flow-control.js +4 -3
  107. package/src/orchestrator/flow-runner.js +121 -2077
  108. package/src/orchestrator/fs-leak-detector.js +156 -0
  109. package/src/orchestrator/hu-sub-pipeline.js +197 -9
  110. package/src/orchestrator/integrations.js +81 -0
  111. package/src/orchestrator/post-loop-stages.js +35 -8
  112. package/src/orchestrator/preflight-checks.js +20 -7
  113. package/src/orchestrator/repair/repair-detector.js +117 -0
  114. package/src/orchestrator/repair/repair-runner.js +142 -0
  115. package/src/orchestrator/reviewer-fallback.js +1 -1
  116. package/src/orchestrator/role-output-compressor.js +0 -1
  117. package/src/orchestrator/session-journal.js +4 -41
  118. package/src/orchestrator/solomon-escalation.js +3 -2
  119. package/src/orchestrator/solomon-rules.js +7 -3
  120. package/src/orchestrator/stages/architect-stage.js +12 -11
  121. package/src/orchestrator/stages/coder-stage.js +56 -7
  122. package/src/orchestrator/stages/hu-reviewer-phases/detect-and-apply-splits.js +127 -0
  123. package/src/orchestrator/stages/hu-reviewer-stage.js +6 -79
  124. package/src/orchestrator/stages/planner-stage.js +1 -1
  125. package/src/orchestrator/stages/research-stage.js +1 -1
  126. package/src/orchestrator/stages/reviewer-stage.js +7 -7
  127. package/src/orchestrator/stages/sonar-stage.js +94 -10
  128. package/src/orchestrator/stages/stage-classes.js +84 -0
  129. package/src/orchestrator/stages/stage-executor.js +1 -1
  130. package/src/orchestrator/stages/triage-stage.js +1 -1
  131. package/src/orchestrator/standby.js +3 -2
  132. package/src/orchestrator/verification-gate.js +20 -12
  133. package/src/plan/adr-generator.js +170 -0
  134. package/src/plan/adr-loader.js +60 -0
  135. package/src/plan/plan-executor.js +19 -1
  136. package/src/plan/plan-hu-ops.js +170 -1
  137. package/src/plan/plan-reviewer.js +199 -0
  138. package/src/plan/plan-schema.js +69 -1
  139. package/src/plan/plan-store.js +40 -17
  140. package/src/plan/spec-detector.js +61 -0
  141. package/src/plan/tests-synthesizer.js +116 -0
  142. package/src/planning-game/client.js +3 -28
  143. package/src/planning-game/decomposition.js +1 -1
  144. package/src/planning-game/pipeline-adapter.js +37 -6
  145. package/src/prompts/audit.js +206 -6
  146. package/src/prompts/coder.js +172 -1
  147. package/src/prompts/hu-reviewer.js +0 -1
  148. package/src/prompts/planner.js +81 -4
  149. package/src/prompts/rtk-snippet.js +1 -1
  150. package/src/review/diff-generator.js +35 -22
  151. package/src/review/snapshot-diff.js +1 -1
  152. package/src/roles/audit-role.js +125 -13
  153. package/src/roles/coder-role.js +25 -3
  154. package/src/roles/planner-role.js +42 -1
  155. package/src/roles/repairer-role.js +181 -0
  156. package/src/roles/tester-role.js +70 -4
  157. package/src/session/mutators.js +304 -0
  158. package/src/session/runtime-overrides.js +59 -0
  159. package/src/{session-store.js → session/store.js} +2 -2
  160. package/src/skills/semantic-detector.js +10 -5
  161. package/src/skills/skill-detector.js +1 -1
  162. package/src/sonar/api.js +1 -1
  163. package/src/sonar/cloud-scanner.js +0 -1
  164. package/src/sonar/credentials.js +14 -6
  165. package/src/sonar/discovery.js +123 -0
  166. package/src/sonar/manager.js +18 -0
  167. package/src/sync/detect-drift.js +113 -0
  168. package/src/tracker-bootstrap.js +44 -0
  169. package/src/utils/agent-detect.js +15 -11
  170. package/src/utils/board-prompt-bridge.js +109 -0
  171. package/src/utils/cli-progress.js +161 -0
  172. package/src/utils/cwd-confirm.js +39 -0
  173. package/src/utils/derive-project-name-from-cwd.js +119 -0
  174. package/src/utils/display/event-handlers.js +1 -1
  175. package/src/utils/display/header.js +1 -1
  176. package/src/utils/display/session-summary.js +3 -3
  177. package/src/utils/display/solomon.js +1 -1
  178. package/src/utils/garbage-collector.js +396 -0
  179. package/src/utils/git.js +16 -4
  180. package/src/utils/locale.js +1 -1
  181. package/src/utils/paths.js +21 -1
  182. package/src/utils/process.js +1 -1
  183. package/src/utils/prompt-project-name.js +35 -0
  184. package/src/utils/role-assigner.js +1 -1
  185. package/src/utils/run-context.js +75 -0
  186. package/src/utils/run-log.js +12 -0
  187. package/src/utils/task-file.js +1 -1
  188. package/src/utils/telemetry.js +13 -1
  189. package/src/webperf/devtools-detect.js +1 -1
  190. package/templates/coder-rules.md +13 -0
  191. package/templates/roles/coder.md +34 -0
  192. package/templates/roles/repairer.md +94 -0
@@ -0,0 +1,238 @@
1
+ /**
2
+ * REASONS Canvas markdown parser.
3
+ *
4
+ * Reads a `SPEC.canvas.md` file and returns a Canvas object that
5
+ * validates against canvas/schema.js.
6
+ *
7
+ * Format:
8
+ *
9
+ * # <title>
10
+ *
11
+ * ## REASONS:Requirements
12
+ * <problem statement, free text>
13
+ *
14
+ * Definition of done:
15
+ * - bullet 1
16
+ * - bullet 2
17
+ *
18
+ * ## REASONS:Entities
19
+ * - `User` — fields: id, email. has-many Order.
20
+ * - `Order` — ...
21
+ *
22
+ * ## REASONS:Approach
23
+ * <free text>
24
+ *
25
+ * ## REASONS:Structure
26
+ * - touches: src/auth/*, src/orders/*
27
+ * - depends_on: TokenService
28
+ * - contracts: POST /orders, GET /orders/:id
29
+ *
30
+ * ## REASONS:Operations
31
+ * 1. <title>
32
+ * Acceptance:
33
+ * - shell: `cmd here`
34
+ * - gherkin: ```Given … When … Then …```
35
+ * 2. ...
36
+ *
37
+ * ## REASONS:Norms
38
+ * - bullet
39
+ *
40
+ * ## REASONS:Safeguards
41
+ * - bullet
42
+ *
43
+ * Permissive on whitespace and bullet style ("- ", "* ", "1. ").
44
+ * Strict on structure: a missing required section ⇒ exception with a
45
+ * pointer to which section is missing.
46
+ */
47
+
48
+ const SECTION_HEADER_RE = /^##\s+REASONS:(\w+)\s*$/i;
49
+ const TITLE_RE = /^#\s+(.+?)\s*$/;
50
+ const BULLET_RE = /^\s*(?:[-*]|\d+\.)\s+(.+?)\s*$/;
51
+ const ACCEPTANCE_HEADER_RE = /^\s*Acceptance(?:\s+tests?)?\s*:\s*$/i;
52
+ const TEST_LINE_RE = /^\s*(?:[-*])\s+(shell|gherkin)\s*:\s*(.+?)\s*$/i;
53
+
54
+ /**
55
+ * Parse a SPEC.canvas.md string into a Canvas object.
56
+ * Throws { name: "CanvasParseError", message } on missing required sections.
57
+ *
58
+ * @param {string} source — markdown text
59
+ * @returns {object} Canvas object (un-validated against schema; caller validates)
60
+ */
61
+ export function parseCanvasMarkdown(source) {
62
+ if (typeof source !== "string" || source.length === 0) {
63
+ throw makeError("Canvas markdown is empty or not a string.");
64
+ }
65
+
66
+ const lines = source.split(/\r?\n/);
67
+ const sections = {};
68
+ let title = null;
69
+ let currentName = null;
70
+ let currentBuf = [];
71
+
72
+ // First pass: split into sections.
73
+ for (const line of lines) {
74
+ const titleMatch = line.match(TITLE_RE);
75
+ if (titleMatch && currentName === null && title === null) {
76
+ title = titleMatch[1].trim();
77
+ continue;
78
+ }
79
+ const sectionMatch = line.match(SECTION_HEADER_RE);
80
+ if (sectionMatch) {
81
+ // flush previous
82
+ if (currentName) {
83
+ sections[currentName] = currentBuf.join("\n");
84
+ }
85
+ currentName = sectionMatch[1].toLowerCase();
86
+ currentBuf = [];
87
+ continue;
88
+ }
89
+ if (currentName) currentBuf.push(line);
90
+ }
91
+ if (currentName) sections[currentName] = currentBuf.join("\n");
92
+
93
+ if (!title) throw makeError("Missing title — first line must be `# <title>`.");
94
+
95
+ // Required sections — must be PRESENT (header exists), but content
96
+ // may be empty for sections like Structure where every key is
97
+ // optional. Use `in` so an empty-body section is accepted.
98
+ for (const required of ["requirements", "approach", "structure", "operations"]) {
99
+ if (!(required in sections)) {
100
+ throw makeError(`Missing required section: ## REASONS:${capitalize(required)}`);
101
+ }
102
+ }
103
+
104
+ return {
105
+ title,
106
+ requirements: parseRequirements(sections.requirements),
107
+ entities: sections.entities ? parseEntities(sections.entities) : [],
108
+ approach: sections.approach.trim(),
109
+ structure: parseStructure(sections.structure),
110
+ operations: parseOperations(sections.operations),
111
+ norms: sections.norms ? parseBullets(sections.norms) : [],
112
+ safeguards: sections.safeguards ? parseBullets(sections.safeguards) : [],
113
+ };
114
+ }
115
+
116
+ function capitalize(s) {
117
+ return s.length > 0 ? s[0].toUpperCase() + s.slice(1) : s;
118
+ }
119
+
120
+ function makeError(msg) {
121
+ const e = new Error(msg);
122
+ e.name = "CanvasParseError";
123
+ return e;
124
+ }
125
+
126
+ /**
127
+ * Requirements: a paragraph (problem) + optional "Definition of done:" bullets.
128
+ */
129
+ function parseRequirements(text) {
130
+ const lines = text.split("\n");
131
+ const problemLines = [];
132
+ const done = [];
133
+ let inDone = false;
134
+ for (const line of lines) {
135
+ if (/^\s*Definition of done:?\s*$/i.test(line)) { inDone = true; continue; }
136
+ if (inDone) {
137
+ const m = line.match(BULLET_RE);
138
+ if (m) done.push(m[1].trim());
139
+ continue;
140
+ }
141
+ if (line.trim()) problemLines.push(line.trim());
142
+ }
143
+ const problem = problemLines.join(" ").trim();
144
+ if (!problem) throw makeError("REASONS:Requirements is empty or has no problem statement.");
145
+ return { problem, done };
146
+ }
147
+
148
+ /**
149
+ * Entities: each bullet is "Name — fields: f1, f2. notes." (loose).
150
+ * We parse the first word as the entity name and capture the rest as notes.
151
+ */
152
+ function parseEntities(text) {
153
+ const out = [];
154
+ for (const raw of text.split("\n")) {
155
+ const m = raw.match(BULLET_RE);
156
+ if (!m) continue;
157
+ const body = m[1].trim();
158
+ // First token (possibly `quoted`) is the name; rest is notes.
159
+ const nameMatch = body.match(/^[`"']?([A-Za-z][\w-]*)[`"']?\s*[—-]?\s*(.*)$/);
160
+ if (!nameMatch) continue;
161
+ const [, name, rest] = nameMatch;
162
+ const fields = [];
163
+ const fm = rest.match(/fields?:\s*([^.]+)/i);
164
+ if (fm) fields.push(...fm[1].split(",").map((s) => s.trim()).filter(Boolean));
165
+ out.push({ name, fields, notes: rest });
166
+ }
167
+ return out;
168
+ }
169
+
170
+ function parseStructure(text) {
171
+ const out = { touches: [], depends_on: [], contracts: [] };
172
+ for (const raw of text.split("\n")) {
173
+ const m = raw.match(BULLET_RE);
174
+ if (!m) continue;
175
+ const body = m[1].trim();
176
+ const kvMatch = body.match(/^(touches|depends_on|contracts)\s*:\s*(.+)$/i);
177
+ if (!kvMatch) continue;
178
+ const key = kvMatch[1].toLowerCase();
179
+ const values = kvMatch[2].split(",").map((s) => s.trim()).filter(Boolean);
180
+ out[key] = values;
181
+ }
182
+ return out;
183
+ }
184
+
185
+ function parseBullets(text) {
186
+ const out = [];
187
+ for (const raw of text.split("\n")) {
188
+ const m = raw.match(BULLET_RE);
189
+ if (m) out.push(m[1].trim());
190
+ }
191
+ return out;
192
+ }
193
+
194
+ /**
195
+ * Operations: each top-level numbered/bulleted entry is one Operation.
196
+ * Inside, an "Acceptance:" sub-line introduces nested bullets where each
197
+ * bullet is "shell: <cmd>" or "gherkin: <scenario>".
198
+ */
199
+ function parseOperations(text) {
200
+ const ops = [];
201
+ const lines = text.split("\n");
202
+ let current = null;
203
+ let inAcceptance = false;
204
+
205
+ for (const line of lines) {
206
+ if (!line.trim()) continue;
207
+ // Top-level operation: numbered list or single dash at left margin.
208
+ const topMatch = line.match(/^(\d+\.\s+|[-*]\s+)(.+)$/);
209
+ if (topMatch && !line.startsWith(" ") && !line.startsWith("\t")) {
210
+ if (current) ops.push(current);
211
+ current = { title: topMatch[2].trim(), acceptance: [] };
212
+ inAcceptance = false;
213
+ continue;
214
+ }
215
+ if (current) {
216
+ if (ACCEPTANCE_HEADER_RE.test(line)) { inAcceptance = true; continue; }
217
+ const testMatch = line.match(TEST_LINE_RE);
218
+ if (testMatch && inAcceptance) {
219
+ current.acceptance.push({
220
+ type: testMatch[1].toLowerCase(),
221
+ content: testMatch[2].replace(/^`+|`+$/g, "").trim(),
222
+ });
223
+ }
224
+ }
225
+ }
226
+ if (current) ops.push(current);
227
+
228
+ if (ops.length === 0) {
229
+ throw makeError("REASONS:Operations has no operations. Each operation must be a numbered or bulleted item with at least one acceptance test.");
230
+ }
231
+ for (const op of ops) {
232
+ if (op.acceptance.length === 0) {
233
+ throw makeError(`Operation "${op.title}" has no acceptance tests. Add at least one ` +
234
+ '`- shell: <cmd>` or `- gherkin: <scenario>` under an "Acceptance:" line.');
235
+ }
236
+ }
237
+ return ops;
238
+ }
@@ -0,0 +1,101 @@
1
+ /**
2
+ * REASONS Canvas — Valibot schema for the structured SPEC format.
3
+ *
4
+ * Issue #539. Per Martin Fowler's Structured Prompt-Driven Development
5
+ * (https://martinfowler.com/articles/structured-prompt-driven/), a
6
+ * Canvas captures intent in 7 named sections so the planner doesn't
7
+ * have to improvise. The shape:
8
+ *
9
+ * Requirements — problem + done-when bullets
10
+ * Entities — domain nouns + relationships
11
+ * Approach — strategy + trade-offs
12
+ * Structure — system fit, dependencies, contracts
13
+ * Operations — concrete numbered steps. Each = one HU.
14
+ * Norms — task-level engineering standards
15
+ * Safeguards — non-negotiables: invariants, perf, security
16
+ *
17
+ * Operations carry their acceptance tests inline so the planner-time
18
+ * validator (validate.js) can check them parse BEFORE any LLM call.
19
+ * That's the bug-class fix this whole feature exists for: the
20
+ * 2026-04-29 incident where the planner emitted a syntactically-broken
21
+ * jq query and the coder iterated 3× against an irreparable test.
22
+ */
23
+
24
+ import * as v from "valibot";
25
+
26
+ const NonEmptyString = v.pipe(v.string(), v.minLength(1));
27
+
28
+ const Entity = v.looseObject({
29
+ name: NonEmptyString,
30
+ fields: v.optional(v.array(v.string())),
31
+ relationships: v.optional(v.array(v.unknown())),
32
+ notes: v.optional(v.string()),
33
+ });
34
+
35
+ const AcceptanceTest = v.looseObject({
36
+ type: v.picklist(["shell", "gherkin"]),
37
+ content: NonEmptyString,
38
+ // optional: file hint for tester translation of gherkin
39
+ file: v.optional(v.string()),
40
+ });
41
+
42
+ const Operation = v.looseObject({
43
+ // Either a free-form title or numbered step text.
44
+ title: NonEmptyString,
45
+ // Optional: the file or module the operation produces / touches.
46
+ file_hint: v.optional(v.string()),
47
+ // Optional: dependencies on other operation titles or HU ids.
48
+ blocked_by: v.optional(v.array(v.string())),
49
+ // Required: at least ONE acceptance test per operation. Empty array
50
+ // is rejected at plan-time so we never ship an HU without a contract.
51
+ acceptance: v.pipe(v.array(AcceptanceTest), v.minLength(1)),
52
+ });
53
+
54
+ const CanvasSchema = v.looseObject({
55
+ // Title is the project / feature name. The planner uses it as the
56
+ // plan name unless the user overrides on prompt.
57
+ title: NonEmptyString,
58
+ requirements: v.looseObject({
59
+ problem: NonEmptyString,
60
+ // Definition-of-done bullets. Empty array allowed — sometimes the
61
+ // problem statement IS the contract — but a non-empty array
62
+ // discourages woolly specs.
63
+ done: v.optional(v.array(NonEmptyString)),
64
+ }),
65
+ entities: v.optional(v.array(Entity)),
66
+ approach: NonEmptyString,
67
+ structure: v.looseObject({
68
+ touches: v.optional(v.array(v.string())),
69
+ depends_on: v.optional(v.array(v.string())),
70
+ contracts: v.optional(v.array(v.string())),
71
+ }),
72
+ operations: v.pipe(v.array(Operation), v.minLength(1)),
73
+ norms: v.optional(v.array(NonEmptyString)),
74
+ safeguards: v.optional(v.array(NonEmptyString)),
75
+ });
76
+
77
+ /**
78
+ * Validate-only entry point. Throws an Error with the offending path
79
+ * + message when the canvas doesn't match the schema. The validator
80
+ * (validate.js) uses this AND adds parse-checks for acceptance tests.
81
+ *
82
+ * @param {unknown} canvas
83
+ * @returns {import("valibot").InferOutput<typeof CanvasSchema>}
84
+ */
85
+ export function parseCanvas(canvas) {
86
+ return v.parse(CanvasSchema, canvas);
87
+ }
88
+
89
+ /**
90
+ * Soft check: returns the validation result without throwing. Useful
91
+ * for surfacing every schema error at once instead of bailing on the
92
+ * first.
93
+ *
94
+ * @param {unknown} canvas
95
+ * @returns {{ success: true, output: object } | { success: false, issues: object[] }}
96
+ */
97
+ export function safeParseCanvas(canvas) {
98
+ const r = v.safeParse(CanvasSchema, canvas);
99
+ if (r.success) return { success: true, output: r.output };
100
+ return { success: false, issues: r.issues };
101
+ }
@@ -0,0 +1,85 @@
1
+ /**
2
+ * Canvas → flat task string adapter.
3
+ *
4
+ * Renders a validated Canvas object as a single markdown blob the
5
+ * existing planner can consume verbatim. Preserves every section
6
+ * with its original heading so downstream steps (planner prompt,
7
+ * coder prompt, plan JSON `task` field) see the same shape.
8
+ *
9
+ * The point: Canvas users get planner-time validation (catching
10
+ * broken acceptance tests before they're persisted) AND benefit from
11
+ * every existing planner / coder pipeline without those pipelines
12
+ * needing Canvas awareness. Norms + Safeguards explicitly bracketed
13
+ * so prompts that scan for them can find them with a regex.
14
+ */
15
+
16
+ /**
17
+ * @param {object} canvas — output of validateCanvas (.canvas)
18
+ * @returns {string} markdown task ready for the planner
19
+ */
20
+ export function canvasToTask(canvas) {
21
+ const lines = [`# ${canvas.title}`, ""];
22
+
23
+ // Requirements
24
+ lines.push("## Requirements", canvas.requirements.problem);
25
+ if (canvas.requirements.done && canvas.requirements.done.length > 0) {
26
+ lines.push("", "Definition of done:");
27
+ for (const d of canvas.requirements.done) lines.push(`- ${d}`);
28
+ }
29
+ lines.push("");
30
+
31
+ // Entities (optional)
32
+ if (canvas.entities && canvas.entities.length > 0) {
33
+ lines.push("## Entities");
34
+ for (const e of canvas.entities) {
35
+ const fields = e.fields && e.fields.length > 0 ? ` — fields: ${e.fields.join(", ")}` : "";
36
+ lines.push(`- ${e.name}${fields}${e.notes ? `. ${e.notes}` : ""}`);
37
+ }
38
+ lines.push("");
39
+ }
40
+
41
+ // Approach
42
+ lines.push("## Approach", canvas.approach, "");
43
+
44
+ // Structure (optional content)
45
+ lines.push("## Structure");
46
+ if (canvas.structure?.touches?.length > 0) lines.push(`- touches: ${canvas.structure.touches.join(", ")}`);
47
+ if (canvas.structure?.depends_on?.length > 0) lines.push(`- depends_on: ${canvas.structure.depends_on.join(", ")}`);
48
+ if (canvas.structure?.contracts?.length > 0) lines.push(`- contracts: ${canvas.structure.contracts.join(", ")}`);
49
+ lines.push("");
50
+
51
+ // Operations — each becomes one HU. Acceptance tests inline so the
52
+ // planner sees the contract from turn 1.
53
+ lines.push("## Operations");
54
+ canvas.operations.forEach((op, i) => {
55
+ lines.push(`${i + 1}. ${op.title}`);
56
+ if (op.file_hint) lines.push(` file: ${op.file_hint}`);
57
+ if (op.blocked_by && op.blocked_by.length > 0) lines.push(` depends on: ${op.blocked_by.join(", ")}`);
58
+ lines.push(" Acceptance:");
59
+ for (const t of op.acceptance) {
60
+ // Render shell as one-liner, gherkin as fenced block so newlines survive.
61
+ if (t.type === "gherkin") {
62
+ lines.push(" - gherkin:", " ```gherkin", ...t.content.split("\n").map((l) => ` ${l}`), " ```");
63
+ } else {
64
+ lines.push(` - shell: \`${t.content}\``);
65
+ }
66
+ }
67
+ });
68
+ lines.push("");
69
+
70
+ // Norms (optional) — bracketed so prompts can find them.
71
+ if (canvas.norms && canvas.norms.length > 0) {
72
+ lines.push("## Norms (per-task engineering standards — coder MUST follow)");
73
+ for (const n of canvas.norms) lines.push(`- ${n}`);
74
+ lines.push("");
75
+ }
76
+
77
+ // Safeguards (optional) — bracketed similarly.
78
+ if (canvas.safeguards && canvas.safeguards.length > 0) {
79
+ lines.push("## Safeguards (non-negotiable invariants — code MUST hold these)");
80
+ for (const s of canvas.safeguards) lines.push(`- ${s}`);
81
+ lines.push("");
82
+ }
83
+
84
+ return lines.join("\n");
85
+ }
@@ -0,0 +1,163 @@
1
+ /**
2
+ * REASONS Canvas validator.
3
+ *
4
+ * Schema validation + planner-time sanity checks for acceptance tests.
5
+ * The schema is enforced via Valibot in canvas/schema.js. This module
6
+ * adds the bug-class fix: parse-check every shell acceptance test
7
+ * BEFORE it gets persisted into a plan and BEFORE any LLM is called.
8
+ *
9
+ * Catches the 2026-04-29 incident class:
10
+ * `length as $n | .filesOver300LOC == $n` → exits non-zero with a
11
+ * descriptive error pointing at the offending operation + test
12
+ * index, BEFORE the user has paid for any agent run.
13
+ */
14
+
15
+ import { spawnSync } from "node:child_process";
16
+ import { safeParseCanvas } from "./schema.js";
17
+
18
+ /**
19
+ * Run a single shell acceptance test through `bash -n` (parse-only,
20
+ * doesn't execute) to catch shell-level syntax errors. Then, if the
21
+ * test invokes `jq`, also probe the jq query through `jq -n <query>`
22
+ * with empty input — jq errors there iff the query has bad syntax.
23
+ *
24
+ * Trade-off accepted: bash -n won't catch every command-substitution
25
+ * pitfall (it parses but doesn't expand), and jq -n with empty input
26
+ * may pass queries that fail at runtime against real input. The point
27
+ * is to catch the OBVIOUS bugs cheaply, not to be airtight.
28
+ *
29
+ * @param {string} cmd
30
+ * @returns {{ ok: true } | { ok: false, kind: string, error: string }}
31
+ */
32
+ export function validateShellTest(cmd) {
33
+ if (typeof cmd !== "string" || cmd.trim().length === 0) {
34
+ return { ok: false, kind: "empty", error: "shell test is empty" };
35
+ }
36
+
37
+ // Layer 1: bash -n parse-check on the whole command.
38
+ const bash = spawnSync("bash", ["-n", "-c", cmd], { encoding: "utf8", timeout: 5000 });
39
+ if (bash.status !== 0) {
40
+ const err = (bash.stderr || "").trim() || "bash -n rejected the command";
41
+ return { ok: false, kind: "shell-syntax", error: err };
42
+ }
43
+
44
+ // Layer 2: every `jq '...'` invocation gets its query parse-checked.
45
+ // Permissive regex: catches `jq -e 'X'`, `jq "X"`, `| jq 'X'`. False
46
+ // negatives are fine — better to skip a real jq than misinterpret a
47
+ // shell-quoting edge case.
48
+ //
49
+ // We distinguish COMPILE errors (the bug we want to catch — invalid
50
+ // syntax, e.g. `length as $n | .field` over an array) from RUNTIME
51
+ // errors (the query is well-formed but fails on null input from
52
+ // `-n`, like `.foo[]` on null). Only compile errors fail validation;
53
+ // runtime errors against synthetic input are expected because real
54
+ // input isn't available at plan-time.
55
+ const jqRe = /\bjq\b\s+(?:-[a-zA-Z]+\s+)*(?:'([^']+)'|"([^"]+)")/g;
56
+ for (const m of cmd.matchAll(jqRe)) {
57
+ const query = m[1] || m[2];
58
+ if (!query) continue;
59
+
60
+ // Static pattern detector for the 2026-04-29 as-binding misuse:
61
+ // `[expr] | length as $X | .field` and similar. The `as $X`
62
+ // binds the value to a name but does NOT change the value
63
+ // flowing through the pipe. The next `.field` is therefore
64
+ // applied to the array tail (or whatever the previous stage
65
+ // returned), not to the original root. Always wrong.
66
+ //
67
+ // Detection: a pipeline whose tail is `length as $X | .X` (or
68
+ // any `<terminal-operator> as $X | .field`) is the smell.
69
+ const asBindingMisuse = /\b(?:length|keys|values|min|max|add|first|last)\s+as\s+\$[A-Za-z_][\w]*\s*\|\s*\.[A-Za-z_]/;
70
+ if (asBindingMisuse.test(query)) {
71
+ return {
72
+ ok: false,
73
+ kind: "jq-syntax",
74
+ error: "Likely as-binding misuse: `length as $n | .field` does not change the value flowing through; `.field` is applied to the previous stage's output, not the root. Use `. as $r | <transform> | $r.field` instead.",
75
+ };
76
+ }
77
+
78
+ const jq = spawnSync("jq", ["-n", query], { encoding: "utf8", timeout: 5000 });
79
+ if (jq.status !== 0) {
80
+ const err = (jq.stderr || "").trim() || "jq rejected the query";
81
+ // jq distinguishes compile errors with these tokens. Anything
82
+ // else (e.g. "Cannot index null with string") is a runtime error
83
+ // against the empty input, NOT a syntax bug.
84
+ const isCompileError = /\b(compile error|syntax error|unexpected|jq: error \(at <stdin>:\d+\): ?$)/i.test(err);
85
+ if (isCompileError) {
86
+ return { ok: false, kind: "jq-syntax", error: err };
87
+ }
88
+ // Special case: `length as $n | .field` returns "Cannot index
89
+ // array/number/string with string" on -n input because the as-
90
+ // binding misuse means `.field` is applied to the wrong thing.
91
+ // This is exactly the 2026-04-29 bug class. Treat it as syntax-
92
+ // adjacent: the query is "compilable" but semantically broken
93
+ // by misuse of as-binding.
94
+ if (/Cannot index (array|number|string) with string/i.test(err)) {
95
+ return { ok: false, kind: "jq-syntax", error: err };
96
+ }
97
+ // Otherwise let it pass — runtime error against synthetic input
98
+ // is fine. jq parsed the query successfully.
99
+ }
100
+ }
101
+
102
+ return { ok: true };
103
+ }
104
+
105
+ /**
106
+ * Validate every operation's acceptance tests in a parsed Canvas.
107
+ * Returns an array of issues; empty array means everything passed.
108
+ *
109
+ * @param {object} canvas
110
+ * @returns {Array<{ operationIndex: number, operationTitle: string, testIndex: number, type: string, content: string, kind: string, error: string }>}
111
+ */
112
+ export function validateAcceptanceTests(canvas) {
113
+ const issues = [];
114
+ if (!canvas || !Array.isArray(canvas.operations)) return issues;
115
+ canvas.operations.forEach((op, opIdx) => {
116
+ (op.acceptance || []).forEach((t, tIdx) => {
117
+ if (t.type === "shell") {
118
+ const r = validateShellTest(t.content);
119
+ if (!r.ok) {
120
+ issues.push({
121
+ operationIndex: opIdx,
122
+ operationTitle: op.title,
123
+ testIndex: tIdx,
124
+ type: t.type,
125
+ content: t.content,
126
+ kind: r.kind,
127
+ error: r.error,
128
+ });
129
+ }
130
+ } else if (t.type === "gherkin") {
131
+ // Minimal gherkin sanity: must contain at least one Given AND
132
+ // one Then. When/And/But are optional. This catches "blank
133
+ // gherkin" without trying to parse the language.
134
+ if (!/\bGiven\b/i.test(t.content) || !/\bThen\b/i.test(t.content)) {
135
+ issues.push({
136
+ operationIndex: opIdx,
137
+ operationTitle: op.title,
138
+ testIndex: tIdx,
139
+ type: t.type,
140
+ content: t.content,
141
+ kind: "gherkin-incomplete",
142
+ error: "Gherkin scenario must contain at least one Given and one Then.",
143
+ });
144
+ }
145
+ }
146
+ });
147
+ });
148
+ return issues;
149
+ }
150
+
151
+ /**
152
+ * Top-level validator. Runs schema + acceptance-test parse-checks.
153
+ *
154
+ * @param {unknown} canvas
155
+ * @returns {{ valid: true, canvas: object } | { valid: false, schemaIssues?: object[], testIssues?: object[] }}
156
+ */
157
+ export function validateCanvas(canvas) {
158
+ const schema = safeParseCanvas(canvas);
159
+ if (!schema.success) return { valid: false, schemaIssues: schema.issues };
160
+ const testIssues = validateAcceptanceTests(schema.output);
161
+ if (testIssues.length > 0) return { valid: false, testIssues };
162
+ return { valid: true, canvas: schema.output };
163
+ }
@@ -60,7 +60,7 @@ function createCoreBinaryCheck(bin) {
60
60
  /**
61
61
  * Docker check. Manual strategy (platform-dependent install).
62
62
  */
63
- export function createDockerCheck() {
63
+ function createDockerCheck() {
64
64
  return {
65
65
  name: "docker",
66
66
  label: "Docker",
@@ -80,7 +80,7 @@ export function createDockerCheck() {
80
80
  /**
81
81
  * Serena MCP (optional). Prompt strategy: we know how to install it.
82
82
  */
83
- export function createSerenaCheck() {
83
+ function createSerenaCheck() {
84
84
  return {
85
85
  name: "serena",
86
86
  label: "Serena MCP",
@@ -88,7 +88,7 @@ export function createSerenaCheck() {
88
88
  applies: (config) => config.serena?.enabled === true,
89
89
  describe: "Install Serena via: uvx --from git+https://github.com/oraios/serena serena",
90
90
  async detect() {
91
- let ok = false;
91
+ let ok;
92
92
  try {
93
93
  const res = await runCommand("serena", ["--version"]);
94
94
  ok = res.exitCode === 0;
package/src/checks/ci.js CHANGED
@@ -37,7 +37,7 @@ function createWorkflowCheck(workflow) {
37
37
  };
38
38
  }
39
39
 
40
- export function createGhCliCheck() {
40
+ function createGhCliCheck() {
41
41
  return {
42
42
  name: "ci:gh",
43
43
  label: "CI: gh CLI",
@@ -55,7 +55,7 @@ export function createGhCliCheck() {
55
55
  };
56
56
  }
57
57
 
58
- export function createGhSecretsCheck() {
58
+ function createGhSecretsCheck() {
59
59
  return {
60
60
  name: "ci:secrets",
61
61
  label: "CI: GitHub secrets",
@@ -20,7 +20,7 @@ import { STRATEGY } from "./types.js";
20
20
  /**
21
21
  * kj.config.yml presence check.
22
22
  */
23
- export function createConfigFileCheck() {
23
+ function createConfigFileCheck() {
24
24
  return {
25
25
  name: "config",
26
26
  label: "Config file",
@@ -42,7 +42,7 @@ export function createConfigFileCheck() {
42
42
  /**
43
43
  * Review rules (.md) informational check.
44
44
  */
45
- export function createReviewRulesCheck() {
45
+ function createReviewRulesCheck() {
46
46
  return {
47
47
  name: "review-rules",
48
48
  label: "Reviewer rules (.md)",
@@ -63,7 +63,7 @@ export function createReviewRulesCheck() {
63
63
  /**
64
64
  * Coder rules (.md) informational check.
65
65
  */
66
- export function createCoderRulesCheck() {
66
+ function createCoderRulesCheck() {
67
67
  return {
68
68
  name: "coder-rules",
69
69
  label: "Coder rules (.md)",
@@ -104,7 +104,7 @@ function findDuplicateTomlKeys(content) {
104
104
  /**
105
105
  * Claude config (~/.claude.json) validity.
106
106
  */
107
- export function createClaudeConfigCheck() {
107
+ function createClaudeConfigCheck() {
108
108
  return {
109
109
  name: "agent-config:claude",
110
110
  label: "Agent config: claude (~/.claude.json)",
@@ -135,7 +135,7 @@ export function createClaudeConfigCheck() {
135
135
  /**
136
136
  * Codex config (~/.codex/config.toml) validity.
137
137
  */
138
- export function createCodexConfigCheck() {
138
+ function createCodexConfigCheck() {
139
139
  return {
140
140
  name: "agent-config:codex",
141
141
  label: "Agent config: codex (~/.codex/config.toml)",
@@ -173,7 +173,7 @@ export function createCodexConfigCheck() {
173
173
  /**
174
174
  * KJ config (~/.karajan/kj.config.yml) YAML validity (separate from existence).
175
175
  */
176
- export function createKjConfigYamlCheck() {
176
+ function createKjConfigYamlCheck() {
177
177
  return {
178
178
  name: "agent-config:karajan",
179
179
  label: "Agent config: karajan (kj.config.yml)",