karajan-code 2.19.4 → 2.20.0

package/README.md

@@ -345,6 +345,18 @@ Opt out: set `telemetry: false` in `~/.karajan/kj.config.yml`
 
 ## Recent releases
 
+> **v2.20.0 released** — Minor. **HU Board polish + UX papercuts** cluster: 5 cards closed across two net-new features, two PG housekeeping syncs for work that had already landed, and one docs refresh.
+>
+> KJC-TSK-0397 (PR #801): **`kj plan generate` now prepends a `[PREFLIGHT-000]` HU to every plan** and gates every functional HU on it. The HU's acceptance tests are stack-aware shell commands — Node gets `node --version` + `npm install` + conditional `npm test` / `npm run lint`; Python gets `python --version` + `pip install -r requirements.txt` (or `poetry install`) + `pytest --collect-only`; Firebase projects get `firebase projects:list`; GCP projects get `gcloud auth list`; everyone gets `git status --porcelain`. Idempotent: a plan that already has a HU titled `PREFLIGHT-000` / "verificar entorno" is left untouched. Opt out per-invocation with `--no-preflight-hu`. The point: Karajan owns the plumbing, the user no longer has to remember to add a 'verify env' step to every task file.
+>
+> KJC-TSK-0395 (PR #802): **`kj init` learns a config scope wizard plus `--global` / `--local` flags**. The wizard now asks where the config should land — `~/.karajan/kj.config.yml` (global) or `./.karajan/kj.config.yml` (local override). `loadConfig` refuses to load a project that has a local config without a global counterpart with an actionable message — the override-on-top-of-base invariant. Use case: a repo with `coder=claude`, another with `coder=opencode`, without editing YAML by hand.
+>
+> KJC-TSK-0396 (PG sync, originally PRs #702 + #703): **HU Board `⏹ Stop` button** aborts every `kj run` associated with a plan via SIGTERM → SIGKILL escalation, resets running HUs to pending. Already shipped in v2.10.x; today's release closes the PG card with the canonical commits as evidence.
+>
+> KJC-TSK-0377 (PG sync, originally PR #683): **auto-cleanup ampliado** to also catch `s_*`, `plan-*`, `auto-tmp_*`, `auto-test_*` prefixes during the boot ephemeral-project sweep. Already shipped in v2.12.x.
+>
+> KJC-TSK-0385 (PR #800): **`docs/task-templates/spec-conventions.md` gains Section 8 (`spec_section` REQUIRED when numbered SPEC headings present) and Section 9 (`acceptance_tests` shape, 2-4 tests, gherkin + shell mix)**. Plus `plan-generate.md` switches two stale `~/.kj/plans/` paths to `~/.karajan/plans/`.
+>
 > **v2.19.4 released** — Patch. **`kj resume` now continues from where it stopped** + **autoInit no longer commits zombies on the user's main**. Two bugs closed in one release.
 >
 > KJC-BUG-0058 (PR #798, reported by [@aitormf](https://github.com/aitormf)): a session that stopped during Sonar would re-run the full pre-loop on `kj resume <id>` — HU-reviewer, intent, discover, triage, domainCurator, **researcher, architect, planner** all from scratch — doubling token cost and breaking the value-prop of the command. Root cause: `resumeFlow` (flow-runner.js:280) called `runFlow` without rehydrating stage state, and the session never persisted stage outputs in the first place. **Fix**: two new mutators in `src/session/mutators.js` (`setStageResult` mirrors into `stage_results[name]` + `stages_completed[]`; `setStageBundle` adds `stage_bundles[name]` for cross-stage context like `researchContext`, `architectContext`, `plannedTask`). Two closures inside `runPreLoopStages` (`persistStage` + `resumeSkip`) wrap every cacheable stage. `init-context.js` rehydrates `ctx.stageResults` from the loaded session before invoking the pre-loop. Triage is *not* skipped on resume — it produces `roleOverrides` the Brain decisor depends on and is cheap to re-run.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "karajan-code",
-  "version": "2.19.4",
+  "version": "2.20.0",
   "description": "Local multi-agent coding orchestrator with TDD, SonarQube, and code review pipeline",
   "type": "module",
   "license": "AGPL-3.0",

package/src/cli/register-pipeline.js

@@ -23,6 +23,8 @@ export function registerPipeline(program, { pkgVersion }) {
     .description("Initialize config, review rules and SonarQube")
     .option("--no-interactive", "Skip wizard, use defaults (for CI/scripts)")
     .option("--scaffold-ci", "Scaffold Karajan CI Gateway workflow files")
+    .option("--global", "Save config to ~/.karajan/kj.config.yml (skip the scope wizard)")
+    .option("--local", "Save config to ./.karajan/kj.config.yml (skip the scope wizard)")
     .action(async (flags) => {
       await withConfig(pkgVersion, "init", flags, async ({ config: _config, logger }) => {
         await initCommand({ logger, flags });

package/src/cli/register-plan.js

@@ -42,6 +42,7 @@ export function registerPlan(program, { pkgVersion }) {
     .option("--no-plan-review", "Skip the high-level plan reviewer pass (gaps / deps / overlap / order)")
     .option("--skip-spec-review", "Bypass the spec-reviewer pre-pipeline audit")
     .option("--quick", "Sketch mode — skip every quality pass after the initial planner call")
+    .option("--no-preflight-hu", "Skip auto-injection of [PREFLIGHT-000] HU at the top of the generated plan")
     .option("-y, --yes", "Skip the project-name prompt (use the auto-derived default).")
     .option("--no-interactive", "Force non-interactive mode (no prompts, use defaults).")
     .action(async (task, flags) => {
@@ -100,6 +101,7 @@ export function registerPlan(program, { pkgVersion }) {
             quick: Boolean(flags.quick),
             yes: Boolean(flags.yes),
             interactive: flags.interactive,
+            preflightHu: flags.preflightHu !== false, // KJC-TSK-0397
           },
         });
       });

package/src/commands/init.js

@@ -1,7 +1,7 @@
 import fs from "node:fs/promises";
 import os from "node:os";
 import path from "node:path";
-import { getConfigPath, loadConfig, writeConfig } from "../config.js";
+import { getConfigPath, getProjectConfigPath, loadConfig, writeConfig } from "../config.js";
 import { sonarUp, checkVmMaxMapCount } from "../sonar/manager.js";
 import { exists, ensureDir } from "../utils/fs.js";
 import { getKarajanHome } from "../utils/paths.js";
@@ -579,19 +579,50 @@ async function ensureGitignoreEntries(projectDir, logger) {
   logger.info(`Added to .gitignore: ${missing.map(e => e.pattern).join(", ")}`);
 }
 
+/**
+ * KJC-TSK-0395: decide where the config is written based on the flags
+ * and (when interactive) a wizard prompt. Returns { configPath, scope }.
+ * Throws when both --global and --local are passed (mutually exclusive).
+ */
+export async function resolveConfigScope({ flags, interactive }) {
+  if (flags?.global && flags?.local) {
+    throw new Error("Cannot pass both --global and --local — pick one scope for the config.");
+  }
+  if (flags?.global) return { configPath: getConfigPath(), scope: "global" };
+  if (flags?.local) return { configPath: getProjectConfigPath(process.cwd()), scope: "local" };
+  if (interactive) {
+    const wizard = createWizard();
+    try {
+      const choice = await wizard.select(
+        "Where do you want to save the config? (default: global)",
+        [
+          { value: "global", label: `Global (${getConfigPath()} — applies to all projects)` },
+          { value: "local",  label: `Local  (${getProjectConfigPath(process.cwd())} — overrides global for this project only)` },
+        ]
+      );
+      return { configPath: choice === "local" ? getProjectConfigPath(process.cwd()) : getConfigPath(), scope: choice };
+    } finally {
+      wizard.close();
+    }
+  }
+  // Non-interactive + no flags → legacy behaviour: global. Keeps CI scripts working.
+  return { configPath: getConfigPath(), scope: "global" };
+}
+
 export async function initCommand({ logger, flags = {} }) {
   const karajanHome = getKarajanHome();
   await ensureDir(karajanHome);
   logger.info(`Ensured ${karajanHome} exists`);
 
-  const configPath = getConfigPath();
+  const interactive = flags.noInteractive !== true && isTTY();
+  const { configPath, scope } = await resolveConfigScope({ flags, interactive });
+  logger.info(`Config scope: ${scope} → ${configPath}`);
   const karajanDir = path.join(process.cwd(), ".karajan");
   await ensureDir(karajanDir);
   const reviewRulesPath = path.resolve(karajanDir, "review-rules.md");
   const coderRulesPath = path.resolve(karajanDir, "coder-rules.md");
 
   const { config, exists: configExists } = await loadConfig();
-  const interactive = flags.noInteractive !== true && isTTY();
 
   // Auto-detect language from OS locale for non-interactive mode
   if (!interactive && !configExists) {

package/src/commands/plan/generate.js

@@ -14,6 +14,7 @@ import { withBrainRecovery } from "../../brain/with-brain-recovery.js";
 import { buildStandbyState } from "../../brain/standby-store.js";
 import { printResumeHint } from "../../utils/display/resume-hint.js";
 import { runSpecReview } from "../../spec-review/run-spec-review.js";
+import { prependPreflightHu } from "../../plan/preflight-hu.js";
 import { formatPlan, formatHuTable } from "./_shared.js";
 
 /**
@@ -414,6 +415,15 @@ async function planGenerateImpl({ task, config, logger, json, context, runLog, f
     }
   }
 
+  // KJC-TSK-0397: inject a [PREFLIGHT-000] HU at the top of the plan so
+  // every functional HU gates on a clean environment (deps + build + tests
+  // + lint + git clean, plus cloud auth when applicable). Idempotent: a
+  // plan that already has a preflight HU is left untouched. Disable with
+  // `--no-preflight-hu`.
+  if (flags.preflightHu !== false) {
+    await prependPreflightHu(plan, projectDir);
+  }
+
   const planId = await savePlan(projectDir, plan);
   const { plansDir } = await import("../../plan/plan-store.js");
   const path = await import("node:path");

package/src/config/loader.js

@@ -114,6 +114,18 @@ export async function loadConfig(projectDir) {
   // Load project config (.karajan/kj.config.yml)
   const projectConfig = await loadProjectConfig(projectDir);
 
+  // KJC-TSK-0395: enforce the local-overrides-global hierarchy. A project
+  // config with no global counterpart is almost always user error (copied
+  // a .karajan dir from another repo, edited the wrong file, etc.) and
+  // would silently behave like a global config without the defaults
+  // people expect. Refuse with an actionable message.
+  if (projectConfig && !globalExists) {
+    throw new Error(
+      `Local config found at ${getProjectConfigPath(projectDir)} but no global config exists.\n` +
+      "Local configs are merged ON TOP of the global one — run `kj init --global` first to create the base."
+    );
+  }
+
   // Merge: DEFAULTS < global < project
   let merged = mergeDeep(DEFAULTS, globalConfig);
   if (projectConfig) {

package/src/plan/preflight-hu.js

@@ -0,0 +1,102 @@
+/**
+ * KJC-TSK-0397: auto-inject a [PREFLIGHT-000] HU at the top of every
+ * plan generated by `kj plan generate` so the sub-pipeline gates on a
+ * clean environment before burning tokens on functional HUs.
+ *
+ * Design points:
+ *   - Pure shell tests — no Karajan-specific runtime, just commands
+ *     that exit 0 when the environment is ready.
+ *   - Stack-aware: Node, Python and Firebase signals come straight
+ *     from detectProjectStack() + on-disk file probes. Adding a new
+ *     stack is one entry in `composePreflightTests`.
+ *   - Idempotent: re-running over a plan that already has a HU with
+ *     id `PREFLIGHT-000` or a title containing 'preflight' / 'verificar
+ *     entorno' returns the plan unchanged. Required because the same
+ *     planner output may flow through structural-pass + plan-fixer
+ *     before reaching savePlan.
+ *   - All other HUs' `blocked_by` get the PREFLIGHT-000 id appended
+ *     (unless they already have it, again idempotent). Their own
+ *     dependencies are preserved.
+ */
+import { existsSync } from "node:fs";
+import { join } from "node:path";
+
+import { detectProjectStack } from "../utils/stack-detect.js";
+
+const PREFLIGHT_ID = "PREFLIGHT-000";
+
+/**
+ * Compose stack-aware shell acceptance tests. Always includes a
+ * `git status --porcelain` clean-tree check; everything else is
+ * additive based on what the project actually uses.
+ */
+export function composePreflightTests(stack, projectDir = ".") {
+  const tests = [
+    { type: "shell", content: "git status --porcelain | (! grep -q .)" },
+  ];
+  const lang = stack?.language;
+  if (lang === "javascript" || lang === "typescript") {
+    tests.push({ type: "shell", content: "node --version | grep -qE '^v(2[0-9]|[3-9][0-9])'" });
+    if (existsSync(join(projectDir, "package.json"))) {
+      tests.push({ type: "shell", content: "npm install --no-audit --no-fund" });
+      tests.push({ type: "shell", content: "test -z \"$(npm run | grep -E '^  test$')\" || npm test" });
+      tests.push({ type: "shell", content: "test -z \"$(npm run | grep -E '^  lint$')\" || npm run lint" });
+    }
+  } else if (lang === "python") {
+    tests.push({ type: "shell", content: "python --version | grep -qE 'Python 3\\.(1[0-9]|[2-9][0-9])'" });
+    if (existsSync(join(projectDir, "requirements.txt"))) {
+      tests.push({ type: "shell", content: "pip install -r requirements.txt" });
+    } else if (existsSync(join(projectDir, "pyproject.toml"))) {
+      tests.push({ type: "shell", content: "test -f poetry.lock && poetry install || pip install -e ." });
+    }
+    tests.push({ type: "shell", content: "command -v pytest && pytest --collect-only || true" });
+  }
+  if (existsSync(join(projectDir, "firebase.json"))) {
+    tests.push({ type: "shell", content: "firebase projects:list" });
+  }
+  if (existsSync(join(projectDir, ".gcloudignore"))) {
+    tests.push({ type: "shell", content: "gcloud auth list --filter=status:ACTIVE --format='value(account)' | (! test -z \"$(cat)\")" });
+  }
+  return tests;
+}
+
+/**
+ * Return true when the plan already has a preflight-style HU (by id or
+ * title). Pattern-matches conservatively to avoid duplicate injection.
+ */
+export function hasPreflightHu(plan) {
+  if (!plan?.hus?.length) return false;
+  return plan.hus.some((hu) => {
+    if (hu.id === PREFLIGHT_ID) return true;
+    const title = (hu.title || hu.description || "").toLowerCase();
+    return title.includes("preflight-000") || title.includes("verificar entorno") || title.includes("preflight check");
+  });
+}
+
+/**
+ * Prepend a [PREFLIGHT-000] HU to the plan and append its id to the
+ * `blocked_by` of every other HU. Returns the mutated plan reference
+ * for convenience; mutation is in place so callers don't need to
+ * reassign. No-op when the plan already has a preflight HU.
+ */
+export async function prependPreflightHu(plan, projectDir) {
+  if (!plan?.hus) return plan;
+  if (hasPreflightHu(plan)) return plan;
+  const stack = await detectProjectStack(projectDir);
+  const preflight = {
+    id: PREFLIGHT_ID,
+    title: "[PREFLIGHT-000] Verificar entorno de desarrollo listo",
+    description: "[PREFLIGHT-000] Block functional HUs until the project's environment is reproducible: deps installed, build/test/lint passing, git tree clean, cloud auth ready when applicable.",
+    task_type: "infra",
+    blocked_by: [],
+    reuse: [],
+    acceptance_tests: composePreflightTests(stack, projectDir),
+    spec_section: null,
+  };
+  for (const hu of plan.hus) {
+    if (!Array.isArray(hu.blocked_by)) hu.blocked_by = [];
+    if (!hu.blocked_by.includes(PREFLIGHT_ID)) hu.blocked_by.push(PREFLIGHT_ID);
+  }
+  plan.hus.unshift(preflight);
+  return plan;
+}