karajan-code 2.19.1 → 2.19.2

package/README.md

@@ -345,6 +345,8 @@ Opt out: set `telemetry: false` in `~/.karajan/kj.config.yml`
 
 ## Recent releases
 
+> **v2.19.2 released** — Patch. **SonarQube 401 now triggers automatic token re-bootstrap** instead of failing the run (KJC-BUG-0057). Until v2.19.1, when the Sonar token was missing / stale / revoked / pointed at a recreated Sonar instance, `kj run` / `kj audit` threw `SonarQube authentication failed (HTTP 401)` with the hint "Regenerate with `kj init`" — putting the user in the loop for plumbing Karajan can do itself. PR #793 wires `src/sonar/api.js::sonarFetchOnce` to invoke a new `src/sonar/token-recovery.js::recoverSonarToken()` on the first 401, which reuses `bootstrapSonarToken()` (already shipped in v2.10.2) — probes admin/admin, rotates the default password if still in place, revokes the existing `karajan-cli` token, generates a fresh GLOBAL_ANALYSIS_TOKEN, mutates `config.sonarqube.token` in place AND mirrors it to `~/.karajan/sonar-credentials.json` so future processes pick it up via the normal resolver chain instead of triggering recovery again. The original request retries once with the new token; the user never sees the 401 when recovery succeeds. Per-process latch ensures N endpoints 401-ing trigger ONE bootstrap, not N. Programmatic, **zero LLM involvement** — exactly the kind of plumbing Karajan should never delegate to the agent. Reported by [@aitormf](https://github.com/aitormf).
+>
 > **v2.19.1 released** — Patch. **APPLICATION BLOCKER fix** for the HU Board: every fresh `npm install -g karajan-code` since the HU Board feature shipped was producing tarballs without the `packages/hu-board/` directory (the `files` array in `package.json` did not include it), and even when the user copied that directory manually, the board crashed at startup with `Cannot find package 'helmet' imported from .../packages/hu-board/src/server.js` because its five dependencies (`helmet`, `chokidar`, `better-sqlite3`, `express`, `express-rate-limit`) were declared in `packages/hu-board/package.json` but missing from the root `dependencies`. PR #791 adds `packages/hu-board/{src,public,package.json}` to `files`, adds the five deps at root at the exact same versions so `npm dedupe` collapses to one copy resolvable by upward traversal, and regenerates `package-lock.json`. Verified end-to-end: `npm pack --dry-run` now ships 12 board files; `node packages/hu-board/src/server.js` boots cleanly. Also internal: 38 direct `os.homedir()` callers routed through the unified resolver (PR #790, `KARAJAN_HOME` now redirects every component) and 5 inline constructions of `~/.karajan/hu-board-runs/` unified under one helper (PR #789). Reported by [@aitormf](https://github.com/aitormf). **If you tried v2.19.0 and `kj board start` failed, upgrade to v2.19.1.**
 >
 > **v2.19.0 released** — Minor. Consolidates the HOME-level state of Karajan into a single root: **`~/.karajan/`**. Previously `~/.kj/` held plans, hibernated standby state, run-registry entries and worktrees, while `~/.karajan/` held sessions, hu-stories, config and the rest — no ADR justified the split and four divergent `getKjHome()` implementations had drifted. Three internal PRs land the change without breaking anyone: PR #781 unifies the resolver and introduces **`KARAJAN_HOME`** as the canonical env var (with `KJ_HOME` honoured + one-shot deprecation warning); PR #782 ships an idempotent **auto-migrator** that runs once on the next `kj` invocation — tarball backup at `~/.karajan/backup/kj-pre-migration-<ISO>.tar.gz` BEFORE moving, marker file `~/.karajan/.kj-migrated.json` prevents re-runs, cross-device safe (`rename` → `cp + rm` on `EXDEV`); PR #783 flips every default to `~/.karajan/` and adds a `legacy-kj-home` check to `kj doctor`. The HU Board reads BOTH locations until the migrator fires, so users who start the board first never see "missing plans". Restore is one `tar -xzf ~/.karajan/backup/kj-pre-migration-<ts>.tar.gz -C ~` away. Safe upgrade from 2.18.x.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "karajan-code",
-  "version": "2.19.1",
+  "version": "2.19.2",
   "description": "Local multi-agent coding orchestrator with TDD, SonarQube, and code review pipeline",
   "type": "module",
   "license": "AGPL-3.0",

package/src/sonar/api.js

@@ -3,6 +3,7 @@ import { withRetry } from "../utils/retry.js";
 import { resolveSonarProjectKey } from "./project-key.js";
 import { resolveSonarToken } from "./config-resolver.js";
 import { filterFalsePositives } from "./issue-filter.js";
+import { recoverSonarToken } from "./token-recovery.js";
 
 class SonarApiError extends Error {
   constructor(message, { url, httpStatus, hint } = {}) {
@@ -25,7 +26,7 @@ function parseHttpResponse(stdout) {
   return { httpCode, body };
 }
 
-async function sonarFetchOnce(config, urlPath) {
+async function sonarFetchOnce(config, urlPath, { _retriedAfterRecovery = false, logger = null } = {}) {
   const token = tokenFromConfig(config);
   const url = `${config.sonarqube.host}${urlPath}`;
   const res = await runCommand("curl", ["-s", "-w", "\n%{http_code}", "-u", `${token}:`, url]);
@@ -42,9 +43,22 @@ async function sonarFetchOnce(config, urlPath) {
   const { httpCode, body } = parseHttpResponse(res.stdout);
 
   if (httpCode === 401) {
+    // KJC-BUG-0057 (v2.19.2): try to bootstrap a fresh token via the Sonar
+    // REST API and retry ONCE. If recovery still fails — or this was already
+    // the retry — surface the actionable error like before.
+    if (!_retriedAfterRecovery) {
+      const recovery = await recoverSonarToken(config, logger);
+      if (recovery.ok) {
+        return sonarFetchOnce(config, urlPath, { _retriedAfterRecovery: true, logger });
+      }
+      throw new SonarApiError(
+        `SonarQube authentication failed (HTTP 401) and auto-recovery failed: ${recovery.reason}. Regenerate the token manually with 'kj init' or save admin user/password in ~/.karajan/sonar-credentials.json.`,
+        { url, httpStatus: 401, hint: "Run 'kj init' to regenerate the SonarQube token, or save admin credentials in ~/.karajan/sonar-credentials.json so Karajan can re-bootstrap automatically." }
+      );
+    }
     throw new SonarApiError(
-      `SonarQube authentication failed (HTTP 401). Token may be invalid or expired. Regenerate with 'kj init'.`,
-      { url, httpStatus: 401, hint: "Run 'kj init' to regenerate the SonarQube token." }
+      `SonarQube authentication failed (HTTP 401) even after auto-recovery. The newly generated token is also being rejected — the Sonar instance may be in an inconsistent state.`,
+      { url, httpStatus: 401, hint: "Inspect the Sonar UI directly; consider 'kj sonar restart'." }
     );
   }
 

package/src/sonar/token-recovery.js

@@ -0,0 +1,67 @@
+// Sonar 401 auto-recovery — KJC-BUG-0057 / v2.19.2.
+//
+// When the Sonar API returns 401 (token missing / invalid / expired / revoked)
+// and we still have admin/admin (or a user/pass we saved at `kj init` time),
+// regenerate the analysis token VIA THE REST API and persist it. The caller
+// retries the original request once with the new token.
+//
+// Programmatic, no LLM involvement. The whole point of the user feedback was
+// that this is plumbing, not a decision: Karajan has the credentials to
+// re-bootstrap and should do it without asking.
+
+import { bootstrapSonarToken } from "./token-bootstrap.js";
+import { saveSonarToken } from "./credentials.js";
+
+// Per-process latch: a single Sonar run that 401s on every endpoint must
+// only trigger ONE bootstrap attempt — not one per endpoint. The latch
+// resets when the process exits.
+let _recoveryAttempted = false;
+
+/**
+ * @internal Reset the latch between tests (mirrors __resetKjHomeWarningForTests).
+ */
+export function __resetSonarRecoveryLatchForTests() {
+  _recoveryAttempted = false;
+}
+
+/**
+ * Attempt to re-bootstrap the Sonar token after a 401. Mutates `config`
+ * in place when successful so the immediate retry picks up the new token.
+ *
+ * @param {object} config       Karajan config (will be mutated on success).
+ * @param {object} [logger]
+ * @returns {Promise<{ ok: boolean, reason?: string, newToken?: string, savedTo?: string, passwordRotated?: boolean }>}
+ */
+export async function recoverSonarToken(config, logger = null) {
+  if (_recoveryAttempted) {
+    return { ok: false, reason: "recovery already attempted in this process" };
+  }
+  _recoveryAttempted = true;
+
+  const host = config?.sonarqube?.host || "http://localhost:9000";
+  logger?.warn?.(`[sonar-recovery] 401 from ${host} — attempting token re-bootstrap`);
+
+  const result = await bootstrapSonarToken({ host });
+
+  if (!result.ok) {
+    logger?.warn?.(`[sonar-recovery] bootstrap failed: ${result.reason}`);
+    return { ok: false, reason: result.reason };
+  }
+
+  // Mutate the in-memory config so the caller's retry sees the new token.
+  config.sonarqube = config.sonarqube || {};
+  config.sonarqube.token = result.token;
+
+  // Also persist to ~/.karajan/sonar-credentials.json so future processes
+  // pick it up via the normal config-resolver chain instead of triggering
+  // recovery again. token-bootstrap.js already wrote sonar.token; this
+  // mirrors it into the structured credentials file the resolver reads.
+  try {
+    await saveSonarToken(result.token);
+  } catch (err) {
+    logger?.warn?.(`[sonar-recovery] persist to sonar-credentials.json failed (non-blocking): ${err.message}`);
+  }
+
+  logger?.info?.(`[sonar-recovery] new token persisted to ${result.savedTo}${result.passwordRotated ? " (admin password rotated)" : ""} — retrying original request`);
+  return { ok: true, newToken: result.token, savedTo: result.savedTo, passwordRotated: result.passwordRotated };
+}