karajan-code 1.15.0 → 1.17.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "karajan-code",
-  "version": "1.15.0",
+  "version": "1.17.0",
   "description": "Local multi-agent coding orchestrator with TDD, SonarQube, and code review pipeline",
   "type": "module",
   "license": "AGPL-3.0",

package/src/activity-log.js

@@ -3,24 +3,24 @@ import path from "node:path";
 import { getSessionRoot } from "./utils/paths.js";
 import { ensureDir } from "./utils/fs.js";
 
+function formatLine(entry) {
+  const ts = entry.timestamp || new Date().toISOString();
+  const lvl = (entry.level || "info").toUpperCase().padEnd(5);
+  const ctx = entry.context
+    ? Object.entries(entry.context)
+        .filter(([, v]) => v !== undefined)
+        .map(([k, v]) => `${k}=${v}`)
+        .join(" ")
+    : "";
+  const ctxStr = ctx ? ` ${ctx}` : "";
+  return `${ts} [${lvl}]${ctxStr} ${entry.message || ""}`;
+}
+
 export function createActivityLog(sessionId) {
   const logPath = path.join(getSessionRoot(), sessionId, "activity.log");
   let buffer = [];
   let flushing = false;
 
-  function formatLine(entry) {
-    const ts = entry.timestamp || new Date().toISOString();
-    const lvl = (entry.level || "info").toUpperCase().padEnd(5);
-    const ctx = entry.context
-      ? Object.entries(entry.context)
-          .filter(([, v]) => v !== undefined)
-          .map(([k, v]) => `${k}=${v}`)
-          .join(" ")
-      : "";
-    const ctxStr = ctx ? ` ${ctx}` : "";
-    return `${ts} [${lvl}]${ctxStr} ${entry.message || ""}`;
-  }
-
   async function flush() {
     if (flushing || buffer.length === 0) return;
     flushing = true;

package/src/agents/availability.js

@@ -8,7 +8,7 @@ export async function assertAgentsAvailable(agentNames = []) {
 
   for (const name of unique) {
     const meta = getAgentMeta(name);
-    if (!meta || !meta.bin) continue;
+    if (!meta?.bin) continue;
     const res = await runCommand(resolveBin(meta.bin), ["--version"]);
     if (res.exitCode !== 0) {
       missing.push({ name, ...meta });
@@ -19,8 +19,7 @@ export async function assertAgentsAvailable(agentNames = []) {
 
   const lines = ["Missing required AI CLIs for this command:"];
   for (const m of missing) {
-    lines.push(`- ${m.name}: command '${m.bin}' not found`);
-    lines.push(`  Install: ${m.installUrl}`);
+    lines.push(`- ${m.name}: command '${m.bin}' not found`, `  Install: ${m.installUrl}`);
   }
   throw new Error(lines.join("\n"));
 }

package/src/agents/claude-agent.js

@@ -2,6 +2,39 @@ import { BaseAgent } from "./base-agent.js";
 import { runCommand } from "../utils/process.js";
 import { resolveBin } from "./resolve-bin.js";
 
+/**
+ * Safely parse a JSON line, returning null on failure.
+ */
+function tryParseJson(line) {
+  try {
+    return JSON.parse(line);
+  } catch { return null; }
+}
+
+/**
+ * Try to extract a result string from a parsed JSON object.
+ * Returns the result string or null if the object is not a result message.
+ */
+function extractResultText(obj) {
+  if (obj.type === "result" && obj.result) {
+    return typeof obj.result === "string" ? obj.result : JSON.stringify(obj.result);
+  }
+  if (obj.result && typeof obj.result === "string") {
+    return obj.result;
+  }
+  return null;
+}
+
+/**
+ * Collect text parts from an assistant message's content blocks.
+ */
+function collectAssistantText(obj) {
+  if (obj.type !== "assistant" || !obj.message?.content) return [];
+  return obj.message.content
+    .filter(block => block.type === "text" && block.text)
+    .map(block => block.text);
+}
+
 /**
  * Extract the final text result from stream-json NDJSON output.
  * Each line is a JSON object. We collect assistant text content from
@@ -11,28 +44,16 @@ function extractTextFromStreamJson(raw) {
   const lines = (raw || "").split("\n").filter(Boolean);
   // Try to find a "result" message with the final text
   for (let i = lines.length - 1; i >= 0; i--) {
-    try {
-      const obj = JSON.parse(lines[i]);
-      if (obj.type === "result" && obj.result) {
-        return typeof obj.result === "string" ? obj.result : JSON.stringify(obj.result);
-      }
-      // Claude Code stream-json final message
-      if (obj.result && typeof obj.result === "string") {
-        return obj.result;
-      }
-    } catch { /* skip unparseable lines */ }
+    const obj = tryParseJson(lines[i]);
+    if (!obj) continue;
+    const result = extractResultText(obj);
+    if (result) return result;
   }
   // Fallback: accumulate all assistant text deltas
   const parts = [];
   for (const line of lines) {
-    try {
-      const obj = JSON.parse(line);
-      if (obj.type === "assistant" && obj.message?.content) {
-        for (const block of obj.message.content) {
-          if (block.type === "text" && block.text) parts.push(block.text);
-        }
-      }
-    } catch { /* skip */ }
+    const obj = tryParseJson(line);
+    if (obj) parts.push(...collectAssistantText(obj));
   }
   return parts.join("") || raw;
 }
@@ -129,7 +150,7 @@ export class ClaudeAgent extends BaseAgent {
       }));
       const raw = pickOutput(res);
       const output = extractTextFromStreamJson(raw);
-      return { ok: res.exitCode === 0, output, error: res.exitCode !== 0 ? raw : "", exitCode: res.exitCode };
+      return { ok: res.exitCode === 0, output, error: res.exitCode === 0 ? "" : raw, exitCode: res.exitCode };
     }
 
     // Without streaming, use json output to get structured response via stderr
@@ -137,7 +158,7 @@ export class ClaudeAgent extends BaseAgent {
     const res = await runCommand(resolveBin("claude"), args, cleanExecaOpts());
     const raw = pickOutput(res);
     const output = extractTextFromStreamJson(raw);
-    return { ok: res.exitCode === 0, output, error: res.exitCode !== 0 ? raw : "", exitCode: res.exitCode };
+    return { ok: res.exitCode === 0, output, error: res.exitCode === 0 ? "" : raw, exitCode: res.exitCode };
   }
 
   async reviewTask(task) {
@@ -150,6 +171,6 @@ export class ClaudeAgent extends BaseAgent {
       timeout: task.timeoutMs
     }));
     const raw = pickOutput(res);
-    return { ok: res.exitCode === 0, output: raw, error: res.exitCode !== 0 ? raw : "", exitCode: res.exitCode };
+    return { ok: res.exitCode === 0, output: raw, error: res.exitCode === 0 ? "" : raw, exitCode: res.exitCode };
   }
 }

package/src/agents/model-registry.js

@@ -21,7 +21,7 @@ export function getModelPricing(name) {
 
 export function isModelDeprecated(name) {
   const entry = modelRegistry.get(name);
-  if (!entry || !entry.deprecated) return false;
+  if (!entry?.deprecated) return false;
   return new Date(entry.deprecated) <= new Date();
 }
 

package/src/becaria/dispatch.js

@@ -66,7 +66,7 @@ export async function dispatchComment({ repo, prNumber, agent, body, becariaConf
   validateAgent(agent);
   if (!body) throw new Error("body is required (comment text)");
 
-  const prefix = becariaConfig?.comment_prefix !== false ? `[${agent}] ` : "";
+  const prefix = becariaConfig?.comment_prefix === false ? "" : `[${agent}] `;
   const eventType = becariaConfig?.comment_event || "becaria-comment";
 
   await sendDispatch(repo, {

package/src/becaria/repo.js

@@ -19,11 +19,11 @@ export async function detectRepo() {
 
   const url = res.stdout.trim();
   // SSH: git@github.com:owner/repo.git  or  git@github.com-alias:owner/repo.git
-  const sshMatch = url.match(/github\.com[^:]*:([^/]+\/[^/]+?)(?:\.git)?$/);
+  const sshMatch = /github\.com[^:]*:([^/]+\/[^/]+?)(?:\.git)?$/.exec(url);
   if (sshMatch) return sshMatch[1];
 
   // HTTPS: https://github.com/owner/repo.git
-  const httpsMatch = url.match(/github\.com\/([^/]+\/[^/]+?)(?:\.git)?$/);
+  const httpsMatch = /github\.com\/([^/]+\/[^/]+?)(?:\.git)?$/.exec(url);
   if (httpsMatch) return httpsMatch[1];
 
   return null;
@@ -40,6 +40,6 @@ export async function detectPrNumber(branch) {
   const res = await runCommand("gh", args);
   if (res.exitCode !== 0) return null;
 
-  const num = parseInt(res.stdout.trim(), 10);
+  const num = Number.parseInt(res.stdout.trim(), 10);
   return Number.isFinite(num) ? num : null;
 }

package/src/cli.js

@@ -72,6 +72,8 @@ program
   .option("--enable-tester")
   .option("--enable-security")
   .option("--enable-triage")
+  .option("--enable-discover")
+  .option("--enable-architect")
   .option("--enable-serena")
   .option("--mode <name>")
   .option("--max-iterations <n>")
@@ -242,7 +244,9 @@ sonar
     console.log(`Opened ${result.url}`);
   });
 
-program.parseAsync().catch((error) => {
+try {
+  await program.parseAsync();
+} catch (error) {
   console.error(error.message);
   process.exit(1);
-});
+}

package/src/commands/doctor.js

@@ -14,56 +14,63 @@ function getPackageVersion() {
   return JSON.parse(readFileSync(pkgPath, "utf8")).version;
 }
 
-export async function runChecks({ config }) {
-  const checks = [];
-
-  // 0. Karajan version
+function checkKarajanVersion() {
   const version = getPackageVersion();
-  checks.push({
+  return {
     name: "karajan",
     label: "Karajan Code",
     ok: true,
     detail: `v${version}`,
     fix: null
-  });
+  };
+}
 
-  // 1. Config file
+async function checkConfigFile() {
   const configPath = getConfigPath();
   const configExists = await exists(configPath);
-  checks.push({
+  return {
     name: "config",
     label: "Config file",
     ok: configExists,
     detail: configExists ? configPath : "Not found",
     fix: configExists ? null : "Run 'kj init' to create the config file."
-  });
+  };
+}
 
-  // 2. Git repository
+async function checkGitRepo() {
   let gitOk = false;
   try {
     gitOk = await ensureGitRepo();
   } catch {
     gitOk = false;
   }
-  checks.push({
+  return {
     name: "git",
     label: "Git repository",
     ok: gitOk,
     detail: gitOk ? "Inside a git repository" : "Not a git repository",
     fix: gitOk ? null : "Run 'git init' or navigate to a git-managed project."
-  });
+  };
+}
 
-  // 3. Docker
+async function checkDocker() {
   const docker = await checkBinary("docker", "--version");
-  checks.push({
+  return {
     name: "docker",
     label: "Docker",
     ok: docker.ok,
     detail: docker.ok ? docker.version : "Not found",
     fix: docker.ok ? null : "Install Docker: https://docs.docker.com/get-docker/"
-  });
+  };
+}
 
-  // 4. SonarQube reachability
+function sonarDetail(config, sonarOk, sonarHost) {
+  if (config.sonarqube?.enabled === false) return "Disabled in config";
+  if (sonarOk) return `Reachable at ${sonarHost}`;
+  return `Not reachable at ${sonarHost}`;
+}
+
+async function checkSonarQube(config) {
   const sonarHost = config.sonarqube?.host || "http://localhost:9000";
   let sonarOk = false;
   if (config.sonarqube?.enabled !== false) {
@@ -73,21 +80,20 @@ export async function runChecks({ config }) {
       sonarOk = false;
     }
   }
-  checks.push({
+  const isOkOrDisabled = sonarOk || config.sonarqube?.enabled === false;
+  return {
     name: "sonarqube",
     label: "SonarQube",
-    ok: sonarOk || config.sonarqube?.enabled === false,
-    detail: config.sonarqube?.enabled === false
-      ? "Disabled in config"
-      : sonarOk
-        ? `Reachable at ${sonarHost}`
-        : `Not reachable at ${sonarHost}`,
-    fix: sonarOk || config.sonarqube?.enabled === false
+    ok: isOkOrDisabled,
+    detail: sonarDetail(config, sonarOk, sonarHost),
+    fix: isOkOrDisabled
       ? null
       : "Run 'kj sonar start' or 'docker start karajan-sonarqube'. Use --no-sonar to skip."
-  });
+  };
+}
 
-  // 5. Agent CLIs
+async function checkAgentCLIs() {
+  const checks = [];
   for (const agent of KNOWN_AGENTS) {
     const result = await checkBinary(agent.name);
     checks.push({
@@ -98,8 +104,11 @@ export async function runChecks({ config }) {
       fix: result.ok ? null : `Install: ${agent.install}`
     });
   }
+  return checks;
+}
 
-  // 6. Core binaries
+async function checkCoreBinaries() {
+  const checks = [];
   for (const bin of ["node", "npm", "git"]) {
     const result = await checkBinary(bin);
     checks.push({
@@ -110,99 +119,136 @@ export async function runChecks({ config }) {
       fix: result.ok ? null : `Install ${bin} from its official website.`
     });
   }
+  return checks;
+}
 
-  // 7. Serena MCP
-  if (config.serena?.enabled) {
-    let serenaOk = false;
-    try {
-      const serenaCheck = await runCommand("serena", ["--version"]);
-      serenaOk = serenaCheck.exitCode === 0;
-    } catch {
-      serenaOk = false;
-    }
-    checks.push({
-      name: "serena",
-      label: "Serena MCP",
-      ok: serenaOk,
-      detail: serenaOk ? "Available" : "Not found (prompts will still include Serena instructions)",
-      fix: serenaOk ? null : "Install Serena: uvx --from git+https://github.com/oraios/serena serena --help"
-    });
+async function checkSerena() {
+  let serenaOk = false;
+  try {
+    const serenaCheck = await runCommand("serena", ["--version"]);
+    serenaOk = serenaCheck.exitCode === 0;
+  } catch {
+    serenaOk = false;
   }
+  return {
+    name: "serena",
+    label: "Serena MCP",
+    ok: serenaOk,
+    detail: serenaOk ? "Available" : "Not found (prompts will still include Serena instructions)",
+    fix: serenaOk ? null : "Install Serena: uvx --from git+https://github.com/oraios/serena serena --help"
+  };
+}
 
-  // 8. BecarIA Gateway infrastructure
-  if (config.becaria?.enabled) {
-    const projectDir = config.projectDir || process.cwd();
-
-    // Workflow files
-    const workflowDir = path.join(projectDir, ".github", "workflows");
-    const requiredWorkflows = ["becaria-gateway.yml", "automerge.yml", "houston-override.yml"];
-    for (const wf of requiredWorkflows) {
-      const wfPath = path.join(workflowDir, wf);
-      const wfExists = await exists(wfPath);
-      checks.push({
-        name: `becaria:workflow:${wf}`,
-        label: `BecarIA workflow: ${wf}`,
-        ok: wfExists,
-        detail: wfExists ? "Found" : "Not found",
-        fix: wfExists ? null : `Run 'kj init --scaffold-becaria' or copy from karajan-code/templates/workflows/${wf}`
-      });
-    }
-
-    // gh CLI
-    const ghCheck = await checkBinary("gh");
+async function checkBecariaWorkflows(projectDir) {
+  const checks = [];
+  const workflowDir = path.join(projectDir, ".github", "workflows");
+  const requiredWorkflows = ["becaria-gateway.yml", "automerge.yml", "houston-override.yml"];
+  for (const wf of requiredWorkflows) {
+    const wfPath = path.join(workflowDir, wf);
+    const wfExists = await exists(wfPath);
     checks.push({
-      name: "becaria:gh",
-      label: "BecarIA: gh CLI",
-      ok: ghCheck.ok,
-      detail: ghCheck.ok ? ghCheck.version : "Not found",
-      fix: ghCheck.ok ? null : "Install GitHub CLI: https://cli.github.com/"
+      name: `becaria:workflow:${wf}`,
+      label: `BecarIA workflow: ${wf}`,
+      ok: wfExists,
+      detail: wfExists ? "Found" : "Not found",
+      fix: wfExists ? null : `Run 'kj init --scaffold-becaria' or copy from karajan-code/templates/workflows/${wf}`
     });
+  }
+  return checks;
+}
 
-    // Secrets check via gh api (best effort — only works if user has admin access)
-    let secretsOk = false;
-    try {
-      const { detectRepo } = await import("../becaria/repo.js");
-      const repo = await detectRepo();
-      if (repo) {
-        const secretsRes = await runCommand("gh", ["api", `repos/${repo}/actions/secrets`, "--jq", ".secrets[].name"]);
-        if (secretsRes.exitCode === 0) {
-          const names = secretsRes.stdout.split("\n").map((s) => s.trim());
-          const hasAppId = names.includes("BECARIA_APP_ID");
-          const hasKey = names.includes("BECARIA_APP_PRIVATE_KEY");
-          secretsOk = hasAppId && hasKey;
-          checks.push({
-            name: "becaria:secrets",
-            label: "BecarIA: GitHub secrets",
-            ok: secretsOk,
-            detail: secretsOk ? "BECARIA_APP_ID + BECARIA_APP_PRIVATE_KEY found" : `Missing: ${!hasAppId ? "BECARIA_APP_ID " : ""}${!hasKey ? "BECARIA_APP_PRIVATE_KEY" : ""}`.trim(),
-            fix: secretsOk ? null : "Add BECARIA_APP_ID and BECARIA_APP_PRIVATE_KEY as GitHub repository secrets"
-          });
-        }
-      }
-    } catch {
-      // Skip secrets check if we can't access the API
-    }
+async function checkBecariaSecrets() {
+  try {
+    const { detectRepo } = await import("../becaria/repo.js");
+    const repo = await detectRepo();
+    if (!repo) return null;
+    const secretsRes = await runCommand("gh", ["api", `repos/${repo}/actions/secrets`, "--jq", ".secrets[].name"]);
+    if (secretsRes.exitCode !== 0) return null;
+    const names = new Set(secretsRes.stdout.split("\n").map((s) => s.trim()));
+    const hasAppId = names.has("BECARIA_APP_ID");
+    const hasKey = names.has("BECARIA_APP_PRIVATE_KEY");
+    const secretsOk = hasAppId && hasKey;
+    return {
+      name: "becaria:secrets",
+      label: "BecarIA: GitHub secrets",
+      ok: secretsOk,
+      detail: secretsOk
+        ? "BECARIA_APP_ID + BECARIA_APP_PRIVATE_KEY found"
+        : `Missing: ${[!hasAppId && "BECARIA_APP_ID", !hasKey && "BECARIA_APP_PRIVATE_KEY"].filter(Boolean).join(" ")}`,
+      fix: secretsOk ? null : "Add BECARIA_APP_ID and BECARIA_APP_PRIVATE_KEY as GitHub repository secrets"
+    };
+  } catch {
+    // Skip secrets check if we can't access the API
+    return null;
   }
+}
 
-  // 9. Review rules / Coder rules
+async function checkBecariaInfra(config) {
+  const checks = [];
   const projectDir = config.projectDir || process.cwd();
-  const reviewRules = await loadFirstExisting(resolveRoleMdPath("reviewer", projectDir));
-  const coderRules = await loadFirstExisting(resolveRoleMdPath("coder", projectDir));
-  checks.push({
-    name: "review-rules",
-    label: "Reviewer rules (.md)",
-    ok: Boolean(reviewRules),
-    detail: reviewRules ? "Found" : "Not found (will use defaults)",
-    fix: null
-  });
+
+  checks.push(...await checkBecariaWorkflows(projectDir));
+
+  const ghCheck = await checkBinary("gh");
   checks.push({
-    name: "coder-rules",
-    label: "Coder rules (.md)",
-    ok: Boolean(coderRules),
-    detail: coderRules ? "Found" : "Not found (will use defaults)",
-    fix: null
+    name: "becaria:gh",
+    label: "BecarIA: gh CLI",
+    ok: ghCheck.ok,
+    detail: ghCheck.ok ? ghCheck.version : "Not found",
+    fix: ghCheck.ok ? null : "Install GitHub CLI: https://cli.github.com/"
   });
 
+  const secretsCheck = await checkBecariaSecrets();
+  if (secretsCheck) checks.push(secretsCheck);
+
+  return checks;
+}
+
+async function checkRuleFiles(config) {
+  const projectDir = config.projectDir || process.cwd();
+  const reviewRules = await loadFirstExisting(resolveRoleMdPath("reviewer", projectDir));
+  const coderRules = await loadFirstExisting(resolveRoleMdPath("coder", projectDir));
+  return [
+    {
+      name: "review-rules",
+      label: "Reviewer rules (.md)",
+      ok: Boolean(reviewRules),
+      detail: reviewRules ? "Found" : "Not found (will use defaults)",
+      fix: null
+    },
+    {
+      name: "coder-rules",
+      label: "Coder rules (.md)",
+      ok: Boolean(coderRules),
+      detail: coderRules ? "Found" : "Not found (will use defaults)",
+      fix: null
+    }
+  ];
+}
+
+export async function runChecks({ config }) {
+  const checks = [];
+
+  checks.push(
+    checkKarajanVersion(),
+    await checkConfigFile(),
+    await checkGitRepo(),
+    await checkDocker(),
+    await checkSonarQube(config),
+    ...await checkAgentCLIs(),
+    ...await checkCoreBinaries()
+  );
+
+  if (config.serena?.enabled) {
+    checks.push(await checkSerena());
+  }
+
+  if (config.becaria?.enabled) {
+    checks.push(...await checkBecariaInfra(config));
+  }
+
+  checks.push(...await checkRuleFiles(config));
+
   return checks;
 }