kanbot 0.3.0 → 0.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (53) hide show
  1. package/README.md +8 -8
  2. package/package.json +1 -1
  3. package/schema/config.schema.json +38 -8
  4. package/src/agents/load.ts +11 -0
  5. package/src/agents/sync.ts +8 -8
  6. package/src/capabilities.ts +157 -0
  7. package/src/commands/board.ts +14 -7
  8. package/src/commands/doctor.ts +80 -6
  9. package/src/commands/init.ts +15 -3
  10. package/src/commands/sync.ts +1 -1
  11. package/src/commands/upgrade.ts +20 -1
  12. package/src/config.ts +38 -8
  13. package/src/daemon/derive.ts +41 -0
  14. package/src/daemon/loop.ts +2 -0
  15. package/src/jobs/prompts.ts +25 -5
  16. package/src/jobs/run.ts +61 -22
  17. package/src/known-hashes.json +42 -57
  18. package/src/providers/claude.ts +40 -30
  19. package/src/providers/codex.ts +60 -30
  20. package/src/providers/mcp.ts +71 -0
  21. package/src/schemas/results.ts +2 -5
  22. package/templates/.agents/skills/approach-designer/SKILL.md +1 -1
  23. package/templates/.agents/skills/kanbot-admin/SKILL.md +21 -4
  24. package/templates/.agents/skills/kanbot-guide/SKILL.md +26 -7
  25. package/templates/.agents/skills/kanbot-idea/SKILL.md +1 -1
  26. package/templates/.agents/skills/plan-template/SKILL.md +14 -6
  27. package/templates/.agents/skills/pr-description/SKILL.md +7 -3
  28. package/templates/.agents/skills/project-conventions/SKILL.md +23 -35
  29. package/templates/.agents/skills/review-findings/SKILL.md +47 -0
  30. package/templates/.agents/skills/spec-review/SKILL.md +10 -27
  31. package/templates/.agents/skills/user-stories/SKILL.md +1 -1
  32. package/templates/.github/pull_request_template.md +6 -0
  33. package/templates/.kanbot/agents/acceptance-reviewer.md +43 -0
  34. package/templates/.kanbot/agents/fixer.md +7 -5
  35. package/templates/.kanbot/agents/implementer.md +49 -0
  36. package/templates/.kanbot/agents/plan-critic.md +3 -3
  37. package/templates/.kanbot/agents/planner.md +10 -9
  38. package/templates/.kanbot/agents/reviewer.md +42 -0
  39. package/templates/AGENTS.md +2 -3
  40. package/templates/.agents/skills/accessibility/SKILL.md +0 -76
  41. package/templates/.agents/skills/code-review/SKILL.md +0 -83
  42. package/templates/.agents/skills/frontend-design/LICENSE.txt +0 -177
  43. package/templates/.agents/skills/frontend-design/SKILL.md +0 -76
  44. package/templates/.agents/skills/tdd/SKILL.md +0 -51
  45. package/templates/.agents/skills/verify-ui/SKILL.md +0 -104
  46. package/templates/.kanbot/agents/implementer-backend.md +0 -57
  47. package/templates/.kanbot/agents/implementer-docs.md +0 -55
  48. package/templates/.kanbot/agents/implementer-frontend.md +0 -54
  49. package/templates/.kanbot/agents/implementer-technical.md +0 -53
  50. package/templates/.kanbot/agents/reviewer-code.md +0 -46
  51. package/templates/.kanbot/agents/reviewer-spec.md +0 -49
  52. package/templates/.kanbot/agents/test-writer.md +0 -35
  53. package/templates/.kanbot/agents/ui-verifier.md +0 -35
@@ -1,8 +1,10 @@
1
1
  import { mkdtemp, rm } from "node:fs/promises";
2
2
  import { tmpdir } from "node:os";
3
3
  import { join } from "node:path";
4
+ import type { AgentDef } from "../agents/load.ts";
4
5
  import { agentInstructions } from "../agents/sync.ts";
5
6
  import { git } from "../daemon/git.ts";
7
+ import { codexMcpArgs, type McpServer, readMcpServers } from "./mcp.ts";
6
8
  import {
7
9
  looksRateLimited,
8
10
  type Provider,
@@ -11,6 +13,58 @@ import {
11
13
  spawnWorker,
12
14
  } from "./types.ts";
13
15
 
16
+ /** CLI args for a headless run. */
17
+ export function codexArgs(o: {
18
+ agent: AgentDef;
19
+ cwd: string;
20
+ gitDir: string;
21
+ schemaFile: string;
22
+ lastFile: string;
23
+ networkAccess: boolean;
24
+ mcpServers: Record<string, McpServer>;
25
+ }): string[] {
26
+ const { agent } = o;
27
+ const sandbox =
28
+ agent.tools.includes("edit") || agent.tools.includes("bash")
29
+ ? "workspace-write"
30
+ : "read-only";
31
+ const cmd = [
32
+ "codex",
33
+ "exec",
34
+ "--json",
35
+ "--ephemeral",
36
+ // Isolate from the user's own setup: no user-level plugins or MCP
37
+ // servers. Auth still comes from CODEX_HOME.
38
+ "--ignore-user-config",
39
+ "--sandbox",
40
+ sandbox,
41
+ "--cd",
42
+ o.cwd,
43
+ "--add-dir",
44
+ o.gitDir,
45
+ "--output-schema",
46
+ o.schemaFile,
47
+ "--output-last-message",
48
+ o.lastFile,
49
+ "-c",
50
+ `developer_instructions=${JSON.stringify(agentInstructions(agent))}`,
51
+ // The repo's committed MCP servers only.
52
+ ...codexMcpArgs(o.mcpServers),
53
+ ];
54
+ if (o.networkAccess)
55
+ cmd.push("-c", "sandbox_workspace_write.network_access=true");
56
+ if (agent.models.codex && agent.models.codex !== "default")
57
+ cmd.push("--model", agent.models.codex);
58
+ if (agent.effort) {
59
+ cmd.push(
60
+ "-c",
61
+ `model_reasoning_effort="${agent.effort === "max" ? "xhigh" : agent.effort}"`,
62
+ );
63
+ }
64
+ cmd.push("-");
65
+ return cmd;
66
+ }
67
+
14
68
  /** Codex CLI headless (`codex exec`), using the logged-in ChatGPT plan. */
15
69
  export function codex({ networkAccess }: { networkAccess: boolean }): Provider {
16
70
  return {
@@ -29,39 +83,15 @@ export function codex({ networkAccess }: { networkAccess: boolean }): Provider {
29
83
  "--path-format=absolute",
30
84
  "--git-common-dir",
31
85
  );
32
- const sandbox =
33
- agent.tools.includes("edit") || agent.tools.includes("bash")
34
- ? "workspace-write"
35
- : "read-only";
36
- const cmd = [
37
- "codex",
38
- "exec",
39
- "--json",
40
- "--ephemeral",
41
- "--sandbox",
42
- sandbox,
43
- "--cd",
44
- input.cwd,
45
- "--add-dir",
86
+ const cmd = codexArgs({
87
+ agent,
88
+ cwd: input.cwd,
46
89
  gitDir,
47
- "--output-schema",
48
90
  schemaFile,
49
- "--output-last-message",
50
91
  lastFile,
51
- "-c",
52
- `developer_instructions=${JSON.stringify(agentInstructions(agent))}`,
53
- ];
54
- if (networkAccess)
55
- cmd.push("-c", "sandbox_workspace_write.network_access=true");
56
- if (agent.models.codex && agent.models.codex !== "default")
57
- cmd.push("--model", agent.models.codex);
58
- if (agent.effort) {
59
- cmd.push(
60
- "-c",
61
- `model_reasoning_effort="${agent.effort === "max" ? "xhigh" : agent.effort}"`,
62
- );
63
- }
64
- cmd.push("-");
92
+ networkAccess,
93
+ mcpServers: await readMcpServers(input.cwd),
94
+ });
65
95
 
66
96
  const res = await spawnWorker(cmd, {
67
97
  cwd: input.cwd,
@@ -0,0 +1,71 @@
1
+ import { existsSync } from "node:fs";
2
+ import { join } from "node:path";
3
+
4
+ /*
5
+ * Workers get the repo's committed MCP servers, never the user's own.
6
+ * `.mcp.json` (Claude's format) is the one source for both providers.
7
+ */
8
+
9
+ export type McpServer = {
10
+ type?: string;
11
+ command?: string;
12
+ args?: string[];
13
+ env?: Record<string, string>;
14
+ url?: string;
15
+ headers?: Record<string, string>;
16
+ };
17
+
18
+ export function mcpConfigPath(dir: string): string | null {
19
+ const path = join(dir, ".mcp.json");
20
+ return existsSync(path) ? path : null;
21
+ }
22
+
23
+ /** Servers in `<dir>/.mcp.json`. Empty when missing or unreadable. */
24
+ export async function readMcpServers(
25
+ dir: string,
26
+ ): Promise<Record<string, McpServer>> {
27
+ const path = mcpConfigPath(dir);
28
+ if (!path) return {};
29
+ try {
30
+ const json = (await Bun.file(path).json()) as {
31
+ mcpServers?: Record<string, McpServer>;
32
+ };
33
+ return json.mcpServers ?? {};
34
+ } catch {
35
+ return {};
36
+ }
37
+ }
38
+
39
+ /** Codex runs stdio and streamable HTTP servers. Others (e.g. sse) are left out. */
40
+ export function codexSupports(s: McpServer): boolean {
41
+ if (s.type === "sse") return false;
42
+ return Boolean(s.command || s.url);
43
+ }
44
+
45
+ const str = (s: string) => JSON.stringify(s);
46
+ const table = (o: Record<string, string>) =>
47
+ `{${Object.entries(o)
48
+ .map(([k, v]) => `${str(k)}=${str(v)}`)
49
+ .join(",")}}`;
50
+
51
+ /** `-c mcp_servers=…` for codex, as an inline TOML table. Empty when none. */
52
+ export function codexMcpArgs(servers: Record<string, McpServer>): string[] {
53
+ const entries = Object.entries(servers)
54
+ .filter(([, s]) => codexSupports(s))
55
+ .map(([name, s]) => {
56
+ const fields = s.command
57
+ ? [
58
+ `command=${str(s.command)}`,
59
+ s.args?.length ? `args=[${s.args.map(str).join(",")}]` : "",
60
+ s.env && Object.keys(s.env).length ? `env=${table(s.env)}` : "",
61
+ ]
62
+ : [
63
+ `url=${str(s.url as string)}`,
64
+ s.headers && Object.keys(s.headers).length
65
+ ? `http_headers=${table(s.headers)}`
66
+ : "",
67
+ ];
68
+ return `${str(name)}={${fields.filter(Boolean).join(",")}}`;
69
+ });
70
+ return entries.length ? ["-c", `mcp_servers={${entries.join(",")}}`] : [];
71
+ }
@@ -35,7 +35,7 @@ export const PlanResult = z.strictObject({
35
35
  .describe("Issues to create, e.g. when the human asks to split work."),
36
36
  labels: z
37
37
  .array(z.string())
38
- .describe("Labels the issue should have, e.g. type:frontend or technical."),
38
+ .describe("Labels the issue should have, e.g. technical."),
39
39
  questions: z
40
40
  .array(z.string())
41
41
  .describe(
@@ -55,9 +55,6 @@ export const ImplementResult = z.strictObject({
55
55
  testsRun: z
56
56
  .array(z.string())
57
57
  .describe("One line each: command and result, e.g. `bun test`: 5 pass."),
58
- screenshots: z
59
- .array(z.string())
60
- .describe("Repo-relative paths of screenshots committed for review."),
61
58
  risks: z
62
59
  .array(z.string())
63
60
  .describe("Real risks only, one line each. Empty when none."),
@@ -98,7 +95,7 @@ export const FixResult = z.strictObject({
98
95
  .string()
99
96
  .nullable()
100
97
  .describe(
101
- "Full updated PR description when your changes made the current one wrong (behaviour, copy, screenshots); null otherwise.",
98
+ "Full updated PR description when your changes made the current one wrong (behaviour, copy, validation); null otherwise.",
102
99
  ),
103
100
  });
104
101
  export type FixResult = z.infer<typeof FixResult>;
@@ -17,7 +17,7 @@ Pick the axis where the decision matters most for this problem, then spread appr
17
17
  | Interaction model | Search box · faceted filters · timeline browsing |
18
18
  | Where logic lives | Client-side filtering of loaded data · server query endpoint · search index |
19
19
  | Data model | Denormalised read model · query on existing tables · materialised view |
20
- | Build vs. reuse | Custom component · existing design-system table · third-party library |
20
+ | Build vs. reuse | Build it · reuse what the project has · third-party library |
21
21
  | Timing | Synchronous · background job with notification · precomputed nightly |
22
22
  | Scope of change | Minimal tweak to the current screen · new dedicated screen |
23
23
 
@@ -1,12 +1,12 @@
1
1
  ---
2
2
 
3
3
  name: kanbot-admin
4
- description: Change this repo's kanbot setup with a human. Use to add or edit kanbot agents, skills or project memory, change `.kanbot/config.yml`, switch identity mode, turn on merge on approval, run `kanbot upgrade` or merge `.kanbot-new` files. Not for board jobs. For setup walkthroughs and explaining options, use kanbot-guide.
4
+ description: Change this repo's kanbot setup with a human. Use to add or edit kanbot agents, skills or project memory, map capabilities, give workers MCP servers, change `.kanbot/config.yml`, switch identity mode, turn on merge on approval, run `kanbot upgrade` or merge `.kanbot-new` files. Not for board jobs. For setup walkthroughs and explaining options, use kanbot-guide.
5
5
  ---
6
6
 
7
7
  # kanbot admin
8
8
 
9
- You are helping a human maintain kanbot, the board-driven agent team in this repo. Board agents (planner, implementers, reviewers, fixer) never use this skill. To explain options or set kanbot up from scratch, use `kanbot-guide`.
9
+ You are helping a human maintain kanbot, the board-driven agent team in this repo. Board agents (planner, implementer, reviewers, fixer) never use this skill. To explain options or set kanbot up from scratch, use `kanbot-guide`.
10
10
 
11
11
  ## Map
12
12
 
@@ -15,6 +15,7 @@ You are helping a human maintain kanbot, the board-driven agent team in this rep
15
15
  | `.kanbot/agents/<name>.md` | Agent definitions, the source of truth | Yes, then `kanbot sync` |
16
16
  | `.agents/skills/<name>/` | Skills shared by all agents | Yes |
17
17
  | `.kanbot/config.yml` | Daemon config; schema next to it | Yes, then restart the daemon |
18
+ | `.mcp.json` | MCP servers workers get | Yes, then commit |
18
19
  | `.kanbot/manifest.json` | Template hashes from the last upgrade | Never by hand |
19
20
  | `.claude/`, `.codex/` | Generated by `kanbot sync` | Never; edit the source and sync |
20
21
  | `~/.kanbot/apps/<id>.pem` | Private key of the kanbot GitHub App | Never commit |
@@ -39,17 +40,32 @@ Back to user mode: set `identity.mode: user`.
39
40
  2. Recommend app mode, so they can approve their own kanbot PRs.
40
41
  3. Warn: never enable the branch rule "Require approval of the most recent reviewable push". It blocks their own approval.
41
42
 
43
+ ### Map a capability
44
+
45
+ kanbot's agents run the process; the repo's own skills and agents do the work on code. Capabilities tell them which to use.
46
+
47
+ 1. Make sure the skill is in `.agents/skills/<name>/` or the agent in `.kanbot/agents/`. A `.claude/agents` or `.codex/agents` agent works on one provider only.
48
+ 2. Add it under `capabilities` in config: `review: code-review`, or `{ use, when, required }` when it only applies sometimes or a miss should block acceptance review.
49
+ 3. Reserved names: `verify` (prove acceptance criteria), `review` (technical review, pass 1), `preview` (something a human can try). Any other name is the human's.
50
+ 4. `kanbot doctor` lists what's mapped, flags a missing `use`, and names reserved needs not yet mapped.
51
+
52
+ Don't add implementers or `type:*` labels. `implementers` in config is deprecated: replace it with capabilities and remove it.
53
+
54
+ ### Give workers an MCP server
55
+
56
+ Add it to `.mcp.json` (Claude's format) and commit. Workers get only these servers, never the human's own. Codex can't run `sse` servers; `kanbot doctor` lists what workers get.
57
+
42
58
  ### Add or change an agent
43
59
 
44
60
  1. Copy the closest existing agent. `name` must match the filename.
45
61
  2. Column agents (`tier: column`) need an `output` schema; subagents (`tier: sub`) are reached through a column agent's `subagents`.
46
- 3. A new implementer also needs an entry under `implementers` in config and a matching `type:<x>` label on GitHub. Tell the human to create the label.
62
+ 3. To have board agents use it, map it as a capability (above).
47
63
  4. The body says _how_ to work. The daemon's prompt carries the task.
48
64
 
49
65
  ### Add a skill
50
66
 
51
67
  1. Create `.agents/skills/<name>/SKILL.md` with `name` (matches the folder) and a `description` that says what it covers and when it applies.
52
- 2. Add the name to `skills` in each agent that should load it.
68
+ 2. For work on code, map it as a capability. For kanbot's own process, add the name to `skills` in each agent that should load it. `kanbot doctor` fails on skills that don't exist.
53
69
 
54
70
  ### Add a memory
55
71
 
@@ -60,6 +76,7 @@ When the human says "remember that …" or corrects something agents keep gettin
60
76
  1. Run `bunx kanbot@latest upgrade --dry-run` and summarise it for the human.
61
77
  2. Run `bunx kanbot@latest upgrade`.
62
78
  3. Merge every `.kanbot-new` file (below).
79
+ 4. Files kanbot no longer ships stay in place. If the repo had kanbot's old craft skills (`verify-ui`, `code-review`, `tdd`…) and no `capabilities`, upgrade maps them. Show the human the new `capabilities` block. Old `implementer-*` and `reviewer-*` agents are unused once the new ones exist; the human may delete them.
63
80
 
64
81
  ### Merge `.kanbot-new` files
65
82
 
@@ -22,6 +22,7 @@ Explain in plain words. Ask before choosing for them; give a recommendation with
22
22
  | Skills and project memory? | `skills` |
23
23
  | Claude or Codex? | `providers` |
24
24
  | Every config field, labels, notifications | `configuration` |
25
+ | Using our own skills and agents for the work | `capabilities` |
25
26
  | Copilot as an extra reviewer | `copilot-review` |
26
27
  | Bot or user identity, merge by approving | `identity` |
27
28
  | Upgrading and `.kanbot-new` files | `upgrading` |
@@ -29,9 +30,11 @@ Explain in plain words. Ask before choosing for them; give a recommendation with
29
30
 
30
31
  ## Board flow
31
32
 
32
- Ideas (you write) → Planning (agent plans, you comment) → Ready (you approve by moving the card) → In Progress (agent builds, opens a PR) → Review (two agent reviews with fixes; you comment) → Done (you merge, or approve and kanbot merges).
33
+ Ideas (you write) → Planning (agent plans, you comment) → Ready (you approve by moving the card) → In Progress (agent builds, opens a PR) → Review (technical, then acceptance review, with fixes; you comment) → Done (you merge, or approve and kanbot merges).
33
34
 
34
- Agents never get a GitHub token. The daemon does every comment, push and PR. Only collaborators with write access can steer agents.
35
+ kanbot runs the process; the repo's own skills and agents do the work on code, through capabilities. Plans list assumptions about user need; open questions keep a card from starting in Ready.
36
+
37
+ Agents never get a GitHub token. The daemon does every comment, push and PR. Only collaborators with write access can steer agents. Workers see only what's committed, including MCP servers in `.mcp.json`; never the user's own plugins or servers.
35
38
 
36
39
  ## Guided setup
37
40
 
@@ -40,11 +43,25 @@ Go step by step. Run each command, check its output, then go on. If `.kanbot/con
40
43
  1. **Requirements.** Bun 1.3+, `gh` logged in, `claude` or `codex` logged in with a subscription (not an API key). Run `gh auth refresh -s project`.
41
44
  2. **Provider.** Ask which subscription they have, then `bunx kanbot init --provider claude|codex` in the repo root.
42
45
  3. **Conventions.** Fill in `.agents/skills/project-conventions/SKILL.md` with them: stack, commands to test, lint and typecheck. Adjust `.github/workflows/ci.yml` to run the same. Every agent reads this first.
43
- 4. **Board.** `kanbot board create`, or `kanbot board link --owner <login> --number <n>` for an existing project. Have them enable the four built-in project workflows it prints; they can't be set through the API.
44
- 5. **Options.** Go through [Choose options](#choose-options). For app mode, run `kanbot app create` and have them install the app on the repo.
45
- 6. **Commit and push** the kanbot files. Agents only see what's on the pushed base branch.
46
- 7. **Check.** `kanbot doctor` until it passes, then `kanbot run --once --dry-run`, then `kanbot run`.
47
- 8. **First card.** Have them write an issue, put it in Planning and read the plan. Point to `workflow`.
46
+ 4. **Capabilities.** kanbot runs the process; the repo's own skills and agents do the work. Ask which skills they have for proving acceptance criteria (`verify`), technical review (`review`) and something a human can try (`preview`), and map them under `capabilities` in `.kanbot/config.yml`. See [Capabilities](#capabilities).
47
+ 5. **Board.** `kanbot board create`, or `kanbot board link --owner <login> --number <n>` for an existing project. Have them enable the four built-in project workflows it prints; they can't be set through the API.
48
+ 6. **Options.** Go through [Choose options](#choose-options). For app mode, run `kanbot app create` and have them install the app on the repo.
49
+ 7. **Commit and push** the kanbot files. Agents only see what's on the pushed base branch.
50
+ 8. **Check.** `kanbot doctor` until it passes, then `kanbot run --once --dry-run`, then `kanbot run`.
51
+ 9. **First card.** Have them write an issue, put it in Planning and read the plan. Point to `workflow`.
52
+
53
+ ## Capabilities
54
+
55
+ ```yaml
56
+ capabilities:
57
+ verify: { use: e2e-tests, when: Changes users see }
58
+ preview: { use: deploy-preview, required: true }
59
+ review: code-review # bare name: no when, not required
60
+ ```
61
+
62
+ - `use`: a skill in `.agents/skills` or an agent in `.kanbot/agents`. `when`: when it applies. `required: true`: a miss blocks acceptance review.
63
+ - Any other name is theirs (`benchmark`, `security`…). Unmapped needs are left to the agent.
64
+ - Suggest, don't install: no `verify` → a skill that runs the app or end-to-end tests; no `preview` → a preview deploy or test build; no `review` → a review skill with their checklist. `kanbot doctor` names what's not mapped.
48
65
 
49
66
  ## Choose options
50
67
 
@@ -89,3 +106,5 @@ Warn: never enable the branch rule "Require approval of the most recent reviewab
89
106
  3. `.kanbot/logs/*.jsonl`: full agent transcripts.
90
107
  4. `needs-human` label: the issue has a comment saying why. Fix the cause, then remove the label to retry.
91
108
  5. Nothing happens: is the daemon running, are kanbot files pushed to the base branch, is the card in an active column?
109
+ 6. Card stays in Ready: the plan has open questions. kanbot commented on the issue. Answer them in Planning, or remove them from the plan.
110
+ 7. Agent didn't use a skill: is it mapped under `capabilities`, does its `when` fit, and is it committed?
@@ -45,7 +45,7 @@ Match the repo's issue template, so the issue reads like one filed through GitHu
45
45
  <notes, or _None._>
46
46
  ```
47
47
 
48
- Title: the outcome in under 70 characters. Technical issues get the `technical` label. Leave `type:*` labels to the planner.
48
+ Title: the outcome in under 70 characters. Technical issues get the `technical` label.
49
49
 
50
50
  Show the title and body. File it only after the human says yes.
51
51
 
@@ -20,13 +20,18 @@ Need: <one or two sentences: what hurts today and how we'll know it worked.>
20
20
  - [ ] Given <context>, when <action>, then <observable result>.
21
21
  <!-- 2-6 items. Cover the happy path plus the edge cases that matter. -->
22
22
 
23
+ ## Assumptions
24
+
25
+ - <What the plan assumes about the user's need or the business value.> Confirm: <ask, data, or a user test>.
26
+ <!-- 1-4 items. Risky, unconfirmed ones also go in `questions`. -->
27
+
23
28
  ## Out of scope
24
29
 
25
30
  - <Only what a reader would otherwise expect. Omit the section if nothing.>
26
31
 
27
32
  ## Design notes
28
33
 
29
- <UI: placement, key copy, states that differ from the obvious. Non-UI: API or data shape. 1-4 lines. Omit if nothing beyond the criteria.>
34
+ <Decisions the criteria don't settle: what users see or call, key copy, data shape. 1-4 lines. Omit if nothing beyond the criteria.>
30
35
 
31
36
  ## Implementation steps
32
37
 
@@ -39,12 +44,14 @@ Need: <one or two sentences: what hurts today and how we'll know it worked.>
39
44
 
40
45
  ## Open questions
41
46
 
42
- - <Only what blocks the human's approval, with the default you assume. Omit if none.>
47
+ <!-- Don't write this section. kanbot fills it from your `questions` output. Open questions keep the issue out of Ready. -->
43
48
  ```
44
49
 
45
50
  ## Rules
46
51
 
47
52
  - Required: User story (or Technical goal), Acceptance criteria, Implementation steps. Omit other sections when empty; don't write "None."
53
+ - Assumptions are about user need and business value, not code. Technical unknowns go in `explore:N` or a spike.
54
+ - Ask a question (`questions` output) only if building on a wrong guess would waste the work. kanbot won't start while any are open.
48
55
  - One line per bullet. No prose paragraphs, no repeating the issue text.
49
56
  - Acceptance criteria are shared by all approaches. Approach-specific steps go inside each `### Approach k`.
50
57
  - File paths come from reading the code, not guesses. Mark new files "(new)".
@@ -65,6 +72,11 @@ Need: entries without a project silently drop off invoices; users find out when
65
72
  - [ ] Given every entry has a project, when I open the month view, then the list is hidden.
66
73
  - [ ] Given loading fails, when I open the month view, then the list shows "Couldn't load entries" and "Try again".
67
74
 
75
+ ## Assumptions
76
+
77
+ - Users fix missing projects before invoicing, not after. Confirm: ask two users how they invoice.
78
+ - Most months have under 20 such entries. Confirm: query last quarter's data.
79
+
68
80
  ## Out of scope
69
81
 
70
82
  - Bulk-assigning projects (new issue).
@@ -78,8 +90,4 @@ List sits above the calendar, collapsed to 5 rows with "Show all (n)". Reuse `Pr
78
90
  1. Add `missingProject` filter to `GET /entries`, with tests. Files: `api/entries/routes.ts`
79
91
  2. Add `MissingProjectSection` with its states and tests. Files: `web/entries/MissingProjectSection.tsx` (new)
80
92
  3. Mount it in the month view and refresh after assignment. Files: `web/month/MonthView.tsx`
81
-
82
- ## Open questions
83
-
84
- - Include earlier months? Default: current month only.
85
93
  ```
@@ -27,8 +27,12 @@ Conventional commit, imperative, under 72 characters, naming the user-visible ef
27
27
 
28
28
  ## Screenshots
29
29
 
30
- ![<state, width>](.kanbot/screenshots/<branch>/<name>.png)
31
- <!-- UI changes only; 1-3 images that show the change. -->
30
+ ![<state>](repo-relative path to a committed image)
31
+ <!-- Optional. Only when the change is visible; 1-3 images. -->
32
+
33
+ ## Validation
34
+
35
+ - <What you used to prove it works (tests, skills, preview) and what it showed. 1-3 bullets.>
32
36
 
33
37
  ## Notes for reviewer
34
38
 
@@ -40,5 +44,5 @@ Conventional commit, imperative, under 72 characters, naming the user-visible ef
40
44
  - One line per bullet. No "Why" section; the issue has it.
41
45
  - Describe what the code does now, not how you got there.
42
46
  - Anything you could not verify goes in `risks`, not the body.
43
- - Screenshot paths must match the `screenshots` output field.
47
+ - Omit Screenshots when there is nothing to show.
44
48
  - Aim for under 20 lines.
@@ -1,7 +1,7 @@
1
1
  ---
2
2
 
3
3
  name: project-conventions
4
- description: This project's stack, exact commands (install, test, lint, typecheck, build, dev server), code conventions and recorded decisions. Read first before planning, implementing, reviewing or fixing anything in this repository, and whenever you need to know how to run tests or start the app.
4
+ description: This project's stack, exact commands (install, run, test, lint, typecheck, build), code conventions and recorded decisions. Read first before planning, implementing, reviewing or fixing anything in this repository, and whenever you need to know how to run tests or the project.
5
5
  ---
6
6
 
7
7
  # Project conventions
@@ -18,52 +18,40 @@ description: This project's stack, exact commands (install, test, lint, typechec
18
18
 
19
19
  - What it is: `<one sentence: what the product does and for whom>`
20
20
  - Primary users: `<roles>`
21
- - Language/locale of the UI: `<e.g. Norwegian bokmål, English>`
21
+ - Language of what users see: `<e.g. Norwegian bokmål, English>`
22
22
 
23
23
  ## Stack
24
24
 
25
- - Language and runtime: `<e.g. TypeScript 5, Node 22 / Bun 1.x>`
26
- - Frontend: `<framework, router, styling approach, component library / design system location>`
27
- - Backend: `<framework, API style (REST/GraphQL/RPC)>`
28
- - Data: `<database, ORM/query builder, migration tool>`
29
- - Package manager: `<pnpm | npm | bun | yarn>` (use only this one)
25
+ - Language and runtime: `<e.g. TypeScript 5 on Bun, Swift 6, Python 3.13>`
26
+ - Main parts: `<one line each: app, service, library, site…>`
27
+ - Package manager or build tool: `<use only this one>`
30
28
 
31
29
  ## Commands
32
30
 
33
- | Task | Command |
34
- | --------------- | ---------------------------------------- |
35
- | Install | `<pnpm install>` |
36
- | Dev server | `<pnpm dev>` → `<http://localhost:5173>` |
37
- | Test (all) | `<pnpm test>` |
38
- | Test (one file) | `<pnpm vitest run path/to/file.test.ts>` |
39
- | Test (one name) | `<pnpm vitest run -t "name">` |
40
- | E2E | `<pnpm playwright test>` |
41
- | Lint | `<pnpm lint>` |
42
- | Format | `<pnpm format>` |
43
- | Typecheck | `<pnpm typecheck>` |
44
- | Build | `<pnpm build>` |
45
- | DB migrate | `<pnpm db:migrate>` |
46
- | Seed data | `<pnpm db:seed>` |
47
-
48
- Environment: `<how to get a working .env for local dev and tests, e.g. cp .env.example .env; which variables have safe defaults>`
31
+ | Task | Command |
32
+ | ----------- | ------------------------------- |
33
+ | Install | `<install dependencies>` |
34
+ | Run locally | `<start it, and where to look>` |
35
+ | Test (all) | `<run all tests>` |
36
+ | Test (one) | `<run one file or test>` |
37
+ | Lint | `<lint>` |
38
+ | Format | `<format>` |
39
+ | Typecheck | `<typecheck>` |
40
+ | Build | `<build>` |
41
+
42
+ Add rows the project needs (migrations, seed data, end-to-end tests…). Environment: `<how to get a working local setup>`
49
43
 
50
44
  ## Layout
51
45
 
52
46
  ```
53
- <src/ app code>
54
- <src/components/ shared UI components>
55
- <src/server/ API handlers>
56
- <tests/ …>
47
+ <dir/ what lives here>
57
48
  ```
58
49
 
59
50
  ## Code conventions
60
51
 
61
- - Naming: `<files kebab-case, components PascalCase, …>`
62
- - Error handling: `<e.g. return Result types in domain code; throw HttpError in handlers>`
63
- - Validation: `<e.g. zod schemas at API boundaries in src/schemas>`
64
- - State/data fetching: `<e.g. TanStack Query; no fetch in components>`
65
- - Styling: `<e.g. CSS modules + tokens in src/styles/tokens.css; no inline colors>`
66
- - Tests: `<framework, location (co-located *.test.ts), factories in tests/factories>`
52
+ - Naming: `<files, types, functions>`
53
+ - Error handling: `<how errors are raised and shown>`
54
+ - Tests: `<framework, where tests live, helpers>`
67
55
  - Commits: Conventional Commits (`feat`, `fix`, `refactor`, `test`, `docs`, `build`, `ci`, `chore`) with a scope.
68
56
  - Do not: `<things that look tempting but are wrong here>`
69
57
 
@@ -75,5 +63,5 @@ Record decisions that agents should not relitigate. One line each, newest first.
75
63
 
76
64
  ## Gotchas
77
65
 
78
- - `<e.g. tests need Docker running for Postgres>`
79
- - `<e.g. generated files in src/gen/ — never edit, run pnpm codegen>`
66
+ - `<e.g. tests need a local database running>`
67
+ - `<e.g. generated files you must never edit>`
@@ -0,0 +1,47 @@
1
+ ---
2
+
3
+ name: review-findings
4
+ description: Severity rubric, finding format and re-review rounds for kanbot reviews. Use when writing review findings, deciding severity, or judging whether a fixer resolved a finding.
5
+ ---
6
+
7
+ # Review findings
8
+
9
+ kanbot turns findings into a fix loop. Severity decides what gets fixed, so get it right.
10
+
11
+ ## Severity
12
+
13
+ | Severity | Meaning | Triggers a fix |
14
+ | --------- | ---------------------------------------------------------------------------------------------------- | -------------- |
15
+ | `blocker` | Wrong behaviour on a main path, data loss, security hole, failing checks, unmet acceptance criterion | Yes |
16
+ | `major` | Bug users will hit, missing test for a criterion, missed required capability, risky scope creep | Yes |
17
+ | `minor` | Real but low impact: unclear naming, small duplication, rare edge case untested | Yes |
18
+ | `nit` | Preference or polish. At most 3 per review | No |
19
+
20
+ When unsure between two levels, pick the lower one and say the risk.
21
+
22
+ ## Writing a finding
23
+
24
+ Location, what is wrong, why it matters, the fix. One to three sentences.
25
+
26
+ > `src/invoices/service.ts:84` — `total` is summed before discounts, so discounted invoices show the full amount (criterion 3). Apply discounts first and add a test with a 10% code.
27
+
28
+ - One problem per finding. Merge repeats into one finding with all locations.
29
+ - Point at the line in the new version of the file. `path` and `line` null for cross-cutting findings.
30
+ - Show a failure ("a user with no projects gets a 500"), not a principle ("not robust").
31
+ - Only what you checked. If unsure, say what would confirm it.
32
+
33
+ ## Avoid
34
+
35
+ - More than ~10 findings. Keep the most important; summarise the rest in one.
36
+ - Style a formatter or linter covers.
37
+ - Scope beyond the plan. Suggest a follow-up issue as a `nit` at most.
38
+ - Rewriting a working approach to your taste without a concrete defect.
39
+ - Approving with an open `blocker` or `major`.
40
+
41
+ ## Verdict
42
+
43
+ `changes` with any `blocker` or `major`; otherwise `approve`. Minor findings and nits may come with an approval.
44
+
45
+ ## Re-review rounds
46
+
47
+ For each earlier finding: fixed (drop it), not fixed (repeat with the same id and what is still wrong), or the fixer disagreed (accept the reason, or explain once more why it matters). Check that fixes didn't add new problems.