kanbango 3.3.0 → 3.5.0

package/.opencode/plans/action-error-recipe.md

@@ -1,121 +0,0 @@
-# Action error recipe (implement)
-
-Status: approved (user said go). Plan mode blocked code edits — switch to **build** and apply.
-
-## Goal
-Missing/empty/unknown `action` on `kanban_manage` / `kanban_gui`: **message** is a full retry recipe (Valid + Example JSON + sent keys).
-
-## Files
-1. `mcp-server.js` — replace `requireToolAction`; add helpers; unknown-action defaults
-2. `tests/mcp-server.test.js` — assert recipe content
-3. `CHANGELOG.md` — one-line unreleased note
-
-## mcp-server.js
-
-Replace current `requireToolAction` block (after `GUI_ACTIONS`) with:
-
-```js
-const ACTION_EXAMPLES = {
-  kanban_manage: '{"action":"create","title":"Ship image","col":"planned"}',
-  kanban_gui: '{"action":"status"}'
-};
-
-function receivedKeys(args) {
-  return Object.keys(args && typeof args === 'object' ? args : {});
-}
-
-function actionRecipeMessage(toolName, allowed, opts = {}) {
-  const keys = opts.received_keys || [];
-  const example = ACTION_EXAMPLES[toolName] || `{"action":"${allowed[0]}"}`;
-  const lines = [];
-  if (opts.kind === 'unknown') {
-    lines.push(`Unknown action "${opts.action}" on ${toolName}.`);
-  } else {
-    lines.push(`Missing required top-level field "action" on ${toolName}.`);
-  }
-  lines.push('Pass action next to other args (not nested under params).');
-  lines.push(`Valid: ${allowed.join(', ')}.`);
-  lines.push(`Example: ${example}`);
-  lines.push(keys.length > 0 ? `You sent keys: ${keys.join(', ')}` : 'You sent keys: (none)');
-  return lines.join(' ');
-}
-
-function actionRecipeHint() {
-  return [
-    'Retry the same tool with top-level action set to one Valid value.',
-    'Common mistake: omitting action, or putting it under params (jira/gitlab style) — kanban uses top-level action.'
-  ].join(' ');
-}
-
-function requireToolAction(args, allowed, toolName) {
-  const action = args && args.action;
-  const keys = receivedKeys(args);
-  if (action === undefined || action === null || action === '') {
-    throw kanban.createKanbanError(
-      'MISSING_REQUIRED_FIELD',
-      actionRecipeMessage(toolName, allowed, {
-        kind: 'missing',
-        received_keys: keys,
-        action: action === undefined ? null : action
-      }),
-      actionRecipeHint(),
-      {
-        field: 'action',
-        tool: toolName,
-        received_keys: keys,
-        allowed_actions: allowed,
-        action: action === undefined ? null : action
-      },
-      false,
-      400
-    );
-  }
-  return action;
-}
-
-function unknownToolAction(action, args, allowed, toolName) {
-  const keys = receivedKeys(args);
-  return invalidRequest(
-    actionRecipeMessage(toolName, allowed, { kind: 'unknown', action, received_keys: keys }),
-    actionRecipeHint(),
-    {
-      field: 'action',
-      tool: toolName,
-      action,
-      received_keys: keys,
-      allowed_actions: allowed
-    }
-  );
-}
-```
-
-Manage default: `throw unknownToolAction(action, args, MANAGE_ACTIONS, 'kanban_manage');`  
-GUI default: `throw unknownToolAction(action, args, GUI_ACTIONS, 'kanban_gui');`
-
-## tests/mcp-server.test.js
-
-Assert on missing/empty/unknown/gui:
-- message includes `Missing required top-level field "action"` (or `Unknown action "nope"`)
-- `Valid:` + key actions + `Example:` + `"action":`
-- sent keys line
-- `details.allowed_actions`
-- no `undefined` in message
-- codes unchanged: MISSING_REQUIRED_FIELD / VALIDATION_ERROR
-
-## CHANGELOG
-
-```md
-### Fixed
-- MCP `kanban_manage` / `kanban_gui`: missing/empty/unknown `action` errors put a full retry recipe in `message` (Valid list + Example JSON + sent keys); missing/empty use `MISSING_REQUIRED_FIELD` instead of `Unknown action: undefined`
-```
-
-## Verify
-```bash
-node tests/mcp-server.test.js
-echo '{"jsonrpc":"2.0","id":1,"method":"tools/call","params":{"name":"kanban_manage","arguments":{"title":"x"}}}' | node mcp-server.js
-```
-
-## Acceptance
-- [ ] Missing action message is copy-paste retry recipe
-- [ ] Unknown action same clarity
-- [ ] Tests green