jupyterlab_claude_code_extension 1.2.19 → 1.2.21

package/README.md

@@ -29,9 +29,9 @@ Chat-panel extensions re-implement the agent loop and trail the real tool. This
 - **Live indicator** - a green dot marks sessions that are currently running somewhere
 - **One-click resume** - click a row to jump back into that session in a terminal. If a terminal for the project is already open, it's reused instead of duplicated
 - **Favorites** - star projects you keep coming back to via the right-click menu
-- **Remove** - drop a project's Claude history from the panel via the right-click menu; the history folder is moved to the trash (it honours JupyterLab's "move files to trash" setting), not deleted permanently
-- **Clean up parallel sessions** - when a project has accumulated extra sessions beyond the main one, a right-click menu item (showing the count in brackets) removes them all, keeping only the main session; removed files honour the same trash setting
-- **Conversation switcher** - a right-click "Switch and Manage Sessions" submenu lists a project's other conversations by name and short session id, e.g. `home (3f2a1b9c)`, with last-activity time; pick one and it becomes the row's current conversation - the next click resumes exactly that one. The submenu shows the 5 most recent; "Manage Sessions..." opens a searchable popup over the full list where conversations can also be deleted - select one, many, or all via checkboxes, then confirm with a two-step Delete button (removed files honour the trash setting). Rows with multiple conversations show a branch icon with the count after the name
+- **Remove** - drop a project's Claude history from the panel via the right-click menu; a confirmation dialog names the project and warns it removes the whole project and all its conversations before anything is touched, then the history folder is moved to the trash (it honours JupyterLab's "move files to trash" setting), not deleted permanently
+- **Clean up parallel sessions** - when a project has accumulated extra sessions beyond the main one, a right-click menu item (showing the count in brackets) removes them all, keeping only the main session; a confirmation dialog naming the project and the count appears first, and removed files honour the same trash setting
+- **Conversation switcher** - a right-click "Switch and Manage Sessions" submenu lists a project's other conversations by name and short session id, e.g. `home (3f2a1b9c)`, with last-activity time; pick one and it becomes the row's current conversation - the next click resumes exactly that one. The submenu shows the 5 most recent; "Manage Sessions..." opens a searchable popup over the full list where conversations can also be deleted - select one, many, or all via checkboxes, then confirm in a dialog that names the project and the count (removed files honour the trash setting). Rows with multiple conversations show a branch icon with the count after the name
 - **Branch session** - fork the current conversation into a new named session via the right-click menu (normal or skip-permissions mode); uses Claude's native `--fork-session`, opens in a new terminal, the chosen name is stamped automatically, and the fork becomes the row's current conversation
 - **Activity at a glance** - each row shows its last activity (`now`, `5m ago`, `2h ago`, `3d ago`) in an aligned column, with the favourite star in its own column beside it; rows active within the last minute light up in the theme's brand colour (including the `now` label), rows idle for over a week dim slightly
 - **Search** - fuzzy filter toggled by the funnel button next to refresh

package/lib/widget.js

@@ -331,6 +331,16 @@ export class ClaudeCodeSessionsWidget extends Widget {
     }
     async _remove(session) {
         var _a;
+        const name = this._lookupName(session);
+        const confirm = await showDialog({
+            title: 'Remove from Claude',
+            body: `Remove "${name}" from Claude? This deletes the entire Claude ` +
+                'project and every conversation it holds. This cannot be undone.',
+            buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Remove' })]
+        });
+        if (!confirm.button.accept) {
+            return;
+        }
         this._removingPaths.add(session.encoded_path);
         this._render();
         try {
@@ -350,6 +360,18 @@ export class ClaudeCodeSessionsWidget extends Widget {
         }
     }
     async _cleanupParallel(session) {
+        const extra = session.extra_sessions;
+        const name = this._lookupName(session);
+        const confirm = await showDialog({
+            title: 'Clean Up Parallel Sessions',
+            body: `Remove ${extra} parallel session${extra === 1 ? '' : 's'} from ` +
+                `"${name}"? The main conversation is kept; the rest are moved to ` +
+                'trash. This cannot be undone.',
+            buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Remove' })]
+        });
+        if (!confirm.button.accept) {
+            return;
+        }
         const body = new Widget();
         body.node.className = 'jp-ClaudeSessionsPanel-cleanupBody';
         const message = document.createElement('div');
@@ -1221,7 +1243,6 @@ export class ClaudeCodeSessionsWidget extends Widget {
         // Local working copy so deletions can refresh the list in place.
         let items = [...branches];
         const selected = new Set();
-        let confirmArmed = false;
         const body = document.createElement('div');
         body.className = 'jp-ClaudeSessionsPanel-branchPopup';
         const search = document.createElement('input');
@@ -1257,12 +1278,9 @@ export class ClaudeCodeSessionsWidget extends Widget {
                 b.label.toLowerCase().includes(needle) ||
                 b.session_id.toLowerCase().includes(needle));
         };
-        // Any selection change disarms a pending confirm.
         const updateControls = () => {
-            confirmArmed = false;
             deleteBtn.disabled = selected.size === 0;
             deleteBtn.textContent = `Delete (${selected.size})`;
-            deleteBtn.classList.remove('jp-mod-confirm');
             const visible = visibleMatches();
             const visibleSelected = visible.filter(b => selected.has(b.session_id)).length;
             selectAll.checked =
@@ -1362,22 +1380,26 @@ export class ClaudeCodeSessionsWidget extends Widget {
             if (selected.size === 0) {
                 return;
             }
-            if (!confirmArmed) {
-                // Two-step delete: first click arms, second click executes.
-                confirmArmed = true;
-                deleteBtn.textContent = `Confirm delete (${selected.size})`;
-                deleteBtn.classList.add('jp-mod-confirm');
-                return;
-            }
-            void this._deleteBranches([...selected]).then(deleted => {
-                if (deleted === null) {
+            const n = selected.size;
+            void showDialog({
+                title: 'Delete Sessions',
+                body: `Delete ${n} session${n === 1 ? '' : 's'} from "${this._activeSession ? this._lookupName(this._activeSession) : ''}"? ` +
+                    'They are moved to trash. This cannot be undone.',
+                buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Delete' })]
+            }).then(confirm => {
+                if (!confirm.button.accept) {
                     return;
                 }
-                items = items.filter(b => !selected.has(b.session_id));
-                selected.clear();
-                this._lastBranches = items;
-                render();
-                updateControls();
+                void this._deleteBranches([...selected]).then(deleted => {
+                    if (deleted === null) {
+                        return;
+                    }
+                    items = items.filter(b => !selected.has(b.session_id));
+                    selected.clear();
+                    this._lastBranches = items;
+                    render();
+                    updateControls();
+                });
             });
         });
         search.addEventListener('input', () => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab_claude_code_extension",
-    "version": "1.2.19",
+    "version": "1.2.21",
     "description": "Browse, resume, and manage your Claude Code CLI sessions from a JupyterLab side panel. One click reactivates the right terminal - no duplicate tabs, live remote-control indicator, and favourites for the projects you keep coming back to.",
     "keywords": [
         "jupyter",

package/src/__tests__/jupyterlab_claude_code_extension.spec.ts

@@ -96,6 +96,14 @@ describe('launch spinner dismiss contract', () => {
       /private async _cleanupParallel[\s\S]*?\n  \}/
     ) ?? [''])[0];
 
+    it('confirms before removing and aborts when not accepted', () => {
+      expect(cleanup).toMatch(
+        /showDialog\(\{\s*title: 'Clean Up Parallel Sessions'/
+      );
+      expect(cleanup).toMatch(/Dialog\.warnButton\(\{ label: 'Remove' \}\)/);
+      expect(cleanup).toMatch(/if \(!confirm\.button\.accept\) \{\s*return;/);
+    });
+
     it('creates a progress element in the dialog body', () => {
       expect(cleanup).toMatch(/createElement\('progress'\)/);
     });
@@ -232,15 +240,14 @@ describe('launch spinner dismiss contract', () => {
       );
     });
 
-    it('delete is two-step and any selection change disarms it', () => {
+    it('delete opens a confirmation dialog and only deletes on accept', () => {
       const popup = (widgetSrc.match(
         /private _showBranchPopup[\s\S]*?\n  \}/
       ) ?? [''])[0];
-      expect(popup).toMatch(/`Confirm delete \(\$\{selected\.size\}\)`/);
-      // updateControls (run on every selection change) resets the armed
-      // state and the button label.
+      expect(popup).toMatch(/showDialog\(\{\s*title: 'Delete Sessions'/);
+      expect(popup).toMatch(/Dialog\.warnButton\(\{ label: 'Delete' \}\)/);
       expect(popup).toMatch(
-        /const updateControls = \(\) => \{\s*confirmArmed = false/
+        /if \(!confirm\.button\.accept\) \{\s*return;[\s\S]*?_deleteBranches/
       );
     });
 

package/src/widget.ts

@@ -407,6 +407,18 @@ export class ClaudeCodeSessionsWidget extends Widget {
   }
 
   private async _remove(session: ISession): Promise<void> {
+    const name = this._lookupName(session);
+    const confirm = await showDialog({
+      title: 'Remove from Claude',
+      body:
+        `Remove "${name}" from Claude? This deletes the entire Claude ` +
+        'project and every conversation it holds. This cannot be undone.',
+      buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Remove' })]
+    });
+    if (!confirm.button.accept) {
+      return;
+    }
+
     this._removingPaths.add(session.encoded_path);
     this._render();
     try {
@@ -431,6 +443,20 @@ export class ClaudeCodeSessionsWidget extends Widget {
   }
 
   private async _cleanupParallel(session: ISession): Promise<void> {
+    const extra = session.extra_sessions;
+    const name = this._lookupName(session);
+    const confirm = await showDialog({
+      title: 'Clean Up Parallel Sessions',
+      body:
+        `Remove ${extra} parallel session${extra === 1 ? '' : 's'} from ` +
+        `"${name}"? The main conversation is kept; the rest are moved to ` +
+        'trash. This cannot be undone.',
+      buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Remove' })]
+    });
+    if (!confirm.button.accept) {
+      return;
+    }
+
     const body = new Widget();
     body.node.className = 'jp-ClaudeSessionsPanel-cleanupBody';
 
@@ -1420,7 +1446,6 @@ export class ClaudeCodeSessionsWidget extends Widget {
     // Local working copy so deletions can refresh the list in place.
     let items = [...branches];
     const selected = new Set<string>();
-    let confirmArmed = false;
 
     const body = document.createElement('div');
     body.className = 'jp-ClaudeSessionsPanel-branchPopup';
@@ -1467,12 +1492,9 @@ export class ClaudeCodeSessionsWidget extends Widget {
       );
     };
 
-    // Any selection change disarms a pending confirm.
     const updateControls = () => {
-      confirmArmed = false;
       deleteBtn.disabled = selected.size === 0;
       deleteBtn.textContent = `Delete (${selected.size})`;
-      deleteBtn.classList.remove('jp-mod-confirm');
       const visible = visibleMatches();
       const visibleSelected = visible.filter(b =>
         selected.has(b.session_id)
@@ -1580,22 +1602,27 @@ export class ClaudeCodeSessionsWidget extends Widget {
       if (selected.size === 0) {
         return;
       }
-      if (!confirmArmed) {
-        // Two-step delete: first click arms, second click executes.
-        confirmArmed = true;
-        deleteBtn.textContent = `Confirm delete (${selected.size})`;
-        deleteBtn.classList.add('jp-mod-confirm');
-        return;
-      }
-      void this._deleteBranches([...selected]).then(deleted => {
-        if (deleted === null) {
+      const n = selected.size;
+      void showDialog({
+        title: 'Delete Sessions',
+        body:
+          `Delete ${n} session${n === 1 ? '' : 's'} from "${this._activeSession ? this._lookupName(this._activeSession) : ''}"? ` +
+          'They are moved to trash. This cannot be undone.',
+        buttons: [Dialog.cancelButton(), Dialog.warnButton({ label: 'Delete' })]
+      }).then(confirm => {
+        if (!confirm.button.accept) {
           return;
         }
-        items = items.filter(b => !selected.has(b.session_id));
-        selected.clear();
-        this._lastBranches = items;
-        render();
-        updateControls();
+        void this._deleteBranches([...selected]).then(deleted => {
+          if (deleted === null) {
+            return;
+          }
+          items = items.filter(b => !selected.has(b.session_id));
+          selected.clear();
+          this._lastBranches = items;
+          render();
+          updateControls();
+        });
       });
     });