jupyterlab_claude_code_extension 1.1.14 → 1.1.16

package/lib/widget.js

@@ -346,7 +346,7 @@ export class ClaudeCodeSessionsWidget extends Widget {
             // via terminal:open. When claude exits, the tab closes. The launch
             // RPC + the WebSocket-resize waiter on the server can take a few
             // seconds, so show a modal spinner for visual feedback.
-            const spinner = this._showLaunchSpinner(`Opening ${this._lookupName(session)}...`);
+            const spinner = this._showLaunchSpinner();
             try {
                 const launched = await requestAPI('launch-terminal', this._serverSettings, {
                     method: 'POST',
@@ -455,17 +455,13 @@ export class ClaudeCodeSessionsWidget extends Widget {
      * caller must dismiss it via ``.dispose()`` once the work is done - the
      * dialog has no buttons so ``.resolve()`` would be a no-op.
      */
-    _showLaunchSpinner(label) {
+    _showLaunchSpinner() {
         const body = new Widget();
         body.node.className = 'jp-ClaudeSessionsPanel-launchOverlay';
         const spinner = document.createElement('div');
         spinner.className =
             'jp-claude-sessions-panel-spinner jp-ClaudeSessionsPanel-launchSpinner';
         body.node.appendChild(spinner);
-        const text = document.createElement('div');
-        text.className = 'jp-ClaudeSessionsPanel-launchLabel';
-        text.textContent = label;
-        body.node.appendChild(text);
         const dialog = new Dialog({
             title: 'Opening Claude Code session',
             body,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab_claude_code_extension",
-    "version": "1.1.14",
+    "version": "1.1.16",
     "description": "Browse, resume, and manage your Claude Code CLI sessions from a JupyterLab side panel. One click reactivates the right terminal - no duplicate tabs, live remote-control indicator, and favourites for the projects you keep coming back to.",
     "keywords": [
         "jupyter",

package/src/__tests__/jupyterlab_claude_code_extension.spec.ts

@@ -1,3 +1,10 @@
+declare const __dirname: string;
+declare function require(name: string): any;
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const fs: { readFileSync: (p: string, enc: string) => string } = require('fs');
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const path: { join: (...args: string[]) => string } = require('path');
+
 import type { ISession } from '../types';
 
 const session = (over: Partial<ISession> = {}): ISession => ({
@@ -61,3 +68,29 @@ describe('session sorting', () => {
     expect(recent[9].project_path).toBe('p15');
   });
 });
+
+/**
+ * Regression guard for 1.1.13 -> 1.1.14: the launch-spinner Dialog is
+ * constructed with ``buttons: []`` so ``Dialog.resolve()`` has no button
+ * to "click" and silently no-ops, leaving the modal stuck over the
+ * panel. The dismiss call in ``_doResumeInTerminal``'s ``finally`` MUST
+ * be ``spinner.dispose()``. These are source-level invariants - cheap,
+ * deterministic, and exactly the contract that broke in 1.1.13.
+ */
+describe('launch spinner dismiss contract', () => {
+  const widgetSrc: string = fs.readFileSync(
+    path.join(__dirname, '..', 'widget.ts'),
+    'utf-8'
+  );
+
+  it('_doResumeInTerminal dismisses spinner via dispose(), not resolve()', () => {
+    expect(widgetSrc).toMatch(/spinner\.dispose\(\)/);
+    expect(widgetSrc).not.toMatch(/spinner\.resolve\(\)/);
+  });
+
+  it('_showLaunchSpinner constructs Dialog with buttons:[]', () => {
+    // The empty buttons array is the reason resolve() no-ops; if this
+    // ever becomes non-empty, the dismiss call can revisit resolve().
+    expect(widgetSrc).toMatch(/_showLaunchSpinner[\s\S]*?buttons:\s*\[\]/);
+  });
+});

package/src/widget.ts

@@ -431,9 +431,7 @@ export class ClaudeCodeSessionsWidget extends Widget {
       // via terminal:open. When claude exits, the tab closes. The launch
       // RPC + the WebSocket-resize waiter on the server can take a few
       // seconds, so show a modal spinner for visual feedback.
-      const spinner = this._showLaunchSpinner(
-        `Opening ${this._lookupName(session)}...`
-      );
+      const spinner = this._showLaunchSpinner();
       try {
         const launched = await requestAPI<ILaunchTerminalResponse>(
           'launch-terminal',
@@ -548,7 +546,7 @@ export class ClaudeCodeSessionsWidget extends Widget {
    * caller must dismiss it via ``.dispose()`` once the work is done - the
    * dialog has no buttons so ``.resolve()`` would be a no-op.
    */
-  private _showLaunchSpinner(label: string): Dialog<unknown> {
+  private _showLaunchSpinner(): Dialog<unknown> {
     const body = new Widget();
     body.node.className = 'jp-ClaudeSessionsPanel-launchOverlay';
 
@@ -557,11 +555,6 @@ export class ClaudeCodeSessionsWidget extends Widget {
       'jp-claude-sessions-panel-spinner jp-ClaudeSessionsPanel-launchSpinner';
     body.node.appendChild(spinner);
 
-    const text = document.createElement('div');
-    text.className = 'jp-ClaudeSessionsPanel-launchLabel';
-    text.textContent = label;
-    body.node.appendChild(text);
-
     const dialog = new Dialog<unknown>({
       title: 'Opening Claude Code session',
       body,

package/style/base.css

@@ -256,13 +256,6 @@
   border-width: 3px;
 }
 
-.jp-ClaudeSessionsPanel-launchLabel {
-  font-size: var(--jp-ui-font-size1);
-  color: var(--jp-ui-font-color1);
-  text-align: center;
-  word-break: break-word;
-}
-
 .jp-ClaudeSessionsPanel-row.jp-mod-busy {
   opacity: 0.55;
   pointer-events: none;