jupyterlab_claude_code_extension 1.0.26 → 1.0.29

package/lib/icons.js

@@ -42,7 +42,7 @@ export const removeIcon = new LabIcon({
     name: 'jupyterlab_claude_code_extension:remove',
     svgstr: removeSvgStr
 });
-const shieldSvgStr = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="16" height="16">
+const shieldSvgStr = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="13" height="13">
   <path class="jp-icon3" fill="#616161" d="M12 1L3 5v6c0 5.55 3.84 10.74 9 12 5.16-1.26 9-6.45 9-12V5l-9-4zm0 10.99h7c-.53 4.12-3.28 7.79-7 8.94V12H5V6.3l7-3.11v8.8z"/>
 </svg>`;
 export const shieldIcon = new LabIcon({

package/lib/widget.d.ts

@@ -38,6 +38,7 @@ export declare class ClaudeCodeSessionsWidget extends Widget {
     private _resumeInTerminal;
     private _doResumeInTerminal;
     private _findTerminalForCwd;
+    private _showCloseExistingDialog;
     private _wireTerminalDisposal;
     /** Apply the resolve-names setting + path-segment disambiguation. */
     private _displayName;

package/lib/widget.js

@@ -1,3 +1,4 @@
+import { Dialog, showDialog } from '@jupyterlab/apputils';
 import { CommandRegistry } from '@lumino/commands';
 import { Menu, Widget } from '@lumino/widgets';
 import { requestAPI } from './request';
@@ -308,21 +309,32 @@ export class ClaudeCodeSessionsWidget extends Widget {
     }
     async _doResumeInTerminal(session, forceDangerous) {
         try {
-            // 1. In-memory microcache - covers rapid-click and post-creation reuse
-            // before the new widget propagates fully through the tracker. Cleared
-            // on widget disposal. NOT persisted to localStorage.
+            // Always prefer reusing an open terminal for this project. The
+            // skip-permissions flag can only be applied to a fresh pty, never
+            // retroactively. So if the user wants dangerous mode but an open
+            // terminal already exists, show a modal asking them to close it
+            // first - we won't auto-close, won't silently reuse the wrong mode.
+            // 1. In-memory microcache.
             const cached = this._terminalsByPath.get(session.project_path);
             if (cached && !cached.isDisposed) {
+                if (forceDangerous) {
+                    await this._showCloseExistingDialog();
+                    this._app.shell.activateById(cached.id);
+                    return;
+                }
                 this._app.shell.activateById(cached.id);
                 return;
             }
-            // 2. Walk every live terminal widget JL knows about and ask the
-            // server for the cwd of EVERY process in its pty's tree. Match if
-            // any one of them equals project_path.
+            // 2. Walk every live terminal widget JL knows about.
             const found = await this._findTerminalForCwd(session.project_path);
             if (found) {
                 this._terminalsByPath.set(session.project_path, found);
                 this._wireTerminalDisposal(session.project_path, found);
+                if (forceDangerous) {
+                    await this._showCloseExistingDialog();
+                    this._app.shell.activateById(found.id);
+                    return;
+                }
                 this._app.shell.activateById(found.id);
                 return;
             }
@@ -384,6 +396,15 @@ export class ClaudeCodeSessionsWidget extends Widget {
         }
         return null;
     }
+    async _showCloseExistingDialog() {
+        await showDialog({
+            title: 'Existing Claude session is running',
+            body: 'A terminal for this project is already open. To launch with ' +
+                '--dangerously-skip-permissions, close that terminal first then ' +
+                'click "Resume (Skip Permissions)" again.',
+            buttons: [Dialog.okButton({ label: 'OK' })]
+        });
+    }
     _wireTerminalDisposal(projectPath, widget) {
         var _a;
         if (!((_a = widget === null || widget === void 0 ? void 0 : widget.disposed) === null || _a === void 0 ? void 0 : _a.connect)) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab_claude_code_extension",
-    "version": "1.0.26",
+    "version": "1.0.29",
     "description": "Browse, resume, and manage your Claude Code CLI sessions from a JupyterLab side panel. One click reactivates the right terminal - no duplicate tabs, live remote-control indicator, and favourites for the projects you keep coming back to.",
     "keywords": [
         "jupyter",

package/src/icons.ts

@@ -51,7 +51,7 @@ export const removeIcon = new LabIcon({
   svgstr: removeSvgStr
 });
 
-const shieldSvgStr = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="16" height="16">
+const shieldSvgStr = `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" width="13" height="13">
   <path class="jp-icon3" fill="#616161" d="M12 1L3 5v6c0 5.55 3.84 10.74 9 12 5.16-1.26 9-6.45 9-12V5l-9-4zm0 10.99h7c-.53 4.12-3.28 7.79-7 8.94V12H5V6.3l7-3.11v8.8z"/>
 </svg>`;
 

package/src/widget.ts

@@ -1,4 +1,5 @@
 import { JupyterFrontEnd } from '@jupyterlab/application';
+import { Dialog, showDialog } from '@jupyterlab/apputils';
 import { ServerConnection } from '@jupyterlab/services';
 import { ITerminalTracker } from '@jupyterlab/terminal';
 import { CommandRegistry } from '@lumino/commands';
@@ -379,22 +380,34 @@ export class ClaudeCodeSessionsWidget extends Widget {
     forceDangerous: boolean
   ): Promise<void> {
     try {
-      // 1. In-memory microcache - covers rapid-click and post-creation reuse
-      // before the new widget propagates fully through the tracker. Cleared
-      // on widget disposal. NOT persisted to localStorage.
+      // Always prefer reusing an open terminal for this project. The
+      // skip-permissions flag can only be applied to a fresh pty, never
+      // retroactively. So if the user wants dangerous mode but an open
+      // terminal already exists, show a modal asking them to close it
+      // first - we won't auto-close, won't silently reuse the wrong mode.
+
+      // 1. In-memory microcache.
       const cached = this._terminalsByPath.get(session.project_path);
       if (cached && !cached.isDisposed) {
+        if (forceDangerous) {
+          await this._showCloseExistingDialog();
+          this._app.shell.activateById(cached.id);
+          return;
+        }
         this._app.shell.activateById(cached.id);
         return;
       }
 
-      // 2. Walk every live terminal widget JL knows about and ask the
-      // server for the cwd of EVERY process in its pty's tree. Match if
-      // any one of them equals project_path.
+      // 2. Walk every live terminal widget JL knows about.
       const found = await this._findTerminalForCwd(session.project_path);
       if (found) {
         this._terminalsByPath.set(session.project_path, found);
         this._wireTerminalDisposal(session.project_path, found);
+        if (forceDangerous) {
+          await this._showCloseExistingDialog();
+          this._app.shell.activateById(found.id);
+          return;
+        }
         this._app.shell.activateById(found.id);
         return;
       }
@@ -464,6 +477,17 @@ export class ClaudeCodeSessionsWidget extends Widget {
     return null;
   }
 
+  private async _showCloseExistingDialog(): Promise<void> {
+    await showDialog({
+      title: 'Existing Claude session is running',
+      body:
+        'A terminal for this project is already open. To launch with ' +
+        '--dangerously-skip-permissions, close that terminal first then ' +
+        'click "Resume (Skip Permissions)" again.',
+      buttons: [Dialog.okButton({ label: 'OK' })]
+    });
+  }
+
   private _wireTerminalDisposal(projectPath: string, widget: any): void {
     if (!widget?.disposed?.connect) {
       return;