jupyterlab_ai_code_assistants_extension 1.2.50 → 1.2.55

package/README.md

@@ -47,7 +47,7 @@ Chat-panel extensions re-implement the agent loop and trail the real tool. This
 - **Conflict-safe upgrade** - if a retired standalone extension is still installed, its panel wins and this extension stands down for that assistant instead of showing a duplicate
 - **DeepSeek in the browser** - the DeepSeek Harness has no terminal chat; its panel lists the projects under `~/.dsh/sessions` (or `$DSH_HOME`) and `Open Web UI` starts `dsh --profile web --no-open --port 0` in the project's terminal, which prints the URL to open. The conversation is then chosen in the harness's own browser UI; branching and deleting work from the panel as for every other assistant. The URL is on the machine running JupyterLab, so a remote server needs a port forward to reach it
 - **Auto-disabled when absent** - an assistant whose CLI is not on `PATH` does not show a panel
-- **Open Callback** - when an assistant's login sends your browser to an `http://127.0.0.1:...` link that fails to load, because the login is waiting on the machine running JupyterLab, run `Open Callback` from the command palette and paste the link; the Jupyter server requests it for you, and the popup says whether the login accepted it. Only `http` links to that machine's own loopback are accepted
+- **Open Callback** - when an assistant's login sends your browser to an `http://127.0.0.1:...` link that fails to load, because the login is waiting on the machine running JupyterLab, run `Open Callback` from the command palette and paste the link; the Jupyter server requests it for you, and the popup says whether the login accepted it, then closes by itself 3 seconds later. Only `http` links to that machine's own loopback are accepted
 
 ## Requirements
 

package/lib/core/callback.js

@@ -3,6 +3,8 @@ import { Widget } from '@lumino/widgets';
 import { requestAPI } from './request';
 /** The command that delivers a pasted login callback link. */
 export const CALLBACK_COMMAND = 'open:callback';
+/** How long the popup stays open after it has shown what a send came to. */
+const CLOSE_DELAY_MS = 3000;
 async function deliver(url, app, trans) {
     try {
         const answer = await requestAPI('callback', app.serviceManager.serverSettings, { method: 'POST', body: JSON.stringify({ url }) });
@@ -54,8 +56,11 @@ class CallbackForm extends Widget {
         this._status.textContent = message;
     }
 }
-/** OK sends the link and leaves the window open, so the result is read - and
- * a refused link replaced - in the same place. Close and Escape end it. */
+/** OK sends the link and leaves the window open, so the result is read in the
+ * same place. The window then closes by itself after `CLOSE_DELAY_MS`. One
+ * window sends one link: the login code in it works once, and a second send
+ * of the same link fails a login the first send completed. Close and Escape
+ * end the window at once. */
 class CallbackDialog extends Dialog {
     constructor(_form, _send, _trans) {
         super({
@@ -71,7 +76,7 @@ class CallbackDialog extends Dialog {
         this._form = _form;
         this._send = _send;
         this._trans = _trans;
-        this._sending = false;
+        this._sent = false;
     }
     resolve(index) {
         if (index === 0) {
@@ -82,19 +87,20 @@ class CallbackDialog extends Dialog {
     }
     async _deliver() {
         const url = this._form.url;
-        if (this._sending) {
+        if (this._sent) {
             return;
         }
         if (!url) {
             this._form.report('error', this._trans.__('Paste the link first.'));
             return;
         }
-        this._sending = true;
+        this._sent = true;
         this._form.report('pending', this._trans.__('Sending the link...'));
         const outcome = await this._send(url);
-        this._sending = false;
         if (!this.isDisposed) {
             this._form.report(outcome.level, outcome.message);
+            // A no-op when Close has already ended the window.
+            window.setTimeout(() => this.reject(), CLOSE_DELAY_MS);
         }
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab_ai_code_assistants_extension",
-    "version": "1.2.50",
+    "version": "1.2.55",
     "description": "A full launcher and manager for every AI code assistant in JupyterLab - Claude Code, Codex, Kimi, Gemini and DeepSeek. Start, resume, fork, switch, and clean up CLI sessions from a side panel per assistant - one click lands you in the right terminal with the assistant already running, no duplicate tabs, no UUID hunting.",
     "keywords": [
         "jupyter",

package/src/__tests__/callback.spec.ts

@@ -28,9 +28,10 @@ import { requestAPI } from '../core/request';
 const request = requestAPI as jest.Mock;
 const LINK = 'http://127.0.0.1:1455/auth/callback?code=one-time&state=s';
 
-/** One macrotask: `Dialog.launch` attaches the popup after its own awaits. */
-const settle = (): Promise<void> =>
-  new Promise(resolve => setTimeout(resolve, 0));
+/** One macrotask: `Dialog.launch` attaches the popup after its own awaits.
+ * The timers are jest's, so that the popup's 3 s close is stepped, not waited
+ * for. */
+const settle = (): Promise<void> => jest.advanceTimersByTimeAsync(0);
 
 function setup(): {
   commands: CommandRegistry;
@@ -88,6 +89,7 @@ describe('the Open Callback command', () => {
   let error: jest.SpyInstance;
 
   beforeEach(() => {
+    jest.useFakeTimers();
     request.mockReset();
     success = jest.spyOn(Notification, 'success').mockReturnValue('' as any);
     error = jest.spyOn(Notification, 'error').mockReturnValue('' as any);
@@ -100,6 +102,7 @@ describe('the Open Callback command', () => {
     )?.click();
     await settle();
     jest.restoreAllMocks();
+    jest.useRealTimers();
   });
 
   it('is on the command palette under the assistants category', () => {
@@ -122,7 +125,7 @@ describe('the Open Callback command', () => {
     expect(commands.hasCommand(CALLBACK_COMMAND)).toBe(true);
   });
 
-  it('OK sends the trimmed link and writes the result under the field, window still open', async () => {
+  it('OK sends the trimmed link, writes the result under the field and the window closes 3 s later', async () => {
     const { commands, serverSettings } = setup();
     request.mockResolvedValue({ status: 302 });
     const popup = await openPopup(commands);
@@ -140,9 +143,10 @@ describe('the Open Callback command', () => {
     expectPlainWords(popup.status.textContent ?? '');
     // Read in the popup, not in a toast, and the popup is still there.
     expect(success).not.toHaveBeenCalled();
+    await jest.advanceTimersByTimeAsync(2999);
     expect(document.querySelector('.jp-Dialog')).not.toBeNull();
 
-    popup.close.click();
+    await jest.advanceTimersByTimeAsync(1);
     await popup.closed;
     expect(document.querySelector('.jp-Dialog')).toBeNull();
   });
@@ -162,11 +166,9 @@ describe('the Open Callback command', () => {
     expect(popup.status.dataset.level).toBe('success');
   });
 
-  it('a refused link is replaced and sent again in the same window', async () => {
+  it('a refused link also closes the window 3 s after it is reported', async () => {
     const { commands } = setup();
-    request
-      .mockRejectedValueOnce(new Error('callback_unreachable'))
-      .mockResolvedValueOnce({ status: 302 });
+    request.mockRejectedValue(new Error('callback_unreachable'));
     const popup = await openPopup(commands);
 
     popup.input.value = LINK;
@@ -174,10 +176,23 @@ describe('the Open Callback command', () => {
     await settle();
     expect(popup.status.dataset.level).toBe('error');
 
-    popup.input.value = LINK.replace('one-time', 'second');
+    await jest.advanceTimersByTimeAsync(3000);
+    await popup.closed;
+    expect(document.querySelector('.jp-Dialog')).toBeNull();
+  });
+
+  it('a second OK in the same window sends nothing: the login code works once', async () => {
+    const { commands } = setup();
+    request.mockResolvedValue({ status: 200 });
+    const popup = await openPopup(commands);
+
+    popup.input.value = LINK;
+    popup.ok.click();
+    await settle();
     popup.ok.click();
     await settle();
-    expect(request).toHaveBeenCalledTimes(2);
+
+    expect(request).toHaveBeenCalledTimes(1);
     expect(popup.status.dataset.level).toBe('success');
   });
 
@@ -191,6 +206,9 @@ describe('the Open Callback command', () => {
 
     expect(request).not.toHaveBeenCalled();
     expect(popup.status.textContent).toBe('Paste the link first.');
+    // Nothing was sent, so there is no result to close after.
+    await jest.advanceTimersByTimeAsync(3000);
+    expect(document.querySelector('.jp-Dialog')).not.toBeNull();
   });
 
   it('Close sends nothing', async () => {

package/src/core/callback.ts

@@ -8,6 +8,9 @@ import { requestAPI } from './request';
 /** The command that delivers a pasted login callback link. */
 export const CALLBACK_COMMAND = 'open:callback';
 
+/** How long the popup stays open after it has shown what a send came to. */
+const CLOSE_DELAY_MS = 3000;
+
 /** What a delivery came to, in words for the user. Never the link, which
  * carries a login code, and never a status code. */
 interface IOutcome {
@@ -91,8 +94,11 @@ class CallbackForm extends Widget {
   private _status: HTMLDivElement;
 }
 
-/** OK sends the link and leaves the window open, so the result is read - and
- * a refused link replaced - in the same place. Close and Escape end it. */
+/** OK sends the link and leaves the window open, so the result is read in the
+ * same place. The window then closes by itself after `CLOSE_DELAY_MS`. One
+ * window sends one link: the login code in it works once, and a second send
+ * of the same link fails a login the first send completed. Close and Escape
+ * end the window at once. */
 class CallbackDialog extends Dialog<void> {
   constructor(
     private _form: CallbackForm,
@@ -121,23 +127,24 @@ class CallbackDialog extends Dialog<void> {
 
   private async _deliver(): Promise<void> {
     const url = this._form.url;
-    if (this._sending) {
+    if (this._sent) {
       return;
     }
     if (!url) {
       this._form.report('error', this._trans.__('Paste the link first.'));
       return;
     }
-    this._sending = true;
+    this._sent = true;
     this._form.report('pending', this._trans.__('Sending the link...'));
     const outcome = await this._send(url);
-    this._sending = false;
     if (!this.isDisposed) {
       this._form.report(outcome.level, outcome.message);
+      // A no-op when Close has already ended the window.
+      window.setTimeout(() => this.reject(), CLOSE_DELAY_MS);
     }
   }
 
-  private _sending = false;
+  private _sent = false;
 }
 
 /**

package/style/base.css

@@ -15,8 +15,8 @@
 
   /* Single source for the gap between the panel border and its content, on
      both sides: the header, search field, error line, section headers and rows
-     all read it, so the title, the search field, the caret column and the
-     status-dot column keep one left edge. 4px, not 8px: the lists reserve a
+     all read it, so the search field, the caret column and the status-dot
+     column keep one left edge. 4px, not 8px: the lists reserve a
      scrollbar gutter as well, so 8px put the time column 23px from the right
      border where the file browser's sits 12px from it. */
   --aica-inset: 4px;
@@ -43,9 +43,13 @@
 }
 
 /* The panel title and section headers mirror the file browser's headers so the
-   sidebar reads uniformly: 600 weight, uppercase, ui-font-size0, 1px tracking. */
+   sidebar reads uniformly: 600 weight, uppercase, ui-font-size0, 1px tracking.
+   The margin is the caret column's width: the title starts where the section
+   labels and the row names start, not on the inset the carets and the status
+   dots stand on (DEF-PANE-285). */
 .jp-AiAssistantsPanel-title {
   flex: 1 1 auto;
+  margin-left: 14px;
   font-weight: 600;
   letter-spacing: 1px;
   text-transform: uppercase;