jupyterlab_ai_code_assistants_extension 1.2.38 → 1.2.41

package/lib/core/terminals.js

@@ -41,8 +41,8 @@ function warnLegacyCompanion() {
     // And said where the user is looking. The symptom is tabs that are simply
     // plain, which reads as a feature that was never on rather than as something
     // to fix, and a console line only reaches someone already suspecting the
-    // cause. The two neighbouring "an installed thing is wrong" announcements in
-    // this extension both pair the console line with this toast. It does not
+    // cause. The retired-extension notice in index.ts pairs its console line
+    // with a toast the same way. It does not
     // close on its own, because the condition does not go away on its own.
     Notification.warning(message, { autoClose: false });
 }

package/lib/index.js

@@ -242,7 +242,7 @@ const plugin = {
         /** Bring the docked panels in line with settings and CLI availability.
          * Both must hold for a panel to be present. */
         const reconcile = () => {
-            var _a, _b, _c, _d, _e;
+            var _a, _b, _c;
             for (const descriptor of registry.descriptors) {
                 const id = descriptor.id;
                 if (suppressed.has(id)) {
@@ -258,38 +258,26 @@ const plugin = {
                 // the server's word on each binary is final.
                 const roster = status;
                 const available = roster === null ? true : probe !== null && probe.available !== false;
-                // Enabled but binary absent must not be a silent state: the user sees
-                // a missing panel with no clue that PATH under the Jupyter server
-                // differs from their shell. Once per id, not per reconcile.
-                // Only when the probe SUCCEEDED and this provider is the one missing.
-                // Blaming PATH for a server the frontend never reached names the wrong
-                // cause; and every provider defaults to enabled, so a machine with one
-                // assistant installed would otherwise raise three toasts about assistants
-                // the user has never heard of. The console line stays for that case.
-                const chosen = (settings === null || settings === void 0 ? void 0 : settings.get(`providers.${id}.enabled`).user) !== undefined;
+                // Enabled but binary absent is logged to the console, never announced:
+                // enabled means the extension supports the assistant, not that it is
+                // installed, so a toast would name a tool the user never installed
+                // (DEF-PANE-277). Only when the probe SUCCEEDED and this provider is
+                // the one missing - blaming PATH for a server the frontend never
+                // reached names the wrong cause. Once per id, not per reconcile.
                 if (probe !== null &&
                     probe.available === false &&
                     enabled &&
-                    chosen &&
                     !warnedUnavailable.has(id)) {
                     warnedUnavailable.add(id);
                     const binary = (_b = (_a = registry.get(id)) === null || _a === void 0 ? void 0 : _a.descriptor.cliBinary) !== null && _b !== void 0 ? _b : id;
-                    const label = (_d = (_c = registry.get(id)) === null || _c === void 0 ? void 0 : _c.descriptor.label) !== null && _d !== void 0 ? _d : id;
                     console.info(`${LOG_PREFIX} "${id}" is enabled but its \`${binary}\` binary was not found on the server's PATH; panel not shown.`);
-                    // And say it where the user is looking. A console line satisfies the
-                    // comment above only for someone who already suspects the cause; the
-                    // symptom is a panel that never appears, which reads as a broken
-                    // install rather than a PATH difference between the Jupyter server
-                    // and the user's shell. The retired-extension case next door already
-                    // gets a notification, so the COMMON failure was the quiet one.
-                    Notification.warning(`${label} is enabled but \`${binary}\` was not found on the Jupyter server's PATH, so its panel is not shown.`, { autoClose: 8000 });
                 }
                 // The latch is per ABSENCE, not per page load. Once the server reports
-                // the binary present again, a later disappearance gets its own warning:
+                // the binary present again, a later disappearance gets its own line:
                 // without this, one transient absence - a CLI upgrade unlinking the
                 // binary for a moment, or an obsolete roster from an overlapping probe -
                 // permanently suppresses the real one (DEF-125). It cannot make the
-                // warning repeat while the state is unchanged, which is what the
+                // line repeat while the state is unchanged, which is what the
                 // once-per-id latch above exists to prevent: the two conditions are
                 // mutually exclusive.
                 if (probe !== null && probe.available !== false) {
@@ -302,7 +290,7 @@ const plugin = {
                         // A panel docked before the first roster was built without the
                         // server root, and cannot resolve paths until it has one.
                         if (roster !== null) {
-                            panel.setRoot((_e = roster.root_dir) !== null && _e !== void 0 ? _e : '', roster.delete_to_trash !== false);
+                            panel.setRoot((_c = roster.root_dir) !== null && _c !== void 0 ? _c : '', roster.delete_to_trash !== false);
                         }
                     }
                     else {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "jupyterlab_ai_code_assistants_extension",
-    "version": "1.2.38",
+    "version": "1.2.41",
     "description": "A full launcher and manager for every AI code assistant in JupyterLab - Claude Code, Codex, Kimi, Gemini and DeepSeek. Start, resume, fork, switch, and clean up CLI sessions from a side panel per assistant - one click lands you in the right terminal with the assistant already running, no duplicate tabs, no UUID hunting.",
     "keywords": [
         "jupyter",

package/src/__tests__/index.spec.ts

@@ -500,6 +500,40 @@ describe('ACC-PROV - the activation contract', () => {
     live.docked.forEach(widget => widget.dispose());
   });
 
+  it('DEF-PANE-277 - an enabled assistant whose binary is absent gets no panel and no toast', async () => {
+    const toasted = jest
+      .spyOn(Notification, 'warning')
+      .mockImplementation(() => '');
+    const logged = jest
+      .spyOn(console, 'info')
+      .mockImplementation(() => undefined);
+    const absent = PROVIDERS[1].descriptor.id;
+
+    // Saved explicitly, as the settings editor writes it. Enabled means the
+    // extension supports the assistant, not that it is installed.
+    const live = await activate({
+      composite: { [`providers.${absent}.enabled`]: true },
+      answers: [() => Promise.resolve(roster(absent))]
+    });
+
+    expect(
+      live.docked
+        .filter(widget => !widget.isDisposed)
+        .map(widget => widget.descriptor.id)
+    ).not.toContain(absent);
+    expect(toasted).not.toHaveBeenCalled();
+    // The reason stays in the browser console, once.
+    expect(
+      logged.mock.calls
+        .map(args => String(args[0]))
+        .filter(line => line.includes(`"${absent}"`))
+    ).toHaveLength(1);
+
+    toasted.mockRestore();
+    logged.mockRestore();
+    live.docked.forEach(widget => widget.dispose());
+  });
+
   it('ACC-PROV-16 - a binary installed after start gains its panel on the next probe', async () => {
     const late = PROVIDERS[2].descriptor.id;
     let present = false;

package/src/core/terminals.ts

@@ -65,8 +65,8 @@ function warnLegacyCompanion(): void {
   // And said where the user is looking. The symptom is tabs that are simply
   // plain, which reads as a feature that was never on rather than as something
   // to fix, and a console line only reaches someone already suspecting the
-  // cause. The two neighbouring "an installed thing is wrong" announcements in
-  // this extension both pair the console line with this toast. It does not
+  // cause. The retired-extension notice in index.ts pairs its console line
+  // with a toast the same way. It does not
   // close on its own, because the condition does not go away on its own.
   Notification.warning(message, { autoClose: false });
 }

package/src/index.ts

@@ -333,46 +333,30 @@ const plugin: JupyterFrontEndPlugin<void> = {
         const roster = status;
         const available =
           roster === null ? true : probe !== null && probe.available !== false;
-        // Enabled but binary absent must not be a silent state: the user sees
-        // a missing panel with no clue that PATH under the Jupyter server
-        // differs from their shell. Once per id, not per reconcile.
-        // Only when the probe SUCCEEDED and this provider is the one missing.
-        // Blaming PATH for a server the frontend never reached names the wrong
-        // cause; and every provider defaults to enabled, so a machine with one
-        // assistant installed would otherwise raise three toasts about assistants
-        // the user has never heard of. The console line stays for that case.
-        const chosen =
-          settings?.get(`providers.${id}.enabled`).user !== undefined;
+        // Enabled but binary absent is logged to the console, never announced:
+        // enabled means the extension supports the assistant, not that it is
+        // installed, so a toast would name a tool the user never installed
+        // (DEF-PANE-277). Only when the probe SUCCEEDED and this provider is
+        // the one missing - blaming PATH for a server the frontend never
+        // reached names the wrong cause. Once per id, not per reconcile.
         if (
           probe !== null &&
           probe.available === false &&
           enabled &&
-          chosen &&
           !warnedUnavailable.has(id)
         ) {
           warnedUnavailable.add(id);
           const binary = registry.get(id)?.descriptor.cliBinary ?? id;
-          const label = registry.get(id)?.descriptor.label ?? id;
           console.info(
             `${LOG_PREFIX} "${id}" is enabled but its \`${binary}\` binary was not found on the server's PATH; panel not shown.`
           );
-          // And say it where the user is looking. A console line satisfies the
-          // comment above only for someone who already suspects the cause; the
-          // symptom is a panel that never appears, which reads as a broken
-          // install rather than a PATH difference between the Jupyter server
-          // and the user's shell. The retired-extension case next door already
-          // gets a notification, so the COMMON failure was the quiet one.
-          Notification.warning(
-            `${label} is enabled but \`${binary}\` was not found on the Jupyter server's PATH, so its panel is not shown.`,
-            { autoClose: 8000 }
-          );
         }
         // The latch is per ABSENCE, not per page load. Once the server reports
-        // the binary present again, a later disappearance gets its own warning:
+        // the binary present again, a later disappearance gets its own line:
         // without this, one transient absence - a CLI upgrade unlinking the
         // binary for a moment, or an obsolete roster from an overlapping probe -
         // permanently suppresses the real one (DEF-125). It cannot make the
-        // warning repeat while the state is unchanged, which is what the
+        // line repeat while the state is unchanged, which is what the
         // once-per-id latch above exists to prevent: the two conditions are
         // mutually exclusive.
         if (probe !== null && probe.available !== false) {