jupiter-dynamic-forms 1.20.0 → 1.20.1

package/dist/index.mjs

@@ -683,6 +683,7 @@ class XBRLFormBuilder {
     var _a, _b;
     const label = this.getPreferredLabel(concept.labels, language, concept.preferredLabel);
     const childPeriodHint = ((_a = concept.preferredLabel) == null ? void 0 : _a.includes("periodStartLabel")) ? "start" : ((_b = concept.preferredLabel) == null ? void 0 : _b.includes("periodEndLabel")) ? "end" : ancestorPeriodHint;
+    const effectivePeriodRole = childPeriodHint === "start" ? "periodStartLabel" : childPeriodHint === "end" ? "periodEndLabel" : void 0;
     const fields = [];
     if (!concept.elementAbstract) {
       let columnIds = [];
@@ -751,8 +752,10 @@ class XBRLFormBuilder {
       periodType: concept.periodType,
       balance: concept.balance,
       // Pass through balance attribute from XBRL data
-      preferredLabel: concept.preferredLabel
+      preferredLabel: concept.preferredLabel,
       // Pass through for period date calculation in manual columns
+      effectivePeriodRole
+      // JDF-039: own-or-inherited periodStartLabel/periodEndLabel role
     };
   }
   /**
@@ -10781,6 +10784,38 @@ let JupiterDynamicForm = class extends LitElement {
     }
     return `${startDate} / ${endDate}`;
   }
+  /**
+   * JDF-040: Resolves the instant date for a submission entry (Save Draft/Submit).
+   * periodStartLabel-effective concepts (own-labelled or inherited, JDF-039) always
+   * resolve via _resolveInstantDate — the same call the self-heal itself makes — instead
+   * of trusting whatever happens to be cached in _periodData/field.periodInstantDate.
+   * This matters because self-heal only ever corrects an EXISTING _periodData override
+   * (it never fabricates one), so a cell that was never manually period-edited would
+   * otherwise fall through to column.periodEndDate here and silently re-emit the wrong
+   * date on every Save Draft/Submit even though field.periodInstantDate was healed.
+   * Everything else keeps the previous fallback chain, but with field.periodInstantDate
+   * now outranking column.periodEndDate, matching the already-correct sibling
+   * implementations in _findFactValueForField and _addConceptDataToSubmission.
+   */
+  _resolveSubmissionInstantDate(concept, field2, fieldPeriodData, column2) {
+    const effectiveRole = this._getEffectivePeriodRole(concept);
+    if (effectiveRole == null ? void 0 : effectiveRole.includes("periodStartLabel")) {
+      const periodStartDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.startDate) || (column2 == null ? void 0 : column2.periodStartDate) || field2.periodStartDate || this.periodStartDate;
+      const periodEndDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodEndDate || this.periodEndDate;
+      return this._resolveInstantDate(effectiveRole, void 0, periodStartDate, periodEndDate);
+    }
+    return (fieldPeriodData == null ? void 0 : fieldPeriodData.instantDate) || (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || field2.periodInstantDate || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodEndDate || field2.periodStartDate || this.periodStartDate;
+  }
+  /**
+   * JDF-039: The label value to use for periodStartLabel/periodEndLabel checks — the
+   * concept's own preferredLabel if it carries one of those roles, otherwise the role
+   * inherited from the nearest ancestor that does (stamped by XBRLFormBuilder as
+   * effectivePeriodRole). Falls back to preferredLabel for any concept built before this
+   * fix (or otherwise missing the field).
+   */
+  _getEffectivePeriodRole(concept) {
+    return concept.effectivePeriodRole ?? concept.preferredLabel;
+  }
   _resolveInstantDate(preferredLabel, instantDate, startDate, endDate) {
     if (preferredLabel == null ? void 0 : preferredLabel.includes("periodStartLabel")) {
       const base = startDate || "2025-01-01";
@@ -10810,7 +10845,7 @@ let JupiterDynamicForm = class extends LitElement {
   _correctPeriodStartInstantDatesInConcepts(concepts, section2) {
     concepts.forEach((concept) => {
       var _a, _b;
-      if (((_a = concept.preferredLabel) == null ? void 0 : _a.includes("periodStartLabel")) && concept.periodType === "instant" && ((_b = concept.fields) == null ? void 0 : _b.length)) {
+      if (((_a = this._getEffectivePeriodRole(concept)) == null ? void 0 : _a.includes("periodStartLabel")) && concept.periodType === "instant" && ((_b = concept.fields) == null ? void 0 : _b.length)) {
         concept.fields.forEach((field2) => {
           this._correctFieldPeriodStartInstantDate(concept, field2, concept.id, section2);
           const repeatCount = this._repeatCounts[concept.id] || 0;
@@ -10830,7 +10865,7 @@ let JupiterDynamicForm = class extends LitElement {
     const fieldPeriodData = (_a = this._periodData[periodDataKey]) == null ? void 0 : _a[field2.columnId];
     const periodStartDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.startDate) || (column2 == null ? void 0 : column2.periodStartDate) || field2.periodStartDate || this.periodStartDate;
     const periodEndDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodEndDate || this.periodEndDate;
-    const correctedInstantDate = this._resolveInstantDate(concept.preferredLabel, void 0, periodStartDate, periodEndDate);
+    const correctedInstantDate = this._resolveInstantDate(this._getEffectivePeriodRole(concept), void 0, periodStartDate, periodEndDate);
     if (fieldPeriodData && fieldPeriodData.instantDate !== correctedInstantDate) {
       console.log(`🩹 [Legacy Period Correction] ${periodDataKey}/${field2.columnId}: instantDate ${fieldPeriodData.instantDate} → ${correctedInstantDate}`);
       fieldPeriodData.instantDate = correctedInstantDate;
@@ -11040,7 +11075,7 @@ let JupiterDynamicForm = class extends LitElement {
         let field2;
         const colStartDate = request.periodType === "instant" ? request.instantDate : request.startDate;
         const colEndDate = request.periodType === "instant" ? request.instantDate : request.endDate;
-        const instantDate = this._resolveInstantDate(concept.preferredLabel, request.instantDate, colStartDate, colEndDate);
+        const instantDate = this._resolveInstantDate(this._getEffectivePeriodRole(concept), request.instantDate, colStartDate, colEndDate);
         if (existingField) {
           field2 = {
             id: `${concept.id}_${columnId}`,
@@ -11756,7 +11791,7 @@ let JupiterDynamicForm = class extends LitElement {
               // CRITICAL: Include conceptType for XBRL validation
               periodStartDate: column2.periodStartDate,
               periodEndDate: column2.periodEndDate,
-              periodInstantDate: conceptPeriodType === "instant" ? column2.periodEndDate || column2.periodStartDate : void 0
+              periodInstantDate: conceptPeriodType === "instant" ? this._resolveInstantDate(this._getEffectivePeriodRole(concept), void 0, column2.periodStartDate, column2.periodEndDate) : void 0
             };
             if ((_a = this._periodData[concept.id]) == null ? void 0 : _a[column2.id]) {
               const customPeriod = this._periodData[concept.id][column2.id];
@@ -12088,7 +12123,7 @@ let JupiterDynamicForm = class extends LitElement {
               }
             };
             if (concept.periodType === "instant") {
-              const instantDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.instantDate) || (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodInstantDate || field2.periodEndDate || field2.periodStartDate || this.periodStartDate;
+              const instantDate = this._resolveSubmissionInstantDate(concept, field2, fieldPeriodData, column2);
               submissionEntry.period.date = instantDate;
             } else {
               const startDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.startDate) || (column2 == null ? void 0 : column2.periodStartDate) || field2.periodStartDate || this.periodStartDate;
@@ -12204,7 +12239,7 @@ let JupiterDynamicForm = class extends LitElement {
                 }
               };
               if (concept.periodType === "instant") {
-                instanceEntry.period.date = (fieldPeriodData == null ? void 0 : fieldPeriodData.instantDate) || (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodInstantDate || field2.periodEndDate || field2.periodStartDate || this.periodStartDate;
+                instanceEntry.period.date = this._resolveSubmissionInstantDate(concept, field2, fieldPeriodData, column2);
               } else {
                 instanceEntry.period.startDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.startDate) || (column2 == null ? void 0 : column2.periodStartDate) || field2.periodStartDate || this.periodStartDate;
                 instanceEntry.period.endDate = (fieldPeriodData == null ? void 0 : fieldPeriodData.endDate) || (column2 == null ? void 0 : column2.periodEndDate) || field2.periodEndDate || this.periodEndDate;