jules-orchestrator-kit 0.54.1 → 0.55.0

package/README.md

@@ -198,11 +198,12 @@ To maximize PR merge rates, dispatch tasks according to deterministic boundaries
 * **Cross-Platform Parity:** Verified 100% green across Linux, macOS (Darwin), and Windows on Node 20, 22, and 24.
 * **Autonomous Self-Healing Loop:** Captures test stderr/stdout, fingerprints error traces, and feeds structured context back into automated repair turns (up to 3 attempts) before human escalation.
 * **Fail-Closed Verification:** A change that ran no verification command at all is rejected, not approved — "nothing to run" is not a pass. Repositories using only the scope and secret phases opt out explicitly with `verify.required: false`.
+* **Anti-Tamper That Reads Semantics:** Counting assertions cannot see a value check swapped for a truthiness check. The guard tracks assertions that name an expected value, so weakening a test is a violation even when the line count is unchanged.
 * **Binary-Aware Scanning:** Files git renders as `Binary files ... differ` are read directly for structured credentials, and their real size is charged against the diff ceiling, so a leading NUL byte cannot hide a token and a committed blob cannot walk past the payload governor.
 * **Fail-Closed Security & Secret Redaction:** Evaluates explicit Deny rules before Allow rules against canonicalized, case-folded paths. Redacts high-entropy keys and base64-encoded credentials (such as Kubernetes `Secret` manifests).
 * **Complexity & Cost Router:** Zero-dependency heuristic classifier (`src/router.mjs`) routing mechanical tasks to lightweight models while reserving primary models for complex refactors, with a `node --check` syntax-verification gate that transparently escalates a FAST-tier result to the primary provider if it left broken JS on disk.
 * **Terminal UI & Diagnostic Matrix (`agentctl doctor`):** Interactive terminal dashboard, task sidecar manager, and automated transactional self-repair.
-* **Verified Test Suite:** Tested with **835 unit tests across 109 suites passing in < 14.0s**.
+* **Verified Test Suite:** Tested with **842 unit tests across 112 suites passing in < 14.0s**.
 
 <br/>
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jules-orchestrator-kit",
-  "version": "0.54.1",
+  "version": "0.55.0",
   "description": "Zero-dependency safety gatekeeper, test oracle generator, and multi-agent coordination protocol for autonomous coding agents — Google Jules, Claude Code, Codex and Gemini CLI.",
   "repository": {
     "type": "git",

package/src/engine.mjs

@@ -1,6 +1,6 @@
 import { loadConfig, parseYaml, normalizeScope } from "./config.mjs";
 import { checkScope, scanDiff, scanBinaryPayloads, redactSecrets } from "./security.mjs";
-import { changedFiles, diffBytes, diffText, binaryDiffEntries, showFromOrigin, runCmd } from "./git.mjs";
+import { changedFiles, diffBytes, diffText, binaryDiffEntries, symlinkChanges, showFromOrigin, runCmd } from "./git.mjs";
 import { createProvider, ProviderRateLimitError, ProviderUnavailableError } from "./provider.mjs";
 import { resolveRoutedProvider } from "./router.mjs";
 import { withBudget, appendLedger, getQueueDir, ensureDir, rollbackBudgetReservation, isConcurrencyGroupLocked, checkDailyBudget } from "./state.mjs";
@@ -213,9 +213,37 @@ export async function gate(opts = {}) {
     }
   }
 
-  const scopeResult = checkScope(files, trustedScope, {
+  // A symlink is judged by its own name, so `notes.md -> .agent/config.yml`
+  // walked straight past a deny list that names the target. Judge both: the
+  // link because it is what the diff adds, and the path it resolves to because
+  // that is what it grants reach to.
+  let symlinks = [];
+  try {
+    symlinks = symlinkChanges(root, base, mode);
+  } catch (_) {
+    // Scope must still be enforced on the ordinary file list if git cannot
+    // describe the links.
+  }
+  const scopeCandidates = [...files];
+  const symlinkTargetOf = new Map();
+  for (const { link, target } of symlinks) {
+    if (!target || scopeCandidates.includes(target)) continue;
+    scopeCandidates.push(target);
+    symlinkTargetOf.set(target, link);
+  }
+
+  const scopeResult = checkScope(scopeCandidates, trustedScope, {
     allowProtected: opts.allowProtected || process.env.JULES_ALLOW_COMMAND_FILE_CHANGES === "true",
   });
+  // Report the violation against the link the change actually introduced, not
+  // against a path the diff never names — the operator has to be able to find it.
+  for (const violation of scopeResult.violations || []) {
+    const link = symlinkTargetOf.get(violation.file);
+    if (!link) continue;
+    violation.reason = `${violation.reason} (reached through symlink ${link})`;
+    violation.symlink = link;
+    violation.file = link;
+  }
 
   phases.push({ phase: "scope", ok: scopeResult.ok, violations: scopeResult.violations });
   appendTelemetry(root, "gate_phase", { phase: "scope", ok: scopeResult.ok });

package/src/evidence.mjs

@@ -11,7 +11,7 @@ import {
   renameSync,
   unlinkSync,
 } from "node:fs";
-import { join, resolve, relative, isAbsolute, sep } from "node:path";
+import { join, resolve, relative, isAbsolute, sep, extname } from "node:path";
 import { createHash, randomUUID } from "node:crypto";
 import { execSync } from "node:child_process";
 
@@ -83,6 +83,19 @@ export function findFilesRecursively(dir, baseDir = dir) {
  * @param {string[]} [options.directories] - Specific directory names to scan (e.g. ['test', 'tests'])
  * @returns {{ treeHash: string, fileCount: number, fileHashes: Record<string, string> }}
  */
+/**
+ * Extensions that count as code when scanning the repository root.
+ *
+ * The directory walk above takes everything under `src/` and the test
+ * directories; this list only governs the loose files beside package.json,
+ * where a `.md` is documentation rather than something the evidence attests to.
+ */
+const SOURCE_EXTENSIONS = new Set([
+  ".js", ".mjs", ".cjs", ".jsx", ".ts", ".tsx", ".mts", ".cts",
+  ".py", ".go", ".rs", ".rb", ".php", ".java", ".kt", ".kts", ".cs", ".fs",
+  ".swift", ".dart", ".ex", ".exs", ".c", ".h", ".cc", ".cpp", ".hpp", ".sol",
+]);
+
 export function computeDirectoryHash(root, options = {}) {
   let fileList = [];
 
@@ -100,6 +113,29 @@ export function computeDirectoryHash(root, options = {}) {
         fileList.push(...found);
       }
     }
+
+    // Plenty of projects keep `app.test.mjs` or `index.js` beside package.json
+    // rather than under one of the directories above, and those files were
+    // invisible to every hash computed here — a manifest could attest to a
+    // pristine test suite while the only test in the repository had been
+    // replaced with garbage.
+    //
+    // Depth one only: recursing from the root would walk node_modules and
+    // vendor trees. Source extensions only: the hash exists to bind the
+    // manifest to the code it verified, and pulling in README.md or the
+    // EVIDENCE.md this very command is about to write would make the hash churn
+    // on its own output.
+    try {
+      for (const entry of readdirSync(root, { withFileTypes: true })) {
+        if (!entry.isFile()) continue;
+        if (entry.name.startsWith(".")) continue;
+        if (!SOURCE_EXTENSIONS.has(extname(entry.name).toLowerCase())) continue;
+        fileList.push(normalizePath(entry.name));
+      }
+    } catch (_) {
+      // An unreadable root yields whatever the directory walk already found.
+    }
+
     fileList = Array.from(new Set(fileList)).sort();
   }
 
@@ -154,6 +190,7 @@ export function computeEvidenceHash(manifest) {
     intent: manifest.intent,
     provenance: manifest.provenance,
     testIntegrity: manifest.testIntegrity,
+    ...(manifest.sourceIntegrity ? { sourceIntegrity: manifest.sourceIntegrity } : {}),
     executionRecords: manifest.executionRecords,
     securityChecks: manifest.securityChecks,
     ...(manifest.status ? { status: manifest.status } : {}),
@@ -235,6 +272,7 @@ export function generateEvidenceManifest(root = process.cwd(), options = {}) {
   // Compute test tree integrity
   const preTestHash = options.preTestHash || null;
   const currentTestState = computeDirectoryHash(root, { testOnly: true });
+  const currentSourceState = computeDirectoryHash(root);
   const postTestHash = currentTestState.treeHash;
 
   let tamperDetected = false;
@@ -278,6 +316,14 @@ export function generateEvidenceManifest(root = process.cwd(), options = {}) {
       testFileCount: currentTestState.fileCount,
       fileHashes: currentTestState.fileHashes,
     },
+    // The manifest attested to the test files and to nothing else, so the code
+    // under test could be replaced wholesale after the fact and verification
+    // still passed. Evidence that survives the thing it attests to being
+    // rewritten is not evidence.
+    sourceIntegrity: {
+      treeHash: currentSourceState.treeHash,
+      fileCount: currentSourceState.fileCount,
+    },
     executionRecords: options.executionRecords || [],
     securityChecks: {
       secretScanOk: options.secretScanOk ?? true,
@@ -466,7 +512,28 @@ export function verifyEvidenceManifest(root = process.cwd(), manifestOrPath = "m
     };
   }
 
-  // 3. Verify security checks
+  // 3. Verify the code the manifest attests to still is that code.
+  //
+  // Without this the manifest proved only that the *tests* had not changed,
+  // so `evidence generate` followed by rewriting src/ and committing left
+  // verification reporting PASSED over an implementation nobody had checked.
+  if (manifest.sourceIntegrity?.treeHash) {
+    const currentSourceState = computeDirectoryHash(root);
+    if (currentSourceState.treeHash !== manifest.sourceIntegrity.treeHash) {
+      return {
+        ok: false,
+        reason: `Source tree has changed since this evidence was generated (${manifest.sourceIntegrity.treeHash.slice(0, 12)} → ${currentSourceState.treeHash.slice(0, 12)}); the manifest no longer attests to what is on disk`,
+        details: {
+          currentHash: currentSourceState.treeHash,
+          manifestHash: manifest.sourceIntegrity.treeHash,
+          manifestCommit: manifest.provenance?.commitSha || null,
+          currentCommit: getGitProvenance(root).commitSha,
+        },
+      };
+    }
+  }
+
+  // 4. Verify security checks
   if (manifest.securityChecks?.secretScanOk === false) {
     return { ok: false, reason: "Evidence manifest records secret scanning failure" };
   }

package/src/git.mjs

@@ -1,7 +1,7 @@
 import { execFileSync, execSync } from "node:child_process";
-import { readFileSync, existsSync, statSync } from "node:fs";
+import { readFileSync, existsSync, statSync, readlinkSync } from "node:fs";
 import { join, delimiter } from "node:path";
-import { normalizePath } from "./config.mjs";
+import { normalizePath, canonicalizePath } from "./config.mjs";
 
 
 export const NET_GUARD_PRELOAD_URL = new URL("./preload-net-guard.mjs", import.meta.url).href;
@@ -412,14 +412,14 @@ export function diffText(root = process.cwd(), base = "main", mode = "committed"
  * @param {string} mode
  * @returns {Array<{ file: string, bytes: number }>}
  */
-export function binaryDiffEntries(root = process.cwd(), base = "main", mode = "committed") {
+export function parseRawDiff(root = process.cwd(), base = "main", mode = "committed") {
   const resolvedRef = resolveBase(root, base);
   const ranges =
     mode === "working-tree" || mode === "working"
       ? [[`${resolvedRef}...HEAD`], ["HEAD"]]
       : [[`${resolvedRef}...HEAD`]];
 
-  const entries = new Map();
+  const out = [];
   for (const range of ranges) {
     let raw = "";
     try {
@@ -433,29 +433,99 @@ export function binaryDiffEntries(root = process.cwd(), base = "main", mode = "c
       const meta = fields[i];
       if (!meta.startsWith(":")) continue;
       const parts = meta.slice(1).split(/\s+/);
-      const dstSha = parts[3];
-      const status = (parts[4] || "").charAt(0);
       const file = fields[i + 1];
       i += 1;
-      if (!file || status === "D") continue;
+      if (!file) continue;
+      out.push({
+        file,
+        srcMode: parts[0] || "",
+        dstMode: parts[1] || "",
+        srcSha: parts[2] || "",
+        dstSha: parts[3] || "",
+        status: (parts[4] || "").charAt(0),
+      });
+    }
+  }
+  return out;
+}
 
-      let bytes = 0;
-      if (dstSha && !/^0+$/.test(dstSha)) {
-        const size = git(["cat-file", "-s", dstSha], { cwd: root, ignoreError: true });
-        bytes = Number(size) || 0;
+/**
+ * Symlinks this change introduces, with the path each one points at.
+ *
+ * `checkScope` is purely lexical, by design — the paths it judges can come from
+ * a diff and need not exist on disk. But that made a symlink a hole straight
+ * through it: a link named `notes.md` pointing at `.agent/config.yml` is judged
+ * as `notes.md`, and the protected path it resolves to is never considered.
+ * Resolving here, rather than inside `checkScope`, keeps that function lexical
+ * and testable while letting the gate judge both names.
+ *
+ * The target is resolved lexically against the link's own directory: it may
+ * point outside the repository, and following it on disk would be the wrong
+ * thing to do with an untrusted path.
+ *
+ * @param {string} root
+ * @param {string} base
+ * @param {string} mode
+ * @returns {Array<{ link: string, target: string }>}
+ */
+export function symlinkChanges(root = process.cwd(), base = "main", mode = "committed") {
+  const SYMLINK_MODE = "120000";
+  const results = [];
+  const seen = new Set();
+
+  for (const entry of parseRawDiff(root, base, mode)) {
+    if (entry.status === "D") continue;
+    if (entry.dstMode !== SYMLINK_MODE) continue;
+    if (seen.has(entry.file)) continue;
+    seen.add(entry.file);
+
+    // A symlink's blob content is its target path.
+    let target = "";
+    if (entry.dstSha && !/^0+$/.test(entry.dstSha)) {
+      target = (git(["cat-file", "blob", entry.dstSha], { cwd: root, ignoreError: true }) || "").trim();
+    }
+    if (!target) {
+      try {
+        target = readlinkSync(join(root, entry.file));
+      } catch (_) {
+        continue;
       }
-      // An unstaged change has an all-zero destination sha; the working file is
-      // the only place its size exists.
-      if (!bytes) {
-        try {
-          bytes = statSync(join(root, file)).size;
-        } catch (_) {
-          bytes = 0;
-        }
+    }
+    if (!target) continue;
+
+    const linkDir = normalizePath(entry.file).split("/").slice(0, -1).join("/");
+    const resolved = normalizePath(target).startsWith("/")
+      ? normalizePath(target)
+      : canonicalizePath(linkDir ? `${linkDir}/${target}` : target);
+
+    results.push({ link: entry.file, target: resolved });
+  }
+
+  return results;
+}
+
+export function binaryDiffEntries(root = process.cwd(), base = "main", mode = "committed") {
+  const entries = new Map();
+  for (const entry of parseRawDiff(root, base, mode)) {
+    if (entry.status === "D") continue;
+    const { file, dstSha } = entry;
+
+    let bytes = 0;
+    if (dstSha && !/^0+$/.test(dstSha)) {
+      const size = git(["cat-file", "-s", dstSha], { cwd: root, ignoreError: true });
+      bytes = Number(size) || 0;
+    }
+    // An unstaged change has an all-zero destination sha; the working file is
+    // the only place its size exists.
+    if (!bytes) {
+      try {
+        bytes = statSync(join(root, file)).size;
+      } catch (_) {
+        bytes = 0;
       }
-      // Keep the largest observation: the same path can appear in both ranges.
-      entries.set(file, Math.max(entries.get(file) || 0, bytes));
     }
+    // Keep the largest observation: the same path can appear in both ranges.
+    entries.set(file, Math.max(entries.get(file) || 0, bytes));
   }
 
   // Only the paths git itself refused to render as text are relevant; a file

package/src/security.mjs

@@ -1120,6 +1120,24 @@ export function checkTestTampering(diffOrText = "", options = {}) {
   const ASSERTION_PATTERN = /(?:\b(?:assert(?:\.[a-zA-Z0-9_$]+)?|expect|t\.(?:assert|expect|is|equal|true|false|Errorf|Fatalf)|require\.[a-zA-Z0-9_$]+)\b|assert!|assert_eq!|assert_ne!)/i;
   const isCommentLine = (str) => /^\s*(?:\/\/|\/\*|\*|#|--|;)/.test(str);
 
+  // An assertion that states a *specific* expected value. Counting assertions
+  // alone let a test be gutted while looking untouched: swapping
+  // `assert.strictEqual(add(2,3), 5)` for `assert.ok(add(2,3) !== undefined)`
+  // removes one and adds one, so `removed > added` stayed false and the guard
+  // said nothing — while the suite stopped checking the answer.
+  const SPECIFIC_ASSERTION = new RegExp(
+    [
+      "\\bassert(?:\\.strict)?\\.?(?:strictEqual|deepStrictEqual|deepEqual|notStrictEqual|notDeepStrictEqual|equal|notEqual|match|doesNotMatch|throws|rejects|doesNotThrow)\\s*\\(",
+      "\\bexpect\\s*\\([^)]*\\)\\s*\\.(?:toBe|toEqual|toStrictEqual|toMatch|toMatchObject|toContain|toHaveBeenCalledWith|toThrow|toHaveLength|toBeCloseTo)\\s*\\(",
+      "\\bassert\\.(?:equals|deepEquals|include|lengthOf)\\s*\\(",
+      "assert_eq!|assert_ne!",
+      "\\bt\\.(?:Errorf|Fatalf)\\s*\\(",
+      "\\brequire\\.(?:Equal|NotEqual|Len|Contains|Error|NoError)\\s*\\(",
+    ].join("|"),
+    "i"
+  );
+  const isSpecificAssertion = (str) => SPECIFIC_ASSERTION.test(str);
+
   const fileAssertions = new Map();
 
   for (let i = 0; i < lines.length; i++) {
@@ -1151,7 +1169,7 @@ export function checkTestTampering(diffOrText = "", options = {}) {
     }
 
     if (!fileAssertions.has(currentFile)) {
-      fileAssertions.set(currentFile, { removed: [], added: 0 });
+      fileAssertions.set(currentFile, { removed: [], added: 0, removedSpecific: [], addedSpecific: 0 });
     }
     const fileStats = fileAssertions.get(currentFile);
 
@@ -1159,6 +1177,9 @@ export function checkTestTampering(diffOrText = "", options = {}) {
       const deletedText = line.slice(1);
       if (!isCommentLine(deletedText) && ASSERTION_PATTERN.test(deletedText)) {
         fileStats.removed.push({ line: currentOldLineNo, text: deletedText });
+        if (isSpecificAssertion(deletedText)) {
+          fileStats.removedSpecific.push({ line: currentOldLineNo, text: deletedText });
+        }
       }
       if (currentOldLineNo !== null) currentOldLineNo++;
     } else if (line.startsWith("+") && !line.startsWith("+++")) {
@@ -1205,6 +1226,7 @@ export function checkTestTampering(diffOrText = "", options = {}) {
       // If valid non-vacuous, non-commented assertion is added, increment added count
       if (!isVacuous && !isCommented && !isCommentLine(addedText) && ASSERTION_PATTERN.test(addedText)) {
         fileStats.added++;
+        if (isSpecificAssertion(addedText)) fileStats.addedSpecific++;
       }
 
       if (currentNewLineNo !== null) currentNewLineNo++;
@@ -1226,6 +1248,31 @@ export function checkTestTampering(diffOrText = "", options = {}) {
         });
       }
     }
+
+    // Replacing an assertion is not the same as keeping one. Counting totals
+    // let a specific expectation be swapped for a vague one at no cost — one
+    // out, one in, guard silent, suite no longer checking the answer. What must
+    // not fall is the number of assertions that name an expected value.
+    //
+    // Only the *replaced* ones are reported here. An assertion deleted outright
+    // is already an ASSERTION_REMOVAL above, and emitting both would report the
+    // same line twice under two names.
+    const alreadyReportedSpecific = stats.removed
+      .slice(stats.added)
+      .filter((item) => isSpecificAssertion(item.text)).length;
+    const specificLost = Math.max(0, stats.removedSpecific.length - stats.addedSpecific);
+    const weakenedCount = Math.max(0, specificLost - alreadyReportedSpecific);
+
+    if (weakenedCount > 0) {
+      for (const item of stats.removedSpecific.slice(stats.addedSpecific, stats.addedSpecific + weakenedCount)) {
+        violations.push({
+          file,
+          line: item.line,
+          type: "ASSERTION_WEAKENED",
+          reason: `Test Tamper Guard: Assertion weakened in ${file}${item.line ? `:${item.line}` : ""} — an assertion naming an expected value was replaced by one that does not: "${item.text.trim()}"`,
+        });
+      }
+    }
   }
 
   return {