jsxgraph 1.11.0 → 1.11.1

package/package.json

@@ -2,7 +2,7 @@
   "name": "jsxgraph",
   "description": "Interactive geometry, plotting, visualization",
   "homepage": "https://jsxgraph.org",
-  "version": "1.11.0",
+  "version": "1.11.1",
   "exports": {
     "types": "./src/index.d.ts",
     "default": "./src/index.js"

package/src/3d/view3d.js

@@ -955,7 +955,7 @@ JXG.extend(
     },
 
     removeObject: function (object, saveMethod) {
-        var i;
+        var i, el;
 
         // this.board.removeObject(object, saveMethod);
         if (Type.isArray(object)) {
@@ -974,12 +974,12 @@ JXG.extend(
         }
 
         try {
-            //     // remove all children.
-            //     for (el in object.childElements) {
-            //         if (object.childElements.hasOwnProperty(el)) {
-            //             object.childElements[el].board.removeObject(object.childElements[el]);
-            //         }
-            //     }
+            // Remove all children.
+            for (el in object.childElements) {
+                if (object.childElements.hasOwnProperty(el)) {
+                    this.removeObject(object.childElements[el]);
+                }
+            }
 
             delete this.objects[object.id];
         } catch (e) {
@@ -990,6 +990,14 @@ JXG.extend(
 
         this.board.removeObject(object, saveMethod);
 
+        // delete this.depthOrdered[12][0];
+        // delete this.depthOrdered[12][1];
+        // delete this.depthOrdered[12][2];
+        // delete this.depthOrdered[12][3];
+        // delete this.depthOrdered[12][4];
+        // delete this.depthOrdered[12][5];
+        // console.log(this.depthOrdered[12])
+
         return this;
     },
 
@@ -2718,6 +2726,7 @@ JXG.createView3D = function (board, parents, attributes) {
     // Set special infobox attributes of view3d.infobox
     // Using setAttribute() is not possible here, since we have to
     // avoid a call of board.update().
+    // The drawback is that we can not use shortcuts
     view.board.infobox.visProp = Type.merge(view.board.infobox.visProp, attr.infobox);
 
     // 3d infobox: drag direction and coordinates

package/src/base/board.js

@@ -2895,8 +2895,9 @@ JXG.extend(
 
             ta = 'none';   // JSXGraph catches all user touch events
             if (this.mode === this.BOARD_MODE_NONE &&
-                Type.evaluate(this.attr.browserpan) &&
-                !(Type.evaluate(this.attr.pan.enabled) && !Type.evaluate(this.attr.pan.needtwofingers))
+                (Type.evaluate(this.attr.browserpan) === true || Type.evaluate(this.attr.browserpan.enabled) === true) &&
+                // One-finger pan has priority over browserPan
+                (Type.evaluate(this.attr.pan.enabled) === false || Type.evaluate(this.attr.pan.needtwofingers) === true)
             ) {
                 // ta = 'pan-x pan-y';  // JSXGraph allows browser scrolling
                 ta = 'auto';  // JSXGraph allows browser scrolling

package/src/base/constants.js

@@ -37,7 +37,7 @@ import JXG from "../jxg.js";
 
 var major = 1,
     minor = 11,
-    patch = 0,
+    patch = 1,
     add = '', // 'dev' 'beta'
     version = major + '.' + minor + '.' + patch + (add ? '-' + add : ''),
     constants;

package/src/base/element.js

@@ -1151,7 +1151,6 @@ JXG.extend(
                                 attributes[Options.shortcuts[key][i]] = attributes[key];
                             }
                         }
-                        delete attributes[key]; // Remove shortcut
                     }
                     for (j = 0; j < subattr.length; j++) {
                         if (Type.isObject(attributes[subattr[j]])) {
@@ -1273,7 +1272,7 @@ JXG.extend(
                     // Otherwise, the value of label would be {visible:false} only.
                     if (Type.isObject(value) && Type.exists(this.visProp[key])) {
                         // this.visProp[key] = Type.merge(this.visProp[key], value);
-                        if (!Type.isObject(this.visProp[key]) && Type.isObject(value)) {
+                        if (!Type.isObject(this.visProp[key]) && value !== null && Type.isObject(value)) {
                             // Handle cases like key=firstarrow and
                             // firstarrow==false and value = { type:1 }.
                             // That is a primitive type is replaced by an object.
@@ -1502,7 +1501,9 @@ JXG.extend(
                                             : value;
                                 this._set(key, value);
                             } else {
-                                JXG.warn("attribute '" + key + "' does not accept type '" + (typeof value) + "' of value " + value + ".");
+                                if (!(key in Options.shortcuts)) {
+                                    JXG.warn("attribute '" + key + "' does not accept type '" + (typeof value) + "' of value " + value + ".");
+                                }
                             }
                             break;
                     }

package/src/options.js

@@ -113,12 +113,12 @@ JXG.Options = {
 
         /**
          * Enable browser scrolling on touch interfaces if the user double taps into an empty region
-         * of the board.
+         * of the board. In turn, browser scrolling is deactivated as soon as a JSXGraph element is dragged.
          *
          * <ul>
          * <li> Implemented for pointer touch devices - not with mouse, pen or old iOS touch.
          * <li> It only works if browserPan:true
-         * <li> One finger action by the settings "pan.enabled:true" and "pan.needTwoFingers:false" has priority
+         * <li> One finger action by the settings "pan.enabled:true" and "pan.needTwoFingers:false" has priority.
          * </ul>
          *
          * @name JXG.Board#browserPan