jssm 5.143.23 → 5.143.25

package/README.md

@@ -18,10 +18,10 @@ Please edit the file it's derived from, instead: `./src/md/readme_base.md`
 
 
 
-* Generated for version 5.143.23 at 6/12/2026, 1:50:43 PM
+* Generated for version 5.143.25 at 6/12/2026, 2:28:30 PM
 
 -->
-# jssm 5.143.23
+# jssm 5.143.25
 
 [**Try the live editor**](https://stonecypher.github.io/jssm-viz-demo/graph_explorer.html) ·
 [Documentation](https://stonecypher.github.io/jssm/docs/) ·
@@ -281,7 +281,7 @@ That decision shows up everywhere downstream:
   or run `npm run benny` against your own machine.
 
 - **More thoroughly tested than any other JavaScript state-machine
-  library.**  7,009 tests at 100.0% line coverage
+  library.**  7,013 tests at 100.0% line coverage
   ([report](https://coveralls.io/github/StoneCypher/jssm)), plus
   fuzz testing via `fast-check`, with parser test data across ten natural
   languages and Emoji.
@@ -414,11 +414,11 @@ If your contribution is missing here, please open an issue.
 
 <br/>
 
-***7,009 tests***, run 81,853 times.
+***7,013 tests***, run 81,857 times.
 
-- 6,253 specs with 100.0% coverage
-- 756 fuzz tests with 83.6% coverage
-- 5,870 TypeScript lines - 1.2 tests per line, 13.9 generated tests per line
+- 6,257 specs with 100.0% coverage
+- 756 fuzz tests with 83.4% coverage
+- 5,880 TypeScript lines - 1.2 tests per line, 13.9 generated tests per line
 
 [![Actions Status](https://github.com/StoneCypher/jssm/workflows/Node%20CI/badge.svg)](https://github.com/StoneCypher/jssm/actions)
 [![NPM version](https://img.shields.io/npm/v/jssm.svg)](https://www.npmjs.com/package/jssm)

package/dist/cdn/instance.js

@@ -21804,7 +21804,9 @@ function compile(tree) {
                     throw new JssmError(undefined, `A state may only bind a property once (${sd.state} re-binds ${decl.name})`, { source_location: nth_matching_loc(tree, (n) => n.key === 'state_declaration' && n.name === sd.state, 1) });
                 }
                 else {
-                    result_cfg.state_property.push({ name: label, default_value: decl.value });
+                    // property/state carry the unserialized pair so the constructor can
+                    // validate bindings without JSON.parse-ing label back apart (#734)
+                    result_cfg.state_property.push({ name: label, default_value: decl.value, property: decl.name, state: sd.state });
                 }
             }
         });
@@ -22400,7 +22402,7 @@ var constants = /*#__PURE__*/Object.freeze({
  *  Useful for runtime diagnostics and for embedding in serialized machine
  *  snapshots so that deserializers can detect version-skew.
  */
-const version = "5.143.23";
+const version = "5.143.25";
 
 // whargarbl lots of these return arrays could/should be sets
 const { state_name_chars, state_name_first_chars, action_label_chars } = constants;
@@ -22734,6 +22736,7 @@ class Machine {
         this._default_properties = new Map();
         this._state_properties = new Map();
         this._required_properties = new Set();
+        this._state_property_first_state = new Map();
         this._state_style = state_style_condense(default_state_config, this);
         this._active_state_style = state_style_condense(default_active_state_config, this);
         this._hooked_state_style = state_style_condense(default_hooked_state_config, this);
@@ -22921,6 +22924,19 @@ class Machine {
         if (Array.isArray(state_property)) {
             state_property.forEach(sp => {
                 this._state_properties.set(sp.name, sp.default_value);
+                // Record the unserialized (property, state) pair for post-build
+                // validation.  The compiler writes both fields; a hand-built config
+                // that carries only the serialized name pays one JSON.parse here,
+                // which is what every binding used to pay at validation time (#734).
+                let j_property = sp.property, j_state = sp.state;
+                if ((j_property === undefined) || (j_state === undefined)) {
+                    const inside = JSON.parse(sp.name);
+                    j_property = inside[0];
+                    j_state = inside[1];
+                }
+                if (!(this._state_property_first_state.has(j_property))) {
+                    this._state_property_first_state.set(j_property, j_state);
+                }
             });
         }
         // set initial state either from the specified or the start state list.  validate admission behavior.
@@ -22940,32 +22956,25 @@ class Machine {
         }
         // done building, do checks
         // assert all props are valid
-        // _state_properties keys are always JSON.stringify([string, string]),
-        // built by name_bind_prop_and_state which throws on non-strings — so the
-        // non-array / non-string else-arms below are unreachable, not untested.
-        this._state_properties.forEach((_value, key) => {
-            const inside = JSON.parse(key);
-            /* v8 ignore else */
-            if (Array.isArray(inside)) {
-                const j_property = inside[0];
-                /* v8 ignore else */
-                if (typeof j_property === 'string') {
-                    const j_state = inside[1];
-                    /* v8 ignore else */
-                    if (typeof j_state === 'string') {
-                        if (!(this.known_prop(j_property))) {
-                            throw new JssmError(this, `State "${j_state}" has property "${j_property}" which is not globally declared`);
-                        }
-                    }
-                }
+        // provenance pairs were recorded at insertion — first state per property,
+        // in first-binding order — replacing the old JSON.parse of every
+        // serialized key; the error fires for the same binding it always did,
+        // because the first property in first-binding order whose name is
+        // undeclared owns the earliest undeclared binding.
+        this._state_property_first_state.forEach((j_state, j_property) => {
+            if (!(this.known_prop(j_property))) {
+                throw new JssmError(this, `State "${j_state}" has property "${j_property}" which is not globally declared`);
             }
         });
         // assert all required properties are serviced
+        // states() allocates a fresh array per call, so take it once rather than
+        // once per required property
+        const all_states_for_props = this.states();
         this._required_properties.forEach(dp_key => {
             if (this._default_properties.has(dp_key)) {
                 throw new JssmError(this, `The property "${dp_key}" is required, but also has a default; these conflict`);
             }
-            this.states().forEach(s => {
+            all_states_for_props.forEach(s => {
                 const bound_name = name_bind_prop_and_state(dp_key, s);
                 if (!(this._state_properties.has(bound_name))) {
                     throw new JssmError(this, `State "${s}" is missing required property "${dp_key}"`);
@@ -25212,7 +25221,19 @@ class Machine {
             const edgeId = (to_id === undefined) ? undefined : this._edge_id_by_pair.get(pair_key(this._state_id, to_id));
             if ((edgeId !== undefined) && (!(this._edges[edgeId].forced_only))) {
                 if (this._has_transition_hooks || this._has_post_transition_hooks) {
-                    trans_type = this.edges_between(this._state, newStateOrAction)[0].kind; // TODO this won't do the right thing if various edges have different types
+                    // first matching outbound edge's kind, without building the result
+                    // array edges_between allocated here on every hooked transition.
+                    // First-match semantics are kept deliberately: _edge_map is
+                    // last-wins for multi-edge (from, to) pairs, so lookup_transition_for
+                    // could disagree with the old edges_between(...)[0].  #735
+                    // TODO this won't do the right thing if various edges have different types
+                    for (const ob_eid of this._outbound_edge_ids.get(this._state)) {
+                        const ob_edge = this._edges[ob_eid];
+                        if (ob_edge.to === newStateOrAction) {
+                            trans_type = ob_edge.kind;
+                            break;
+                        }
+                    }
                 }
                 valid = true;
                 newState = newStateOrAction;
@@ -25226,6 +25247,11 @@ class Machine {
         // unchanged for all downstream uses without introducing an impossible
         // (uncoverable) branch; the value is only dereferenced under the guards
         // that imply it was built.  #670
+        // NOTE (#735): the { ...hook_args, hook_name } spreads at the four
+        // everything-hook sites are contractual, not waste — handlers may capture
+        // their context, and each captured context must durably carry its own
+        // hook_name (pinned by the simultaneous-everything-hook specs).  A shared
+        // mutated object cannot satisfy that; do not "optimize" the spreads away.
         const hook_args_obj = (this._has_hooks || this._has_post_hooks)
             ? {
                 data: this._data,
@@ -25585,10 +25611,15 @@ class Machine {
                     cause: 'transition'
                 });
             }
-            if (this.state_is_terminal(newState)) {
+            // one state-record fetch answers both checks; newState is known-valid
+            // here, and the public state_is_terminal / state_is_complete pair would
+            // each redo has_state plus its own map walk.  Same predicates:
+            // terminal = no exits, complete = the constructor-set flag.  #735
+            const new_state_rec = this._states.get(newState);
+            if (new_state_rec.to.length === 0) {
                 this._fire('terminal', { state: newState, data: newData_after });
             }
-            if (this.state_is_complete(newState)) {
+            if (new_state_rec.complete) {
                 this._fire('complete', { state: newState, data: newData_after });
             }
         }

package/dist/cdn/viz.js

@@ -21829,7 +21829,9 @@ function compile(tree) {
                     throw new JssmError(undefined, `A state may only bind a property once (${sd.state} re-binds ${decl.name})`, { source_location: nth_matching_loc(tree, (n) => n.key === 'state_declaration' && n.name === sd.state, 1) });
                 }
                 else {
-                    result_cfg.state_property.push({ name: label, default_value: decl.value });
+                    // property/state carry the unserialized pair so the constructor can
+                    // validate bindings without JSON.parse-ing label back apart (#734)
+                    result_cfg.state_property.push({ name: label, default_value: decl.value, property: decl.name, state: sd.state });
                 }
             }
         });
@@ -22425,7 +22427,7 @@ var constants = /*#__PURE__*/Object.freeze({
  *  Useful for runtime diagnostics and for embedding in serialized machine
  *  snapshots so that deserializers can detect version-skew.
  */
-const version = "5.143.23";
+const version = "5.143.25";
 
 // whargarbl lots of these return arrays could/should be sets
 const { state_name_chars, state_name_first_chars, action_label_chars } = constants;
@@ -22759,6 +22761,7 @@ class Machine {
         this._default_properties = new Map();
         this._state_properties = new Map();
         this._required_properties = new Set();
+        this._state_property_first_state = new Map();
         this._state_style = state_style_condense(default_state_config, this);
         this._active_state_style = state_style_condense(default_active_state_config, this);
         this._hooked_state_style = state_style_condense(default_hooked_state_config, this);
@@ -22946,6 +22949,19 @@ class Machine {
         if (Array.isArray(state_property)) {
             state_property.forEach(sp => {
                 this._state_properties.set(sp.name, sp.default_value);
+                // Record the unserialized (property, state) pair for post-build
+                // validation.  The compiler writes both fields; a hand-built config
+                // that carries only the serialized name pays one JSON.parse here,
+                // which is what every binding used to pay at validation time (#734).
+                let j_property = sp.property, j_state = sp.state;
+                if ((j_property === undefined) || (j_state === undefined)) {
+                    const inside = JSON.parse(sp.name);
+                    j_property = inside[0];
+                    j_state = inside[1];
+                }
+                if (!(this._state_property_first_state.has(j_property))) {
+                    this._state_property_first_state.set(j_property, j_state);
+                }
             });
         }
         // set initial state either from the specified or the start state list.  validate admission behavior.
@@ -22965,32 +22981,25 @@ class Machine {
         }
         // done building, do checks
         // assert all props are valid
-        // _state_properties keys are always JSON.stringify([string, string]),
-        // built by name_bind_prop_and_state which throws on non-strings — so the
-        // non-array / non-string else-arms below are unreachable, not untested.
-        this._state_properties.forEach((_value, key) => {
-            const inside = JSON.parse(key);
-            /* v8 ignore else */
-            if (Array.isArray(inside)) {
-                const j_property = inside[0];
-                /* v8 ignore else */
-                if (typeof j_property === 'string') {
-                    const j_state = inside[1];
-                    /* v8 ignore else */
-                    if (typeof j_state === 'string') {
-                        if (!(this.known_prop(j_property))) {
-                            throw new JssmError(this, `State "${j_state}" has property "${j_property}" which is not globally declared`);
-                        }
-                    }
-                }
+        // provenance pairs were recorded at insertion — first state per property,
+        // in first-binding order — replacing the old JSON.parse of every
+        // serialized key; the error fires for the same binding it always did,
+        // because the first property in first-binding order whose name is
+        // undeclared owns the earliest undeclared binding.
+        this._state_property_first_state.forEach((j_state, j_property) => {
+            if (!(this.known_prop(j_property))) {
+                throw new JssmError(this, `State "${j_state}" has property "${j_property}" which is not globally declared`);
             }
         });
         // assert all required properties are serviced
+        // states() allocates a fresh array per call, so take it once rather than
+        // once per required property
+        const all_states_for_props = this.states();
         this._required_properties.forEach(dp_key => {
             if (this._default_properties.has(dp_key)) {
                 throw new JssmError(this, `The property "${dp_key}" is required, but also has a default; these conflict`);
             }
-            this.states().forEach(s => {
+            all_states_for_props.forEach(s => {
                 const bound_name = name_bind_prop_and_state(dp_key, s);
                 if (!(this._state_properties.has(bound_name))) {
                     throw new JssmError(this, `State "${s}" is missing required property "${dp_key}"`);
@@ -25237,7 +25246,19 @@ class Machine {
             const edgeId = (to_id === undefined) ? undefined : this._edge_id_by_pair.get(pair_key(this._state_id, to_id));
             if ((edgeId !== undefined) && (!(this._edges[edgeId].forced_only))) {
                 if (this._has_transition_hooks || this._has_post_transition_hooks) {
-                    trans_type = this.edges_between(this._state, newStateOrAction)[0].kind; // TODO this won't do the right thing if various edges have different types
+                    // first matching outbound edge's kind, without building the result
+                    // array edges_between allocated here on every hooked transition.
+                    // First-match semantics are kept deliberately: _edge_map is
+                    // last-wins for multi-edge (from, to) pairs, so lookup_transition_for
+                    // could disagree with the old edges_between(...)[0].  #735
+                    // TODO this won't do the right thing if various edges have different types
+                    for (const ob_eid of this._outbound_edge_ids.get(this._state)) {
+                        const ob_edge = this._edges[ob_eid];
+                        if (ob_edge.to === newStateOrAction) {
+                            trans_type = ob_edge.kind;
+                            break;
+                        }
+                    }
                 }
                 valid = true;
                 newState = newStateOrAction;
@@ -25251,6 +25272,11 @@ class Machine {
         // unchanged for all downstream uses without introducing an impossible
         // (uncoverable) branch; the value is only dereferenced under the guards
         // that imply it was built.  #670
+        // NOTE (#735): the { ...hook_args, hook_name } spreads at the four
+        // everything-hook sites are contractual, not waste — handlers may capture
+        // their context, and each captured context must durably carry its own
+        // hook_name (pinned by the simultaneous-everything-hook specs).  A shared
+        // mutated object cannot satisfy that; do not "optimize" the spreads away.
         const hook_args_obj = (this._has_hooks || this._has_post_hooks)
             ? {
                 data: this._data,
@@ -25610,10 +25636,15 @@ class Machine {
                     cause: 'transition'
                 });
             }
-            if (this.state_is_terminal(newState)) {
+            // one state-record fetch answers both checks; newState is known-valid
+            // here, and the public state_is_terminal / state_is_complete pair would
+            // each redo has_state plus its own map walk.  Same predicates:
+            // terminal = no exits, complete = the constructor-set flag.  #735
+            const new_state_rec = this._states.get(newState);
+            if (new_state_rec.to.length === 0) {
                 this._fire('terminal', { state: newState, data: newData_after });
             }
-            if (this.state_is_complete(newState)) {
+            if (new_state_rec.complete) {
                 this._fire('complete', { state: newState, data: newData_after });
             }
         }