jspurefix 5.8.0 → 5.8.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jspurefix",
-  "version": "5.8.0",
+  "version": "5.8.5",
   "description": "pure node js fix engine",
   "keywords": [
     "typescript",
@@ -44,8 +44,8 @@
     "repo44-bench-tc": "node dist/jsfix-cmd jsfix-cmd --dict=repo44 --fix=data/examples/FIX.4.4/repo/trade-capture/fix.txt --benchmark --delimiter=\"|\" --repeats=30000",
     "repo44-bench-sd": "node dist/jsfix-cmd --dict=repo44 --fix=data/examples/FIX.4.4/repo/security-definition/fix.txt --benchmark --delimiter=\"|\" --repeats=150000",
     "repo44-bench-lo": "node dist/jsfix-cmd --dict=repo44 --fix=data/examples/FIX.4.4/repo/logon/fix.txt --benchmark --delimiter=\"|\" --repeats=250000",
-    "qf-bench-lo": "node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/quickfix/logon/fix.txt --benchmark --delimiter=\"|\" --repeats=250000",
-    "qf-bench-hb": "node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/quickfix/heartbeat/fix.txt --benchmark --delimiter=\"|\" --repeats=250000",
+    "qf-bench-lo": "node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/quickfix/logon/fix.txt --benchmark --delimiter=\"|\" --repeats=1000000",
+    "qf-bench-hb": "node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/quickfix/heartbeat/fix.txt --benchmark --delimiter=\"|\" --repeats=1000000",
     "fixml": "node dist/jsfix-cmd --dict=repofixml",
     "tcp-qf-md": "node dist/sample/tcp/qf-md/app",
     "tcp-tls-tc": "node dist/sample/tcp/tls-trade-capture/app",
@@ -74,9 +74,9 @@
   "author": "",
   "license": "MIT",
   "dependencies": {
-    "@jest/globals": "^30.3.0",
+    "@jest/globals": "^30.4.1",
     "align-text": "^1.0.2",
-    "axios": "^1.14.0",
+    "axios": "^1.16.1",
     "express": "^5.2.1",
     "lodash": "^4.18.1",
     "mathjs": "^15.2.0",
@@ -99,16 +99,16 @@
     "@types/lodash": "^4.17.24",
     "@types/mathjs": "^9.4.2",
     "@types/minimist": "^1.2.5",
-    "@types/node": "^25.5.2",
+    "@types/node": "^25.9.1",
     "@types/request-promise-native": "^1.0.21",
     "@types/sax": "^1.2.7",
     "@types/winston": "^2.4.4",
     "eslint": "^9.39.4",
     "eslint-config-love": "^151.0.0",
-    "jest": "^30.3.0",
+    "jest": "^30.4.2",
     "madge": "^8.0.0",
     "standard": "^17.1.2",
-    "ts-jest": "^29.4.9",
-    "typescript": "^6.0.2"
+    "ts-jest": "^29.4.11",
+    "typescript": "^6.0.3"
   }
 }

package/src/buffer/ascii/ascii-parser.ts

@@ -30,7 +30,8 @@ export class AsciiParser extends MsgParser {
 
   constructor (@inject(DITokens.IJsFixConfig) public readonly config: IJsFixConfig,
     @inject(DITokens.readStream) public readonly readStream: Readable | null,
-    @inject(DITokens.ParseBuffer) protected readonly receivingBuffer: ElasticBuffer) {
+    @inject(DITokens.ParseBuffer) protected readonly receivingBuffer: ElasticBuffer,
+    @inject(DITokens.maxMessageLen) public readonly maxMessageLen: number = 160 * 1024) {
     super()
 
     this.delimiter = config.delimiter ?? AsciiChars.Soh
@@ -38,7 +39,7 @@ export class AsciiParser extends MsgParser {
     this.id = AsciiParser.nextId++
     this.segmentParser = config.sessionContainer.resolve<AsciiSegmentParser>(AsciiSegmentParser)
     this.state = config.sessionContainer.resolve<AsciiParserState>(AsciiParserState)
-    this.state.locations = new Tags(this.receivingBuffer.size / 10)
+    this.state.locations = new Tags(this.receivingBuffer.size / 10, this.maxMessageLen)
     this.state.definitions = this.config.definitions
     this.state.beginMessage()
     if (readStream !== null) {

package/src/buffer/tag/tags.ts

@@ -8,10 +8,11 @@ export class Tags {
   public static readonly CheckSumTag: number = MsgTag.CheckSum
   public static readonly MsgTag: number = MsgTag.MsgType
 
-  public tagPos: TagPos[] = new Array(this.startingLength)
+  public tagPos: TagPos[] = new Array(Math.min(this.startingLength, this.maxLength))
   public nextTagPos: number = 0
 
-  constructor (public readonly startingLength: number = 30 * 1000) {
+  constructor (public readonly startingLength: number = 30 * 1000,
+    public readonly maxLength: number = 1024 * 1024) {
   }
 
   public static toJSType (tagType: TagType): string {
@@ -101,7 +102,7 @@ export class Tags {
 
   public clone (): Tags {
     const next: number = this.nextTagPos
-    const cloned: Tags = new Tags(next)
+    const cloned: Tags = new Tags(next, this.maxLength)
     cloned.nextTagPos = next
     for (let i = 0; i < next; ++i) {
       cloned.tagPos[i] = this.tagPos[i].clone()
@@ -128,7 +129,10 @@ export class Tags {
   }
 
   private expand (): void {
-    const size = this.tagPos.length * 2
+    if (this.tagPos.length >= this.maxLength) {
+      throw new Error(`tag count exceeds maximum of ${this.maxLength} - message too large or stream misaligned`)
+    }
+    const size = Math.min(this.tagPos.length * 2, this.maxLength)
     const tagPos = new Array(size)
     for (let i = 0; i < this.tagPos.length; ++i) {
       tagPos[i] = this.tagPos[i]

package/src/transport/ascii/ascii-session.ts

@@ -101,7 +101,9 @@ export abstract class AsciiSession extends FixSession {
           this.sessionLogger.info('logon with ResetSeqNumFlag=Y, accepting regardless of sequence')
           const seqNo = view.getTyped(MsgTag.MsgSeqNum) as number
           this.sessionState.lastPeerMsgSeqNum = seqNo
-          this.coordinator.onMessageReceived(seqNo, false)
+          this.coordinator.onMessageReceived(seqNo, false).catch((e: Error) => {
+            this.sessionLogger.warning(`coordinator.onMessageReceived store persist failed: ${e.message}`)
+          })
           return true
         }
       }
@@ -119,7 +121,9 @@ export abstract class AsciiSession extends FixSession {
           const possDupFlag = view.getTyped(MsgTag.PossDupFlag) as boolean | undefined
           if (possDupFlag === true) {
             this.sessionLogger.debug(`message '${msgType}' has PossDupFlag=Y, bypassing sequence check`)
-            this.coordinator.onMessageReceived(seqNo, true)
+            this.coordinator.onMessageReceived(seqNo, true).catch((e: Error) => {
+              this.sessionLogger.warning(`coordinator.onMessageReceived store persist failed: ${e.message}`)
+            })
             return true
           }
           // Check if this is a delayed message that fills a pending gap range.
@@ -127,7 +131,9 @@ export abstract class AsciiSession extends FixSession {
           const inPendingGapRange = pendingRequests.some(p => seqNo >= p.begin && seqNo <= p.end)
           if (inPendingGapRange) {
             this.sessionLogger.info(`accepting delayed message seq ${seqNo} (in pending gap range)`)
-            this.coordinator.onMessageReceived(seqNo, false)
+            this.coordinator.onMessageReceived(seqNo, false).catch((e: Error) => {
+              this.sessionLogger.warning(`coordinator.onMessageReceived store persist failed: ${e.message}`)
+            })
             return true
           }
           // serious problem ... drop immediately
@@ -171,7 +177,9 @@ export abstract class AsciiSession extends FixSession {
 
           // Update sequence state regardless — the gap-triggering message is valid.
           state.lastPeerMsgSeqNum = seqNo
-          this.coordinator.onMessageReceived(seqNo, false)
+          this.coordinator.onMessageReceived(seqNo, false).catch((e: Error) => {
+            this.sessionLogger.warning(`coordinator.onMessageReceived store persist failed: ${e.message}`)
+          })
 
           // Logon and ResendRequest were already fully handled above (peerLogon / onResendRequest).
           // Don't return true for them — they must not be dispatched to onSessionMsg again.
@@ -182,7 +190,9 @@ export abstract class AsciiSession extends FixSession {
         } else {
           ret = true
           state.lastPeerMsgSeqNum = seqNo
-          this.coordinator.onMessageReceived(seqNo, false)
+          this.coordinator.onMessageReceived(seqNo, false).catch((e: Error) => {
+            this.sessionLogger.warning(`coordinator.onMessageReceived store persist failed: ${e.message}`)
+          })
         }
 
         // Reset timeout recovery on successful message receipt
@@ -333,7 +343,9 @@ export abstract class AsciiSession extends FixSession {
     this.sessionState.lastPeerMsgSeqNum = this.coordinator.lastProcessedPeerSeqNum
 
     if (this.store) {
-      this.store.clear()
+      this.store.clear().catch((e: Error) => {
+        this.sessionLogger.warning(`store.clear failed: ${e.message}`)
+      })
       this.resender = new FixMsgAsciiStoreResend(this.store, this.config)
     }
 
@@ -439,7 +451,9 @@ export abstract class AsciiSession extends FixSession {
         // expect  newSeqNo to be the next message's sequence number.
         this.sessionState.lastPeerMsgSeqNum = newSeqNo - 1
         // Notify coordinator to update expected target and clear pending resend requests
-        this.coordinator.onGapFillReceived(gapFillSeq, newSeqNo)
+        this.coordinator.onGapFillReceived(gapFillSeq, newSeqNo).catch((e: Error) => {
+          this.sessionLogger.warning(`coordinator.onGapFillReceived store persist failed: ${e.message}`)
+        })
         break
       }
 
@@ -524,7 +538,9 @@ export abstract class AsciiSession extends FixSession {
 
       // Fire-and-forget the async coordinator call (store updates resolve on next microtask)
       // but compute the expected values synchronously since we know the reset outcome
-      this.coordinator.handlePeerReset(peerSeqNum, weAlsoReset)
+      this.coordinator.handlePeerReset(peerSeqNum, weAlsoReset).catch((e: Error) => {
+        this.sessionLogger.warning(`coordinator.handlePeerReset store persist failed: ${e.message}`)
+      })
       if (transmitter) {
         transmitter.msgSeqNum = savedEncoderSeqNum ?? 1
       }
@@ -532,7 +548,9 @@ export abstract class AsciiSession extends FixSession {
 
       // Recreate resender with empty store
       if (this.store) {
-        this.store.clear()
+        this.store.clear().catch((e: Error) => {
+          this.sessionLogger.warning(`store.clear failed: ${e.message}`)
+        })
         this.resender = new FixMsgAsciiStoreResend(this.store, this.config)
       }
       logger.info(`reset complete: encoderSeqNum=${transmitter?.msgSeqNum}, lastPeerMsgSeqNum=${peerSeqNum}`)
@@ -555,14 +573,18 @@ export abstract class AsciiSession extends FixSession {
       if (weReset && resetSeqNumFlag !== true) {
         logger.info('acceptor sending ResetSeqNumFlag=Y (peer sent N), resetting sequences')
         // Fire-and-forget async coordinator call, set values synchronously
-        this.coordinator.resetAsAcceptor()
+        this.coordinator.resetAsAcceptor().catch((e: Error) => {
+          this.sessionLogger.warning(`coordinator.resetAsAcceptor store persist failed: ${e.message}`)
+        })
         const transmitter = this.transport?.transmitter as AsciiMsgTransmitter | undefined
         if (transmitter) {
           transmitter.msgSeqNum = 1
         }
         this.sessionState.lastPeerMsgSeqNum = 0
         if (this.store) {
-          this.store.clear()
+          this.store.clear().catch((e: Error) => {
+            this.sessionLogger.warning(`store.clear failed: ${e.message}`)
+          })
           this.resender = new FixMsgAsciiStoreResend(this.store, this.config)
         }
       }

package/src/transport/session/fix-session.ts

@@ -110,14 +110,26 @@ export abstract class FixSession extends events.EventEmitter {
         this.setState(SessionState.WaitingForALogon)
       }
 
-      this.on('error', (e: Error) => {
+      // Use named handlers and detach BOTH when the promise settles.  Only one of
+      // 'error'/'done' fires per run; without removing the sibling the unfired
+      // listener would leak on every reconnect (issue #146).  `once` alone is not
+      // enough for the same reason — the sibling never fires, so never self-detaches.
+      const cleanup = (): void => {
+        this.removeListener('error', onError)
+        this.removeListener('done', onDone)
+      }
+      const onError = (e: Error): void => {
+        cleanup()
         logger.error(e)
         reject(e)
-      })
-
-      this.on('done', () => {
+      }
+      const onDone = (): void => {
+        cleanup()
         resolve(this.transport?.id)
-      })
+      }
+
+      this.on('error', onError)
+      this.on('done', onDone)
     })
   }