jspurefix 3.2.0 → 3.5.0

package/src/jsfix-cmd.ts

@@ -18,9 +18,140 @@ import { EnumCompiler, ICompilerSettings, MsgCompiler } from './dictionary/compi
 import { AsciiMsgTransmitter } from './transport/ascii/ascii-msg-transmitter'
 import { SessionContainer } from './runtime'
 import { DITokens } from './runtime/di-tokens'
+import buildOptions from 'minimist-options'
+import { Dictionary } from './collections'
+import { QuickFixXmlFileBuilder } from './dictionary/parser/quickfix/quick-fix-xml-file-builder'
+
 const fs = require('node-fs-extra')
 
-const argv: any = minimist(process.argv.slice(2))
+const options = buildOptions({
+  dict: {
+    type: 'string',
+    alias: 'd',
+    default: 'data/FIX44.xml'
+  },
+
+  type: {
+    type: 'string-array',
+    alias: 't'
+  },
+
+  fix: {
+    type: 'string',
+    alias: 'f',
+    default: 'data/FIX44.xml'
+  },
+
+  session: {
+    type: 'string',
+    alias: 's'
+  },
+
+  delimiter: {
+    type: 'string',
+    alias: 'l',
+    default: '|'
+  },
+
+  help: {
+    type: 'boolean',
+    alias: ['h'],
+    default: false
+  },
+
+  unit: {
+    type: 'boolean',
+    alias: ['u'],
+    default: false
+  },
+
+  generate: {
+    type: 'boolean',
+    alias: ['g'],
+    default: false
+  },
+
+  stats: {
+    type: 'boolean',
+    alias: ['st'],
+    default: false
+  },
+
+  tokens: {
+    type: 'boolean',
+    alias: ['t'],
+    default: false
+  },
+
+  objects: {
+    type: 'boolean',
+    alias: ['o'],
+    default: true
+  },
+
+  structures: {
+    type: 'boolean',
+    alias: ['r'],
+    default: false
+  },
+
+  script: {
+    type: 'boolean',
+    alias: ['i'],
+    default: false
+  },
+
+  compile: {
+    type: 'boolean',
+    alias: ['c'],
+    default: false
+  },
+
+  groups: {
+    type: 'boolean',
+    alias: ['g'],
+    default: true
+  },
+
+  density: {
+    type: 'number',
+    alias: 'd',
+    default: 0.8
+  },
+
+  repeats: {
+    type: 'number',
+    alias: 'r',
+    default: 1
+  },
+
+  arr: {
+    type: 'array',
+    alias: 'a',
+    default: []
+  }
+
+  /*
+  booleans: {
+    type: 'boolean-array',
+    alias: 'b',
+    default: [true, false]
+  },
+
+  numbers: {
+    type: 'number-array',
+    alias: 'n',
+    default: [0, 1]
+  },
+
+  published: 'boolean',
+
+  // Special option for positional arguments (`_` in minimist)
+  arguments: 'string'
+  */
+})
+
+const argv: any = minimist(process.argv.slice(2), options)
 
 enum PrintMode {
   Structure = 1,
@@ -38,7 +169,8 @@ enum Command {
   Encode = 4,
   Benchmark = 5,
   Compile = 6,
-  Unknown = 7
+  Trim,
+  Unknown = 8
 }
 
 class ParseSummary {
@@ -70,13 +202,15 @@ export class JsfixCmd {
   private sessionDescription: ISessionDescription
   private delimiter: number = AsciiChars.Soh
   private stats: ILooseObject = {}
-  private filter: string | null = null
+  private readonly filter: Dictionary<boolean> = new Dictionary<boolean>()
   private messages: number = 0
   private print: boolean = true
 
   private static getCommand (): Command {
     let command: Command = Command.Unknown
-    if (argv.compile) {
+    if (argv.trim) {
+      command = Command.Trim
+    } else if (argv.compile) {
       command = Command.Compile
     } else if (argv.generate) {
       command = Command.Generate
@@ -106,6 +240,8 @@ export class JsfixCmd {
       mode = PrintMode.Structure
     } else if (argv.encoded) {
       mode = PrintMode.Encoded
+    } else if (argv.trim) {
+      mode = PrintMode.Object
     }
     return mode
   }
@@ -177,6 +313,12 @@ export class JsfixCmd {
             break
           }
 
+          case Command.Trim: {
+            const xml = this.trim()
+            console.log(xml)
+            break
+          }
+
           case Command.Unknown:
           default: {
             actioned = false
@@ -321,6 +463,14 @@ export class JsfixCmd {
     await enumCompiler.generate(writeFile)
   }
 
+  private trim (): string {
+    this.setFilter()
+    const types = this.filter.count() > 0 ? this.filter.keys() : this.definitions.simple.get('MsgType')?.enums.keys() ?? []
+    const qfb = new QuickFixXmlFileBuilder(this.definitions)
+    qfb.write(types)
+    return qfb.elasticBuffer.toString()
+  }
+
   private async compile (): Promise<void> {
     let output = argv.output
     const dp = new DefinitionFactory().getDictPath(argv.dict)
@@ -361,10 +511,26 @@ export class JsfixCmd {
     }
   }
 
-  private async dispatch (ft: MsgTransport): Promise<any> {
+  private setFilter (): void {
+    const types: string[] = []
     if (argv.type != null) {
-      this.filter = argv.type.toString()
+      if (Array.isArray(argv.type)) {
+        argv.type.forEach((mt: any) => {
+          types.push(mt)
+        })
+      } else {
+        argv.type.split(',').forEach((mt: string) => {
+          types.push(mt)
+        })
+      }
+      types.forEach((mt: any) => {
+        this.filter.add(mt, true)
+      })
     }
+  }
+
+  private async dispatch (ft: MsgTransport): Promise<any> {
+    this.setFilter()
     let time: boolean = false
     if (argv.time || argv.stats) {
       this.print = false
@@ -389,7 +555,7 @@ export class JsfixCmd {
     // the receiver is message parser which is piped from an input stream - file, socket
     ft.receiver.on('msg', (msgType: string, m: AsciiView) => {
       if (filter) {
-        if (msgType !== filter) {
+        if (filter.containsKey(msgType)) {
           return
         }
       }
@@ -483,7 +649,7 @@ export class JsfixCmd {
 
   async benchParse (contents: string, iterations: number): Promise<ParseSummary> {
     return new Promise((resolve, reject) => {
-      const toParse = new StringDuplex(contents.repeat(iterations), false)
+      const toParse = new StringDuplex(contents.repeat(iterations))
       const startsAt: Date = new Date()
       let i = 0
       const config = this.config
@@ -498,7 +664,9 @@ export class JsfixCmd {
           resolve(summary)
         }
       })
-      asciiParser.on('error', e => { reject(e) })
+      asciiParser.on('error', e => {
+        reject(e)
+      })
     })
   }
 
@@ -558,46 +726,49 @@ function showHelp (): void {
   console.log('npm run cmd -- --help')
   console.log()
 
+  console.log('print to console a trim quickfix format xml only including given message types')
+  console.log('node dist/jsfix-cmd  --dict=qf44 --trim --type="0,1,2,3,4,5,AE"')
+
   console.log('token format i.e. [602] 687 (LegQty) = 33589')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt --delimiter="|" --tokens')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt --delimiter="|" --tokens')
   console.log()
 
   console.log('token format use fix repo dictionary')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt' +
     ' --delimiter="|" --tokens')
   console.log()
 
   console.log('structure format i.e. show locations of components etc.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --structures')
   console.log()
 
   console.log('full JS object in JSON format.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --objects')
   console.log()
 
   console.log('full JS object in JSON format - filter only type messages.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --type=8 --objects')
   console.log()
 
   console.log('timing stats and message counts. Structured parsing of all messages.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt --stats')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt --stats')
   console.log()
 
   console.log('encode a json object to fix format')
-  console.log('jsfix-cmd --json=data/examples/FIX.4.4/quickfix/execution-report/object.json' +
+  console.log('node dist/jsfix-cmd --json=data/examples/FIX.4.4/quickfix/execution-report/object.json' +
     ' --session=data/session.json --type=8 --delimiter="|"')
   console.log()
 
   console.log('display field definition')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --field=MsgType|35')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --field=MsgType|35')
   console.log()
 
   console.log('display field use fix repo dictionary e.g. 271 MDEntrySize QTY Quantity or volume represented by the Market Data Entry.')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=MsgType')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=35')
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=MsgType')
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=35')
   console.log()
 
   console.log('script to describe field in repository version 4.4')
@@ -609,21 +780,21 @@ function showHelp (): void {
   console.log()
 
   console.log('generate unit test set of files - i.e. randomly generate an object, encode to fix. density 1 is all fields')
-  console.log('jsfix-cmd --generate --type=AE --density=0.8 --unit --delimiter="|" --session=data/session/test-initiator.json')
+  console.log('node dist/jsfix-cmd --generate --type=AE --density=0.8 --unit --delimiter="|" --session=data/session/test-initiator.json')
   console.log('npm run repo44-unit -- --type=AE')
   console.log('test script with no repeat groups')
   console.log('npm run repo44-unit -- --type=AE --groups=false')
   console.log()
 
   console.log('generate a fix log of randomly generated but syntactically correct messages')
-  console.log('jsfix-cmd --generate --density=0.8 --repeats=50 --script --delimiter="|" --session=data/session/test-initiator.json')
+  console.log('node dist/jsfix-cmd --generate --density=0.8 --repeats=50 --script --delimiter="|" --session=data/session/test-initiator.json')
   console.log('npm run repo44-script')
   console.log('parse above generated script')
   console.log('npm run repo44-repscr')
   console.log()
 
   console.log('replay example repo fix file of 50 messages.')
-  console.log('jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/fix.txt --delimiter="|" --stats')
+  console.log('node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/fix.txt --delimiter="|" --stats')
   console.log('npm run repo44-replay -- --stats')
   console.log('npm run repo44-replay -- --objects')
   console.log('npm run repo44-replay -- --tokens')
@@ -631,7 +802,7 @@ function showHelp (): void {
   console.log()
 
   console.log('benchmark parse a message')
-  console.log('jsfix-cmd --delimiter="|" --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt --benchmark')
+  console.log('node dist/jsfix-cmd --delimiter="|" --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt --benchmark')
   console.log('npm run repo44-bench -- --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt')
   console.log()
 

package/src/runtime/session-launcher.ts

@@ -11,13 +11,16 @@ const defaultLoggerFactory = new JsFixWinstonLogFactory(WinstonLogger.consoleOpt
 export abstract class SessionLauncher {
   public root: string = '../../'
   protected readonly logger: IJsFixLogger
-  public readonly initiatorConfig: ISessionDescription
+  public readonly initiatorConfig: ISessionDescription | null
   public readonly acceptorConfig: ISessionDescription | null
-  protected constructor (initiatorConfig: string | ISessionDescription,
+
+  protected constructor (
+    initiatorConfig: string | ISessionDescription | null = null,
     acceptorConfig: string | ISessionDescription | null = null,
-    private readonly loggerFactory: JsFixLoggerFactory = defaultLoggerFactory) {
+    private readonly loggerFactory: JsFixLoggerFactory = defaultLoggerFactory
+  ) {
     this.logger = this.loggerFactory.logger('launcher')
-    this.initiatorConfig = this.loadConfig(initiatorConfig)
+    this.initiatorConfig = initiatorConfig ? this.loadConfig(initiatorConfig) : null
     this.acceptorConfig = acceptorConfig ? this.loadConfig(acceptorConfig) : null
   }
 
@@ -128,6 +131,7 @@ export abstract class SessionLauncher {
   }
 
   private async makeClient (): Promise<any> {
+    if (!this.initiatorConfig) return
     const sessionContainer = await this.makeSystem(this.initiatorConfig)
     this.register(sessionContainer)
     this.logger.info('create initiator')

package/src/store/fix-msg-ascii-store-resend.ts

@@ -28,9 +28,15 @@ export class FixMsgAsciiStoreResend {
 
   private inflateRange (startSeq: number, endSeq: number, input: IFixMsgStoreRecord[]): IFixMsgStoreRecord[] {
     const toResend: IFixMsgStoreRecord[] = []
+    // If no records for this given sequence number range, returns a single gap fill
+    if (input.length === 0) {
+      this.gap(startSeq, endSeq + 1, toResend)
+      return toResend
+    }
+
     let expected = startSeq
     for (let i = 0; i < input.length; ++i) {
-      const record = input[i].clone()
+      const record = this.prepareRecordForRetransmission(input[i])
       const seqNum = record.seqNum
       const toGap = seqNum - expected
       if (toGap > 0) {
@@ -48,16 +54,16 @@ export class FixMsgAsciiStoreResend {
     return toResend
   }
 
-  public gap (beginGap: number, seqNum: number, arr: IFixMsgStoreRecord[]): void {
+  private gap (beginGap: number, newSeq: number, arr: IFixMsgStoreRecord[]): void {
     if (beginGap > 0) {
-      arr.push(this.sequenceResetGap(beginGap, seqNum))
+      arr.push(this.sequenceResetGap(beginGap, newSeq))
     }
   }
 
   // if records were sent as encoded text then inflate back to object
   // so can be resent or examined
 
-  public inflate (record: IFixMsgStoreRecord): void {
+  private inflate (record: IFixMsgStoreRecord): void {
     if (record.obj) return
     if (!record.encoded) return
     const parser = this.parser
@@ -71,17 +77,67 @@ export class FixMsgAsciiStoreResend {
     parser.parseText(record.encoded)
   }
 
-  public sequenceResetGap (startGap: number, newSeq: number): IFixMsgStoreRecord {
+  /**
+   * A continuous sequence of messages not being retransmitted should be skipped over using a
+   * single SequenceReset(35=4) message with GapFillFlag(123) set to “Y” and MsgSeqNum(34) set
+   * to the sequence number of the first skipped message and NewSeqNo(36) must always be set
+   * to the value of the next sequence number to be expected by the peer immediately following
+   * the messages being skipped.
+   */
+  private sequenceResetGap (startGap: number, newSeq: number): IFixMsgStoreRecord {
     const factory = this.config.factory
     const gapFill: ISequenceReset = factory?.sequenceReset(newSeq, true) as ISequenceReset
     gapFill.StandardHeader = factory?.header(MsgType.SequenceReset, startGap) as IStandardHeader
     gapFill.StandardHeader.PossDupFlag = true
-    gapFill.NewSeqNo = newSeq
+
     return new FixMsgStoreRecord(
       MsgType.SequenceReset,
       new Date(),
-      newSeq,
+      startGap,
       gapFill,
-      null)
+      null,
+    )
+  }
+
+  /**
+   * Prepares the FIX message as response to ResendRequest (2).
+   *
+   * The FIX session processor retransmitting a message with the PossDupFlag(43) set to "Y" must modify the following fields:
+   *
+   * SendingTime(52) set to the current sending time
+   * OrigSendingTime(122) set to the SendingTime(52) from the original message
+   * Recalculate the BodyLength(9)
+   * Recalculate the CheckSum(10)
+   *
+   * If the message is encrypted, SecureDataLen(90) and SecureData(91) may also require re-encryption and re-encoding
+   *
+   * @see https://www.fixtrading.org/standards/fix-session-layer-online/#message-recovery
+   *
+   * @param originalRecord the FIX message to be retransmitted as possible duplicate
+   * @returns the FIX message ready to be retransmitted
+   */
+  private prepareRecordForRetransmission (originalRecord: IFixMsgStoreRecord): IFixMsgStoreRecord {
+    const retransmitted = originalRecord.clone() // We don't want to accidently change any fields of the original record
+
+    const factory = this.config.factory
+    if (!retransmitted.obj) {
+      retransmitted.obj = {}
+    }
+
+    // Rebuilds header with the updated fields
+    const header = factory?.header(
+      retransmitted.msgType,
+      retransmitted.seqNum,
+      new Date(), // SendingTime(52)
+      {
+        PossDupFlag: true,
+        OrigSendingTime: retransmitted.timestamp
+      }
+    )
+    retransmitted.obj = {
+      ...retransmitted.obj,
+      StandardHeader: header
+    }
+    return retransmitted
   }
 }

package/src/transport/ascii/ascii-session.ts

@@ -160,7 +160,11 @@ export abstract class AsciiSession extends FixSession {
   protected onResendRequest (view: MsgView): void {
     // if no records are in store then send a gap fill for entire sequence
     this.setState(SessionState.HandleResendRequest)
-    const [beginSeqNo, endSeqNo] = view.getTypedTags([MsgTag.BeginSeqNo, MsgTag.EndSeqNo])
+    const [beginSeqNo, requestedEndSeqNo] = view.getTypedTags([MsgTag.BeginSeqNo, MsgTag.EndSeqNo])
+    const endSeqNo = requestedEndSeqNo === 0
+      ? this.sessionState.lastSentSeqNum()
+      : requestedEndSeqNo
+
     this.sessionLogger.info(`onResendRequest getResendRequest beginSeqNo = ${beginSeqNo}, endSeqNo = ${endSeqNo}`)
     this.resender.getResendRequest(beginSeqNo as number, endSeqNo as number).then((records: IFixMsgStoreRecord[]) => {
       const validRecords = records.filter(rec => rec.obj !== null)

package/src/transport/duplex/fix-duplex.ts

@@ -1,5 +1,7 @@
 import { Readable, Writable } from 'stream'
 
+export type MakeDuplex = () => FixDuplex
+
 export abstract class FixDuplex {
   public readable: Readable
   public writable: Writable

package/src/transport/duplex/http-duplex.ts

@@ -1,6 +1,6 @@
 import { FixDuplex } from './fix-duplex'
 import { Readable, Writable } from 'stream'
-import axios, { isCancel, AxiosError } from 'axios'
+import axios from 'axios'
 import { IHttpAdapter } from '../http/http-adapter'
 
 export class HttpDuplex extends FixDuplex {

package/src/transport/duplex/string-duplex.ts

@@ -1,33 +1,82 @@
 import { FixDuplex } from './fix-duplex'
 import { Readable, Writable } from 'stream'
 
-export class StringDuplex extends FixDuplex {
-  constructor (public readonly text: string = '', public chunks: boolean = false) {
+export enum StringDuplexTraits {
+  None = 0,
+  Hunked = 1 << 0, // 0001 -- the bitshift is unnecessary, but done for consistency
+  Terminate = 1 << 1, // 0010
+  All = ~(~0 << 2) // 11
+}
+
+export class StringDuplexTraitsHelper {
+  public static isTerminate (traits: StringDuplexTraits): boolean {
+    return (traits & StringDuplexTraits.Terminate) === StringDuplexTraits.Terminate
+  }
+
+  public static isHunked (traits: StringDuplexTraits): boolean {
+    return (traits & StringDuplexTraits.Hunked) === StringDuplexTraits.Hunked
+  }
+}
+
+class StrHandler extends Readable {
+  protected pos: number = 0
+  protected remaining: number
+
+  constructor (public readonly txt: string, public readonly traits: StringDuplexTraits) {
     super()
-    this.readable = StringDuplex.makeReadable(text, chunks)
-    this.writable = StringDuplex.makeWritable()
+    this.remaining = txt.length
   }
 
-  private static makeReadable (text: string, chunks: boolean): Readable {
-    const Readable = require('stream').Readable
-    let total: number = 0
-    const reader = {
-      read: (size: number) => {
-        total += size
-        if (text.length > 0 && total > text.length) {
-          readable.push(null)
-        }
-      }
-    }
-    const readable = new Readable(reader)
-    if (!chunks) {
-      readable.push(text)
-    } else {
-      // simulate a set of chunks sent to parser
-      StringDuplex.sendReaderChunks(text, readable)
+  public isTerminate (): boolean {
+    return StringDuplexTraitsHelper.isTerminate(this.traits)
+  }
+
+  public isHunked (): boolean {
+    return StringDuplexTraitsHelper.isHunked(this.traits)
+  }
+
+  protected sendHunk (slice: string): void {
+    this.push(slice)
+    this.pos += slice.length
+    this.remaining -= slice.length
+    this.remaining = Math.max(0, this.remaining)
+    if (this.isTerminate() && this.remaining === 0) {
+      this.push(null)
     }
+  }
+
+  public _read (n: number): void {
+    const len = this.txt.length
+    const pos = this.pos
+    const toSend = Math.min(n, len - pos)
+    const slice = this.txt.slice(pos, pos + toSend)
+    this.sendHunk(slice)
+  }
+}
+
+class HunkedStrHandler extends StrHandler {
+  private iteration = 0
 
-    return readable
+  constructor (public readonly txt: string, public readonly traits: StringDuplexTraits) {
+    super(txt, traits)
+  }
+
+  public _read (n: number): void {
+    this.iteration++
+    const want = (this.iteration % 10) + 1
+    const chunk = Math.min(this.remaining, want)
+    const snippet = this.txt.slice(this.pos, this.pos + chunk)
+    this.sendHunk(snippet)
+  }
+}
+
+export class StringDuplex extends FixDuplex {
+  constructor (public readonly text: string = '', public readonly traits: StringDuplexTraits = StringDuplexTraits.Terminate) {
+    super()
+    this.readable = StringDuplexTraitsHelper.isHunked(traits)
+      ? new HunkedStrHandler(text, traits)
+      : new StrHandler(text, traits)
+    this.writable = StringDuplex.makeWritable()
   }
 
   private static makeWritable (): Writable {
@@ -46,25 +95,7 @@ export class StringDuplex extends FixDuplex {
     return receiver
   }
 
-  private static sendReaderChunks (text: string, readable: Readable): void {
-    // simulate a set of chunks sent to parser
-    let start = 0
-    let iteration = 0
-    let remaining = text.length
-    while (remaining > 0) {
-      iteration++
-      const chunk = Math.min(remaining, iteration % 10)
-      remaining -= chunk
-      const end = start + chunk
-      const snippet = text.slice(start, end)
-      readable.push(snippet)
-      start = end
-    }
-  }
-
   public end (): void {
-    if (this.text.length === 0) {
-      this.readable.push(null)
-    }
+    this.readable.push(null)
   }
 }

package/src/transport/http/http-acceptor.ts

@@ -2,7 +2,7 @@ import { MsgTransport } from '../factory'
 import { FixAcceptor } from '../fix-acceptor'
 import { IJsFixConfig, IJsFixLogger } from '../../config'
 import { IFixmlRequest } from '../fixml'
-import { StringDuplex, FixDuplex } from '../duplex'
+import { FixDuplex, StringDuplex, StringDuplexTraits } from '../duplex'
 import { Dictionary } from '../../collections'
 
 import * as express from 'express'
@@ -19,7 +19,7 @@ export class HttpAcceptor extends FixAcceptor {
   private readonly logger: IJsFixLogger
   private readonly router: express.Router
   private nextId: number = 0
-  private readonly keys: Dictionary<MsgTransport> = new Dictionary()
+  private readonly keys: Dictionary<MsgTransport> = new Dictionary<MsgTransport>()
 
   constructor (@inject(DITokens.IJsFixConfig) public readonly config: IJsFixConfig) {
     super(config?.description?.application ?? null)
@@ -100,7 +100,7 @@ export class HttpAcceptor extends FixAcceptor {
     const id = this.nextId++
     this.logger.info(JSON.stringify(body, null, 4))
     // check hand back session key
-    const d = new StringDuplex()
+    const d = new StringDuplex('', StringDuplexTraits.None)
     const transport = new MsgTransport(id, this.config, d)
     const token = this.saveTransport(id, transport)
     this.respond(d, res, token).then(() => {