jspurefix 3.1.0 → 3.4.0

package/src/dictionary/parser/quickfix/quick-fix-xml-formatter.ts

@@ -0,0 +1,67 @@
+import { EOL as newLine } from 'os'
+import { ContainedComponentField, ContainedGroupField, ContainedSimpleField } from '../../contained'
+import { FieldEnum } from '../../field-enum'
+import { MessageDefinition, SimpleFieldDefinition } from '../../definition'
+
+export class QuickFixXmlFormatter {
+  private static isRequired (r: boolean): string {
+    return r ? 'Y' : 'N'
+  }
+
+  private static whitespace (n: number): string {
+    return ' '.repeat(n)
+  }
+
+  public static startFix (major: number, minor: number, servicePack: number): string {
+    return `<fix major='${major}' type='FIX' servicepack='${servicePack}' minor='${minor}'>${newLine}`
+  }
+
+  public static endFix (): string {
+    return `</fix>${newLine}`
+  }
+
+  public static startEntity (name: string, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}<${name}>${newLine}`
+  }
+
+  public static endEntity (name: string, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}</${name}>${newLine}`
+  }
+
+  public static startComponent (name: string, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}<component name='${name}'>${newLine}`
+  }
+
+  public static endComponent (ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}</component>${newLine}`
+  }
+
+  public static addField (sf: ContainedSimpleField, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)} <!-- ${sf.definition.tag} ${sf.definition.type} -->${newLine}${QuickFixXmlFormatter.whitespace(ws)}<field name='${sf.name}' required='${QuickFixXmlFormatter.isRequired(sf.required)}'/>${newLine}`
+  }
+
+  public static addComponent (cf: ContainedComponentField, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}<component name='${cf.name}' required='${QuickFixXmlFormatter.isRequired(cf.required)}'/>${newLine}`
+  }
+
+  public static addGroup (gf: ContainedGroupField, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)} <!-- ${gf.definition.noOfField?.tag ?? -1} ${gf.definition.noOfField?.type} -->${newLine}${QuickFixXmlFormatter.whitespace(ws)}<group name='${gf.name}' required='${QuickFixXmlFormatter.isRequired(gf.required)}'>${newLine}`
+  }
+
+  public static endGroup (ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}</group>${newLine}`
+  }
+
+  public static addEnum (fe: (FieldEnum | null), ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}<value enum='${fe?.key}' description='${fe?.description ?? fe?.val}'/>${newLine}`
+  }
+
+  public static defineField (sf: SimpleFieldDefinition, ws: number): string {
+    const term = sf.isEnum() ? '>' : '/>'
+    return (`${QuickFixXmlFormatter.whitespace(ws)}<field number='${sf.tag}' name='${sf.name}' type='${sf.type}'${term}${newLine}`)
+  }
+
+  public static defineMessage (def: MessageDefinition, ws: number): string {
+    return `${QuickFixXmlFormatter.whitespace(ws)}<message name='${def.name}' msgcat='${def.category}' msgtype='${def.msgType}'>${newLine}`
+  }
+}

package/src/dictionary/version-util.ts

@@ -2,24 +2,15 @@ import { FixVersion } from './fix-versions'
 
 export abstract class VersionUtil {
   public static resolve (description: string): FixVersion {
-    let version: FixVersion = FixVersion.Unknown
-    if (description.includes('FIX.4.0')) {
-      version = FixVersion.FIX40
-    } else if (description.includes('FIX.4.1')) {
-      version = FixVersion.FIX41
-    } else if (description.includes('FIX.4.2')) {
-      version = FixVersion.FIX42
-    } else if (description.includes('FIX.4.3')) {
-      version = FixVersion.FIX43
-    } else if (description.includes('FIX.4.4')) {
-      version = FixVersion.FIX44
-    } else if (description.includes('FIX.5.0')) {
-      version = FixVersion.FIX50
-    } else if (description.includes('FIX.5.0SP1')) {
-      version = FixVersion.FIX50SP1
-    } else if (description.includes('FIX.5.0SP1')) {
-      version = FixVersion.FIX50SP2
-    }
-    return version
+    if (description === 'FIX.4.0') return FixVersion.FIX40
+    if (description === 'FIX.4.1') return FixVersion.FIX41
+    if (description === 'FIX.4.2') return FixVersion.FIX42
+    if (description === 'FIX.4.3') return FixVersion.FIX43
+    if (description === 'FIX.4.4') return FixVersion.FIX44
+    if (description === 'FIX.5.0') return FixVersion.FIX50
+    if (description === 'FIX.5.0SP1') return FixVersion.FIX50SP1
+    if (description === 'FIX.5.0SP2') return FixVersion.FIX50SP2
+    if (description === 'FIXML.5.0SP2') return FixVersion.FIXML50SP2
+    return FixVersion.Unknown
   }
 }

package/src/jsfix-cmd.ts

@@ -18,9 +18,140 @@ import { EnumCompiler, ICompilerSettings, MsgCompiler } from './dictionary/compi
 import { AsciiMsgTransmitter } from './transport/ascii/ascii-msg-transmitter'
 import { SessionContainer } from './runtime'
 import { DITokens } from './runtime/di-tokens'
+import buildOptions from 'minimist-options'
+import { Dictionary } from './collections'
+import { QuickFixXmlFileBuilder } from './dictionary/parser/quickfix/quick-fix-xml-file-builder'
+
 const fs = require('node-fs-extra')
 
-const argv: any = minimist(process.argv.slice(2))
+const options = buildOptions({
+  dict: {
+    type: 'string',
+    alias: 'd',
+    default: 'data/FIX44.xml'
+  },
+
+  type: {
+    type: 'string-array',
+    alias: 't'
+  },
+
+  fix: {
+    type: 'string',
+    alias: 'f',
+    default: 'data/FIX44.xml'
+  },
+
+  session: {
+    type: 'string',
+    alias: 's'
+  },
+
+  delimiter: {
+    type: 'string',
+    alias: 'l',
+    default: '|'
+  },
+
+  help: {
+    type: 'boolean',
+    alias: ['h'],
+    default: false
+  },
+
+  unit: {
+    type: 'boolean',
+    alias: ['u'],
+    default: false
+  },
+
+  generate: {
+    type: 'boolean',
+    alias: ['g'],
+    default: false
+  },
+
+  stats: {
+    type: 'boolean',
+    alias: ['st'],
+    default: false
+  },
+
+  tokens: {
+    type: 'boolean',
+    alias: ['t'],
+    default: false
+  },
+
+  objects: {
+    type: 'boolean',
+    alias: ['o'],
+    default: true
+  },
+
+  structures: {
+    type: 'boolean',
+    alias: ['r'],
+    default: false
+  },
+
+  script: {
+    type: 'boolean',
+    alias: ['i'],
+    default: false
+  },
+
+  compile: {
+    type: 'boolean',
+    alias: ['c'],
+    default: false
+  },
+
+  groups: {
+    type: 'boolean',
+    alias: ['g'],
+    default: true
+  },
+
+  density: {
+    type: 'number',
+    alias: 'd',
+    default: 0.8
+  },
+
+  repeats: {
+    type: 'number',
+    alias: 'r',
+    default: 1
+  },
+
+  arr: {
+    type: 'array',
+    alias: 'a',
+    default: []
+  }
+
+  /*
+  booleans: {
+    type: 'boolean-array',
+    alias: 'b',
+    default: [true, false]
+  },
+
+  numbers: {
+    type: 'number-array',
+    alias: 'n',
+    default: [0, 1]
+  },
+
+  published: 'boolean',
+
+  // Special option for positional arguments (`_` in minimist)
+  arguments: 'string'
+  */
+})
+
+const argv: any = minimist(process.argv.slice(2), options)
 
 enum PrintMode {
   Structure = 1,
@@ -38,7 +169,29 @@ enum Command {
   Encode = 4,
   Benchmark = 5,
   Compile = 6,
-  Unknown = 7
+  Trim,
+  Unknown = 8
+}
+
+class ParseSummary {
+  public readonly micros_per_msg: number
+  public readonly chars_per_second: number
+  public readonly fields_per_second: number
+  public readonly content_length: number
+
+  constructor (
+    public readonly content: string,
+    public readonly view: string,
+    public readonly msg_type: string,
+    public readonly iterations: number,
+    public readonly elapsed_ms: number,
+    public readonly fields: number
+  ) {
+    this.content_length = this.content.length
+    this.micros_per_msg = (this.elapsed_ms / this.iterations) * 1000
+    this.chars_per_second = Math.round(this.content_length * this.iterations / this.elapsed_ms * 1000)
+    this.fields_per_second = Math.round(this.fields * this.iterations / this.elapsed_ms * 1000)
+  }
 }
 
 export class JsfixCmd {
@@ -49,13 +202,15 @@ export class JsfixCmd {
   private sessionDescription: ISessionDescription
   private delimiter: number = AsciiChars.Soh
   private stats: ILooseObject = {}
-  private filter: string | null = null
+  private readonly filter: Dictionary<boolean> = new Dictionary<boolean>()
   private messages: number = 0
   private print: boolean = true
 
   private static getCommand (): Command {
     let command: Command = Command.Unknown
-    if (argv.compile) {
+    if (argv.trim) {
+      command = Command.Trim
+    } else if (argv.compile) {
       command = Command.Compile
     } else if (argv.generate) {
       command = Command.Generate
@@ -85,6 +240,8 @@ export class JsfixCmd {
       mode = PrintMode.Structure
     } else if (argv.encoded) {
       mode = PrintMode.Encoded
+    } else if (argv.trim) {
+      mode = PrintMode.Object
     }
     return mode
   }
@@ -133,7 +290,8 @@ export class JsfixCmd {
             // time how long to parse 10000 repeats of contents of file
             const repeats: number = !isNaN(argv.repeats) ? argv.repeats : 10000
             try {
-              await this.benchmark(repeats)
+              const summary = await this.benchmark(repeats)
+              console.log(JSON.stringify(summary, null, 4))
             } catch (e) {
               reject(e)
             }
@@ -155,6 +313,12 @@ export class JsfixCmd {
             break
           }
 
+          case Command.Trim: {
+            const xml = this.trim()
+            console.log(xml)
+            break
+          }
+
           case Command.Unknown:
           default: {
             actioned = false
@@ -299,6 +463,14 @@ export class JsfixCmd {
     await enumCompiler.generate(writeFile)
   }
 
+  private trim (): string {
+    this.setFilter()
+    const types = this.filter.count() > 0 ? this.filter.keys() : this.definitions.simple.get('MsgType')?.enums.keys() ?? []
+    const qfb = new QuickFixXmlFileBuilder(this.definitions)
+    qfb.write(types)
+    return qfb.elasticBuffer.toString()
+  }
+
   private async compile (): Promise<void> {
     let output = argv.output
     const dp = new DefinitionFactory().getDictPath(argv.dict)
@@ -339,10 +511,26 @@ export class JsfixCmd {
     }
   }
 
-  private async dispatch (ft: MsgTransport): Promise<any> {
+  private setFilter (): void {
+    const types: string[] = []
     if (argv.type != null) {
-      this.filter = argv.type.toString()
+      if (Array.isArray(argv.type)) {
+        argv.type.forEach((mt: any) => {
+          types.push(mt)
+        })
+      } else {
+        argv.type.split(',').forEach((mt: string) => {
+          types.push(mt)
+        })
+      }
+      types.forEach((mt: any) => {
+        this.filter.add(mt, true)
+      })
     }
+  }
+
+  private async dispatch (ft: MsgTransport): Promise<any> {
+    this.setFilter()
     let time: boolean = false
     if (argv.time || argv.stats) {
       this.print = false
@@ -367,7 +555,7 @@ export class JsfixCmd {
     // the receiver is message parser which is piped from an input stream - file, socket
     ft.receiver.on('msg', (msgType: string, m: AsciiView) => {
       if (filter) {
-        if (msgType !== filter) {
+        if (filter.containsKey(msgType)) {
           return
         }
       }
@@ -459,45 +647,43 @@ export class JsfixCmd {
     })
   }
 
-  async benchParse (contents: string, iterations: number, print: boolean): Promise<void> {
+  async benchParse (contents: string, iterations: number): Promise<ParseSummary> {
     return new Promise((resolve, reject) => {
-      const toParse = new StringDuplex(contents.repeat(iterations), false)
+      const toParse = new StringDuplex(contents.repeat(iterations))
       const startsAt: Date = new Date()
       let i = 0
       const config = this.config
       const buffer = config.sessionContainer.resolve<ElasticBuffer>(DITokens.ParseBuffer)
       const asciiParser: MsgParser = new AsciiParser(config, toParse.readable, buffer)
-      function printer (msgType: string, v: MsgView): void {
-        const elapsed: number = new Date().getTime() - startsAt.getTime()
-        console.log(contents)
-        console.log(v.toString())
-        console.log(`[${msgType}]: iterations = ${iterations}, fields = ${v?.structure?.tags.nextTagPos}, length = ${contents.length} chars, elapsed ms ${elapsed}, ${(elapsed / iterations) * 1000} micros per msg`)
-      }
       asciiParser.on('msg', (msgType: string, v: MsgView) => {
         ++i
         if (i === iterations) {
-          if (print) {
-            printer(msgType, v)
-          }
-          resolve()
+          const elapsed: number = new Date().getTime() - startsAt.getTime()
+          const fields = v?.structure?.tags.nextTagPos ?? 0
+          const summary = new ParseSummary(contents, v.toString(), msgType, iterations, elapsed, fields)
+          resolve(summary)
         }
       })
-      asciiParser.on('error', e => reject(e))
+      asciiParser.on('error', e => {
+        reject(e)
+      })
     })
   }
 
-  private async benchmark (repeats: number): Promise<any> {
+  private async benchmark (repeats: number): Promise<(ParseSummary | null)> {
     if (!argv.fix) {
       console.log('provide a path to fix file i.e. --fix=data/examples/execution-report/fix.txt')
-      return
+      return null
     }
     return await new Promise<any>((resolve, reject) => {
       const fix: string = this.norm(argv.fix)
       this.promisedRead(fix)
         .then(contents => {
-          this.benchParse(contents, repeats, true)
-            .then((a: any) => resolve(a))
-            .catch(e => reject(e))
+          this.benchParse(contents, repeats)
+            .then((a: ParseSummary) => {
+              resolve(a)
+            })
+            .catch(e => { reject(e) })
         }).catch(e => {
           reject(e)
         })
@@ -540,46 +726,49 @@ function showHelp (): void {
   console.log('npm run cmd -- --help')
   console.log()
 
+  console.log('print to console a trim quickfix format xml only including given message types')
+  console.log('node dist/jsfix-cmd  --dict=qf44 --trim --type="0,1,2,3,4,5,AE"')
+
   console.log('token format i.e. [602] 687 (LegQty) = 33589')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt --delimiter="|" --tokens')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt --delimiter="|" --tokens')
   console.log()
 
   console.log('token format use fix repo dictionary')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --fix=data/examples/quickfix/FIX.4.4/execution-report/fix.txt' +
     ' --delimiter="|" --tokens')
   console.log()
 
   console.log('structure format i.e. show locations of components etc.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --structures')
   console.log()
 
   console.log('full JS object in JSON format.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --objects')
   console.log()
 
   console.log('full JS object in JSON format - filter only type messages.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt' +
     ' --delimiter="|" --tokens --type=8 --objects')
   console.log()
 
   console.log('timing stats and message counts. Structured parsing of all messages.')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt --stats')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --fix=data/examples/FIX.4.4/quickfix/execution-report/fix.txt --stats')
   console.log()
 
   console.log('encode a json object to fix format')
-  console.log('jsfix-cmd --json=data/examples/FIX.4.4/quickfix/execution-report/object.json' +
+  console.log('node dist/jsfix-cmd --json=data/examples/FIX.4.4/quickfix/execution-report/object.json' +
     ' --session=data/session.json --type=8 --delimiter="|"')
   console.log()
 
   console.log('display field definition')
-  console.log('jsfix-cmd --dict=data/FIX44.xml --field=MsgType|35')
+  console.log('node dist/jsfix-cmd --dict=data/FIX44.xml --field=MsgType|35')
   console.log()
 
   console.log('display field use fix repo dictionary e.g. 271 MDEntrySize QTY Quantity or volume represented by the Market Data Entry.')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=MsgType')
-  console.log('jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=35')
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=MsgType')
+  console.log('node dist/jsfix-cmd --dict=data/fix_repo/FIX.4.4/Base --field=35')
   console.log()
 
   console.log('script to describe field in repository version 4.4')
@@ -591,21 +780,21 @@ function showHelp (): void {
   console.log()
 
   console.log('generate unit test set of files - i.e. randomly generate an object, encode to fix. density 1 is all fields')
-  console.log('jsfix-cmd --generate --type=AE --density=0.8 --unit --delimiter="|" --session=data/session/test-initiator.json')
+  console.log('node dist/jsfix-cmd --generate --type=AE --density=0.8 --unit --delimiter="|" --session=data/session/test-initiator.json')
   console.log('npm run repo44-unit -- --type=AE')
   console.log('test script with no repeat groups')
   console.log('npm run repo44-unit -- --type=AE --groups=false')
   console.log()
 
   console.log('generate a fix log of randomly generated but syntactically correct messages')
-  console.log('jsfix-cmd --generate --density=0.8 --repeats=50 --script --delimiter="|" --session=data/session/test-initiator.json')
+  console.log('node dist/jsfix-cmd --generate --density=0.8 --repeats=50 --script --delimiter="|" --session=data/session/test-initiator.json')
   console.log('npm run repo44-script')
   console.log('parse above generated script')
   console.log('npm run repo44-repscr')
   console.log()
 
   console.log('replay example repo fix file of 50 messages.')
-  console.log('jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/fix.txt --delimiter="|" --stats')
+  console.log('node dist/jsfix-cmd --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/fix.txt --delimiter="|" --stats')
   console.log('npm run repo44-replay -- --stats')
   console.log('npm run repo44-replay -- --objects')
   console.log('npm run repo44-replay -- --tokens')
@@ -613,7 +802,7 @@ function showHelp (): void {
   console.log()
 
   console.log('benchmark parse a message')
-  console.log('jsfix-cmd --delimiter="|" --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt --benchmark')
+  console.log('node dist/jsfix-cmd --delimiter="|" --session=data/session/test-initiator.json --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt --benchmark')
   console.log('npm run repo44-bench -- --fix=data/examples/FIX.4.4/repo/trade-capture-no-groups/fix.txt')
   console.log()
 
@@ -643,6 +832,6 @@ if (help) {
       showHelp()
     }
   }).catch((e: Error) => {
-    console.log(`error ${e.message}`)
+    console.error(e)
   })
 }

package/src/runtime/di-tokens.ts

@@ -1,4 +1,3 @@
-
 export enum DITokens {
   // the JSON representation defining header
   ISessionDescription = 'ISessionDescription',

package/src/runtime/session-launcher.ts

@@ -1,6 +1,6 @@
 import * as path from 'path'
 import { IJsFixConfig, IJsFixLogger, JsFixLoggerFactory, JsFixWinstonLogFactory, WinstonLogger } from '../config'
-import { ISessionDescription, FixEntity, FixSession } from '../transport'
+import { FixEntity, FixSession, ISessionDescription } from '../transport'
 import { DependencyContainer } from 'tsyringe'
 import { EngineFactory } from './engine-factory'
 import { SessionContainer } from './session-container'
@@ -11,13 +11,16 @@ const defaultLoggerFactory = new JsFixWinstonLogFactory(WinstonLogger.consoleOpt
 export abstract class SessionLauncher {
   public root: string = '../../'
   protected readonly logger: IJsFixLogger
-  public readonly initiatorConfig: ISessionDescription
+  public readonly initiatorConfig: ISessionDescription | null
   public readonly acceptorConfig: ISessionDescription | null
-  protected constructor (initiatorConfig: string | ISessionDescription,
+
+  protected constructor (
+    initiatorConfig: string | ISessionDescription | null = null,
     acceptorConfig: string | ISessionDescription | null = null,
-    private readonly loggerFactory: JsFixLoggerFactory = defaultLoggerFactory) {
+    private readonly loggerFactory: JsFixLoggerFactory = defaultLoggerFactory
+  ) {
     this.logger = this.loggerFactory.logger('launcher')
-    this.initiatorConfig = this.loadConfig(initiatorConfig)
+    this.initiatorConfig = initiatorConfig ? this.loadConfig(initiatorConfig) : null
     this.acceptorConfig = acceptorConfig ? this.loadConfig(acceptorConfig) : null
   }
 
@@ -54,6 +57,12 @@ export abstract class SessionLauncher {
     }
   }
 
+  /**
+   * provide a factory which will be invoked with a config where an instance of the application
+   * should be constructed and returned.
+   * @param config to be provided to the constucted application representing this session
+   * @protected
+   */
   protected makeFactory (config: IJsFixConfig): EngineFactory | null {
     return null
   }
@@ -80,15 +89,23 @@ export abstract class SessionLauncher {
     })
   }
 
+  /**
+   * is this session config representing an ascii based session
+   * @param description config to be tested.
+   */
   public isAscii (description: ISessionDescription): boolean {
     return this.sessionContainer.isAscii(description)
   }
 
+  /**
+   * is this session config representing an initiator based session
+   * @param description config to be tested.
+   */
   public isInitiator (description: ISessionDescription): boolean {
     return this.sessionContainer.isInitiator(description)
   }
 
-  protected registerApplication (sessionContainer: DependencyContainer): void {
+  protected registerApplication (_: DependencyContainer): void {
     this.logger.info('bypass register via DI')
   }
 
@@ -114,6 +131,7 @@ export abstract class SessionLauncher {
   }
 
   private async makeClient (): Promise<any> {
+    if (!this.initiatorConfig) return
     const sessionContainer = await this.makeSystem(this.initiatorConfig)
     this.register(sessionContainer)
     this.logger.info('create initiator')
@@ -129,13 +147,11 @@ export abstract class SessionLauncher {
   }
 
   async serverOrEmpty (): Promise<any> {
-    const server = this.acceptorConfig ? this.makeServer() : this.empty()
-    return server
+    return this.acceptorConfig ? this.makeServer() : this.empty()
   }
 
   async clientOrEmpty (): Promise<any> {
-    const client = this.initiatorConfig ? this.makeClient() : this.empty()
-    return client
+    return this.initiatorConfig ? this.makeClient() : this.empty()
   }
 
   private async setup (): Promise<any> {

package/src/sample/http/oms/http-client.ts

@@ -29,7 +29,7 @@ export class HttpClient extends FixmlSession {
       }
 
       case 'ExecRpt': {
-        const fill: (IExecutionReport|null) = view!.toObject() as IExecutionReport
+        const fill: (IExecutionReport | null) = view.toObject() as IExecutionReport
         this.logger.info(`received execution report ${fill?.OrderQtyData?.OrderQty}@${fill.Price}`)
         break
       }
@@ -37,11 +37,11 @@ export class HttpClient extends FixmlSession {
   }
 
   // use msgType for example to persist only trade capture messages to database
-  protected onDecoded (msgType: string, txt: string): void {
+  protected onDecoded (_: string, txt: string): void {
     this.fixLog.info(txt)
   }
 
-  protected onEncoded (msgType: string, txt: string): void {
+  protected onEncoded (_: string, txt: string): void {
     this.fixLog.info(txt)
   }
 
@@ -49,7 +49,7 @@ export class HttpClient extends FixmlSession {
     return true
   }
 
-  protected onReady (view: MsgView): void {
+  protected onReady (_: MsgView): void {
     this.logger.info('onReady')
     const logoutSeconds = this.logoutSeconds
     const req = this.factory.createOrder('IBM', Side.Buy, 10000, 100.12)