jsonresume-theme-engineering 0.6.2 → 0.7.0

package/README.md

@@ -1,6 +1,22 @@
 # jsonresume-theme-engineering [![](https://badge.fury.io/js/jsonresume-theme-engineering.svg)](https://www.npmjs.org/package/jsonresume-theme-engineering)
 
-This is the engineering theme for [JSON Resume](http://jsonresume.org/), based off of [jsonresume-theme-business-professional-compact](https://github.com/yechoorv/jsonresume-theme-business-professional-compact) and aims to implement the best practices for engineering resumes described in https://www.reddit.com/r/EngineeringResumes/wiki/index/. It is intended for [senior/staff level engineers](https://www.reddit.com/r/EngineeringResumes/wiki/index/#wiki_senior_engineers_and_above_.2810.2B_yoe.29).
+This is the engineering theme for [JSON Resume](http://jsonresume.org/), based on [jsonresume-theme-business-professional-compact](https://github.com/yechoorv/jsonresume-theme-business-professional-compact); it aims to implement the best practices for engineering resumes described in https://www.reddit.com/r/EngineeringResumes/wiki/index/.
+
+It is intended for [senior/staff level engineers](https://www.reddit.com/r/EngineeringResumes/wiki/index/#wiki_senior_engineers_and_above_.2810.2B_yoe.29), meaning engineers who already have a professional track record. Therefore, it is possible to group several positions at a company under a single heading in order to visualize promotions. Similarly, consulting work for several projects can be displayed for a consulting agency.
+
+This can be done by multiple work items with the same (company) name like this:
+```
+  "work": [
+    {
+      "name": "Stripe",
+      "position": "Staff Software Engineer",
+    },
+    {
+      "name": "Stripe",
+      "position": "Senior Software Engineer"
+    }
+  ]
+```
 
 <p align="center">
   <kbd>

package/index.js

@@ -33,10 +33,15 @@ Handlebars.registerHelper({
     return moment(date).format('MMM YYYY');
   },
 
-  getValueIfDiffFromPrevious: function (array, index, key) {
-    return array[index - 1] && array[index][key] === array[index - 1][key]
-      ? ''
-      : array[index][key];
+  getValueIfDiffFromPrevious: function (array, index, checkKey, returnKey) {
+    const current = array[index];
+    const previous = array[index - 1];
+
+    if (previous && previous[checkKey] === current[checkKey]) {
+      return '';
+    }
+
+    return current[typeof returnKey === 'string' ? returnKey : checkKey];
   },
 });
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsonresume-theme-engineering",
-  "version": "0.6.2",
+  "version": "0.7.0",
   "description": "JSON Resume theme for engineers",
   "keywords": [
     "jsonresume",

package/partials/item-details.hbs

@@ -1,9 +1,5 @@
 <div class="item-details">
-    {{#if location}}
-    <div class="item-details-title">
-        {{location}}
-    </div>
-    {{/if}}
+
     {{#if startDate}}
     {{#if endDate}}
     <div class="date">

package/partials/item-header.hbs

@@ -1,12 +1,24 @@
 <div class="item-header">
+    {{#if subtitle}}
     {{#if title}}
     <div class="item-header-title">
-        {{title}}
+        {{title}}{{#if location}}<span class="item-location">, {{location}}</span>{{/if}}
     </div>
     {{/if}}
-    {{#if subtitle}}
-    <div class="item-header-subtitle">
-        {{subtitle}}
+    <div class="item-header-subtitle-row">
+        <div class="item-header-subtitle">
+            {{subtitle}}
+        </div>
+        {{> item-details startDate=startDate endDate=endDate startDate2=startDate2 endDate2=endDate2}}
+    </div>
+    {{else}}
+    <div class="item-header-title-row">
+        {{#if title}}
+        <div class="item-header-title">
+            {{title}}{{#if location}}<span class="item-location">, {{location}}</span>{{/if}}
+        </div>
+        {{/if}}
+        {{> item-details startDate=startDate endDate=endDate startDate2=startDate2 endDate2=endDate2}}
     </div>
     {{/if}}
 </div>

package/partials/item.hbs

@@ -1,6 +1,5 @@
 <div class="item">
-    {{> item-header title=title subtitle=subtitle }}
-    {{> item-details location=location startDate=startDate endDate=endDate }}
+    {{> item-header title=title subtitle=subtitle location=location startDate=startDate endDate=endDate startDate2=startDate2 endDate2=endDate2}}
     <div class="clearfix"></div>
     {{> @partial-block }}
 </div>

package/style.css

@@ -44,7 +44,6 @@ a {
 }
 
 .item>.item-header {
-    float: left;
     display: block;
 }
 
@@ -52,16 +51,27 @@ a {
     font-weight: bold;
 }
 
-.item>.item-header>.item-header-subtitle {
+.item-location {
+    font-weight: normal;
+}
+
+.item-header-subtitle-row,
+.item-header-title-row {
+    display: flex;
+    justify-content: space-between;
+    align-items: baseline;
+}
+
+.item-header-subtitle-row>.item-header-subtitle {
     font-style: italic;
 }
 
-.item>.item-details {
-    float: right;
+.item-header .item-details {
     text-align: right;
+    flex-shrink: 0;
 }
 
-.item>.item-details>.item-details-title {
+.item-header .item-details>.item-details-title {
     font-weight: bold;
 }
 
@@ -91,6 +101,7 @@ a {
         size: portrait;
         margin: 10mm 25mm;
     }
+
     #resume {
         max-width: 100%;
         border: 0px;
@@ -98,13 +109,15 @@ a {
         box-shadow: none;
         -webkit-box-shadow: none;
     }
+
     body,
     html,
     #resume {
         margin: 0px;
         padding: 0px;
     }
+
     .controls {
         display: none;
     }
-}
+}

package/views/basics.hbs

@@ -11,8 +11,8 @@
         {{#if location~}}
         <span class="vertical-separator">{{location.city}}, {{location.countryCode}}</span>
         {{~/if}}
-        {{#if website~}}
-        <span class="vertical-separator">{{wrapURL website}}</span>
+        {{#if url~}}
+        <span class="vertical-separator">{{wrapURL url}}</span>
         {{~/if}}
     </div>
     {{#if summary}}

package/views/work.hbs

@@ -2,7 +2,7 @@
 <section id="work">
     <h2>Work Experience</h2>
     {{#each resume.work}}
-        {{#> item title=(getValueIfDiffFromPrevious @root.resume.work @index "company") subtitle=position location=location startDate=startDate endDate=endDate startDate2=startDate2 endDate2=endDate2}}
+        {{#> item title=(getValueIfDiffFromPrevious @root.resume.work @index "name") subtitle=position location=(getValueIfDiffFromPrevious @root.resume.work @index "name" "location") startDate=startDate endDate=endDate startDate2=startDate2 endDate2=endDate2}}
 
         {{#if highlights.length}}
         <ul class="highlights">

package/.nvmrc

@@ -1 +0,0 @@
-24.13.1

package/.prettierignore

@@ -1,3 +0,0 @@
-sample-resume.json
-resume.json
-renovate.json