json-rest-api 1.0.29 → 2.1.0

package/tests/searchschema-knex-behavior.test.js

@@ -1,187 +0,0 @@
-import { describe, it, before, beforeEach, after } from 'node:test'
-import assert from 'node:assert/strict'
-import knexLib from 'knex'
-import {
-  cleanTables,
-  createJsonApiDocument,
-} from './helpers/test-utils.js'
-import { storageMode } from './helpers/storage-mode.js'
-import { createSearchSchemaMergeApi } from './fixtures/api-configs.js'
-
-const maybeDescribe = storageMode.isAnyApi() ? describe.skip : describe
-
-// Create Knex instance for tests - always use SQLite in-memory
-const knex = knexLib({
-  client: 'better-sqlite3',
-  connection: {
-    filename: ':memory:'
-  },
-  useNullAsDefault: true
-})
-
-maybeDescribe('SearchSchema Merge Behavior (Knex execution)', () => {
-  let api
-
-  before(async () => {
-    api = await createSearchSchemaMergeApi(knex)
-  })
-
-  after(async () => {
-    await knex.destroy()
-  })
-
-  beforeEach(async () => {
-    await cleanTables(knex, ['searchmerge_products', 'searchmerge_users', 'searchmerge_orders'])
-  })
-
-  it('should use exact matching for search:true strings unless filterOperator is explicit', async () => {
-    const context = {}
-
-    await api.resources.users.post({
-      inputRecord: createJsonApiDocument('users', {
-        username: 'ann',
-        email: 'ann@example.com',
-        bio: 'Writes API guides'
-      })
-    }, context)
-
-    await api.resources.users.post({
-      inputRecord: createJsonApiDocument('users', {
-        username: 'anna',
-        email: 'anna@example.com',
-        bio: 'Writing API tutorials'
-      })
-    }, context)
-
-    const usernameResults = await api.resources.users.query({
-      queryParams: {
-        filters: {
-          username: 'ann'
-        }
-      }
-    }, context)
-
-    assert.equal(usernameResults.data.length, 1, 'search:true username should use exact matching')
-    assert.equal(usernameResults.data[0].attributes.username, 'ann')
-
-    const bioResults = await api.resources.users.query({
-      queryParams: {
-        filters: {
-          bio: 'Writ'
-        }
-      }
-    }, context)
-
-    assert.equal(bioResults.data.length, 2, 'explicit like operator should still support partial matching')
-  })
-
-  it('should allow filtering with merged searchSchema fields', async () => {
-    const context = {}
-
-    await api.resources.products.post({
-      inputRecord: createJsonApiDocument('products', {
-        name: 'Widget A',
-        description: 'A great widget',
-        price: 50,
-        sku: 'WGT-001',
-        status: 'active'
-      })
-    }, context)
-
-    await api.resources.products.post({
-      inputRecord: createJsonApiDocument('products', {
-        name: 'Widget B',
-        description: 'Another widget',
-        price: 150,
-        sku: 'WGT-002',
-        status: 'inactive'
-      })
-    }, context)
-
-    const nameResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          name: 'Widget A'
-        }
-      }
-    }, context)
-    assert.equal(nameResults.data.length, 1, 'Should find one product by name')
-    assert.equal(nameResults.data[0].attributes.name, 'Widget A')
-
-    const priceResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          price: [40, 60]
-        }
-      }
-    }, context)
-    assert.equal(priceResults.data.length, 1, 'Should find one product in price range')
-    assert.equal(priceResults.data[0].attributes.price, 50)
-
-    const statusResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          status: ['active']
-        }
-      }
-    }, context)
-    assert.equal(statusResults.data.length, 1, 'Should find one active product')
-    assert.equal(statusResults.data[0].attributes.status, 'active')
-
-    const skuResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          sku: 'WGT-002'
-        }
-      }
-    }, context)
-    assert.equal(skuResults.data.length, 1, 'Should find one product by SKU')
-    assert.equal(skuResults.data[0].attributes.sku, 'WGT-002')
-  })
-
-  it('should support arbitrary public filter keys when searchSchema maps them intentionally', async () => {
-    const context = {}
-
-    await api.resources.products.post({
-      inputRecord: createJsonApiDocument('products', {
-        name: 'Widget Alpha',
-        description: 'The great all-purpose widget',
-        price: 50,
-        sku: 'WGT-101',
-        status: 'active'
-      })
-    }, context)
-
-    await api.resources.products.post({
-      inputRecord: createJsonApiDocument('products', {
-        name: 'Widget Beta',
-        description: 'A quiet replacement unit',
-        price: 60,
-        sku: 'WGT-102',
-        status: 'inactive'
-      })
-    }, context)
-
-    const aliasResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          term: 'great'
-        }
-      }
-    }, context)
-
-    assert.equal(aliasResults.data.length, 1, 'term should be resolved by backend search mapping')
-    assert.equal(aliasResults.data[0].attributes.name, 'Widget Alpha')
-
-    const customResults = await api.resources.products.query({
-      queryParams: {
-        filters: {
-          availability: true
-        }
-      }
-    }, context)
-
-    assert.equal(customResults.data.length, 1, 'availability should be interpreted by backend custom filter logic')
-    assert.equal(customResults.data[0].attributes.status, 'active')
-  })
-})

package/tests/searchschema-merge.test.js

@@ -1,151 +0,0 @@
-import { describe, it, before, beforeEach, after } from 'node:test'
-import assert from 'node:assert/strict'
-import knexLib from 'knex'
-import {
-  cleanTables,
-} from './helpers/test-utils.js'
-import { createSearchSchemaMergeApi } from './fixtures/api-configs.js'
-import { generateSearchSchemaFromSchema } from '../plugins/core/lib/querying-writing/schema-helpers.js'
-
-// Create Knex instance for tests - always use SQLite in-memory
-const knex = knexLib({
-  client: 'better-sqlite3',
-  connection: {
-    filename: ':memory:'
-  },
-  useNullAsDefault: true
-})
-
-describe('SearchSchema Merge Behavior', () => {
-  let api
-
-  before(async () => {
-    // Create API instance once - NEVER in beforeEach
-    api = await createSearchSchemaMergeApi(knex)
-  })
-
-  after(async () => {
-    // Clean up - destroy connection
-    await knex.destroy()
-  })
-
-  beforeEach(async () => {
-    // Clean tables between tests
-    await cleanTables(knex, ['searchmerge_products', 'searchmerge_users', 'searchmerge_orders'])
-  })
-
-  it('should merge search:true fields with explicit searchSchema', async () => {
-    // First do a query to trigger schema compilation
-    await api.resources.products.query({
-      queryParams: {}
-    })
-
-    // Get the compiled searchSchema for products (has both search:true and searchSchema)
-    const scope = api.resources.products
-    const searchSchema = scope.vars.schemaInfo.searchSchemaInstance
-
-    // Verify searchSchema exists
-    assert.ok(searchSchema, 'searchSchema should exist')
-    assert.ok(searchSchema.structure, 'searchSchema should have structure')
-
-    // Check that search:true fields were added
-    assert.ok(searchSchema.structure.name, 'name field should be searchable')
-    assert.equal(searchSchema.structure.name.filterOperator || '=', '=', 'name should use default = operator')
-
-    assert.ok(searchSchema.structure.description, 'description field should be searchable')
-    assert.equal(searchSchema.structure.description.filterOperator || '=', '=', 'description should use default = operator')
-
-    assert.ok(searchSchema.structure.sku, 'sku field should be searchable')
-    assert.equal(searchSchema.structure.sku.filterOperator || '=', '=', 'sku should use default = operator')
-
-    // Check that explicit searchSchema fields override search:true
-    assert.ok(searchSchema.structure.price, 'price field should be searchable')
-    assert.equal(searchSchema.structure.price.filterOperator, 'between', 'price should use between operator from searchSchema')
-
-    // Check that arbitrary public filter keys are allowed when defined intentionally
-    assert.ok(searchSchema.structure.term, 'term alias should be searchable')
-    assert.deepEqual(searchSchema.structure.term.oneOf, ['name', 'description'], 'term should map to multiple fields')
-
-    // Check that virtual fields from searchSchema are present
-    assert.ok(searchSchema.structure.category_name, 'category_name virtual field should be searchable')
-    assert.equal(searchSchema.structure.category_name.filterOperator, 'like', 'category_name should use like operator')
-    assert.equal(searchSchema.structure.category_name.actualField, 'category.name', 'category_name should map to category.name')
-
-    assert.ok(searchSchema.structure.availability, 'availability custom filter should be searchable')
-    assert.equal(typeof searchSchema.structure.availability.applyFilter, 'function', 'availability should use custom backend logic')
-
-    // Check explicit searchSchema field not marked with search:true
-    assert.ok(searchSchema.structure.status, 'status field should be searchable from searchSchema')
-    assert.equal(searchSchema.structure.status.filterOperator, 'in', 'status should use in operator')
-
-    // Check that non-searchable fields are not included
-    assert.ok(!searchSchema.structure.category_id, 'category_id should not be searchable')
-  })
-
-  it('should work with only search:true fields (no explicit searchSchema)', async () => {
-    // First do a query to trigger schema compilation
-    await api.resources.users.query({
-      queryParams: {}
-    })
-
-    // Get the compiled searchSchema for users (only search:true fields)
-    const scope = api.resources.users
-    const searchSchema = scope.vars.schemaInfo.searchSchemaInstance
-
-    assert.ok(searchSchema, 'searchSchema should exist')
-    assert.ok(searchSchema.structure.username, 'username should be searchable')
-    assert.ok(searchSchema.structure.email, 'email should be searchable')
-    assert.ok(searchSchema.structure.bio, 'bio should be searchable')
-    assert.equal(searchSchema.structure.bio.filterOperator, 'like', 'bio should use like operator')
-    assert.ok(!searchSchema.structure.age, 'age should not be searchable')
-  })
-
-  it('should work with only explicit searchSchema (no search:true)', async () => {
-    // First do a query to trigger schema compilation
-    await api.resources.orders.query({
-      queryParams: {}
-    })
-
-    // Get the compiled searchSchema for orders (only explicit searchSchema)
-    const scope = api.resources.orders
-    const searchSchema = scope.vars.schemaInfo.searchSchemaInstance
-
-    assert.ok(searchSchema, 'searchSchema should exist')
-    assert.ok(searchSchema.structure.order_number, 'order_number should be searchable')
-    assert.ok(searchSchema.structure.status, 'status should be searchable')
-    assert.equal(searchSchema.structure.status.filterOperator, 'in', 'status should use in operator')
-    assert.ok(!searchSchema.structure.total, 'total should not be searchable')
-  })
-
-  it('should reject invalid filter keys that are not part of the public searchSchema contract', async () => {
-    await assert.rejects(
-      async () => {
-        await api.resources.products.query({
-          queryParams: {
-            filters: {
-              invalid_field: 'nope'
-            }
-          }
-        })
-      },
-      (error) => error?.code === 'REST_API_VALIDATION',
-      'Should reject fields that are not defined in searchSchema'
-    )
-  })
-
-  it('should keep canonical belongsTo field keys searchable alongside relationship aliases', () => {
-    const searchSchema = generateSearchSchemaFromSchema({
-      petId: {
-        type: 'id',
-        belongsTo: 'pets',
-        as: 'pet',
-        search: true
-      }
-    }, null)
-
-    assert.ok(searchSchema.pet, 'relationship alias should stay searchable')
-    assert.equal(searchSchema.pet.actualField, 'petId')
-    assert.ok(searchSchema.petId, 'canonical field key should stay searchable for parent filters')
-    assert.equal(searchSchema.petId.actualField, 'petId')
-  })
-})