jskelet 0.6.8 → 0.6.9

package/CHANGELOG.md

@@ -16,8 +16,10 @@ one is listed under a **Breaking** heading.
   `build.assets.upload`) is set, production `jskelet build` PutObjects
   `public/assets/` (and optional `include` dirs) to S3 after precompress.
   Credentials prefer standard `AWS_ACCESS_KEY_ID` / `AWS_SECRET_ACCESS_KEY` /
-  `AWS_SESSION_TOKEN`, then `JSKELET_S3_*`. Missing bucket or credentials fail
-  the build; watch mode never uploads. `.br` / `.gz` siblings are skipped.
+  `AWS_SESSION_TOKEN`, then `JSKELET_S3_*`. The Assets upload step always
+  appears on production builds; when off it logs a one-line reason
+  (`skipped (no JSKELET_ASSETS_BUCKET)`, `skipped (credentials missing)`, …).
+  Watch mode never uploads. `.br` / `.gz` siblings are skipped.
 
 ### Changed
 

package/docs/07-yapilandirma.md

@@ -638,10 +638,11 @@ değişmez** — asset'ler origin'den servis edilir.
 | `assets.upload.cacheControl` | `string` | `public, max-age=31536000, immutable` | PutObject `Cache-Control`. |
 
 Credential config'e yazılmaz. Öncelik: `AWS_ACCESS_KEY_ID` /
-`AWS_SECRET_ACCESS_KEY` / `AWS_SESSION_TOKEN`, yoksa `JSKELET_S3_*`. Upload açık
-iken bucket veya credential yoksa **build düşer**. Watch turunda upload yok.
-`.br` / `.gz` yüklenmez. Ayrıntı: [08-build.md](./08-build.md),
-[10-dagitim.md](./10-dagitim.md).
+`AWS_SECRET_ACCESS_KEY` / `AWS_SESSION_TOKEN`, yoksa `JSKELET_S3_*`. Production
+build'de Assets upload adımı her zaman görünür; kapalıysa
+`skipped (no JSKELET_ASSETS_BUCKET)` / `skipped (credentials missing)` gibi tek
+satır sebep basılır (build düşmez). Watch turunda adım yok. `.br` / `.gz`
+yüklenmez. Ayrıntı: [08-build.md](./08-build.md), [10-dagitim.md](./10-dagitim.md).
 
 ```js
 build: {

package/docs/08-build.md

@@ -20,7 +20,7 @@ davranışı burada. Çıktının çalışma anında nasıl servis edildiği
 5. Images         config.images !== false, watch değil ve sharp kurulu ise
 6. Manifest       .jskelet/manifest.json
 7. Precompress    watch değilse
-8. Assets upload  build.assets.upload açıksa (watch değil)
+8. Assets upload  watch değilse (kapalıysa `skipped (sebep)`)
 ```
 
 Şablon derlemesi asset taramasından **önce** biter; istek yolunda parse yoktur.
@@ -34,7 +34,8 @@ Sıra rastgele değil:
 - **Precompress, upload'tan hemen önce:** origin hâlâ `.br`/`.gz` üretir; S3
   adımı yalnızca ham dosyaları kopyalar.
 - **Görseller watch turunda hiç çalışmaz:** `sharp` ile yeniden kodlama pahalı.
-- **Assets upload watch'ta yok:** yalnızca production `jskelet build`.
+- **Assets upload watch'ta yok:** yalnızca production `jskelet build`; kapalıysa
+  yine satır basılır (`skipped (no JSKELET_ASSETS_BUCKET)` vb.).
 
 Görevler yalnızca ilgili yapılandırma varsa çalışır. Font tanımlamayan bir proje
 font adımını hiç görmez; bu, "framework her projeye kendi varsayımlarını

package/docs/10-dagitim.md

@@ -70,9 +70,9 @@ AWS_SECRET_ACCESS_KEY=…
 
 `jskelet build` bitince `public/assets/` (ve config'te `include` edilen
 dizinler) S3'e kopyalanır; origin'deki dosyalar da durur. Bucket veya
-credential eksikken upload açıksa build düşer. Watch / `jskelet dev` upload
-yapmaz. CSP kullanıyorsanız CDN origin'ini `script-src` / `style-src` /
-`img-src` ve `preconnect` listesine ekleyin.
+credential yoksa adım `skipped (…)` ile sebep basar, build devam eder. Watch /
+`jskelet dev` upload yapmaz. CSP kullanıyorsanız CDN origin'ini `script-src` /
+`style-src` / `img-src` ve `preconnect` listesine ekleyin.
 
 Production'da dosya veya S3 sink açıldığında HTTP access log middleware
 otomatik mount edilir (`logs.kinds` içinde `http` varsa). Admin paneli ring'i

package/docs/en/07-configuration.md

@@ -652,9 +652,12 @@ changes** — assets stay on the origin.
 
 Credentials are not written in the config. Preference order:
 `AWS_ACCESS_KEY_ID` / `AWS_SECRET_ACCESS_KEY` / `AWS_SESSION_TOKEN`, then
-`JSKELET_S3_*`. When upload is on, a missing bucket or credentials **fails the
-build**. No upload on watch passes. `.br` / `.gz` siblings are not uploaded.
-Details: [08-build.md](./08-build.md), [10-deployment.md](./10-deployment.md).
+`JSKELET_S3_*`. On a production build the Assets upload step always appears;
+when off it logs a one-line reason such as
+`skipped (no JSKELET_ASSETS_BUCKET)` or `skipped (credentials missing)` (the
+build does not fail). No upload on watch passes. `.br` / `.gz` siblings are not
+uploaded. Details: [08-build.md](./08-build.md),
+[10-deployment.md](./10-deployment.md).
 
 ```js
 build: {

package/docs/en/08-build.md

@@ -20,7 +20,7 @@ build is in [09-dev-tools.md](./09-dev-tools.md).
 5. Images         if config.images !== false, not watch, and sharp is installed
 6. Manifest       .jskelet/manifest.json
 7. Precompress    if not watch
-8. Assets upload  if build.assets.upload is on (not watch)
+8. Assets upload  if not watch (logs `skipped (reason)` when off)
 ```
 
 Template compilation finishes **before** asset scanning; there is no parse on
@@ -34,7 +34,8 @@ The order is not arbitrary:
 - **Precompress runs just before upload:** the origin still gets `.br`/`.gz`;
   the S3 step copies only the raw files.
 - **Images never run on a watch pass:** re-encoding with `sharp` is expensive.
-- **Assets upload never runs on watch:** only production `jskelet build`.
+- **Assets upload never runs on watch:** only production `jskelet build`; when
+  off the step still prints (`skipped (no JSKELET_ASSETS_BUCKET)`, etc.).
 
 Tasks only run if the relevant configuration exists. A project that does not
 define any fonts never sees the font step; this is the build-side counterpart of

package/docs/en/10-deployment.md

@@ -70,10 +70,10 @@ AWS_SECRET_ACCESS_KEY=…
 ```
 
 When `jskelet build` finishes, files under `public/assets/` (and any other
-`include` directories) are copied to S3; origin copies remain. If upload is on
-and the bucket or credentials are missing, the build fails. Watch /
-`jskelet dev` never upload. If you use CSP, add the CDN origin to
-`script-src` / `style-src` / `img-src` and to `preconnect`.
+`include` directories) are copied to S3; origin copies remain. If the bucket or
+credentials are missing, the step logs `skipped (…)` with the reason and the
+build continues. Watch / `jskelet dev` never upload. If you use CSP, add the CDN
+origin to `script-src` / `style-src` / `img-src` and to `preconnect`.
 
 When a file or S3 sink is enabled in production, the HTTP access log middleware
 mounts automatically (if `http` is in `logs.kinds`). The admin panel ring is

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jskelet",
-  "version": "0.6.8",
+  "version": "0.6.9",
   "description": "A framework that feels like no framework: Express 5 + build-time .jsk SSR (optional EJS peer), vanilla JS islands, Tailwind v4 and an in-process HTML TTL cache.",
   "type": "module",
   "license": "MIT",

package/src/build/build.mjs

@@ -110,8 +110,9 @@ if (!watch) {
   const { precompressAssets } = await import("./tasks/precompress.mjs");
   await task("Precompress", precompressAssets);
 
+  // Her production build'de satır görünür; kapalıysa `skipped (sebep)`.
   // CDN'e basılacak dosyalar precompress'ten sonra hazır; `.br`/`.gz` yüklenmez.
-  if (config.build?.assets?.upload?.enabled) {
+  {
     const { uploadAssets } = await import("./tasks/assets-upload.mjs");
     await task("Assets upload", () => uploadAssets(config));
   }

package/src/build/tasks/assets-upload.mjs

@@ -2,8 +2,8 @@
  * Production build sonunda hash'li varlıkları S3'e PutObject ile kopyalar.
  *
  * Watch turunda çalışmaz (çağıran sorumlu). Credential env'den gelir
- * (`AWS_*` önce, `JSKELET_S3_*` yedek). Bucket yoksa veya credential yoksa
- * build düşer — CDN prefix ile boş bucket'a deploy olmasın diye.
+ * (`AWS_*` önce, `JSKELET_S3_*` yedek). Bucket / credential yoksa veya upload
+ * kapalıysa adım yine görünür: `skipped (…)` ile sebep basılır, build düşmez.
  *
  * `.br` / `.gz` kardeşleri yüklenmez: edge kendi sıkıştırmasını yapsın;
  * origin precompress Express için kalır.
@@ -12,6 +12,7 @@ import fs from "node:fs";
 import path from "node:path";
 import { readS3CredentialsFromEnv } from "../../config/index.js";
 import { putObject } from "../../server/logs/s3-put.js";
+import * as log from "../../log.mjs";
 import { paths } from "../paths.mjs";
 
 const CONCURRENCY = 8;
@@ -87,27 +88,46 @@ function resolveIncludeDir(name) {
 }
 
 /**
+ * Upload yapılmayacaksa kısa sebep; yapılacaksa `null`.
+ *
  * @param {import('../../config/index.js').ResolvedConfig} config
- * @param {{ put?: typeof putObject }} [options]
- * @returns {Promise<string>} Özet satır (log.task için)
+ * @returns {string | null}
  */
-export async function uploadAssets(config, options = {}) {
+export function assetsUploadSkipReason(config) {
   const upload = config.build?.assets?.upload;
-  if (!upload?.enabled) return "skipped";
 
-  if (!upload.bucket) {
-    throw new Error(
-      "[assets] upload enabled but no bucket — set JSKELET_ASSETS_BUCKET " +
-        "or build.assets.upload.bucket",
-    );
+  if (!upload?.enabled) {
+    // Bucket yoksa asıl eksik env'i söyle — `enabled: false` çoğu zaman
+    // bucket tanımlanmadığı için dolaylıdır.
+    if (!upload?.bucket) return "no JSKELET_ASSETS_BUCKET";
+    return "build.assets.upload.enabled is false";
+  }
+
+  if (!upload.bucket) return "no JSKELET_ASSETS_BUCKET";
+
+  if (!readS3CredentialsFromEnv()) return "credentials missing";
+
+  return null;
+}
+
+/**
+ * @param {import('../../config/index.js').ResolvedConfig} config
+ * @param {{ put?: typeof putObject }} [options]
+ * @returns {Promise<void>}
+ */
+export async function uploadAssets(config, options = {}) {
+  const reason = assetsUploadSkipReason(config);
+  if (reason) {
+    log.detail(`skipped (${reason})`);
+    return;
   }
 
+  const upload = config.build.assets.upload;
   const credentials = readS3CredentialsFromEnv();
-  if (!credentials) {
-    throw new Error(
-      "[assets] upload enabled but credentials missing — set " +
-        "AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY or JSKELET_S3_*",
-    );
+  // skipReason null iken credential ve bucket vardır; TS/akış için daralt.
+  if (!upload.bucket || !credentials) {
+    log.detail("skipped (credentials missing)");
+    return;
   }
 
   const put = options.put ?? putObject;
@@ -131,7 +151,10 @@ export async function uploadAssets(config, options = {}) {
     }
   }
 
-  if (!jobs.length) return "0 files";
+  if (!jobs.length) {
+    log.detail("0 files");
+    return;
+  }
 
   let uploaded = 0;
   let index = 0;
@@ -163,5 +186,5 @@ export async function uploadAssets(config, options = {}) {
 
   const target = `${upload.bucket}/${keyPrefix}`.replace(/\/+/g, "/");
   const via = upload.endpoint ? ` @ ${upload.endpoint}` : "";
-  return `${uploaded} → s3://${target}${via}`;
+  log.detail(`${uploaded} → s3://${target}${via}`);
 }