jsii-pacmak 1.63.2 → 1.65.1

package/lib/targets/python.js

@@ -26,7 +26,7 @@ const DOCSTRING_QUOTES = "'''";
 class Python extends target_1.Target {
     constructor(options) {
         super(options);
-        this.generator = new PythonGenerator(options.rosetta);
+        this.generator = new PythonGenerator(options.rosetta, options);
     }
     async generateCode(outDir, tarball) {
         await super.generateCode(outDir, tarball);
@@ -394,6 +394,7 @@ class BaseMethod {
                     const paramType = (0, type_name_1.toTypeName)(prop.prop).pythonType({
                         ...context,
                         parameterType: true,
+                        typeAnnotation: true,
                     });
                     const paramDefault = prop.prop.optional ? ' = None' : '';
                     pythonParams.push(`${paramName}: ${paramType}${paramDefault}`);
@@ -419,7 +420,6 @@ class BaseMethod {
         }
         const decorators = new Array();
         if (this.jsName !== undefined) {
-            // "# type: ignore[misc]" needed because mypy does not know how to check decorated declarations
             decorators.push(`@jsii.member(jsii_name="${this.jsName}")`);
         }
         if (this.decorator !== undefined) {
@@ -429,22 +429,19 @@ class BaseMethod {
             decorators.push('@abc.abstractmethod');
         }
         if (decorators.length > 0) {
-            // "# type: ignore[misc]" needed because mypy does not know how to check decorated declarations
-            for (const decorator of decorators
-                .join(' # type: ignore[misc]\n')
-                .split('\n')) {
+            for (const decorator of decorators) {
                 code.line(decorator);
             }
         }
         pythonParams.unshift(slugifyAsNeeded(this.implicitParameter, pythonParams.map((param) => param.split(':')[0].trim())));
-        openSignature(code, 'def', this.pythonName, pythonParams, false, returnType);
+        openSignature(code, 'def', this.pythonName, pythonParams, returnType);
         this.generator.emitDocString(code, this.apiLocation, this.docs, {
             arguments: documentableArgs,
             documentableItem: `method-${this.pythonName}`,
         });
         if ((this.shouldEmitBody || forceEmitBody) &&
             (!renderAbstract || !this.abstract)) {
-            emitParameterTypeChecks(code, pythonParams.slice(1), `${(0, type_name_1.toPythonFullName)(this.parent.fqn, context.assembly)}.${this.pythonName}`);
+            emitParameterTypeChecks(code, context, pythonParams.slice(1), `${(0, type_name_1.toPythonFullName)(this.parent.fqn, context.assembly)}.${this.pythonName}`);
         }
         this.emitBody(code, context, renderAbstract, forceEmitBody, liftedPropNames, pythonParams[0], returnType);
         code.closeBlock();
@@ -567,13 +564,17 @@ class BaseProperty {
     emit(code, context, opts) {
         const { renderAbstract = true, forceEmitBody = false } = opts ?? {};
         const pythonType = (0, type_name_1.toTypeName)(this.type).pythonType(context);
-        // "# type: ignore[misc]" is needed because mypy cannot check decorated things
-        code.line(`@${this.decorator} # type: ignore[misc]`);
+        code.line(`@${this.decorator}`);
         code.line(`@jsii.member(jsii_name="${this.jsName}")`);
         if (renderAbstract && this.abstract) {
             code.line('@abc.abstractmethod');
         }
-        openSignature(code, 'def', this.pythonName, [this.implicitParameter], true, pythonType);
+        openSignature(code, 'def', this.pythonName, [this.implicitParameter], pythonType, 
+        // PyRight and MyPY both special-case @property, but not custom implementations such as our @classproperty...
+        // MyPY reports on the re-declaration, but PyRight reports on the initial declaration (duh!)
+        this.isStatic && !this.immutable
+            ? 'pyright: ignore [reportGeneralTypeIssues]'
+            : undefined);
         this.generator.emitDocString(code, this.apiLocation, this.docs, {
             documentableItem: `prop-${this.pythonName}`,
         });
@@ -588,14 +589,16 @@ class BaseProperty {
         code.closeBlock();
         if (!this.immutable) {
             code.line();
+            // PyRight and MyPY both special-case @property, but not custom implementations such as our @classproperty...
+            // MyPY reports on the re-declaration, but PyRight reports on the initial declaration (duh!)
             code.line(`@${this.pythonName}.setter${this.isStatic ? ' # type: ignore[no-redef]' : ''}`);
             if (renderAbstract && this.abstract) {
                 code.line('@abc.abstractmethod');
             }
-            openSignature(code, 'def', this.pythonName, [this.implicitParameter, `value: ${pythonType}`], false, 'None');
+            openSignature(code, 'def', this.pythonName, [this.implicitParameter, `value: ${pythonType}`], 'None');
             if ((this.shouldEmitBody || forceEmitBody) &&
                 (!renderAbstract || !this.abstract)) {
-                emitParameterTypeChecks(code, [`value: ${pythonType}`], 
+                emitParameterTypeChecks(code, context, [`value: ${pythonType}`], 
                 // In order to get a property accessor, we must resort to getting the
                 // attribute on the type, instead of the value (where the getter would
                 // be implicitly invoked for us...)
@@ -732,7 +735,7 @@ class Struct extends BasePythonClassType {
         const constructorArguments = kwargs.length > 0
             ? [implicitParameter, '*', ...kwargs]
             : [implicitParameter];
-        openSignature(code, 'def', '__init__', constructorArguments, false, 'None');
+        openSignature(code, 'def', '__init__', constructorArguments, 'None');
         this.emitConstructorDocstring(code);
         // Re-type struct arguments that were passed as "dict". Do this before validating argument types...
         for (const member of members.filter((m) => m.isStruct(this.generator))) {
@@ -745,7 +748,7 @@ class Struct extends BasePythonClassType {
             code.line(`${member.pythonName} = ${typeName}(**${member.pythonName})`);
             code.closeBlock();
         }
-        emitParameterTypeChecks(code, kwargs, `${(0, type_name_1.toPythonFullName)(this.spec.fqn, context.assembly)}.__init__`);
+        emitParameterTypeChecks(code, context, kwargs, `${(0, type_name_1.toPythonFullName)(this.spec.fqn, context.assembly)}.__init__`);
         // Required properties, those will always be put into the dict
         assignDictionary(code, `${implicitParameter}._values: typing.Dict[str, typing.Any]`, members
             .filter((m) => !m.optional)
@@ -772,7 +775,7 @@ class Struct extends BasePythonClassType {
     emitGetter(member, code, context) {
         const pythonType = member.typeAnnotation(context);
         code.line('@builtins.property');
-        openSignature(code, 'def', member.pythonName, ['self'], true, pythonType);
+        openSignature(code, 'def', member.pythonName, ['self'], pythonType);
         member.emitDocString(code);
         // NOTE: No parameter to validate here, this is a getter.
         code.line(`result = self._values.get(${JSON.stringify(member.pythonName)})`);
@@ -1483,6 +1486,12 @@ class Package {
             .reduce((buildTools, entry) => (entry ? [...buildTools, entry] : buildTools), new Array());
         code.line(`requires = [${buildTools.map((x) => `"${x}"`).join(', ')}]`);
         code.line('build-backend = "setuptools.build_meta"');
+        code.line();
+        code.line('[tool.pyright]');
+        code.line('defineConstant = { DEBUG = true }');
+        code.line('pythonVersion = "3.7"');
+        code.line('pythonPlatform = "All"');
+        code.line('reportSelfClsParameterName = false');
         code.closeFile('pyproject.toml');
         // We also need to write out a MANIFEST.in to ensure that all of our required
         // files are included.
@@ -1575,7 +1584,7 @@ class TypeResolver {
     }
 }
 class PythonGenerator extends generator_1.Generator {
-    constructor(rosetta, options = {}) {
+    constructor(rosetta, options) {
         super(options);
         this.rosetta = rosetta;
         this.code.openBlockFormatter = (s) => `${s}:`;
@@ -1723,6 +1732,7 @@ class PythonGenerator extends generator_1.Generator {
             assembly: assm,
             emittedTypes: new Set(),
             resolver,
+            runtimeTypeChecking: this.runtimeTypeChecking,
             submodule: assm.name,
             typeResolver: (fqn) => resolver.dereference(fqn),
         });
@@ -1972,7 +1982,7 @@ function slugifyAsNeeded(name, inUse) {
 //
 // @see https://black.readthedocs.io/en/stable/the_black_code_style.html
 const TARGET_LINE_LENGTH = 88;
-function openSignature(code, keyword, name, params, trailingComma = false, returnType) {
+function openSignature(code, keyword, name, params, returnType, lineComment) {
     const prefix = `${keyword} ${name}`;
     const suffix = returnType ? ` -> ${returnType}` : '';
     if (params.length === 0) {
@@ -1981,8 +1991,8 @@ function openSignature(code, keyword, name, params, trailingComma = false, retur
     }
     const join = ', ';
     const { elementsSize, joinSize } = totalSizeOf(params, join);
-    const hasComments = !params.some((param) => /# .+$/.exec(param));
-    if (hasComments &&
+    const hasComments = params.some((param) => /#\s*.+$/.exec(param) != null);
+    if (!hasComments &&
         TARGET_LINE_LENGTH >
             code.currentIndentLength +
                 prefix.length +
@@ -1990,25 +2000,15 @@ function openSignature(code, keyword, name, params, trailingComma = false, retur
                 joinSize +
                 suffix.length +
                 2) {
-        code.openBlock(`${prefix}(${params.join(join)})${suffix}`);
+        code.indent(`${prefix}(${params.join(join)})${suffix}:${lineComment ? `  # ${lineComment}` : ''}`);
         return;
     }
     code.indent(`${prefix}(`);
-    if (!hasComments &&
-        TARGET_LINE_LENGTH >
-            code.currentIndentLength +
-                elementsSize +
-                joinSize +
-                (trailingComma ? 1 : 0)) {
-        code.line(`${params.join(join)}${trailingComma ? ',' : ''}`);
-    }
-    else {
-        for (const param of params) {
-            code.line(param.replace(/(\s*# .+)?$/, ',$1'));
-        }
+    for (const param of params) {
+        code.line(param.replace(/(\s*# .+)?$/, ',$1'));
     }
     code.unindent(false);
-    code.openBlock(`)${suffix}`);
+    code.indent(`)${suffix}:${lineComment ? `  # ${lineComment}` : ''}`);
 }
 /**
  * Emits runtime type checking code for parameters.
@@ -2017,9 +2017,12 @@ function openSignature(code, keyword, name, params, trailingComma = false, retur
  * @param params      the parameter signatures to be type-checked.
  * @param typedEntity the type-annotated entity.
  */
-function emitParameterTypeChecks(code, params, typedEntity) {
+function emitParameterTypeChecks(code, context, params, typedEntity) {
+    if (!context.runtimeTypeChecking) {
+        return;
+    }
     const paramInfo = params.map((param) => {
-        const [name] = param.split(/\s*[:=]\s*/, 1);
+        const [name] = param.split(/\s*[:=#]\s*/, 1);
         if (name === '*') {
             return { kwargsMark: true };
         }
@@ -2044,11 +2047,14 @@ function emitParameterTypeChecks(code, params, typedEntity) {
             openedBlock = true;
         }
         let expectedType = `${typesVar}[${JSON.stringify(name)}]`;
+        let comment = '';
         if (is_rest) {
             // This is a vararg, so the value will appear as a tuple.
             expectedType = `typing.Tuple[${expectedType}, ...]`;
+            // Need to ignore reportGeneralTypeIssues because pyright incorrectly parses that as a type annotation 😒
+            comment = ' # pyright: ignore [reportGeneralTypeIssues]';
         }
-        code.line(`check_type(argname=${JSON.stringify(`argument ${name}`)}, value=${name}, expected_type=${expectedType})`);
+        code.line(`check_type(argname=${JSON.stringify(`argument ${name}`)}, value=${name}, expected_type=${expectedType})${comment}`);
     }
     if (openedBlock) {
         code.closeBlock();

package/lib/targets/version-utils.js

@@ -72,7 +72,7 @@ exports.toPythonVersionRange = toPythonVersionRange;
  * @returns the version that should be serialized
  */
 function toReleaseVersion(assemblyVersion, target) {
-    const version = (0, semver_1.parse)(assemblyVersion, { includePrerelease: true });
+    const version = (0, semver_1.parse)(assemblyVersion);
     if (version == null) {
         throw new Error(`Unable to parse the provided assembly version: "${assemblyVersion}"`);
     }

package/lib/version.d.ts

@@ -1,5 +1,5 @@
 /** The short version number for this JSII compiler (e.g: `X.Y.Z`) */
-export declare const VERSION = "1.63.2";
+export declare const VERSION = "1.65.1";
 /** The qualified version number for this JSII compiler (e.g: `X.Y.Z (build #######)`) */
-export declare const VERSION_DESC = "1.63.2 (build a8a8833)";
+export declare const VERSION_DESC = "1.65.1 (build b0947e4)";
 //# sourceMappingURL=version.d.ts.map

package/lib/version.js

@@ -1,9 +1,9 @@
 "use strict";
-// Generated at 2022-07-29T15:35:51Z by generate.sh
+// Generated at 2022-08-29T17:36:17Z by generate.sh
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.VERSION_DESC = exports.VERSION = void 0;
 /** The short version number for this JSII compiler (e.g: `X.Y.Z`) */
-exports.VERSION = '1.63.2';
+exports.VERSION = '1.65.1';
 /** The qualified version number for this JSII compiler (e.g: `X.Y.Z (build #######)`) */
-exports.VERSION_DESC = '1.63.2 (build a8a8833)';
+exports.VERSION_DESC = '1.65.1 (build b0947e4)';
 //# sourceMappingURL=version.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsii-pacmak",
-  "version": "1.63.2",
+  "version": "1.65.1",
   "description": "A code generation framework for jsii backend languages",
   "license": "Apache-2.0",
   "author": {
@@ -37,32 +37,35 @@
     "package": "package-js"
   },
   "dependencies": {
-    "@jsii/check-node": "1.63.2",
-    "@jsii/spec": "^1.63.2",
+    "@jsii/check-node": "1.65.1",
+    "@jsii/spec": "^1.65.1",
     "clone": "^2.1.2",
-    "codemaker": "^1.63.2",
+    "codemaker": "^1.65.1",
     "commonmark": "^0.30.0",
     "escape-string-regexp": "^4.0.0",
     "fs-extra": "^10.1.0",
-    "jsii-reflect": "^1.63.2",
-    "jsii-rosetta": "^1.63.2",
+    "jsii-reflect": "^1.65.1",
+    "jsii-rosetta": "^1.65.1",
     "semver": "^7.3.7",
     "spdx-license-list": "^6.6.0",
     "xmlbuilder": "^15.1.1",
     "yargs": "^16.2.0"
   },
   "devDependencies": {
-    "@jsii/dotnet-runtime": "^1.63.2",
-    "@jsii/java-runtime": "^1.63.2",
-    "@jsii/go-runtime": "^1.63.2",
-    "@scope/jsii-calc-lib": "^1.63.2",
+    "@jsii/dotnet-runtime": "^1.65.1",
+    "@jsii/java-runtime": "^1.65.1",
+    "@jsii/go-runtime": "^1.65.1",
+    "@scope/jsii-calc-lib": "^1.65.1",
     "@types/clone": "^2.1.1",
+    "@types/diff": "^5.0.2",
     "@types/commonmark": "^0.27.5",
     "@types/fs-extra": "^9.0.13",
     "@types/semver": "^7.3.10",
-    "jsii": "^1.63.2",
-    "jsii-build-tools": "^1.63.2",
-    "jsii-calc": "^3.20.120"
+    "diff": "^5.1.0",
+    "jsii": "^1.65.1",
+    "jsii-build-tools": "^1.65.1",
+    "jsii-calc": "^3.20.120",
+    "pyright": "^1.1.266"
   },
   "keywords": [
     "jsii",