jsharmony-cms 1.5.6 → 1.7.1

package/clientjs/component/dialogs/dialog.js

@@ -38,7 +38,7 @@ var OverlayService = require('./overlayService');
 
 
 
-  /**
+/**
   * Called when the dialog wants to accept/save the changes
   * @callback Dialog~acceptCallback
   * @param {Function} successFunc - Call this function if successfully accepted (e.g., no data errors; valid save).
@@ -73,7 +73,7 @@ var OverlayService = require('./overlayService');
  * @param {Function} cancelFunc - Call this function to trigger cancel logic
  */
 
- /**
+/**
   * @class
   * @param {Object} jsh
   * @param {Object} cms
@@ -92,7 +92,7 @@ function Dialog(jsh, cms, model, config) {
 
   this.overlayService = new OverlayService(this);
 
-  this._jsh.$(this._jsh.root).append(this._$wrapper)
+  this._jsh.$(this._jsh.root).append(this._$wrapper);
 
   /**
    * @public
@@ -142,7 +142,7 @@ Dialog.prototype.destroy = function() {
   if (this._$overlay) this._$overlay.remove();
   delete Dialog._idLookup[this._id];
   this._destroyed = true;
-}
+};
 
 /**
  * Get a CSS selector that can be used to find
@@ -152,7 +152,7 @@ Dialog.prototype.destroy = function() {
  */
 Dialog.prototype.getFormSelector = function() {
   return  '.xdialogbox.' + this._id;
-}
+};
 
 /**
  * Get a globally unique (W.R.T this dialog class)
@@ -170,7 +170,7 @@ Dialog.prototype.getNextId = function() {
   } while (!id);
   Dialog._idLookup[id] = true;
   return id;
-}
+};
 
 /**
  * Get the scroll top position for the page.
@@ -180,7 +180,7 @@ Dialog.prototype.getNextId = function() {
  */
 Dialog.prototype.getScrollTop = function($wrapper) {
   return $wrapper.scrollParent().scrollTop();
-}
+};
 
 /**
  * @private
@@ -190,7 +190,7 @@ Dialog.prototype.load = function(callback) {
   this._jsh.XPage.LoadVirtualModel(_this._jsh.$(_this.getFormSelector()), this._model, function(xmodel) {
     callback(xmodel);
   });
-}
+};
 
 /**
  * Create the dialog elements and append to the body DOM.
@@ -216,7 +216,7 @@ Dialog.prototype.makeDialog = function(id, config) {
     .append($form);
 
   return $wrapper;
-}
+};
 
 /**
  * @public
@@ -230,14 +230,12 @@ Dialog.prototype.open = function() {
   var _this = this;
   var formSelector = this.getFormSelector();
   var oldActive = document.activeElement;
-  var hasToolbarOffset = !!_this._cms.editor.getOffsetTop();
-  var wasAtTop = !_this._jsh.$(document).scrollTop();
 
   this.load(function(xmodel) {
 
     var $wrapper = _this._jsh.$(formSelector);
     _this.registerLovs(xmodel);
-    var lastScrollTop = 0
+    var lastScrollTop = 0;
     _this._jsh.XExt.execif(_this.onBeforeOpen,
       function(f){
         _this.onBeforeOpen(xmodel, f);
@@ -280,7 +278,7 @@ Dialog.prototype.open = function() {
       }
     );
   });
-}
+};
 
 /**
  * Register the LOVs defined in the model.
@@ -304,7 +302,7 @@ Dialog.prototype.registerLovs = function(xmodel) {
       xmodel.controller.setLOV(field.name, lovs);
     }
   });
-}
+};
 
 /**
  * Set the scroll top position for the page.
@@ -314,6 +312,6 @@ Dialog.prototype.registerLovs = function(xmodel) {
  */
 Dialog.prototype.setScrollTop = function(position, $wrapper) {
   $wrapper.scrollParent().scrollTop(position);
-}
+};
 
 exports = module.exports = Dialog;

package/clientjs/component/dialogs/dialogResizer.js

@@ -72,7 +72,7 @@ DialogResizer.addIntervalCallback = function(cb) {
     this._intervalId = setInterval(function() {
       _.forEach(DialogResizer._intervalCallbacks, function(item) { item.cb(); });
     }, 100);
-  };
+  }
 
   return function() {
     var index = DialogResizer._intervalCallbacks.findIndex(function(item) { return item.id === id; });
@@ -83,8 +83,8 @@ DialogResizer.addIntervalCallback = function(cb) {
       clearInterval(DialogResizer._intervalId);
       DialogResizer._intervalId = undefined;
     }
-  }
-}
+  };
+};
 
 /**
  * This must be called when the dialog is closed
@@ -95,7 +95,7 @@ DialogResizer.prototype.closeDialog = function() {
   if (this._execCleanUp) {
     this._execCleanUp();
   }
-}
+};
 
 /**
  * Perform the resize on the given element.
@@ -104,7 +104,7 @@ DialogResizer.prototype.closeDialog = function() {
  */
 DialogResizer.prototype.resize = function(wrapper) {
   this._jsh.XWindowResize();
-}
+};
 
 /**
  * Use a interval resize strategy to resize the dialog.
@@ -118,7 +118,7 @@ DialogResizer.prototype.startIntervalResize = function(wrapper) {
   this._execCleanUp = DialogResizer.addIntervalCallback(function() {
     _this.resize(wrapper);
   });
-}
+};
 
 /**
  * Use a MutationObserver resize strategy to resize the dialog.
@@ -135,8 +135,8 @@ DialogResizer.prototype.startMutationObserver = function(wrapper) {
   observer.observe(wrapper, { childList: true, subtree: true });
   this._execCleanUp = function() {
     observer.disconnect();
-  }
-}
+  };
+};
 
 /**
  * Use a ResizeObserver resize strategy to resize the dialog.
@@ -147,12 +147,12 @@ DialogResizer.prototype.startMutationObserver = function(wrapper) {
 DialogResizer.prototype.startResizeObserver = function(wrapper) {
   var _this = this;
   var observer = new ResizeObserver(function() {
-      _this.resize(wrapper);
+    _this.resize(wrapper);
   });
   observer.observe(wrapper);
   this._execCleanUp = function() {
     observer.unobserve(wrapper);
-  }
-}
+  };
+};
 
 exports = module.exports = DialogResizer;

package/clientjs/component/dialogs/formDialog.js

@@ -148,7 +148,7 @@ FormDialog.prototype.augmentModel = function(model, config) {
   model.fields = newFields.length > 0 ? (model.fields || []).concat(newFields) : model.fields;
   model.buttons = newButtons.length > 0 ? (model.buttons || []).concat(newButtons) : model.buttons;
   return model;
-}
+};
 
 /**
  * Open the form  dialog
@@ -190,7 +190,7 @@ FormDialog.prototype.open = function(data) {
         controller.Render(data, undefined, onComplete);
       }
     );
-  }
+  };
 
 
   dialog.onOpened = function(_$dialog, _xmodel, acceptFunc, cancelFunc) {
@@ -199,13 +199,13 @@ FormDialog.prototype.open = function(data) {
     $dialog.find('.save_button.xelem' + xmodel.id).off('click').on('click', acceptFunc).on('click', function(e){ e.preventDefault(); });
     $dialog.find('.cancel_button.xelem' + xmodel.id).off('click').on('click', cancelFunc).on('click', function(e){ e.preventDefault(); });
     if (_.isFunction(_this.onOpened)) _this.onOpened($dialog, xmodel);
-  }
+  };
 
   // This callback is called when trying to set/save the data.
   dialog.onAccept = function(success) {
     var isSuccess = _.isFunction(_this.onAccept) && _this.onAccept($dialog, xmodel);
     if (isSuccess) success();
-  }
+  };
 
   dialog.onCancel = function(options) {
     if (!options.force && xmodel.controller.HasUpdates()) {
@@ -221,18 +221,18 @@ FormDialog.prototype.open = function(data) {
       }
       return false;
     }
-  }
+  };
 
   // This is the final callback to be called and is
   // called anytime (whether accepted or canceled) the
   // dialog closes.
   dialog.onClose = function() {
-    controller.form.Prop.Enabled = false
+    controller.form.Prop.Enabled = false;
     if (_.isFunction(_this.onClose)) _this.onClose($dialog, xmodel);
-  }
+  };
 
   dialog.open();
-}
+};
 
 
 exports = module.exports = FormDialog;

package/clientjs/component/dialogs/gridDialog.js

@@ -127,7 +127,7 @@ GridDialog.prototype.open = function() {
         if(onComplete) onComplete();
       }
     );
-  }
+  };
 
   dialog.onOpened = function(_$dialog, _xmodel, acceptFunc, cancelFunc) {
     $dialog = _$dialog;
@@ -135,7 +135,7 @@ GridDialog.prototype.open = function() {
     controller.Render(function() {
       if (_.isFunction(_this.onOpened)) _this.onOpened(_$dialog, xmodel);
     });
-  }
+  };
 
   dialog.onCancel = function(options) {
     if (!options.force && controller.HasUpdates()) {
@@ -145,14 +145,14 @@ GridDialog.prototype.open = function() {
       });
       return false;
     }
-  }
+  };
 
   dialog.onClose = function() {
     controller.grid.Prop.Enabled = false;
     if (_.isFunction(_this.onClose)) _this.onClose($dialog, xmodel);
-  }
+  };
 
   dialog.open();
-}
+};
 
 exports = module.exports = GridDialog;

package/clientjs/component/dialogs/overlayService.js

@@ -53,7 +53,7 @@ OverlayService.prototype.popDialog = function() {
   var zIndex = this.getZIndex($dialog);
   $overlay.css('z-index', zIndex);
   $dialog.before($overlay);
-}
+};
 
 /**
  * Add a dialog element to the overlay stack.
@@ -67,7 +67,7 @@ OverlayService.prototype.pushDialog = function(dialog) {
   $overlay.css('z-index', zIndex);
   OverlayService._dialogStack.push(this.jsh.$(dialog));
   this.jsh.$(dialog).before($overlay);
-}
+};
 
 /**
  * Get the overlay. Creates and adds to DOM if it doesn't already
@@ -91,7 +91,7 @@ OverlayService.prototype.getOverlay = function() {
   });
 
   return $childOverlay;
-}
+};
 
 /**
  * Get the z-index for the element.
@@ -103,6 +103,6 @@ OverlayService.prototype.getOverlay = function() {
 OverlayService.prototype.getZIndex = function(element) {
   var zIndex = parseInt(this.jsh.$(element).css('zIndex'));
   return isNaN(zIndex) || zIndex == undefined ? 0 : zIndex;
-}
+};
 
 exports = module.exports = OverlayService;

package/clientjs/component/editors/dataEditor_form.js

@@ -19,7 +19,6 @@ along with this package.  If not, see <http://www.gnu.org/licenses/>.
 
 var _ = require('lodash');
 var FormDialog = require('../dialogs/formDialog');
-var ComponentTemplate = require('../componentModel/componentTemplate');
 var HTMLPropertyEditorController = require('./htmlPropertyEditorController');
 var TemplateRenderer = require('../templateRenderer');
 
@@ -27,6 +26,8 @@ var TemplateRenderer = require('../templateRenderer');
 
 /** @typedef {import('../componentModel/componentTemplate').MediaBrowserControlInfo} MediaBrowserControlInfo */
 
+/** @typedef {import('../componentModel/componentTemplate').ComponentTemplate} ComponentTemplate */
+
 /**
  * @callback DataEditor_Form~beforeRenderDataItemPreview
  * @param {RenderConfig} renderConfig
@@ -107,7 +108,7 @@ DataEditor_Form.prototype.attachEditors = function($dialog, $wrapper, $toolbar)
     editor.initialize(function() {});
     _this._htmlEditors.push(editor);
   });
-}
+};
 
 /**
  * @private
@@ -120,7 +121,7 @@ DataEditor_Form.prototype.enableBrowserControl = function($dialog, info, enable)
   if(jctrl.hasClass('editable')){
     $dialog.find('.xform_ctrl.' + info.titleFieldName).attr('disabled', enable ? null : true);
   }
-}
+};
 
 /**
  * Open the editor
@@ -141,7 +142,7 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
     modelConfig.actions = 'B';
   }
 
-  var itemData = modelTemplate.populateDataInstance(itemData || {});
+  itemData = modelTemplate.populateDataInstance(itemData || {});
 
   var dialog = new FormDialog(this._jsh, this._cms, modelConfig, {
     acceptButtonLabel: 'OK',
@@ -194,7 +195,7 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
       // Don't attach any events until after the onRenderGridItemPreview hook is called.
       // Otherwise, the events might be attached to elements that get replaced or removed.
       _this.attachEditors($dialog, $wrapper, $toolbar);
-    }
+    };
 
     // This function NEEDS to be debounced.
     // It SHOULD be anyway so it doesn't re-render the preview on every
@@ -239,9 +240,9 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
         }, xmodel.get(browserControlName));
       }
       else {
-        console.warn(new Error('Unknown browser type ' + info.browserType));
+        console.warn(new Error('Unknown editor browser type ' + info.browserType)); // eslint-disable-line no-console
       }
-    }
+    };
 
     editor.onChangeBrowserTitleControl = function(browserControlName) {
       // When the user manually changes the link title,
@@ -250,7 +251,7 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
       if (info == undefined) return;
       xmodel.set(browserControlName, xmodel.get(info.titleFieldName));
       editor.onChangeData();
-    }
+    };
 
     editor.resetEditorBrowser = function(linkControlName) {
       var info = modelTemplate.getBrowserFieldInfo(linkControlName);
@@ -259,13 +260,13 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
       xmodel.set(linkControlName, '');
       xmodel.set(info.titleFieldName, '');
       editor.onChangeData();
-    }
+    };
 
     _this._onBeforeRenderDataItemPreview = editor.onBeforeRenderDataItemPreview;
     _this._onRenderDataItemPreview = editor.onRenderDataItemPreview;
 
     if(onComplete) onComplete();
-  }
+  };
 
   dialog.onOpened = function($dialog, xmodel) {
     var editor = _this._jsh.App[xmodel.id];
@@ -276,14 +277,14 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
         $dialog.css('opacity', '1');
       }, 50);
     });
-  }
+  };
 
   dialog.onAccept = function($dialog, xmodel) {
     if(!xmodel.controller.Commit(itemData, 'U')) return false;
     itemData = modelTemplate.makePristineCopy(itemData);
     if (_.isFunction(onAcceptCb)) onAcceptCb(itemData);
     return true;
-  }
+  };
 
   dialog.onCancel = function(options, $dialog, xmodel) {
     if (!options.force && xmodel.controller.HasUpdates()) {
@@ -293,7 +294,7 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
       });
       return false;
     }
-  }
+  };
 
   dialog.onClose = function($dialog, xmodel) {
     //Destroy model
@@ -304,10 +305,10 @@ DataEditor_Form.prototype.open = function(itemData, properties, onAcceptCb, onCl
     delete _this._jsh.App[xmodel.id];
     _.forEach(_this._htmlEditors, function(editor) { editor.destroy(); });
     if (_.isFunction(onCloseCb)) onCloseCb();
-  }
+  };
 
   dialog.open(itemData);
-}
+};
 
 /**
  * @private
@@ -336,7 +337,7 @@ DataEditor_Form.prototype.renderPreview = function($wrapper, template, data, pro
 
   $wrapper.empty().append(rendered);
 
-  if(this._cms && this._cms.editor) this._cms.editor.disableLinks($wrapper)
+  if(this._cms && this._cms.editor) this._cms.editor.disableLinks($wrapper);
 
   if (_.isFunction(this._onRenderDataItemPreview)) this._onRenderDataItemPreview($wrapper.children()[0], renderConfig.data, renderConfig.properties, _this._cms, _this._component);
 
@@ -345,6 +346,6 @@ DataEditor_Form.prototype.renderPreview = function($wrapper, template, data, pro
       _this._cms.componentManager.renderContentComponent(el);
     });
   }, 50);
-}
+};
 
 exports = module.exports = DataEditor_Form;

package/clientjs/component/editors/dataEditor_gridPreview.js

@@ -18,11 +18,10 @@ along with this package.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 var _ = require('lodash');
-var ComponentTemplate = require('../componentModel/componentTemplate');
 var GridDialog = require('../dialogs/gridDialog');
 var DataEditor_GridPreviewController = require('./dataEditor_gridPreviewController');
 
-
+/** @typedef {import('../componentModel/componentTemplate').ComponentTemplate} ComponentTemplate */
 
 /**
  * @class
@@ -86,41 +85,41 @@ DataEditor_GridPreview.prototype.open = function(data, properties, dataUpdatedCb
 
     dataController.onDataUpdated = function(updatedData) {
       if (_.isFunction(dataUpdatedCb)) dataUpdatedCb(updatedData);
-    }
+    };
 
     dataController.onBeforeRenderGridRow = function(renderOptions) {
       if (_.isFunction(componentInstance.onBeforeRenderGridRow)) componentInstance.onBeforeRenderGridRow(renderOptions);
-    }
+    };
 
     dataController.onRenderGridRow = function(element, data, properties, cms, component) {
       if (_.isFunction(componentInstance.onRenderGridRow)) componentInstance.onRenderGridRow(element, data, properties, cms, component);
-    }
+    };
 
     var modelInterface = _this._jsh.App[xmodel.id];
 
     modelInterface.onRowBind = function(xmodel, jobj, dataRow) {
       if (!dataController) return;
       dataController.addRow(jobj, dataRow);
-    }
+    };
 
     modelInterface.onCommit = function(xmodel, rowId, callback) {
       callback();
-    }
+    };
 
     modelInterface.close = function() {
       _this._jsh.XExt.CancelDialog();
-    }
+    };
 
     modelInterface.addItem = function() {
       dataController.addItem();
-    }
+    };
 
     if(onComplete) onComplete();
-  }
+  };
 
   dialog.onOpened = function($dialog, xmodel) {
     dataController.initialize();
-  }
+  };
 
   dialog.onClose = function($dialog, xmodel) {
     //Destroy model
@@ -130,11 +129,11 @@ DataEditor_GridPreview.prototype.open = function(data, properties, dataUpdatedCb
     delete _this._jsh.XModels[xmodel.id];
     delete _this._jsh.App[xmodel.id];
     delete _this._jsh.App[componentInstanceId];
-  }
+  };
 
   dialog.open();
 
-}
+};
 
 DataEditor_GridPreview.prototype.updateAddButtonText = function(selector, captions) {
 
@@ -143,7 +142,7 @@ DataEditor_GridPreview.prototype.updateAddButtonText = function(selector, captio
   var $el = this._jsh.$(selector);
   var $img = $el.find('img');
   $el.empty().append($img).append(text);
-}
+};
 
 
 exports = module.exports = DataEditor_GridPreview;