jsgui3-server 0.0.145 → 0.0.146

package/resources/processors/bundlers/js/esbuild/Core_JS_Non_Minifying_Bundler_Using_ESBuild.js

@@ -44,97 +44,84 @@ class Core_JS_Non_Minifying_Bundler_Using_ESBuild extends Bundler_Using_ESBuild
 
 
 
-    bundle_js_string(js_string) {
-        const res_obs = obs(async(next, complete, error) => {
-            const o_build = {
-                stdin: {
-                    contents: js_string,
-                    resolveDir: process.cwd()
-                },
-                bundle: true,
-                treeShaking: true,
-                write: false,
-                // Remove outdir since we're keeping in memory
-            }
-
-            // Configure sourcemaps based on configuration
-            const sourcemapsEnabled = this.sourcemap_config.enabled !== false; // Default: true in debug, false in production
-            if (sourcemapsEnabled && (this.debug || this.sourcemap_config.includeInProduction)) {
-                o_build.sourcemap = this.sourcemap_config.format || 'inline';
-            }
-
-            let result = await esbuild.build(o_build);
-
-            if (result.outputFiles.length === 1) {
-                const output_file = result.outputFiles[0];
-                const res_bundle = new Bundle();
-                const o_bundle_item = {
-                    type: 'JavaScript',
-                    extension: 'js',
-                    text: output_file.text
-                }
-                res_bundle.push(o_bundle_item);
-                next(res_bundle);
-                complete();
-            } else {
-                console.trace();
-                throw 'NYI';
-            }
-        });
-        return res_obs;
-    }
+    bundle_js_string(js_string) {
+        const res_obs = obs(async(next, complete, error) => {
+            try {
+                const o_build = {
+                    stdin: {
+                        contents: js_string,
+                        resolveDir: process.cwd()
+                    },
+                    bundle: true,
+                    treeShaking: true,
+                    write: false
+                };
+
+                // Configure sourcemaps based on configuration
+                const sourcemapsEnabled = this.sourcemap_config.enabled !== false;
+                if (sourcemapsEnabled && (this.debug || this.sourcemap_config.includeInProduction)) {
+                    o_build.sourcemap = this.sourcemap_config.format || 'inline';
+                }
+
+                const result = await esbuild.build(o_build);
+
+                if (result.outputFiles.length === 1) {
+                    const output_file = result.outputFiles[0];
+                    const res_bundle = new Bundle();
+                    const o_bundle_item = {
+                        type: 'JavaScript',
+                        extension: 'js',
+                        text: output_file.text
+                    };
+                    res_bundle.push(o_bundle_item);
+                    next(res_bundle);
+                    complete(res_bundle);
+                } else {
+                    console.trace();
+                    throw 'NYI';
+                }
+            } catch (err) {
+                if (typeof error === 'function') error(err);
+            }
+        });
+        return res_obs;
+    }
 
     bundle(js_file_path) {
 
 
-        const res_obs = obs(async(next, complete, error) => {
-
-            // Validate input
-            if (typeof js_file_path !== 'string' || js_file_path.trim() === '') {
-                throw new Error('bundle() expects a valid file path string');
-            }
-
-            //console.log('Core_JS_Bundler_Using_ESBuild bundle js_file_path:', js_file_path);
-
-            // Looks like we need better linking build options....
-
-            const o_build = {
-                entryPoints: [js_file_path],
-
-
-                //format: 'iife',
-                bundle: true,
-
-                // Possibly no minification here....
-                // Want to use non-minified or only partially minified version to separate the JS and the CSS.
-
-                treeShaking: true,
-
-                //sourcemap: 'external',
-                write: false,
-                // Remove outdir since we're keeping in memory
-            }
-
-            // Configure sourcemaps based on configuration
-            const sourcemapsEnabled = this.sourcemap_config.enabled !== false; // Default: true in debug, false in production
-            if (sourcemapsEnabled && (this.debug || this.sourcemap_config.includeInProduction)) {
-                o_build.sourcemap = this.sourcemap_config.format || 'inline';
-            }
-
-
-
-            let result = await esbuild.build(o_build);
-            //console.log('result.outputFiles:\n\n');
-            //for (let out of result.outputFiles) {
-                //console.log('out.path, out.contents, out.hash, out.text', out.path, out.contents, out.hash, out.text)
-            //}
+        const res_obs = obs(async(next, complete, error) => {
+            try {
+                // Validate input
+                if (typeof js_file_path !== 'string' || js_file_path.trim() === '') {
+                    throw new Error('bundle() expects a valid file path string');
+                }
+
+                const o_build = {
+                    entryPoints: [js_file_path],
+                    bundle: true,
+                    treeShaking: true,
+                    write: false
+                };
+
+                // Configure sourcemaps based on configuration
+                const sourcemapsEnabled = this.sourcemap_config.enabled !== false;
+                if (sourcemapsEnabled && (this.debug || this.sourcemap_config.includeInProduction)) {
+                    o_build.sourcemap = this.sourcemap_config.format || 'inline';
+                }
+
+                const result = await esbuild.build(o_build);
+            //console.log('result.outputFiles:\n\n');
+            //for (let out of result.outputFiles) {
+                //console.log('out.path, out.contents, out.hash, out.text', out.path, out.contents, out.hash, out.text)
+            //}
 
             //console.log('result.outputFiles.length', result.outputFiles.length);
 
 
-            if (result.outputFiles.length === 1) {
-
-                const output_file = result.outputFiles[0];
+                if (result.outputFiles.length === 1) {
+
+                const output_file = result.outputFiles[0];
 
                 //console.log('output_file.text.length', output_file.text.length);
                 //console.log('output_file.text', output_file.text);
@@ -169,10 +156,10 @@ class Core_JS_Non_Minifying_Bundler_Using_ESBuild extends Bundler_Using_ESBuild
                     text: output_file.text
                 }
 
-                res_bundle.push(o_bundle_item);
-
-                next(res_bundle);
-                complete();
+                    res_bundle.push(o_bundle_item);
+
+                    next(res_bundle);
+                    complete(res_bundle);
 
 
 
@@ -206,18 +193,18 @@ class Core_JS_Non_Minifying_Bundler_Using_ESBuild extends Bundler_Using_ESBuild
                 //console.trace();
                 //throw 'NYI';
 
-            } else {
-
-
-                console.trace();
-                throw 'NYI';
-
-            }
-
-
-            // The core bundler....
-            //   Maybe later even use a Static_Response_Preparer???
-            //   And have the relevant Publisher use it?
+                } else {
+                    console.trace();
+                    throw 'NYI';
+                }
+            } catch (err) {
+                if (typeof error === 'function') error(err);
+            }
+
+
+            // The core bundler....
+            //   Maybe later even use a Static_Response_Preparer???
+            //   And have the relevant Publisher use it?
 
 
 
@@ -235,4 +222,4 @@ class Core_JS_Non_Minifying_Bundler_Using_ESBuild extends Bundler_Using_ESBuild
 
 }
 
-module.exports = Core_JS_Non_Minifying_Bundler_Using_ESBuild;
+module.exports = Core_JS_Non_Minifying_Bundler_Using_ESBuild;

package/resources/processors/bundlers/js/esbuild/Core_JS_Single_File_Minifying_Bundler_Using_ESBuild.js

@@ -55,12 +55,58 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
         return options;
     }
 
-    get_default_minify_config() {
-        return {
-            enabled: true,
-            level: 'normal'
-        };
-    }
+    get_default_minify_config() {
+        return {
+            enabled: true,
+            level: 'normal'
+        };
+    }
+
+    apply_minify_options(o_build) {
+        const enabled = this.minify_config.enabled !== false;
+        if (!enabled) {
+            o_build.minify = false;
+            return;
+        }
+
+        const level = this.minify_config.level || 'normal';
+        const level_overrides = {
+            conservative: {
+                minifyIdentifiers: false,
+                minifyWhitespace: false,
+                minifySyntax: false
+            },
+            aggressive: {
+                drop: ['console', 'debugger']
+            }
+        };
+
+        o_build.minify = true;
+        if (level_overrides[level]) {
+            Object.assign(o_build, level_overrides[level]);
+        }
+
+        const minify_options = this.get_minify_options();
+        if (minify_options && typeof minify_options === 'object') {
+            if (minify_options.mangle === false) {
+                o_build.minifyIdentifiers = false;
+            }
+            if (minify_options.compress === false) {
+                o_build.minifySyntax = false;
+                o_build.minifyWhitespace = false;
+            } else if (minify_options.compress && typeof minify_options.compress === 'object') {
+                if (minify_options.compress.sequences === false) {
+                    o_build.minifySyntax = false;
+                }
+                const drop = [];
+                if (minify_options.compress.drop_console) drop.push('console');
+                if (minify_options.compress.drop_debugger) drop.push('debugger');
+                if (drop.length) {
+                    o_build.drop = Array.from(new Set([...(o_build.drop || []), ...drop]));
+                }
+            }
+        }
+    }
 
 
 
@@ -75,40 +121,23 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
             if (typeof str_js !== 'string') {
                 throw new Error('bundle() expects a string parameter');
             }
-        const res_obs = obs(async(next, complete, error) => {
-
-
-
-            //console.log('Core_JS_Bundler_Using_ESBuild bundle js_file_path:', js_file_path);
-
-            // Looks like we need better linking build options....
-
-            let result = await esbuild.build({
-                stdin: {
-                    contents: str_js,
-
-                    // These are all optional:
-                    //resolveDir: './src',
-                    //sourcefile: 'imaginary-file.js',
-                    //loader: 'ts',
-                },
-                bundle: true,
-                
-                // Possibly no minification here....
-                // Want to use non-minified or only partially minified version to separate the JS and the CSS.
-
-                treeShaking: true,
-                minify: true,
-                //format: 'iife',
-
-                //sourcemap: 'external',
-                write: false,
-                // Remove outdir since we're keeping in memory
-            })
-            //console.log('result.outputFiles:\n\n');
-            for (let out of result.outputFiles) {
-                //console.log('out.path, out.contents, out.hash, out.text', out.path, out.contents, out.hash, out.text)
-            }
+        const res_obs = obs(async(next, complete, error) => {
+            try {
+                const o_build = {
+                    stdin: {
+                        contents: str_js
+                    },
+                    bundle: true,
+                    treeShaking: true,
+                    write: false
+                };
+
+                this.apply_minify_options(o_build);
+
+                const result = await esbuild.build(o_build);
+                for (let out of result.outputFiles) {
+                    //console.log('out.path, out.contents, out.hash, out.text', out.path, out.contents, out.hash, out.text)
+                }
 
             //console.log('result.outputFiles.length', result.outputFiles.length);
 
@@ -116,9 +145,9 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
             //throw 'stop';
 
 
-            if (result.outputFiles.length === 1) {
-
-                const output_file = result.outputFiles[0];
+                if (result.outputFiles.length === 1) {
+
+                const output_file = result.outputFiles[0];
 
                 //console.log('output_file', output_file);
 
@@ -155,10 +184,10 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
                     text: output_file.text
                 }
 
-                res_bundle.push(o_bundle_item);
-
-                next(res_bundle);
-                complete();
+                    res_bundle.push(o_bundle_item);
+
+                    next(res_bundle);
+                    complete(res_bundle);
 
 
 
@@ -192,18 +221,18 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
                 //console.trace();
                 //throw 'NYI';
 
-            } else {
-
-
-                console.trace();
-                throw 'NYI';
-
-            }
-
-
-            // The core bundler....
-            //   Maybe later even use a Static_Response_Preparer???
-            //   And have the relevant Publisher use it?
+                } else {
+                    console.trace();
+                    throw 'NYI';
+                }
+            } catch (err) {
+                if (typeof error === 'function') error(err);
+            }
+
+
+            // The core bundler....
+            //   Maybe later even use a Static_Response_Preparer???
+            //   And have the relevant Publisher use it?
 
 
 
@@ -221,4 +250,4 @@ class Core_JS_Single_File_Minifying_Bundler_Using_ESBuild extends Bundler_Using_
 
 }
 
-module.exports = Core_JS_Single_File_Minifying_Bundler_Using_ESBuild;
+module.exports = Core_JS_Single_File_Minifying_Bundler_Using_ESBuild;

package/tests/README.md

@@ -63,15 +63,50 @@ npm run test:puppeteer:windows
 ```bash
 # Debug mode (enables sourcemaps)
 node tests/test-runner.js --debug
-
-# Verbose output
-node tests/test-runner.js --verbose
-
-# Specific test with debug
-node tests/test-runner.js --test=end-to-end.test.js --debug
-```
-
-## Test Coverage
+
+# Verbose output
+node tests/test-runner.js --verbose
+
+# Specific test with debug
+node tests/test-runner.js --test=end-to-end.test.js --debug
+```
+
+## Recommended Testing Workflow
+
+1. Run a focused suite first (fast feedback).
+2. Run the example regression suite next (HTML/CSS/JS smoke checks).
+3. Run Puppeteer interaction tests last (heavier, requires a browser).
+4. Run the full suite only when changes are broad or before release.
+
+Suggested sequence:
+```bash
+node tests/test-runner.js --test=bundlers.test.js
+npm run test:examples:controls
+npm run test:puppeteer:windows
+npm test
+```
+
+## Patterns That Work
+
+- Use per-test temporary client files and delete them in `finally`.
+- Always close servers in `finally` to avoid port leaks.
+- Prefer `get_free_port` over hard-coded ports.
+- Keep style config explicit in tests that validate sourcemaps.
+- Inject Sass overrides via `style.scss_sources` when testing themes.
+
+## Antipatterns To Avoid
+
+- Copying `node_modules` between Windows and WSL or across OSes.
+- Leaving servers running after a failed test (leaks ports and state).
+- Tests that rely on global bundler state or implicit ordering.
+- Hard-coded ports or shared temp file names across tests.
+
+## Common Failure Signatures
+
+- `waiting for wp_publisher ready` + test timeout usually means the JS/CSS bundler failed before the server emitted `ready`. Check for esbuild or Sass errors earlier in the log.
+- `You installed esbuild for another platform` indicates a native esbuild binary mismatch (see troubleshooting docs).
+
+## Test Coverage
 
 ### 1. Component Isolation Tests (`bundlers.test.js`, `assigners.test.js`, `publishers.test.js`)
 
@@ -157,6 +192,7 @@ Server-level integration tests for controls that define `.scss` or `.sass` style
 - Confirms indented Sass compiles and is removed from JS bundles
 - Checks inline CSS sourcemaps include original Sass/SCSS sources
 - Ensures mixed CSS + Sass output preserves order without emitting inaccurate sourcemaps
+- Confirms server `scss_sources` overrides are applied during compilation
 
 Note: These tests are skipped if the `sass` dependency is not installed.
 

package/tests/bundlers.test.js

@@ -4,12 +4,17 @@ const fs = require('fs').promises;
 const path = require('path');
 
 // Import bundler classes
-const Core_JS_Non_Minifying_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Core_JS_Non_Minifying_Bundler_Using_ESBuild');
-const Core_JS_Single_File_Minifying_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Core_JS_Single_File_Minifying_Bundler_Using_ESBuild');
-const Advanced_JS_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Advanced_JS_Bundler_Using_ESBuild');
-
-describe('Bundler Component Isolation Tests', function() {
-this.timeout(30000); // Increase timeout for bundling operations
+const Core_JS_Non_Minifying_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Core_JS_Non_Minifying_Bundler_Using_ESBuild');
+const Core_JS_Single_File_Minifying_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Core_JS_Single_File_Minifying_Bundler_Using_ESBuild');
+const Advanced_JS_Bundler_Using_ESBuild = require('../resources/processors/bundlers/js/esbuild/Advanced_JS_Bundler_Using_ESBuild');
+
+const await_observable = observable => new Promise((resolve, reject) => {
+    observable.on('error', reject);
+    observable.on('complete', resolve);
+});
+
+describe('Bundler Component Isolation Tests', function() {
+this.timeout(30000); // Increase timeout for bundling operations
 
     let testJsFile;
     let testJsContent;
@@ -108,29 +113,30 @@ this.timeout(30000); // Increase timeout for bundling operations
             assert(!bundleItem.text.includes('//# sourceMappingURL='), 'Production bundle should not include sourcemap');
         });
 
-        it('should bundle JavaScript string directly', async function() {
-            const bundler = new Core_JS_Non_Minifying_Bundler_Using_ESBuild();
-
-            const jsString = `
-                function directTest() {
-                    return 'direct result';
-                }
-                console.log('Direct bundle test');
-            `;
-
-            const result = await bundler.bundle_js_string(jsString);
-
-            assert(Array.isArray(result), 'Result should be an array');
-            const bundle = result[0];
-            const bundleItem = bundle._arr[0];
-
-            assert.strictEqual(bundleItem.type, 'JavaScript');
-            assert(bundleItem.text.includes('directTest'), 'Should contain the direct test function');
-            assert(bundleItem.text.includes('Direct bundle test'), 'Should contain the test log');
-            // Verify the function is actually executable
-            const testFunction = new Function(bundleItem.text + '; return directTest;')();
-            assert.strictEqual(testFunction(), 'direct result', 'Bundled function should be executable');
-        });
+        it('should bundle JavaScript string directly', async function() {
+            const bundler = new Core_JS_Non_Minifying_Bundler_Using_ESBuild();
+
+            const jsString = `
+                globalThis.directTest = function directTest() {
+                    return 'direct result';
+                };
+                console.log(globalThis.directTest());
+                console.log('Direct bundle test');
+            `;
+
+            const result = await bundler.bundle_js_string(jsString);
+
+            assert(Array.isArray(result), 'Result should be an array');
+            const bundle = result[0];
+            const bundleItem = bundle._arr[0];
+
+            assert.strictEqual(bundleItem.type, 'JavaScript');
+            assert(bundleItem.text.includes('direct result'), 'Should contain the direct result string');
+            assert(bundleItem.text.includes('Direct bundle test'), 'Should contain the test log');
+            // Verify the function is actually executable
+            const testFunction = new Function(bundleItem.text + '; return globalThis.directTest;')();
+            assert.strictEqual(testFunction(), 'direct result', 'Bundled function should be executable');
+        });
     });
 
     describe('Core_JS_Single_File_Minifying_Bundler_Using_ESBuild', function() {
@@ -316,23 +322,23 @@ this.timeout(30000); // Increase timeout for bundling operations
                     console.log('invalid syntax'
             `;
 
-            try {
-                await bundler.bundle_js_string(invalidJs);
-                assert.fail('Should have thrown an error for invalid JavaScript');
-            } catch (error) {
-                assert(error, 'Should throw an error for invalid JavaScript');
-            }
-        });
-
-        it('should handle non-existent files', async function() {
-            const bundler = new Core_JS_Non_Minifying_Bundler_Using_ESBuild();
-
-            try {
-                await bundler.bundle('/non/existent/file.js');
-                assert.fail('Should have thrown an error for non-existent file');
-            } catch (error) {
-                assert(error, 'Should throw an error for non-existent file');
-            }
-        });
+            try {
+                await await_observable(bundler.bundle_js_string(invalidJs));
+                assert.fail('Should have thrown an error for invalid JavaScript');
+            } catch (error) {
+                assert(error, 'Should throw an error for invalid JavaScript');
+            }
+        });
+
+        it('should handle non-existent files', async function() {
+            const bundler = new Core_JS_Non_Minifying_Bundler_Using_ESBuild();
+
+            try {
+                await await_observable(bundler.bundle('/non/existent/file.js'));
+                assert.fail('Should have thrown an error for non-existent file');
+            } catch (error) {
+                assert(error, 'Should throw an error for non-existent file');
+            }
+        });
     });
 });

package/tests/examples-controls.e2e.test.js

@@ -33,7 +33,9 @@ const examples = [
         ctrl_name: 'Demo_UI',
         expected_window_count: 1,
         expected_canvas_id: 'globeCanvas'
-    }
+    },
+    { dir_name: '16) window, form container', ctrl_name: 'Demo_UI', expected_window_count: 1 },
+    { dir_name: '17) window, mvvm binding', ctrl_name: 'Demo_UI', expected_window_count: 1 }
 ];
 
 function make_request(url, { headers = {} } = {}) {