jsgar 4.9.0 → 4.9.2

package/dist/gar.umd.js

@@ -1040,10 +1040,14 @@
                     const keyId = keyUpdate.key_id;
                     const keyName = keyUpdate.name;
 
-                    // Handle key introduction if name is provided and key is new
-                    if (keyName && !this.serverKeyIdToName.has(keyId)) {
-                        this.serverKeyIdToName.set(keyId, keyName);
-                        this.serverKeyNameToId.set(keyName, keyId);
+                    // Handle key introduction if name is provided. De-dup only the
+                    // serverKey*ToName/Id maps; always invoke the registered handler
+                    // so callers see every BatchUpdate-carried key event.
+                    if (keyName) {
+                        if (!this.serverKeyIdToName.has(keyId)) {
+                            this.serverKeyIdToName.set(keyId, keyName);
+                            this.serverKeyNameToId.set(keyName, keyId);
+                        }
 
                         // If no batch handler but key handler exists, call KeyIntroduction handler
                         if (!hasBatchHandler && keyHandler) {
@@ -1101,9 +1105,18 @@
                 this.log('INFO', 'Received Logoff from server');
                 this.stop();
             } else if (msgType === 'Error') {
-                this.log('ERROR', `GAR ${message.value.message}`);
-                this.exitCode = 1;
-                this.stop();
+                // proto.gar's `error` struct carries `recoverable: bool`. Recoverable errors mean
+                // the server processed the failing message (e.g. a publish that violated some
+                // server-side check), logged it, and kept the connection alive. We dispatch the
+                // message to the user's error handler but don't tear down the client. Non-recoverable
+                // errors are followed by a server disconnect; we set exit_code + stop() so callers
+                // (CLI tools, the html_view UI) see the failure.
+                const recoverable = !!message.value.recoverable;
+                this.log(recoverable ? 'WARNING' : 'ERROR', `GAR ${message.value.message}`);
+                if (!recoverable) {
+                    this.exitCode = 1;
+                    this.stop();
+                }
             }
 
             this.checkHeartbeat();
@@ -1387,28 +1400,25 @@
         }
 
         /**
-         * Introduce a new key if not already known and return local key ID.
+         * Introduce a new key if not already known and return local key ID. className is required;
+         * a bare introduction with no class_list can't be routed by upstream proxies.
          * @param {string} name - Key name
-         * @param {string|Array<string>|null} [className=null] - Class name(s)
+         * @param {string|Array<string>} className - Class name(s)
          * @returns {number} Local key ID
          */
-        getAndPossiblyIntroduceKeyId(name, className = null) {
+        getAndPossiblyIntroduceKeyId(name, className) {
             const existingId = this.localKeyMap.get(name);
             if (existingId !== undefined && this.invalidatedKeyIds.has(existingId)) {
                 this.invalidatedKeyIds.delete(existingId);
                 this.localKeyMap.delete(name);
             }
             if (!this.localKeyMap.has(name)) {
+                if (!className) throw new Error(`getAndPossiblyIntroduceKeyId: className required to introduce key "${name}"`);
                 const keyId = this.localKeyCounter++;
                 this.localKeyMap.set(name, keyId);
                 const value = { key_id: keyId, name };
-                if (className) {
-                    if (typeof className === 'string') {
-                        value.class_list = className.split(/\s+/).filter(Boolean);
-                    } else if (Array.isArray(className)) {
-                        value.class_list = className;
-                    }
-                }
+                if (typeof className === 'string') value.class_list = className.split(/\s+/).filter(Boolean);
+                else if (Array.isArray(className)) value.class_list = className;
                 this.sendMessage({ message_type: 'KeyIntroduction', value });
             }
             return this.localKeyMap.get(name);
@@ -1511,6 +1521,10 @@
          * @param {any} value - JSON-serializable value
          */
         publishRecordWithIds(keyId, topicId, value) {
+            if (value === undefined) {
+                this.log('ERROR', `publishRecordWithIds(${keyId}, ${topicId}): refusing to publish undefined — JSON.stringify would drop the "value" field and the server would reject with "Missing record 'value' field"`);
+                return;
+            }
             const updateMsg = {
                 message_type: 'JSONRecordUpdate',
                 value: {
@@ -1529,6 +1543,10 @@
          * @param {string|null} [className=null] - Class name
          */
         publishRecord(keyName, topicName, value, className = null) {
+            if (value === undefined) {
+                this.log('ERROR', `publishRecord(${keyName}, ${topicName}): refusing to publish undefined — JSON.stringify would drop the "value" field and the server would reject with "Missing record 'value' field"`);
+                return;
+            }
             const keyId = this.getAndPossiblyIntroduceKeyId(keyName, className);
             const topicId = this.getAndPossiblyIntroduceTopicId(topicName);
             this.publishRecordWithIds(keyId, topicId, value);

package/gar.js

@@ -1034,10 +1034,14 @@ class GARClient {
                 const keyId = keyUpdate.key_id;
                 const keyName = keyUpdate.name;
 
-                // Handle key introduction if name is provided and key is new
-                if (keyName && !this.serverKeyIdToName.has(keyId)) {
-                    this.serverKeyIdToName.set(keyId, keyName);
-                    this.serverKeyNameToId.set(keyName, keyId);
+                // Handle key introduction if name is provided. De-dup only the
+                // serverKey*ToName/Id maps; always invoke the registered handler
+                // so callers see every BatchUpdate-carried key event.
+                if (keyName) {
+                    if (!this.serverKeyIdToName.has(keyId)) {
+                        this.serverKeyIdToName.set(keyId, keyName);
+                        this.serverKeyNameToId.set(keyName, keyId);
+                    }
 
                     // If no batch handler but key handler exists, call KeyIntroduction handler
                     if (!hasBatchHandler && keyHandler) {
@@ -1095,9 +1099,18 @@ class GARClient {
             this.log('INFO', 'Received Logoff from server');
             this.stop();
         } else if (msgType === 'Error') {
-            this.log('ERROR', `GAR ${message.value.message}`);
-            this.exitCode = 1;
-            this.stop();
+            // proto.gar's `error` struct carries `recoverable: bool`. Recoverable errors mean
+            // the server processed the failing message (e.g. a publish that violated some
+            // server-side check), logged it, and kept the connection alive. We dispatch the
+            // message to the user's error handler but don't tear down the client. Non-recoverable
+            // errors are followed by a server disconnect; we set exit_code + stop() so callers
+            // (CLI tools, the html_view UI) see the failure.
+            const recoverable = !!message.value.recoverable;
+            this.log(recoverable ? 'WARNING' : 'ERROR', `GAR ${message.value.message}`);
+            if (!recoverable) {
+                this.exitCode = 1;
+                this.stop();
+            }
         }
 
         this.checkHeartbeat();
@@ -1381,28 +1394,25 @@ class GARClient {
     }
 
     /**
-     * Introduce a new key if not already known and return local key ID.
+     * Introduce a new key if not already known and return local key ID. className is required;
+     * a bare introduction with no class_list can't be routed by upstream proxies.
      * @param {string} name - Key name
-     * @param {string|Array<string>|null} [className=null] - Class name(s)
+     * @param {string|Array<string>} className - Class name(s)
      * @returns {number} Local key ID
      */
-    getAndPossiblyIntroduceKeyId(name, className = null) {
+    getAndPossiblyIntroduceKeyId(name, className) {
         const existingId = this.localKeyMap.get(name);
         if (existingId !== undefined && this.invalidatedKeyIds.has(existingId)) {
             this.invalidatedKeyIds.delete(existingId);
             this.localKeyMap.delete(name);
         }
         if (!this.localKeyMap.has(name)) {
+            if (!className) throw new Error(`getAndPossiblyIntroduceKeyId: className required to introduce key "${name}"`);
             const keyId = this.localKeyCounter++;
             this.localKeyMap.set(name, keyId);
             const value = { key_id: keyId, name };
-            if (className) {
-                if (typeof className === 'string') {
-                    value.class_list = className.split(/\s+/).filter(Boolean);
-                } else if (Array.isArray(className)) {
-                    value.class_list = className;
-                }
-            }
+            if (typeof className === 'string') value.class_list = className.split(/\s+/).filter(Boolean);
+            else if (Array.isArray(className)) value.class_list = className;
             this.sendMessage({ message_type: 'KeyIntroduction', value });
         }
         return this.localKeyMap.get(name);
@@ -1505,6 +1515,10 @@ class GARClient {
      * @param {any} value - JSON-serializable value
      */
     publishRecordWithIds(keyId, topicId, value) {
+        if (value === undefined) {
+            this.log('ERROR', `publishRecordWithIds(${keyId}, ${topicId}): refusing to publish undefined — JSON.stringify would drop the "value" field and the server would reject with "Missing record 'value' field"`);
+            return;
+        }
         const updateMsg = {
             message_type: 'JSONRecordUpdate',
             value: {
@@ -1523,6 +1537,10 @@ class GARClient {
      * @param {string|null} [className=null] - Class name
      */
     publishRecord(keyName, topicName, value, className = null) {
+        if (value === undefined) {
+            this.log('ERROR', `publishRecord(${keyName}, ${topicName}): refusing to publish undefined — JSON.stringify would drop the "value" field and the server would reject with "Missing record 'value' field"`);
+            return;
+        }
         const keyId = this.getAndPossiblyIntroduceKeyId(keyName, className);
         const topicId = this.getAndPossiblyIntroduceTopicId(topicName);
         this.publishRecordWithIds(keyId, topicId, value);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsgar",
-  "version": "4.9.0",
+  "version": "4.9.2",
   "description": "A Javascript client for the GAR protocol",
   "type": "module",
   "main": "dist/gar.umd.js",