jsf.js_next_gen 4.1.0-beta.16 → 4.1.0-beta.18

package/README.md

@@ -281,6 +281,21 @@ Tests
 - Added tests for HiddenInputBuilder, Lang, and async queue     
 
 
+## 4.1.0-beta.17
+
+- Bugfix: caret position regression on partial updates
+  - After typing into an input that triggers an ajax request, the keyboard caret jumped to
+    the beginning of the field (e.g. typing `123` resulted in `321`). This regressed in
+    `mona-dish` `0.50.0-beta.3`'s caret restoration and is fixed there; the focused input now
+    keeps its caret whether a partial response re-renders a different component or the input
+    itself.
+- Dependency update
+  - Updated `mona-dish` to `0.50.0-beta.3`
+- Tests added
+  - Added two protocol-level regression tests (`ResponseTest`) reproducing the Tobago
+    `<tc:in>`/`<tc:out>` scenario: typing `123` keeps the caret in order for both the
+    "re-render only the output" and the "re-render the input itself" cases.
+
 ## 4.1.0-beta.16
 
 - Dependency update

package/dist/docs/index.html

@@ -249,6 +249,30 @@ enqueues on separate instances to cancel each other's debounce window</li>
 <li>Added tests for ExtDomQuery (nonce DOM fallback, runHeadInserts text-node path) and ExtConfig (append, appendIf, deepCopy)</li>
 <li>Added tests for HiddenInputBuilder, Lang, and async queue</li>
 </ul>
+<h2 id="410-beta17" class="tsd-anchor-link">4.1.0-beta.17<a href="#410-beta17" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="assets/icons.svg#icon-anchor"></use></svg></a></h2>
+<ul>
+<li>Bugfix: caret position regression on partial updates
+<ul>
+<li>After typing into an input that triggers an ajax request, the keyboard caret jumped to
+the beginning of the field (e.g. typing <code>123</code> resulted in <code>321</code>). This regressed in
+<code>mona-dish</code> <code>0.50.0-beta.3</code>'s caret restoration and is fixed there; the focused input now
+keeps its caret whether a partial response re-renders a different component or the input
+itself.</li>
+</ul>
+</li>
+<li>Dependency update
+<ul>
+<li>Updated <code>mona-dish</code> to <code>0.50.0-beta.3</code></li>
+</ul>
+</li>
+<li>Tests added
+<ul>
+<li>Added two protocol-level regression tests (<code>ResponseTest</code>) reproducing the Tobago
+<code>&lt;tc:in&gt;</code>/<code>&lt;tc:out&gt;</code> scenario: typing <code>123</code> keeps the caret in order for both the
+&quot;re-render only the output&quot; and the &quot;re-render the input itself&quot; cases.</li>
+</ul>
+</li>
+</ul>
 <h2 id="410-beta16" class="tsd-anchor-link">4.1.0-beta.16<a href="#410-beta16" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="assets/icons.svg#icon-anchor"></use></svg></a></h2>
 <ul>
 <li>
@@ -306,4 +330,4 @@ enqueues on separate instances to cancel each other's debounce window</li>
 generative AI Tooling, as per <a href="https://www.apache.org/legal/generative-tooling.html">https://www.apache.org/legal/generative-tooling.html</a>
 disclosures now are added!
 See AI_CONTRIBUTIONS.md for full disclosure</p>
-</div></div><div class="col-sidebar"><div class="page-menu"><div class="tsd-navigation settings"><details class="tsd-accordion"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>Settings</h3></summary><div class="tsd-accordion-details"><div class="tsd-filter-visibility"><span class="settings-label">Member Visibility</span><ul id="tsd-filter-options"><li class="tsd-filter-item"><label class="tsd-filter-input"><input type="checkbox" id="tsd-filter-inherited" name="inherited" checked/><svg width="32" height="32" viewBox="0 0 32 32" aria-hidden="true"><rect class="tsd-checkbox-background" width="30" height="30" x="1" y="1" rx="6" fill="none"></rect><path class="tsd-checkbox-checkmark" d="M8.35422 16.8214L13.2143 21.75L24.6458 10.25" stroke="none" stroke-width="3.5" stroke-linejoin="round" fill="none"></path></svg><span>Inherited</span></label></li></ul></div><div class="tsd-theme-toggle"><label class="settings-label" for="tsd-theme">Theme</label><select id="tsd-theme"><option value="os">OS</option><option value="light">Light</option><option value="dark">Dark</option></select></div></div></details></div><details open class="tsd-accordion tsd-page-navigation"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>On This Page</h3></summary><div class="tsd-accordion-details"><a href="#🚀-scratchpad-for-the-typescript-based-reimplementation-of-jsfjs"><span>🚀 <wbr/>Scratchpad for the <wbr/>Type<wbr/>Script-<wbr/>based reimplementation of jsf.js</span></a><ul><li><a href="#what-is-this"><span>What is this?</span></a></li><li><a href="#status"><span>Status</span></a></li><li><ul><li><a href="#special-info"><span>Special <wbr/>Info</span></a></li><li><a href="#general-build"><span>General <wbr/>Build</span></a></li><li><ul><li><a href="#on-windows"><span>On <wbr/>Windows</span></a></li></ul></li><li><a href="#tests"><span>Tests</span></a></li><li><a href="#test-coverage"><span>Test <wbr/>Coverage</span></a></li><li><a href="#changelist-compared-to-the-original-implementation"><span>Changelist compared to the original implementation</span></a></li></ul></li><li><a href="#upload-support"><span>Upload <wbr/>Support</span></a></li><li><a href="#changes-since-40"><span>Changes since 4.0</span></a></li><li><a href="#changes-since-410-beta-10"><span>Changes since 4.1.0-<wbr/>beta-<wbr/>10</span></a></li><li><a href="#410-beta16"><span>4.1.0-<wbr/>beta.16</span></a></li><li><a href="#410-beta15"><span>4.1.0-<wbr/>beta.15</span></a></li><li><a href="#410-beta13-410-beta14"><span>4.1.0-<wbr/>beta.13 / 4.1.0-<wbr/>beta.14</span></a></li></ul></div></details></div><div class="site-menu"><nav class="tsd-navigation"><a href="modules.html">jsf.js_next_gen</a><ul class="tsd-small-nested-navigation" id="tsd-nav-container"><li>Loading...</li></ul></nav></div></div></div><footer><p class="tsd-generator">Generated using <a href="https://typedoc.org/" target="_blank">TypeDoc</a></p></footer><div class="overlay"></div></body></html>
+</div></div><div class="col-sidebar"><div class="page-menu"><div class="tsd-navigation settings"><details class="tsd-accordion"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>Settings</h3></summary><div class="tsd-accordion-details"><div class="tsd-filter-visibility"><span class="settings-label">Member Visibility</span><ul id="tsd-filter-options"><li class="tsd-filter-item"><label class="tsd-filter-input"><input type="checkbox" id="tsd-filter-inherited" name="inherited" checked/><svg width="32" height="32" viewBox="0 0 32 32" aria-hidden="true"><rect class="tsd-checkbox-background" width="30" height="30" x="1" y="1" rx="6" fill="none"></rect><path class="tsd-checkbox-checkmark" d="M8.35422 16.8214L13.2143 21.75L24.6458 10.25" stroke="none" stroke-width="3.5" stroke-linejoin="round" fill="none"></path></svg><span>Inherited</span></label></li></ul></div><div class="tsd-theme-toggle"><label class="settings-label" for="tsd-theme">Theme</label><select id="tsd-theme"><option value="os">OS</option><option value="light">Light</option><option value="dark">Dark</option></select></div></div></details></div><details open class="tsd-accordion tsd-page-navigation"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>On This Page</h3></summary><div class="tsd-accordion-details"><a href="#🚀-scratchpad-for-the-typescript-based-reimplementation-of-jsfjs"><span>🚀 <wbr/>Scratchpad for the <wbr/>Type<wbr/>Script-<wbr/>based reimplementation of jsf.js</span></a><ul><li><a href="#what-is-this"><span>What is this?</span></a></li><li><a href="#status"><span>Status</span></a></li><li><ul><li><a href="#special-info"><span>Special <wbr/>Info</span></a></li><li><a href="#general-build"><span>General <wbr/>Build</span></a></li><li><ul><li><a href="#on-windows"><span>On <wbr/>Windows</span></a></li></ul></li><li><a href="#tests"><span>Tests</span></a></li><li><a href="#test-coverage"><span>Test <wbr/>Coverage</span></a></li><li><a href="#changelist-compared-to-the-original-implementation"><span>Changelist compared to the original implementation</span></a></li></ul></li><li><a href="#upload-support"><span>Upload <wbr/>Support</span></a></li><li><a href="#changes-since-40"><span>Changes since 4.0</span></a></li><li><a href="#changes-since-410-beta-10"><span>Changes since 4.1.0-<wbr/>beta-<wbr/>10</span></a></li><li><a href="#410-beta17"><span>4.1.0-<wbr/>beta.17</span></a></li><li><a href="#410-beta16"><span>4.1.0-<wbr/>beta.16</span></a></li><li><a href="#410-beta15"><span>4.1.0-<wbr/>beta.15</span></a></li><li><a href="#410-beta13-410-beta14"><span>4.1.0-<wbr/>beta.13 / 4.1.0-<wbr/>beta.14</span></a></li></ul></div></details></div><div class="site-menu"><nav class="tsd-navigation"><a href="modules.html">jsf.js_next_gen</a><ul class="tsd-small-nested-navigation" id="tsd-nav-container"><li>Loading...</li></ul></nav></div></div></div><footer><p class="tsd-generator">Generated using <a href="https://typedoc.org/" target="_blank">TypeDoc</a></p></footer><div class="overlay"></div></body></html>

package/dist/window/faces-development.js

@@ -1827,11 +1827,16 @@ class DomQuery {
         if (this.isAbsent()) {
             return undefined;
         }
-        let focusElementId = (_a = document === null || document === void 0 ? void 0 : document.activeElement) === null || _a === void 0 ? void 0 : _a.id;
-        let caretPosition = (focusElementId) ? DomQuery.getCaretPosition(document.activeElement) : null;
+        let toReplace = this.getAsElem(0).value;
+        let activeElement = document === null || document === void 0 ? void 0 : document.activeElement;
+        let focusElementId = activeElement === null || activeElement === void 0 ? void 0 : activeElement.id;
+        // only save/restore the caret if the focused element is actually part of the
+        // subtree that gets replaced. Otherwise updating an unrelated component would
+        // reset the caret of a different, still focused input field.
+        let restoreFocus = !!focusElementId && !!((_a = toReplace === null || toReplace === void 0 ? void 0 : toReplace.contains) === null || _a === void 0 ? void 0 : _a.call(toReplace, activeElement));
+        let caretPosition = restoreFocus ? DomQuery.getCaretPosition(activeElement) : null;
         let nodes = DomQuery.fromMarkup(markup);
         let res = [];
-        let toReplace = this.getAsElem(0).value;
         let firstInsert = nodes.get(0);
         let parentNode = toReplace.parentNode;
         let replaced = firstInsert.getAsElem(0).value;
@@ -1852,10 +1857,12 @@ class DomQuery {
         if (runEmbeddedCss) {
             this.runCss();
         }
-        let focusElement = DomQuery.byId(focusElementId);
-        if (focusElementId && focusElement.isPresent() &&
-            caretPosition != null && "undefined" != typeof caretPosition) {
-            focusElement.eachElem(item => DomQuery.setCaretPosition(item, caretPosition));
+        if (restoreFocus) {
+            let focusElement = DomQuery.byId(focusElementId);
+            if (focusElement.isPresent() &&
+                caretPosition != null && "undefined" != typeof caretPosition) {
+                focusElement.eachElem(item => DomQuery.setCaretPosition(item, caretPosition));
+            }
         }
         return nodes;
     }
@@ -2322,25 +2329,18 @@ class DomQuery {
         }
         return false;
     }
-    // from
-    // http:// blog.vishalon.net/index.php/javascript-getting-and-setting-caret-position-in-textarea/
     static getCaretPosition(ctrl) {
-        let caretPos = 0;
         try {
-            if (document === null || document === void 0 ? void 0 : document.selection) {
-                ctrl.focus();
-                let selection = document.selection.createRange();
-                // the selection now is start zero
-                selection.moveStart('character', -ctrl.value.length);
-                // the caret-position is the selection start
-                caretPos = selection.text.length;
+            // selectionStart is supported on text inputs/textareas in every relevant
+            // browser (IE9+ and all modern engines)
+            if (typeof (ctrl === null || ctrl === void 0 ? void 0 : ctrl.selectionStart) === "number") {
+                return ctrl.selectionStart;
             }
         }
         catch (e) {
-            // now this is ugly, but not supported input types throw errors for selectionStart
-            // just in case someone dumps this code onto unsupported browsers
+            // some input types throw on selectionStart access; treat as "no caret"
         }
-        return caretPos;
+        return 0;
     }
     /**
      * sets the caret position
@@ -6913,7 +6913,7 @@ class Messages {
         /** @constant */
         this.ERR_TRANSPORT = "Transport type {0} does not exist";
         /** @constant */
-        this.ERR_EVT_PASS = "an event must be passed down (either a an event object null or undefined) ";
+        this.ERR_EVT_PASS = "an event must be passed down (either an event object null or undefined) ";
         /** @constant */
         this.ERR_CONSTRUCT = "Parts of the response couldn't be retrieved when constructing the event data= {0} ";
         /** @constant */
@@ -7160,7 +7160,7 @@ class AsyncRunnable {
     }
     /**
      * registers a finally functor
-     * @param func the functor for the finally handling chanin
+     * @param func the functor for the finally handling chain
      */
     finally(func) {
         // no ie11 support we probably are going to revert to shims for that one
@@ -7515,6 +7515,21 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony import */ var mona_dish__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! mona-dish */ "./node_modules/mona-dish/src/main/typescript/index_core.ts");
 /* harmony import */ var _ExtDomQuery__WEBPACK_IMPORTED_MODULE_1__ = __webpack_require__(/*! ./ExtDomQuery */ "./src/main/typescript/impl/util/ExtDomQuery.ts");
 /* harmony import */ var _core_Const__WEBPACK_IMPORTED_MODULE_2__ = __webpack_require__(/*! ../core/Const */ "./src/main/typescript/impl/core/Const.ts");
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
 
 
@@ -7991,6 +8006,21 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export */   XhrQueueController: () => (/* binding */ XhrQueueController)
 /* harmony export */ });
 /* harmony import */ var _Lang__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ./Lang */ "./src/main/typescript/impl/util/Lang.ts");
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
 const debounce = _Lang__WEBPACK_IMPORTED_MODULE_0__.ExtLang.debounce;
 /**
@@ -9790,7 +9820,7 @@ class XhrRequest extends _util_AsyncRunnable__WEBPACK_IMPORTED_MODULE_0__.AsyncR
     appendIssuingItem(formData) {
         var _a, _b;
         const issuingItemId = this.internalContext.getIf(_core_Const__WEBPACK_IMPORTED_MODULE_7__.CTX_PARAM_SRC_CTL_ID).value;
-        //to avoid sideffects with buttons we only can append the issuing item if no behavior event is set
+        //to avoid side effects with buttons we only can append the issuing item if no behavior event is set
         //MYFACES-4679!
         const eventType = (_b = (_a = formData.getIf((0,_core_Const__WEBPACK_IMPORTED_MODULE_7__.$nsp)(_core_Const__WEBPACK_IMPORTED_MODULE_7__.P_BEHAVIOR_EVENT)).value) === null || _a === void 0 ? void 0 : _a[0]) !== null && _b !== void 0 ? _b : null;
         const isBehaviorEvent = !!eventType && eventType !== 'click';