jsf.js_next_gen 4.1.0-beta.12 → 4.1.0-beta.14

package/AI_CONTRIBUTIONS.md

@@ -0,0 +1,66 @@
+# AI Contributions Disclosure
+
+In accordance with the [Apache Software Foundation policy on generative AI tooling](https://www.apache.org/legal/generative-tooling.html), this file discloses that portions of this project were created or substantially modified with assistance from generative AI tools.
+
+## Tool used
+
+**Claude** (Anthropic) — conversational AI coding assistant
+
+## Scope
+
+All new source files and substantial modifications introduced from the TypeScript 6 migration onwards (starting with commit `d609321` in http://github.com/werpu/jsf_js_ts) were produced with AI assistance. This covers both production source code and test code.
+
+### Newly created files (AI-generated)
+
+- `src/main/typescript/@types/definitions/modules.d.ts`
+- `src/main/typescript/test/api/JsfPushShimTest.spec.ts`
+- `src/main/typescript/test/api/PushTypeCompatibility.ts`
+- `src/main/typescript/test/impl/AssertionsTest.spec.ts`
+- `src/main/typescript/test/impl/FileUtilsTest.spec.ts`
+- `src/main/typescript/test/impl/ResponseDataResolverTest.spec.ts`
+- `src/main/typescript/test/impl/util/ExtLangTest.spec.ts`
+- `src/main/typescript/test/impl/util/HiddenInputBuilderTest.spec.ts`
+- `src/main/typescript/test/xhrCore/WebsocketTest.spec.ts`
+
+### Substantially modified files (AI-assisted)
+
+- `src/main/typescript/api/_api.ts`
+- `src/main/typescript/api/faces.ts`
+- `src/main/typescript/api/jsf.ts`
+- `src/main/typescript/impl/AjaxImpl.ts`
+- `src/main/typescript/impl/PushImpl.ts`
+- `src/main/typescript/impl/util/Assertions.ts`
+- `src/main/typescript/impl/util/AsyncRunnable.ts`
+- `src/main/typescript/impl/util/ExtDomQuery.ts`
+- `src/main/typescript/impl/util/FileUtils.ts`
+- `src/main/typescript/impl/util/HiddenInputBuilder.ts`
+- `src/main/typescript/impl/util/Lang.ts`
+- `src/main/typescript/impl/util/XhrQueueController.ts`
+- `src/main/typescript/impl/xhrCore/ErrorData.ts`
+- `src/main/typescript/impl/xhrCore/EventData.ts`
+- `src/main/typescript/impl/xhrCore/IResponseProcessor.ts`
+- `src/main/typescript/impl/xhrCore/RequestDataResolver.ts`
+- `src/main/typescript/impl/xhrCore/Response.ts`
+- `src/main/typescript/impl/xhrCore/ResponseDataResolver.ts`
+- `src/main/typescript/impl/xhrCore/ResponseProcessor.ts`
+- `src/main/typescript/impl/xhrCore/XhrFormData.ts`
+- `src/main/typescript/impl/xhrCore/XhrRequest.ts`
+- `src/main/typescript/myfaces/OamSubmit.ts`
+- `src/main/typescript/test/frameworkBase/_ext/monadish/DomQueryTest.spec.ts`
+- `src/main/typescript/test/frameworkBase/_ext/shared/StandardInits.ts`
+- `src/main/typescript/test/impl/util/ExtDomQueryTest.spec.ts`
+- `src/main/typescript/test/myfaces/OamSubmit.spec.ts`
+- `src/main/typescript/test/queue/AsynchronousQueueTest.spec.ts`
+- `src/main/typescript/test/xhrCore/ErrorChainTest.spec.ts`
+- `src/main/typescript/test/xhrCore/FakeWebsocket.ts`
+- `src/main/typescript/test/xhrCore/RequestTest.spec.ts`
+- `src/main/typescript/test/xhrCore/ResponseTest.spec.ts`
+- `src/main/typescript/test/xhrCore/TobagoFileUploadTest.spec.ts`
+- `src/main/typescript/test/xhrCore/XhrFormDataTest.spec.ts`
+- `src/main/typescript/@types/definitions/index.d.ts`
+
+## Nature of AI assistance
+
+The AI assistant was used interactively: the human author directed the work, reviewed all output, made corrections, 
+and approved each change before it was applied. 
+The AI did not commit code autonomously. All contributions remain under the Apache License 2.0.

package/README.md

@@ -251,4 +251,42 @@ faces.ajax.request(document.getElementById("cmd_eval"), null,
   * Added tests that max reconnect exhaustion calls `onclose`.
   * Added tests that close code `1008` is terminal and does not reconnect.
   * Added tests that explicit `open()` after a terminal close fires `onopen` again as a fresh connection.
-  * JSF 2.3 jsf.push.init compatibility test added
+  * JSF 2.3 jsf.push.init compatibility test added
+
+4.1.0-beta.12
+
+Bug Fixes
+
+- WebSocket push spec alignment (PushImpl.ts): Full compliance with the Jakarta Faces push specification on 2,2 and 2.3 level
+  - hasEverConnected flag is now set before firing onopen callbacks (prevents re-entrant terminal-close edge case)
+  - Code 1000 (normal closure) is now always treated as terminal regardless of reason, per spec
+  - reconnectAttempts and hasEverConnected are reset after a terminal close, allowing faces.push.open() to re-establish a connection and fire onopen again
+- XhrQueueController debounce race condition: Each XhrQueueController instance now uses a unique debounce key — previously all instances shared one key, causing     
+  enqueues on separate instances to cancel each other's debounce window
+- Code cleanup: Removed dead exports from ResponseDataResolver.ts; minor cleanup in _api.ts and PushImpl.ts
+
+Improvements
+
+- PushImpl.ts readability: Lifecycle code refactored for clarity
+- FileUtils.ts: Minor code improvements (stricter equality, cleaner split)
+
+Tests
+
+- Added tests for WebSocket re-open after terminal close
+- Added XhrQueueController two-instance debounce isolation test
+- Added direct unit tests for FileUtils (encodeFormData, decodeEncodedValues, fixEmptyParameters)
+- Added tests for Assertions.ts — branch coverage up to ~88%
+- Added tests for ResponseDataResolver.resolveContexts
+- Added tests for ExtDomQuery (nonce DOM fallback, runHeadInserts text-node path) and ExtConfig (append, appendIf, deepCopy)
+- Added tests for HiddenInputBuilder, Lang, and async queue     
+
+
+## 4.1.0-beta.13
+
+- Added AI disclaimers to fulfill the ASF criteria for code being integrated into the Apache MyFaces codebase
+
+Note as of Version 4.0 the code has been improved with the help of 
+generative AI Tooling, as per https://www.apache.org/legal/generative-tooling.html
+disclosures now are added!
+See AI_CONTRIBUTIONS.md for full disclosure
+

package/dist/docs/index.html

@@ -220,4 +220,41 @@ and adjusts the references in the resource according to the request patterns.</p
 </ul>
 </li>
 </ul>
-</div></div><div class="col-sidebar"><div class="page-menu"><div class="tsd-navigation settings"><details class="tsd-accordion"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>Settings</h3></summary><div class="tsd-accordion-details"><div class="tsd-filter-visibility"><span class="settings-label">Member Visibility</span><ul id="tsd-filter-options"><li class="tsd-filter-item"><label class="tsd-filter-input"><input type="checkbox" id="tsd-filter-inherited" name="inherited" checked/><svg width="32" height="32" viewBox="0 0 32 32" aria-hidden="true"><rect class="tsd-checkbox-background" width="30" height="30" x="1" y="1" rx="6" fill="none"></rect><path class="tsd-checkbox-checkmark" d="M8.35422 16.8214L13.2143 21.75L24.6458 10.25" stroke="none" stroke-width="3.5" stroke-linejoin="round" fill="none"></path></svg><span>Inherited</span></label></li></ul></div><div class="tsd-theme-toggle"><label class="settings-label" for="tsd-theme">Theme</label><select id="tsd-theme"><option value="os">OS</option><option value="light">Light</option><option value="dark">Dark</option></select></div></div></details></div><details open class="tsd-accordion tsd-page-navigation"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>On This Page</h3></summary><div class="tsd-accordion-details"><a href="#🚀-scratchpad-for-the-typescript-based-reimplementation-of-jsfjs"><span>🚀 <wbr/>Scratchpad for the <wbr/>Type<wbr/>Script-<wbr/>based reimplementation of jsf.js</span></a><ul><li><a href="#what-is-this"><span>What is this?</span></a></li><li><a href="#status"><span>Status</span></a></li><li><ul><li><a href="#special-info"><span>Special <wbr/>Info</span></a></li><li><a href="#general-build"><span>General <wbr/>Build</span></a></li><li><ul><li><a href="#on-windows"><span>On <wbr/>Windows</span></a></li></ul></li><li><a href="#tests"><span>Tests</span></a></li><li><a href="#test-coverage"><span>Test <wbr/>Coverage</span></a></li><li><a href="#changelist-compared-to-the-original-implementation"><span>Changelist compared to the original implementation</span></a></li></ul></li><li><a href="#upload-support"><span>Upload <wbr/>Support</span></a></li><li><a href="#changes-since-40"><span>Changes since 4.0</span></a></li><li><a href="#changes-since-410-beta-10"><span>Changes since 4.1.0-<wbr/>beta-<wbr/>10</span></a></li></ul></div></details></div><div class="site-menu"><nav class="tsd-navigation"><a href="modules.html">jsf.js_next_gen</a><ul class="tsd-small-nested-navigation" id="tsd-nav-container"><li>Loading...</li></ul></nav></div></div></div><footer><p class="tsd-generator">Generated using <a href="https://typedoc.org/" target="_blank">TypeDoc</a></p></footer><div class="overlay"></div></body></html>
+<p>4.1.0-beta.12</p>
+<p>Bug Fixes</p>
+<ul>
+<li>WebSocket push spec alignment (PushImpl.ts): Full compliance with the Jakarta Faces push specification on 2,2 and 2.3 level
+<ul>
+<li>hasEverConnected flag is now set before firing onopen callbacks (prevents re-entrant terminal-close edge case)</li>
+<li>Code 1000 (normal closure) is now always treated as terminal regardless of reason, per spec</li>
+<li>reconnectAttempts and hasEverConnected are reset after a terminal close, allowing faces.push.open() to re-establish a connection and fire onopen again</li>
+</ul>
+</li>
+<li>XhrQueueController debounce race condition: Each XhrQueueController instance now uses a unique debounce key — previously all instances shared one key, causing<br>
+enqueues on separate instances to cancel each other's debounce window</li>
+<li>Code cleanup: Removed dead exports from ResponseDataResolver.ts; minor cleanup in _api.ts and PushImpl.ts</li>
+</ul>
+<p>Improvements</p>
+<ul>
+<li>PushImpl.ts readability: Lifecycle code refactored for clarity</li>
+<li>FileUtils.ts: Minor code improvements (stricter equality, cleaner split)</li>
+</ul>
+<p>Tests</p>
+<ul>
+<li>Added tests for WebSocket re-open after terminal close</li>
+<li>Added XhrQueueController two-instance debounce isolation test</li>
+<li>Added direct unit tests for FileUtils (encodeFormData, decodeEncodedValues, fixEmptyParameters)</li>
+<li>Added tests for Assertions.ts — branch coverage up to ~88%</li>
+<li>Added tests for ResponseDataResolver.resolveContexts</li>
+<li>Added tests for ExtDomQuery (nonce DOM fallback, runHeadInserts text-node path) and ExtConfig (append, appendIf, deepCopy)</li>
+<li>Added tests for HiddenInputBuilder, Lang, and async queue</li>
+</ul>
+<h2 id="410-beta13" class="tsd-anchor-link">4.1.0-beta.13<a href="#410-beta13" aria-label="Permalink" class="tsd-anchor-icon"><svg viewBox="0 0 24 24" aria-hidden="true"><use href="assets/icons.svg#icon-anchor"></use></svg></a></h2>
+<ul>
+<li>Added AI disclaimers to fulfill the ASF criteria for code being integrated into the Apache MyFaces codebase</li>
+</ul>
+<p>Note as of Version 4.0 the code has been improved with the help of
+generative AI Tooling, as per <a href="https://www.apache.org/legal/generative-tooling.html">https://www.apache.org/legal/generative-tooling.html</a>
+disclosures now are added!
+See AI_CONTRIBUTIONS.md for full disclosure</p>
+</div></div><div class="col-sidebar"><div class="page-menu"><div class="tsd-navigation settings"><details class="tsd-accordion"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>Settings</h3></summary><div class="tsd-accordion-details"><div class="tsd-filter-visibility"><span class="settings-label">Member Visibility</span><ul id="tsd-filter-options"><li class="tsd-filter-item"><label class="tsd-filter-input"><input type="checkbox" id="tsd-filter-inherited" name="inherited" checked/><svg width="32" height="32" viewBox="0 0 32 32" aria-hidden="true"><rect class="tsd-checkbox-background" width="30" height="30" x="1" y="1" rx="6" fill="none"></rect><path class="tsd-checkbox-checkmark" d="M8.35422 16.8214L13.2143 21.75L24.6458 10.25" stroke="none" stroke-width="3.5" stroke-linejoin="round" fill="none"></path></svg><span>Inherited</span></label></li></ul></div><div class="tsd-theme-toggle"><label class="settings-label" for="tsd-theme">Theme</label><select id="tsd-theme"><option value="os">OS</option><option value="light">Light</option><option value="dark">Dark</option></select></div></div></details></div><details open class="tsd-accordion tsd-page-navigation"><summary class="tsd-accordion-summary"><svg width="20" height="20" viewBox="0 0 24 24" fill="none" aria-hidden="true"><use href="assets/icons.svg#icon-chevronDown"></use></svg><h3>On This Page</h3></summary><div class="tsd-accordion-details"><a href="#🚀-scratchpad-for-the-typescript-based-reimplementation-of-jsfjs"><span>🚀 <wbr/>Scratchpad for the <wbr/>Type<wbr/>Script-<wbr/>based reimplementation of jsf.js</span></a><ul><li><a href="#what-is-this"><span>What is this?</span></a></li><li><a href="#status"><span>Status</span></a></li><li><ul><li><a href="#special-info"><span>Special <wbr/>Info</span></a></li><li><a href="#general-build"><span>General <wbr/>Build</span></a></li><li><ul><li><a href="#on-windows"><span>On <wbr/>Windows</span></a></li></ul></li><li><a href="#tests"><span>Tests</span></a></li><li><a href="#test-coverage"><span>Test <wbr/>Coverage</span></a></li><li><a href="#changelist-compared-to-the-original-implementation"><span>Changelist compared to the original implementation</span></a></li></ul></li><li><a href="#upload-support"><span>Upload <wbr/>Support</span></a></li><li><a href="#changes-since-40"><span>Changes since 4.0</span></a></li><li><a href="#changes-since-410-beta-10"><span>Changes since 4.1.0-<wbr/>beta-<wbr/>10</span></a></li><li><a href="#410-beta13"><span>4.1.0-<wbr/>beta.13</span></a></li></ul></div></details></div><div class="site-menu"><nav class="tsd-navigation"><a href="modules.html">jsf.js_next_gen</a><ul class="tsd-small-nested-navigation" id="tsd-nav-container"><li>Loading...</li></ul></nav></div></div></div><footer><p class="tsd-generator">Generated using <a href="https://typedoc.org/" target="_blank">TypeDoc</a></p></footer><div class="overlay"></div></body></html>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsf.js_next_gen",
-  "version": "4.1.0-beta.12",
+  "version": "4.1.0-beta.14",
   "description": "A next generation typescript reimplementation of jsf.js",
   "main": "dist/window/faces.js",
   "scripts": {
@@ -55,6 +55,6 @@
     "uuid": "^14.0.0"
   },
   "dependencies": {
-    "mona-dish": "0.40.0-beta.3"
+    "mona-dish": "0.40.0-beta.4"
   }
 }

package/src/main/typescript/@types/definitions/modules.d.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 
 declare module "mona-dish/dist/js/umd/index.js" {
     export * from "mona-dish";

package/src/main/typescript/test/api/JsfPushShimTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 import {describe} from "mocha";
 import * as sinon from "sinon";
 import {expect} from "chai";

package/src/main/typescript/test/api/PushTypeCompatibility.ts

@@ -13,7 +13,17 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 
+/**
+ * Compile-time type compatibility check for Push.init() overloads.
+ *
+ * This file is never executed. Its only purpose is to make the TypeScript
+ * compiler verify that both supported call signatures of Push.init() are
+ * accepted: the 4-callback form (onopen, onmessage, onerror, onclose) and
+ * the legacy 3-callback form (onmessage, onerror, onclose). If either
+ * overload is accidentally broken, tsc will reject this file.
+ */
 function verifyPushInitTypeCompatibility(push: Push): void {
     push.init("clientId1", "booga.ws", "mychannel",
         () => {},

package/src/main/typescript/test/impl/AssertionsTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 import {describe, it} from "mocha";
 import {expect} from "chai";
 import {XMLQuery} from "mona-dish";

package/src/main/typescript/test/impl/FileUtilsTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 import {describe, it} from "mocha";
 import {expect} from "chai";
 import {Config} from "mona-dish";

package/src/main/typescript/test/impl/ResponseDataResolverTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 import {describe, it} from "mocha";
 import {expect} from "chai";
 import {resolveContexts} from "../../impl/xhrCore/ResponseDataResolver";

package/src/main/typescript/test/impl/util/ExtLangTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 
 import {describe} from "mocha";
 import {expect} from "chai";

package/src/main/typescript/test/impl/util/HiddenInputBuilderTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 
 import {describe} from "mocha";
 import {expect} from "chai";

package/src/main/typescript/test/xhrCore/WebsocketTest.spec.ts

@@ -13,6 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+// AI-generated: this file was created with assistance from Claude (Anthropic) — see AI_CONTRIBUTIONS.md
 import {describe} from "mocha";
 import * as sinon from "sinon";
 import * as nise from "nise";