jsf.js_next_gen 4.0.1-beta.1 → 4.0.1-beta.3

package/src/main/typescript/test/frameworkBase/_ext/monadish/markups/tobago-without-header.ts

@@ -0,0 +1,108 @@
+export const tobagoSheetWithoutHeader = `<tobago-sheet id="page:mainForm:s1" data-tobago-selection-mode="multi" data-tobago-first="0" rows="0" row-count="88" data-tobago-layout="{&quot;columns&quot;:[1.0]}">
+  <style nonce="" id="page:mainForm:s1:j_id_2n">#page\\:mainForm\\:s1{max-height:486px;}
+  </style>
+  <input id="page:mainForm:s1::widths" name="page:mainForm:s1::widths" type="hidden" value="[]">
+  <input id="page:mainForm:s1::rendered" name="page:mainForm:s1::rendered" type="hidden" value="[true]">
+  <input id="page:mainForm:s1::scrollPosition" name="page:mainForm:s1::scrollPosition" type="hidden" value="[0,0]">
+  <input id="page:mainForm:s1::selected" name="page:mainForm:s1::selected" type="hidden" value="[]">
+  <div class="tobago-body">
+    <table cellspacing="0" cellpadding="0" summary="" class="table table-sm tobago-tableLayout-fixed">
+      <colgroup>
+        <col>
+        <col>
+      </colgroup>
+      <tbody>
+      <tr row-index="0" id="page:mainForm:s1:0:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:0:t_name"><span class="form-control-plaintext">Sun</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:0:sample0" execute="page:mainForm:s1:0:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="1" id="page:mainForm:s1:1:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:1:t_name"><span class="form-control-plaintext">Mercury</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:1:sample0" execute="page:mainForm:s1:1:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="2" id="page:mainForm:s1:2:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:2:t_name"><span class="form-control-plaintext">Venus</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:2:sample0" execute="page:mainForm:s1:2:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="3" id="page:mainForm:s1:3:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:3:t_name"><span class="form-control-plaintext">Earth</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:3:sample0" execute="page:mainForm:s1:3:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="4" id="page:mainForm:s1:4:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:4:t_name"><span class="form-control-plaintext">Mars</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:4:sample0" execute="page:mainForm:s1:4:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="5" id="page:mainForm:s1:5:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:5:t_name"><span class="form-control-plaintext">Jupiter</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:5:sample0" execute="page:mainForm:s1:5:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="6" id="page:mainForm:s1:6:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:6:t_name"><span class="form-control-plaintext">Saturn</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:6:sample0" execute="page:mainForm:s1:6:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="7" id="page:mainForm:s1:7:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:7:t_name"><span class="form-control-plaintext">Uranus</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:7:sample0" execute="page:mainForm:s1:7:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      <tr row-index="8" id="page:mainForm:s1:8:sample0">
+        <td>
+          <tobago-out id="page:mainForm:s1:8:t_name"><span class="form-control-plaintext">Neptune</span></tobago-out>
+        </td>
+        <td>
+          <div>
+          </div>
+          <tobago-behavior event="click" client-id="page:mainForm:s1:8:sample0" execute="page:mainForm:s1:8:sample0"></tobago-behavior>
+        </td>
+      </tr>
+      </tbody>
+    </table>
+  </div>
+</tobago-sheet>`;

package/src/main/typescript/test/frameworkBase/_ext/shared/StandardInits.ts

@@ -83,6 +83,7 @@ export module StandardInits {
 <body>
 <form id="blarg">
     <input type="text" id="input_1" name="input_1" value="input_1_val"></input>
+    <input type="text" id="input_2_text" name="input_2_text" value="input_2_text_val"></input>
     <input type="hidden" id="jakarta.faces.ViewState" name="jakarta.faces.ViewState" value="blubbblubblubb"></input>
     <input type="button" id="input_2" name="input_2" value="input_1_val"></input>
 </form>
@@ -222,7 +223,7 @@ export module StandardInits {
     <meta charset="UTF-8">
     <title>Title</title>
     <script type="text/javascript"
-            src="/wfmportal/${IS_40 ? 'jakarta' : 'javax'}.faces.resource/${IS_40 ? 'faces': 'jsf'}.js.jsf?ln=jakarta.faces&separator=${separatorChar}"></script>
+            src="./fixtures/${IS_40 ? 'jakarta' : 'javax'}.faces.resource/${IS_40 ? 'faces': 'jsf'}.js.jsf?ln=jakarta.faces&separator=${separatorChar}"></script>
 </head>
 <body>
 <form id="blarg">
@@ -513,7 +514,7 @@ export module StandardInits {
         //let dom2 = new JSDOM(template)
         //return initMyFacesFromDom(dom2);
         let clean = null;
-        //we use jsdom global to fullfill our requirements
+        //we use jsdom global to fulfill our requirements
         //we need to import dynamically and use awaits
         if (withJsf) {
 

package/src/main/typescript/test/myfaces/OnLoadSpec.ts

@@ -0,0 +1,52 @@
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import {describe, it} from "mocha";
+
+import {expect} from "chai";
+import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
+import defaultMyFaces = StandardInits.defaultMyFaces;
+
+
+
+declare var myfaces: any;
+
+/**
+ * Adds test s for the newly introduced onload handling
+ */
+describe('Tests on the xhr core when it starts to call the request', function () {
+
+    beforeEach(async () => {
+        return
+    });
+
+    it("must be present", async function(done)  {
+        await defaultMyFaces();
+        expect(myfaces?.onDomReady).to.exist;
+        done();
+    });
+
+    it("must be called on onDocumentReady", async function(done) {
+        let called: boolean = false;
+        const onDomCalled = () => {
+            expect(true).to.true;
+            done();
+        }
+        myfaces?.onDomReady(onDomCalled);
+        await defaultMyFaces();
+    });
+
+});

package/src/main/typescript/test/queue/AsynchronousProbe.ts

@@ -18,10 +18,10 @@
  * we need a probe to test our asynchronous behavior
  * the asynchronous behavior needs to be in an asynchronous runnable
  */
-import {AsyncRunnable} from "../../impl/util/AsyncRunnable";
+import {IAsyncRunnable} from "../../impl/util/AsyncRunnable";
 import {IValueHolder} from "mona-dish";
 
-export class ProbeClass implements AsyncRunnable<Promise<any>>, IValueHolder<Promise<any>> {
+export class ProbeClass implements IAsyncRunnable<Promise<any>>, IValueHolder<Promise<any>> {
 
     value: Promise<any>;
     fCatch: (data: any) => any;
@@ -44,7 +44,7 @@ export class ProbeClass implements AsyncRunnable<Promise<any>>, IValueHolder<Pro
         });
     }
 
-    catch(func: (data: any) => any): AsyncRunnable<boolean> {
+    catch(func: (data: any) => any): IAsyncRunnable<boolean> {
         let catchFunc = (data: any) => {
             this.catchPerformed = true;
             return func(data);
@@ -57,7 +57,7 @@ export class ProbeClass implements AsyncRunnable<Promise<any>>, IValueHolder<Pro
         return this;
     }
 
-    finally(func: () => void): AsyncRunnable<boolean> {
+    finally(func: () => void): IAsyncRunnable<boolean> {
         let finallyFunc = () => {
             this.finallyPerformed = true;
             func();
@@ -88,7 +88,7 @@ export class ProbeClass implements AsyncRunnable<Promise<any>>, IValueHolder<Pro
         //TODO do something with it
     }
 
-    then(func: (data: any) => any): AsyncRunnable<boolean> {
+    then(func: (data: any) => any): IAsyncRunnable<boolean> {
 
         let thenFunc = (data: any) => {
             this.thenPerformed = true;

package/src/main/typescript/test/queue/AsynchronousQueueTest.spec.ts

@@ -18,10 +18,11 @@ import {describe, it} from 'mocha';
 import {expect} from 'chai';
 import * as sinon from 'sinon';
 import {ProbeClass} from "./AsynchronousProbe";
-import {AsynchronousQueue} from "../../impl/util/AsyncQueue";
+
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 import {Implementation} from "../../impl/AjaxImpl";
 import defaultMyFaces = StandardInits.defaultMyFaces;
+import {XhrQueueController} from "../../impl/util/XhrQueueController";
 
 describe('Asynchronous Queue tests', () => {
 
@@ -60,7 +61,7 @@ describe('Asynchronous Queue tests', () => {
 
         const probe1 = new ProbeClass(setTimeout);
 
-        const queue = new AsynchronousQueue();
+        const queue = new XhrQueueController();
         probe1.then(() => {
             expect(probe1.thenPerformed, "called").to.be.true;
             done();
@@ -69,7 +70,7 @@ describe('Asynchronous Queue tests', () => {
     });
 
     it('multiple  entries', (done) => {
-        const queue = new AsynchronousQueue();
+        const queue = new XhrQueueController();
         const probe1 = new ProbeClass(setTimeout);
         const probe2 = new ProbeClass(setTimeout);
         const probe3 = new ProbeClass(setTimeout);

package/src/main/typescript/test/xhrCore/EventTests.spec.ts

@@ -87,28 +87,34 @@ describe('tests the addOnEvent and addOnError handling', function () {
     });
 
     it("must have onError called in case of error", function () {
-        let onErrorCalled1 = 0;
-        let onErrorCalled2 = 0;
-
-        let errorTitle = '';
-        let errorMessage = '';
-        faces.ajax.addOnError((data: any) => {
-            errorTitle = data.errorName;
-            errorMessage = data.errorMessage;
-            onErrorCalled1++
-        });
-        faces.ajax.addOnError(() => {
-            onErrorCalled2++;
-        });
-
-        //cmd_error_component
-        DQ.byId("cmd_error_component").click();
-        this.respond(XmlResponses.ERROR_2);
-
-        expect(onErrorCalled1).to.eq(1);
-        expect(onErrorCalled2).to.eq(1);
-        expect(errorTitle).to.eq('Erro21');
-        expect(errorMessage).to.eq('serverError: Error2 Text');
+        const oldErr = console.error;
+        console.error = () => {}
+        try {
+            let onErrorCalled1 = 0;
+            let onErrorCalled2 = 0;
+
+            let errorTitle = '';
+            let errorMessage = '';
+            faces.ajax.addOnError((data: any) => {
+                errorTitle = data.errorName;
+                errorMessage = data.errorMessage;
+                onErrorCalled1++
+            });
+            faces.ajax.addOnError(() => {
+                onErrorCalled2++;
+            });
+
+            //cmd_error_component
+            DQ.byId("cmd_error_component").click();
+            this.respond(XmlResponses.ERROR_2);
+
+            expect(onErrorCalled1).to.eq(1);
+            expect(onErrorCalled2).to.eq(1);
+            expect(errorTitle).to.eq('Erro21');
+            expect(errorMessage).to.eq('serverError: Error2 Text');
+        } finally {
+            console.error = oldErr;
+        }
     });
 
     it("must have an id set if there is an emitting element", function () {

package/src/main/typescript/test/xhrCore/NamespacesRequestTest.spec.ts

@@ -24,7 +24,7 @@ import {
     COMPLETE,
     P_AJAX,
     P_EXECUTE,
-    P_PARTIAL_SOURCE,
+    P_AJAX_SOURCE,
     P_RENDER,
     P_VIEWSTATE,
     P_WINDOW_ID,
@@ -107,7 +107,7 @@ describe('Namespacing tests', function () {
             expect(!!resultsMap["execute"]).to.be.false;
             expect(P_WINDOW_ID in resultsMap).to.be.false;
             expect(P_VIEWSTATE in resultsMap).to.be.true;
-            expect(resultsMap[P_PARTIAL_SOURCE]).to.eq(escape("jd_0:input_2"));
+            expect(resultsMap[P_AJAX_SOURCE]).to.eq(escape("jd_0:input_2"));
             expect(resultsMap[P_AJAX]).to.eq("true");
             expect(resultsMap[P_RENDER]).to.eq(escape("jd_0:blarg jd_0:input_2"));
             expect(resultsMap[P_EXECUTE]).to.eq(escape("jd_0:input_1 jd_0:input_2"));
@@ -143,7 +143,7 @@ describe('Namespacing tests', function () {
             expect(!!resultsMap["execute"]).to.be.false;
             expect(P_WINDOW_ID in resultsMap).to.be.false;
             expect(P_VIEWSTATE in resultsMap).to.be.true;
-            expect(resultsMap[P_PARTIAL_SOURCE]).to.eq(escape("jd_0:input_2"));
+            expect(resultsMap[P_AJAX_SOURCE]).to.eq(escape("jd_0:input_2"));
             expect(resultsMap[P_AJAX]).to.eq("true");
             expect(resultsMap[P_RENDER]).to.eq(escape("jd_0:blarg jd_0:input_2"));
             expect(resultsMap[P_EXECUTE]).to.eq(escape("jd_0:input_1 jd_0:input_2"));
@@ -191,7 +191,7 @@ describe('Namespacing tests', function () {
             let viewState = Stream.ofAssoc(resultsMap).filter(data => data[0].indexOf(P_VIEWSTATE) != -1).map(item => item[1]).first().value;
 
             expect(viewState).to.eq("booga");
-            expect(resultsMap[NAMING_CONTAINER_PREF + P_PARTIAL_SOURCE]).to.eq("jd_0:input_2");
+            expect(resultsMap[NAMING_CONTAINER_PREF + P_AJAX_SOURCE]).to.eq("jd_0:input_2");
             expect(resultsMap[NAMING_CONTAINER_PREF + P_AJAX]).to.eq("true");
             expect(resultsMap[NAMING_CONTAINER_PREF + P_RENDER]).to.eq("jd_0:blarg jd_0:input_2");
             expect(resultsMap[NAMING_CONTAINER_PREF + P_EXECUTE]).to.eq("jd_0:input_1 jd_0:input_2");

package/src/main/typescript/test/xhrCore/RequestParamsTest.spec.ts

@@ -31,7 +31,7 @@ import {ExtConfig} from "../../impl/util/ExtDomQuery";
  * @param keyValueEntries a list of key value entries divided by =
  * @param paramsMapper a key value remapper
  */
-function mergeKeyValueEntries(target: Config, keyValueEntries: Stream<string[]>, paramsMapper = (key, value) => [key, value]) {
+function mergeKeyValueEntries(target: Config, keyValueEntries: string[][], paramsMapper = (key, value) => [key, value]) {
 
     function fixKeyWithoutVal(keyVal: string[]) {
         return keyVal.length < 3 ? [keyVal?.[0] ?? [], keyVal?.[1] ?? []] : keyVal;
@@ -42,7 +42,7 @@ function mergeKeyValueEntries(target: Config, keyValueEntries: Stream<string[]>,
         //special case of having keys without values
         .map(keyVal => fixKeyWithoutVal(keyVal))
         .map(keyVal => paramsMapper(keyVal[0] as string, keyVal[1]))
-        .each(keyVal => {
+        .forEach(keyVal => {
             let value = keyVal?.splice(1)?.join("") ?? "";
             if(toMerge.getIfPresent(keyVal[0]).isPresent()) {
                 toMerge.append(keyVal[0] as string).value = value;

package/src/main/typescript/test/xhrCore/RequestTest.spec.ts

@@ -23,7 +23,7 @@ import {
     COMPLETE, EMPTY_STR,
     P_AJAX,
     P_EXECUTE,
-    P_PARTIAL_SOURCE,
+    P_AJAX_SOURCE,
     P_RENDER,
     P_VIEWSTATE,
     P_WINDOW_ID,
@@ -45,6 +45,29 @@ let issueStdReq = function (element) {
         }
     });
 };
+
+
+let issueStdPPSReq = function (element) {
+    faces.ajax.request(element, null, {
+        execute: "input_1",
+        render: "@form",
+        /*
+        * myfaces is the extension placeholder, atm only pps is used
+        * which was the most useful extension in our legacy codebase
+        */
+        myfaces: {
+            pps: true
+        },
+        /*
+         * params is the spec conform way to pass additional request paramerters
+         */
+        params: {
+            pass1: "pass1",
+            pass2: "pass2"
+        }
+    });
+};
+
 /**
  * specialized tests testing the xhr core behavior when it hits the xmlHttpRequest object
  */
@@ -119,13 +142,16 @@ describe('Tests on the xhr core when it starts to call the request', function ()
                 resultsMap[keyVal[0]] = keyVal[1];
             }
 
+            // normal request, all issuing form must be encoded!
+            expect(!!(resultsMap?.["input_2_text"] ?? false)).to.eq(true);
+            expect(!!(resultsMap?.["input_1"] ?? false)).to.eq(true);
             expect(resultsMap["pass1"]).to.eq("pass1");
             expect(resultsMap["pass2"]).to.eq("pass2");
             expect(!!resultsMap["render"]).to.be.false;
             expect(!!resultsMap["execute"]).to.be.false;
             expect(P_WINDOW_ID in resultsMap).to.be.false;
             expect(P_VIEWSTATE in resultsMap).to.be.true;
-            expect(resultsMap[P_PARTIAL_SOURCE]).to.eq("input_2");
+            expect(resultsMap[P_AJAX_SOURCE]).to.eq("input_2");
             expect(resultsMap[P_AJAX]).to.eq("true");
             expect(resultsMap[P_RENDER]).to.eq("blarg");
             expect(resultsMap[P_EXECUTE]).to.eq("input_1%20input_2");
@@ -292,7 +318,7 @@ describe('Tests after core when it hits response', function () {
                         expect(!!lastArg.onError).to.be.false;
                         expect(lastArg.pass1 == "pass1").to.be.true;
                         expect(lastArg.pass2 == "pass2").to.be.true;
-                        expect(!!lastArg[P_PARTIAL_SOURCE]).to.be.true;
+                        expect(!!lastArg[P_AJAX_SOURCE]).to.be.true;
                         expect(!!lastArg[P_AJAX]).to.be.true;
                         expect(!!lastArg[P_EXECUTE]).to.be.true;
                         expect(!!lastArg[P_RENDER]).to.be.true;
@@ -354,7 +380,7 @@ describe('Tests after core when it hits response', function () {
                         expect(!!lastArg.onError).to.be.false;
                         expect(lastArg.pass1 == "pass1").to.be.true;
                         expect(lastArg.pass2 == "pass2").to.be.true;
-                        expect(!!lastArg[P_PARTIAL_SOURCE]).to.be.true;
+                        expect(!!lastArg[P_AJAX_SOURCE]).to.be.true;
                         expect(!!lastArg[P_AJAX]).to.be.true;
                         expect(!!lastArg[P_EXECUTE]).to.be.true;
                         expect(!!lastArg[P_RENDER]).to.be.true;
@@ -417,7 +443,7 @@ describe('Tests after core when it hits response', function () {
                         expect(!!lastArg.onError).to.be.false;
                         expect(lastArg.pass1 == "pass1").to.be.true;
                         expect(lastArg.pass2 == "pass2").to.be.true;
-                        expect(!!lastArg[P_PARTIAL_SOURCE]).to.be.true;
+                        expect(!!lastArg[P_AJAX_SOURCE]).to.be.true;
                         expect(!!lastArg[P_AJAX]).to.be.true;
                         expect(!!lastArg[P_EXECUTE]).to.be.true;
                         expect(!!lastArg[P_RENDER]).to.be.true;
@@ -451,9 +477,10 @@ describe('Tests after core when it hits response', function () {
 
         let send = sinon.spy(XMLHttpRequest.prototype, "send");
         let xhrReq = null;
-
+        const oldErr = console.error;
         try {
             let errorCnt = 0;
+
             let element = DomQuery.byId("input_2").getAsElem(0).value;
             faces.ajax.request(element, null, {
                 execute: "input_1",
@@ -474,6 +501,8 @@ describe('Tests after core when it hits response', function () {
                 },
                 onevent: (evt: any) => {
                     if (evt.status == COMPLETE) {
+                        console.error = () => {
+                        };
                         throw Error("This error is wanted, ignore the log");
                     }
                 }
@@ -484,9 +513,13 @@ describe('Tests after core when it hits response', function () {
             xhrReq.respond(200, {'Content-Type': 'text/xml'}, STD_XML);
 
         } catch (e) {
+            if (e.message.indexOf("This error is wanted") != -1) {
+                return;
+            }
             console.error(e);
 
         } finally {
+            console.error = oldErr;
             send.restore();
         }
 
@@ -557,6 +590,47 @@ describe('Tests after core when it hits response', function () {
         done("Expecting a client error to be thrown")
     });
 
+    it("must have a proper working myfaces.pps = true, partial page submit", function (done) {
+        /**
+         * derived from the passthrough test
+         */
+        let send = sinon.spy(XMLHttpRequest.prototype, "send");
+        try {
+            //we only issue input 1
+            let element = DomQuery.byId("input_1").getAsElem(0).value;
+            issueStdPPSReq(element);
+
+            expect(send.called).to.be.true;
+            let argsVal: any = send.args[0][0];
+            let arsArr = argsVal.split("&");
+            let resultsMap = {};
+            for (let val of arsArr) {
+                let keyVal = val.split("=");
+                resultsMap[keyVal[0]] = keyVal[1];
+            }
+
+            expect(resultsMap?.["input_2_text"] ?? false).to.eq(false);
+            expect(!!(resultsMap?.["input_1"] ?? false)).to.eq(true);
+            expect(resultsMap["pass1"]).to.eq("pass1");
+            expect(resultsMap["pass2"]).to.eq("pass2");
+            expect(!!resultsMap["render"]).to.be.false;
+            expect(!!resultsMap["execute"]).to.be.false;
+            expect(P_WINDOW_ID in resultsMap).to.be.false;
+            expect(P_VIEWSTATE in resultsMap).to.be.true;
+            expect(resultsMap[P_AJAX_SOURCE]).to.eq("input_1");
+            expect(resultsMap[P_AJAX]).to.eq("true");
+            expect(resultsMap[P_RENDER]).to.eq("blarg");
+            expect(resultsMap[P_EXECUTE]).to.eq("input_1");
+
+
+            // TODO the request map only has the params and input1_ and input_2 passed no matter now many other values
+            // we might have to add some input elements into the form which are filetered out
+        } finally {
+            send.restore();
+        }
+        done();
+    });
+
 
 });
 

package/src/main/typescript/test/xhrCore/RequestTest_23.spec.ts

@@ -324,7 +324,7 @@ describe('Tests after core when it hits response', function () {
 
         let send = sinon.spy(XMLHttpRequest.prototype, "send");
         let xhrReq = null;
-
+        let oldErr = console.error;
         try {
             let element = DomQuery.byId("input_2").getAsElem(0).value;
             jsf.ajax.request(element, null, {
@@ -344,6 +344,7 @@ describe('Tests after core when it hits response', function () {
                 },
                 onevent: (evt: any) => {
                     if (evt.status == COMPLETE) {
+                        console.error = () => {};
                         throw Error("This error is wanted, ignore the log");
                     }
                 }
@@ -354,9 +355,13 @@ describe('Tests after core when it hits response', function () {
             xhrReq.respond(200, {'Content-Type': 'text/xml'}, STD_XML);
 
         } catch (e) {
+            if(e.message.indexOf("This error is wanted") != -1) {
+                return;
+            }
             console.error(e);
 
         } finally {
+            console.error = oldErr;
             send.restore();
         }
 

package/src/main/typescript/test/xhrCore/ResponseTest.spec.ts

@@ -517,7 +517,6 @@ describe('Tests of the various aspects of the response protocol functionality',
         </partial-response>`
 
         window.document.body.innerHTML = INNER_HTML_MULIT_VIEW;
-        global["debug4"] = true;
         faces.ajax.request(window.document.getElementById("viewroot_1:submit_1"), null, {
             "javax.faces.behavior.event": "change",
             execute: "submit_1",
@@ -675,7 +674,7 @@ describe('Tests of the various aspects of the response protocol functionality',
         });
 
         //TODO xhr stubbing, to check if the viewId is prepended in render!
-
+        global["state_1"] = true;
         this.respond(`<?xml version="1.0" encoding="UTF-8"?>
 <partial-response id="viewroot_1">
     <changes>
@@ -727,35 +726,37 @@ describe('Tests of the various aspects of the response protocol functionality',
     it('must handle a ViewExpired Error correctly, and only once in a listener', function (done) {
 
         document.body.innerHTML = TCK_790_NAV_MARKUP;
-
-        let errorCalled = 0;
-        faces.ajax.addOnError((error)=> {
-            expect(error.errorName).to.eq("jakarta.faces.application.ViewExpiredException");
-            expect(error.errorMessage).to.eq("serverError: View \"/testhmtl.xhtml\" could not be restored.");
-            expect(error.source.id).to.eq("form1x:button");
-            errorCalled++;
-        });
-
-        faces.ajax.request(window.document.getElementById("form1x:button"), null, {
-            "javax.faces.behavior.event": "click",
-            execute: "@form",
-            render: ":form1x:button"
-        });
-
-        this.respond(`<?xml version="1.0" encoding="UTF-8"?>
+        const oldErr = console.error;
+        console.error = () => {};
+        try {
+            let errorCalled = 0;
+            faces.ajax.addOnError((error) => {
+                expect(error.errorName).to.eq("jakarta.faces.application.ViewExpiredException");
+                expect(error.errorMessage).to.eq("serverError: View \"/testhmtl.xhtml\" could not be restored.");
+                expect(error.source.id).to.eq("form1x:button");
+                errorCalled++;
+            });
+
+            faces.ajax.request(window.document.getElementById("form1x:button"), null, {
+                "javax.faces.behavior.event": "click",
+                execute: "@form",
+                render: ":form1x:button"
+            });
+
+            this.respond(`<?xml version="1.0" encoding="UTF-8"?>
         <partial-response><error>
         <error-name>jakarta.faces.application.ViewExpiredException</error-name>
         <error-message><![CDATA[View "/testhmtl.xhtml" could not be restored.]]></error-message>
         </error>
         </partial-response>`)
 
-        expect(errorCalled).to.eq(1);
-
+            expect(errorCalled).to.eq(1);
+        } finally {
+            console.error = oldErr;
+        }
         done();
 
     });
 
 
-
-
 });

package/target/api/_api.js

@@ -261,7 +261,7 @@ var myfaces;
      *
      * @param executionFunc the function to be executed upon ready
      */
-    function onOnDomReady(executionFunc) {
+    function onDomReady(executionFunc) {
         if (document.readyState !== "complete") {
             onReadyChain.push(executionFunc);
             if (!readyStateListener) {
@@ -286,7 +286,7 @@ var myfaces;
             executionFunc();
         }
     }
-    myfaces.onOnDomReady = onOnDomReady;
+    myfaces.onDomReady = onDomReady;
     /**
      * legacy oam functions
      */