jsf.js_next_gen 4.0.0-beta-18 → 4.0.0-beta-19

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jsf.js_next_gen",
-  "version": "4.0.0-beta-18",
+  "version": "4.0.0-beta-19",
   "description": "A next generation typescript reimplementation of jsf.js",
   "main": "dist/window/faces.js",
   "scripts": {

package/src/main/typescript/@types/definitions/index.d.ts

@@ -1,4 +1,4 @@
-/* Licensed to the Apache Software Foundation (ASF) under one or more
+/*! Licensed to the Apache Software Foundation (ASF) under one or more
  * contributor license agreements.  See the NOTICE file distributed with
  * this work for additional information regarding copyright ownership.
  * The ASF licenses this file to you under the Apache License, Version 2.0
@@ -17,29 +17,18 @@
 /**
  * Basic internal types used
  *
- * This file is only to eliminate various any calls into
- * window, jsf and myfaces and make also the calls into
- * the apis from a an extended window context in a type safe
- * way
- *
- * We use this trick to map the types into the modules
- * which we need to produce proper jsdoc files
+ * This file is only there to allow global calls into window, faces and ajax
+ * in a typesafe manner, hence eliminating <b>any</b> casts.
  */
 declare global {
 
-    type Producer<T> = () => T;
     type Consumer<T> = (s?: T) => void;
-    type Runnable = () => any;
-    type Transformable<S, T> = (s: S) => T;
-
     type AssocArr<T> = { [key: string]: T };
-
     type EvalFuncs = Array<Function | string>;
     type Options = { [key: string]: string | Function | { [key: string]: string | Function } };
     type Context = AssocArr<any>;
     type ElemDef = Element | string;
 
-
     /**
      *  * <ul>
      *     <li> errorData.type : &quot;error&quot;</li>
@@ -58,7 +47,6 @@ declare global {
         serverErrorName: string;
         serverErrorMessage: string;
         source: any;
-
         responseCode: string;
         responseText: string;
         responseXML: string;
@@ -74,29 +62,8 @@ declare global {
         source: any;
     }
 
-    /*! Licensed to the Apache Software Foundation (ASF) under one or more
-     * contributor license agreements.  See the NOTICE file distributed with
-     * this work for additional information regarding copyright ownership.
-     * The ASF licenses this file to you under the Apache License, Version 2.0
-     * (the "License"); you may not use this file except in compliance with
-     * the License.  You may obtain a copy of the License at
-     *
-     *      http://www.apache.org/licenses/LICENSE-2.0
-     *
-     * Unless required by applicable law or agreed to in writing, software
-     * distributed under the License is distributed on an "AS IS" BASIS,
-     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-     * See the License for the specific language governing permissions and
-     * limitations under the License.
-     */
-
-    /**
-     * interface definitions to make the code more compiler typesafe
-     */
-
     interface Ajax {
         request(element: Element, event?: Event, options?: Context): void;
-
         response(request: XMLHttpRequest, context?: Context): void;
     }
 
@@ -113,13 +80,10 @@ declare global {
              onclose: Function,
              behaviorScripts: any,
              autoconnect: boolean): void;
-
         open(socketClientId: string);
-
         close(socketClientId: string): void;
     }
 
-
     interface FacesAPI {
         contextpath: string;
         specversion: number;
@@ -155,10 +119,18 @@ declare global {
         };
     }
 
+    /*
+     * Global namespaces type definitions
+     */
     let myfaces: MyFacesAPI;
     let jsf: FacesAPI;
     let faces: FacesAPI;
-    // special trick, the typscript compiler treats window as Window
+
+    // special "magic", Typescript merges whatever we have
+    // to window. This is a language "hack", but documented.
+    // see https://www.typescriptlang.org/docs/handbook/declaration-files/templates/global-modifying-module-d-ts.html
+    // lib.dom.d.ts declares the type Window as being type for window.
+    // noinspection JSUnusedGlobalSymbols
     interface Window {
         myfaces: MyFacesAPI,
         faces: FacesAPI,
@@ -167,7 +139,9 @@ declare global {
         called: { [key: string]: any }
     }
 }
+
 // this is needed to tell the compiler that we have an ambient
 // module, otherwise the global overload would produce an error
+// https://www.typescriptlang.org/docs/handbook/declaration-files/templates/global-modifying-module-d-ts.html
 // noinspection JSUnusedGlobalSymbols
 export var __my_faces_ambient_module_glob_;

package/src/main/typescript/test/impl/ImplTest.spec.ts

@@ -14,16 +14,14 @@
  * limitations under the License.
  */
 
-import {Config} from "mona-dish";
+import {Config, DomQuery} from "mona-dish";
 import {describe, it} from 'mocha';
 import {expect} from 'chai';
 import * as sinon from 'sinon';
 
-import {DomQuery} from "mona-dish";
-
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
-import defaultMyFaces = StandardInits.defaultMyFaces;
 import {P_EXECUTE, P_RENDER} from "../../impl/core/Const";
+import defaultMyFaces = StandardInits.defaultMyFaces;
 
 
 sinon.reset();
@@ -48,8 +46,7 @@ describe('faces.ajax.request test suite', () => {
         //we stub the addRequestToQueue, to enable the request check only
         //without any xhr and response, both will be tested separately for
         //proper behavior
-        const Impl = Implementation;
-        const addRequestToQueue = sinon.stub(Impl.queueHandler, "addRequestToQueue");
+        const addRequestToQueue = sinon.stub(Implementation.queueHandler, "addRequestToQueue");
         //now the faces.ajax.request should trigger but should not go into
         //the asynchronous event loop.
         //lets check it out
@@ -61,8 +58,6 @@ describe('faces.ajax.request test suite', () => {
 
             expect(addRequestToQueue.called).to.be.true;
             expect(addRequestToQueue.callCount).to.eq(1);
-
-            const argElement = <Config>addRequestToQueue.args[0][2];
             const context = (<Config>addRequestToQueue.args[0][2]);
 
             expect(context.getIf("passThrgh", P_RENDER).value).eq("@all");

package/src/main/typescript/test/impl/ImplTest_23.spec.ts

@@ -14,13 +14,11 @@
  * limitations under the License.
  */
 
-import {Config} from "mona-dish";
+import {Config, DomQuery} from "mona-dish";
 import {describe, it} from 'mocha';
 import {expect} from 'chai';
 import * as sinon from 'sinon';
 
-import {DomQuery} from "mona-dish";
-
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 import {P_EXECUTE, P_RENDER} from "../../impl/core/Const";
 import defaultMyFaces23 = StandardInits.defaultMyFaces23;
@@ -41,16 +39,14 @@ declare var Implementation: any;
 describe('javax.ajax.request test suite', () => {
 
     beforeEach(async () => {
-        let ret = await defaultMyFaces23();
-        return ret;
+        return await defaultMyFaces23();
     });
 
     it("jsf.ajax.request can be called", () => {
         //we stub the addRequestToQueue, to enable the request check only
         //without any xhr and response, both will be tested separately for
         //proper behavior
-        const Impl = Implementation;
-        const addRequestToQueue = sinon.stub(Impl.queueHandler, "addRequestToQueue");
+        const addRequestToQueue = sinon.stub(Implementation.queueHandler, "addRequestToQueue");
         //now the javax.ajax.request should trigger but should not go into
         //the asynchronous event loop.
         //lets check it out
@@ -62,8 +58,6 @@ describe('javax.ajax.request test suite', () => {
 
             expect(addRequestToQueue.called).to.be.true;
             expect(addRequestToQueue.callCount).to.eq(1);
-
-            const argElement = <Config>addRequestToQueue.args[0][2];
             const context = (<Config>addRequestToQueue.args[0][2]);
 
             expect(context.getIf("passThrgh", P_RENDER).value).eq("@all");

package/src/main/typescript/test/impl/SeparatorCharsTest.spec.ts

@@ -21,8 +21,6 @@ import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 import defaultMyFaces = StandardInits.defaultMyFaces;
 import defaultSeparatorChar = StandardInits.defaultSeparatorChar;
 
-const jsdom = require("jsdom");
-const {JSDOM} = jsdom;
 sinon.reset();
 
 declare var faces: any;

package/src/main/typescript/test/xhrCore/EventTests.spec.ts

@@ -28,6 +28,7 @@ declare var faces: any;
 
 describe('tests the addOnEvent and addOnError handling', function () {
 
+    // noinspection DuplicatedCode
     beforeEach(async function () {
         let waitForResult = protocolPage();
         return waitForResult.then((close) => {
@@ -36,7 +37,7 @@ describe('tests the addOnEvent and addOnError handling', function () {
             this.requests = [];
 
             this.respond = (response: string): XMLHttpRequest => {
-                let xhrReq = this.requests.shift();
+                let xhrReq = (this.requests as Array<any>).shift();
                 xhrReq.responsetype = "text/xml";
                 xhrReq.respond(200, {'Content-Type': 'text/xml'}, response);
                 return xhrReq;
@@ -59,13 +60,6 @@ describe('tests the addOnEvent and addOnError handling', function () {
     afterEach(function () {
         this.closeIt();
     });
-
-    let allowedStati = {
-        "begin": true,
-        "complete": true,
-        "success": true,
-    };
-
     it("must have a global add on event call with all three phases passed", function () {
         let onEventCalled1 = 0;
         let onEventCalled2 = 0;
@@ -82,11 +76,10 @@ describe('tests the addOnEvent and addOnError handling', function () {
                 throw ("Wrong status")
             }
         });
-        faces.ajax.addOnEvent((data: any) => {
+        faces.ajax.addOnEvent(() => {
             onEventCalled2++;
-
         });
-        let issuer = DQ.byId("cmd_update_insert").click();
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_1);
 
         expect(onEventCalled1).to.eq(3);
@@ -104,12 +97,12 @@ describe('tests the addOnEvent and addOnError handling', function () {
             errorMessage = data.errorMessage;
             onErrorCalled1++
         });
-        faces.ajax.addOnError((data: any) => {
+        faces.ajax.addOnError(() => {
             onErrorCalled2++;
         });
 
         //cmd_error_component
-        let issuer = DQ.byId("cmd_error_component").click();
+        DQ.byId("cmd_error_component").click();
         this.respond(XmlResponses.ERROR_2);
 
         expect(onErrorCalled1).to.eq(1);
@@ -119,7 +112,6 @@ describe('tests the addOnEvent and addOnError handling', function () {
     });
 
     it("must have an id set if there is an emitting element", function () {
-        let onEventCalled1 = 0;
         let onEventCalled2 = 0;
 
         let assertSourceExists = (data: any) => {
@@ -129,11 +121,11 @@ describe('tests the addOnEvent and addOnError handling', function () {
         faces.ajax.addOnEvent((data: any) => {
             assertSourceExists(data);
         });
-        faces.ajax.addOnEvent((data: any) => {
+        faces.ajax.addOnEvent(() => {
             onEventCalled2++;
 
         });
-        let issuer = DQ.byId("cmd_update_insert").click();
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_1);
 
     });

package/src/main/typescript/test/xhrCore/FakeWebsocket.ts

@@ -19,14 +19,14 @@ export class FakeWebsocket {
     onmessage: Function = () => {}
     onclose: Function = () => {}
 
-    constructor(data?: any) {
+    constructor() {
         setTimeout(() => {
             this.onopen();
         }, 10);
     }
 
 
-    send(msg: any) {
+    send() {
     }
 
     _respond(response: any) {

package/src/main/typescript/test/xhrCore/FileUploadTest.spec.ts

@@ -18,33 +18,10 @@ import * as sinon from "sinon";
 import {expect} from "chai";
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
 import {DomQuery} from "mona-dish";
-import {
-    COMPLETE,
-    P_AJAX,
-    P_EXECUTE,
-    P_PARTIAL_SOURCE,
-    P_RENDER,
-    P_VIEWSTATE,
-    P_WINDOW_ID,
-    SUCCESS
-} from "../../impl/core/Const";
-import defaultMyFaces = StandardInits.defaultMyFaces;
-import STD_XML = StandardInits.STD_XML;
 import defaultFileForm = StandardInits.defaultFileForm;
 import {Implementation} from "../../impl/AjaxImpl";
 
 declare var faces: any;
-declare var Impl
-
-
-let issueStdReq = function (element) {
-    faces.ajax.request(element, null, {
-        execute: "input_1",
-        render: "@form",
-        pass1: "pass1",
-        pass2: "pass2"
-    });
-};
 
 /**
  * specialized tests testing the xhr core behavior when it hits the xmlHttpRequest object
@@ -87,7 +64,6 @@ describe('Tests on the xhr core when it starts to call the request', function ()
     it('must have sent a form multipart request', function (done) {
         let send = sinon.spy(XMLHttpRequest.prototype, "send");
         const CONTENT_TYPE = "Content-Type";
-        const MULTIPART_FORM = "multipart/form-data";
         const POST = "POST";
 
         try {
@@ -119,7 +95,6 @@ describe('Tests on the xhr core when it starts to call the request', function ()
         let send = sinon.spy(XMLHttpRequest.prototype, "send");
 
         const CONTENT_TYPE = "Content-Type";
-        const MULTIPART_FORM = "multipart/form-data";
         const POST = "POST";
 
         try {

package/src/main/typescript/test/xhrCore/RequestParamsTest.spec.ts

@@ -16,23 +16,13 @@
 import * as sinon from "sinon";
 import {Implementation} from "../../impl/AjaxImpl";
 import {StandardInits} from "../frameworkBase/_ext/shared/StandardInits";
-import defaultMyFaces = StandardInits.defaultMyFaces;
+
 import protocolPage = StandardInits.protocolPage;
 import {DQ} from "mona-dish";
 import {XhrFormData} from "../../impl/xhrCore/XhrFormData";
 import { expect } from "chai";
 
 describe("test for proper request param patterns identical to the old implementation", function () {
-    const DELETE_PATTERN = {
-        op: "delete1",
-        "jakarta.faces.source": "cmd_delete",
-        "jakarta.faces.partial.event": "click",
-        "jakarta.faces.partial.ajax": "true",
-        "jakarta.faces.partial.execute": "cmd_delete",
-        "form1": "form1",
-        "jakarta.faces.ViewState": "blubbblubblubb"
-    }
-
     const UPDATE_INSERT_2 = {
         "op": "updateinsert2",
         "jakarta.faces.partial.event": "click",
@@ -42,17 +32,6 @@ describe("test for proper request param patterns identical to the old implementa
         "form1": "form1",
         "jakarta.faces.ViewState": "blubbblubblubb"
     }
-
-    const ERRORS = {
-        "op": "errors",
-        "jakarta.faces.partial.event": "click",
-        "jakarta.faces.source": "cmd_error",
-        "jakarta.faces.partial.ajax": "true",
-        "jakarta.faces.partial.execute": "cmd_error",
-        "form1": "form1",
-        "jakarta.faces.ViewState": "blubbblubblubb"
-    }
-
     /**
      * matches two maps for absolute identicality
      */

package/src/main/typescript/test/xhrCore/RequestTest_23.spec.ts

@@ -57,9 +57,9 @@ function remapNamespacesFor23() {
 
 
 let {
-    P_PARTIAL_SOURCE, P_VIEWSTATE, P_VIEWROOT, P_VIEWHEAD, P_VIEWBODY,
-    P_AJAX, P_EXECUTE, P_RENDER, P_EVT, P_CLIENT_WINDOW, P_RESET_VALUES,
-    P_WINDOW_ID, ENCODED_URL
+    P_PARTIAL_SOURCE, P_VIEWSTATE,
+    P_AJAX, P_EXECUTE, P_RENDER,
+    P_WINDOW_ID
 } = remapNamespacesFor23();
 
 
@@ -232,7 +232,7 @@ describe('Tests after core when it hits response', function () {
                 render: "@form",
                 pass1: "pass1",
                 pass2: "pass2",
-                onevent: (evt: any) => {
+                onevent: () => {
                     localCnt++;
                 }
             });
@@ -325,7 +325,6 @@ describe('Tests after core when it hits response', function () {
         let xhrReq = null;
 
         try {
-            let errorCnt = 0;
             let element = DomQuery.byId("input_2").getAsElem(0).value;
             jsf.ajax.request(element, null, {
                 execute: "input_1",

package/src/main/typescript/test/xhrCore/ResponseTest.spec.ts

@@ -21,9 +21,8 @@ import * as sinon from "sinon";
 
 import {XmlResponses} from "../frameworkBase/_ext/shared/XmlResponses";
 import {expect} from "chai";
-import protocolPage = StandardInits.protocolPage;
 import {DQ} from "mona-dish";
-import {Optional} from "mona-dish";
+import protocolPage = StandardInits.protocolPage;
 
 declare var faces: any;
 declare var Implementation: any;
@@ -70,8 +69,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
     it("must have a simple field updated as well as the viewstate", function (done) {
         //DQ.byId("cmd_update_insert").click();
-        let issuer = DQ.byId("cmd_update_insert").click();
-
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_1);
 
         expect(DQ.byId("changesArea")
@@ -102,8 +100,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
     it("must have a simple field updated  with the second before update rendering path", function (done) {
         //DQ.byId("cmd_update_insert").click();
-        let issuer = DQ.byId("cmd_update_insert").click();
-
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_2);
 
         expect(DQ.byId("changesArea")
@@ -158,7 +155,6 @@ describe('Tests of the various aspects of the response protocol functionality',
         this.respond(XmlResponses.HEAD_REPLACEMENT);
 
         //basic replacement
-        let newHead = DQ.byId(document.head);
         let newBody = DQ.byId(document.body);
         let newContent = <string>newBody.html().value;
 
@@ -219,8 +215,7 @@ describe('Tests of the various aspects of the response protocol functionality',
     });
 
     it("must have processed a proper eval of a script given in the eval tag", function () {
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         this.respond(XmlResponses.EVAL_1);
 
         let resultHTML: string = <string>DQ.byId(document.body).html().value;
@@ -229,9 +224,7 @@ describe('Tests of the various aspects of the response protocol functionality',
     });
 
     it("must have updated the viewstates properly", function () {
-
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         /*js full submit form, coming from the integration tests*/
         window.document.body.innerHTML = `<form id="j_id__v_0" name="j_id__v_0" method="post" action="/IntegrationJSTest/integrationtestsjasmine/test7-eventtest.jsf"
       enctype="application/x-www-form-urlencoded"><span id="updatePanel">hello world</span><a href="#"
@@ -266,9 +259,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
 
     it("must have updated the viewstates properly with lenient update block", function () {
-
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         /*js full submit form, coming from the integration tests*/
         window.document.body.innerHTML = `<form id="j_id__v_0" name="j_id__v_0" method="post" action="/IntegrationJSTest/integrationtestsjasmine/test7-eventtest.jsf"
       enctype="application/x-www-form-urlencoded"><span id="updatePanel">hello world</span><a href="#"

package/src/main/typescript/test/xhrCore/ResponseTest23.spec.ts

@@ -6,7 +6,7 @@
  * the License.  You may obtain a copy of the License at
  *
  *      http://www.apache.org/licenses/LICENSE-2.0
- *
+ *Ø
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -72,10 +72,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
     it("must have a simple field updated as well as the viewstate", function (done) {
         //DQ.byId("cmd_update_insert").click();
-
-
-        let issuer = DQ.byId("cmd_update_insert").click();
-
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_1);
 
         expect(DQ.byId("changesArea")
@@ -106,8 +103,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
     it("must have a simple field updated  with the second before update rendering path", function (done) {
         //DQ.byId("cmd_update_insert").click();
-        let issuer = DQ.byId("cmd_update_insert").click();
-
+        DQ.byId("cmd_update_insert").click();
         this.respond(XmlResponses.UPDATE_INSERT_2);
 
         expect(DQ.byId("changesArea")
@@ -162,7 +158,6 @@ describe('Tests of the various aspects of the response protocol functionality',
         this.respond(XmlResponses.HEAD_REPLACEMENT);
 
         //basic replacement
-        let newHead = DQ.byId(document.head);
         let newBody = DQ.byId(document.body);
         let newContent = <string>newBody.html().value;
 
@@ -223,8 +218,7 @@ describe('Tests of the various aspects of the response protocol functionality',
     });
 
     it("must have processed a proper eval of a script given in the eval tag", function () {
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         this.respond(XmlResponses.EVAL_1);
 
         let resultHTML: string = <string>DQ.byId(document.body).html().value;
@@ -233,9 +227,7 @@ describe('Tests of the various aspects of the response protocol functionality',
     });
 
     it("must have updated the viewstates properly", function () {
-
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         /*js full submit form, coming from the integration tests*/
         window.document.body.innerHTML = `<form id="j_id__v_0" name="j_id__v_0" method="post" action="/IntegrationJSTest/integrationtestsjasmine/test7-eventtest.jsf"
       enctype="application/x-www-form-urlencoded"><span id="updatePanel">hello world</span><a href="#"
@@ -270,9 +262,7 @@ describe('Tests of the various aspects of the response protocol functionality',
 
 
     it("must have updated the viewstates properly with lenient update block", function () {
-
-        let issuer = DQ.byId("cmd_eval").click();
-
+        DQ.byId("cmd_eval").click();
         /*js full submit form, coming from the integration tests*/
         window.document.body.innerHTML = `<form id="j_id__v_0" name="j_id__v_0" method="post" action="/IntegrationJSTest/integrationtestsjasmine/test7-eventtest.jsf"
       enctype="application/x-www-form-urlencoded"><span id="updatePanel">hello world</span><a href="#"

package/src/main/typescript/test/xhrCore/ShadowDomTest.spec.ts

@@ -84,7 +84,6 @@ describe('shadow dom testsuite', () => {
 
 
     it("shadow dom updated triggered from outside", function() {
-        const Impl = Implementation;
         //const addRequestToQueue = sinon.stub(Impl.queueHandler, "addRequestToQueue");
 
         expect(DomQuery.querySelectorAll("#shadowDomArea").length).to.eq(1);

package/src/main/typescript/test/xhrCore/WebsocketTest.ts

@@ -126,13 +126,13 @@ describe('Tests the jsf websocket client side api on high level (generic test wi
 
         let msg = null;
         let cnl = null;
-        new Promise((resolve, reject) => {
+        new Promise((resolve) => {
             faces.push.init("blarg", "booga.ws", "mychannel", () => {
                     openCalled = true;
                     this.fakeWebsocket._respond({data: '"booga"'});
                 },
 
-                (message: string, channel: string, event: any) => {
+                (message: string, channel: string) => {
                     messageCalled = true;
                     msg = message;
                     cnl = channel;
@@ -174,13 +174,13 @@ describe('Tests the jsf websocket client side api on high level (generic test wi
 
         let msg = null;
         let cnl = null;
-        new Promise((resolve, reject) => {
+        new Promise((resolve) => {
             faces.push.init("blarg", "booga.ws", "mychannel", () => {
                     openCalled = true;
                     this.fakeWebsocket._respond({data: '"booga"'});
                 },
 
-                (message: string, channel: string, event: any) => {
+                (message: string, channel: string) => {
                     messageCalled = true;
                     msg = message;
                     cnl = channel;

package/target/test/impl/ImplTest.spec.js

@@ -47,13 +47,13 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+const mona_dish_1 = require("mona-dish");
 const mocha_1 = require("mocha");
 const chai_1 = require("chai");
 const sinon = __importStar(require("sinon"));
-const mona_dish_1 = require("mona-dish");
 const StandardInits_1 = require("../frameworkBase/_ext/shared/StandardInits");
-var defaultMyFaces = StandardInits_1.StandardInits.defaultMyFaces;
 const Const_1 = require("../../impl/core/Const");
+var defaultMyFaces = StandardInits_1.StandardInits.defaultMyFaces;
 sinon.reset();
 /**
  * testing the faces.ajax.request api without triggering any
@@ -69,8 +69,7 @@ sinon.reset();
         //we stub the addRequestToQueue, to enable the request check only
         //without any xhr and response, both will be tested separately for
         //proper behavior
-        const Impl = Implementation;
-        const addRequestToQueue = sinon.stub(Impl.queueHandler, "addRequestToQueue");
+        const addRequestToQueue = sinon.stub(Implementation.queueHandler, "addRequestToQueue");
         //now the faces.ajax.request should trigger but should not go into
         //the asynchronous event loop.
         //lets check it out
@@ -80,7 +79,6 @@ sinon.reset();
             }).click();
             (0, chai_1.expect)(addRequestToQueue.called).to.be.true;
             (0, chai_1.expect)(addRequestToQueue.callCount).to.eq(1);
-            const argElement = addRequestToQueue.args[0][2];
             const context = addRequestToQueue.args[0][2];
             (0, chai_1.expect)(context.getIf("passThrgh", Const_1.P_RENDER).value).eq("@all");
             //Execute issuing form due to @form and always the issuing element