js.documents 1.81.8 → 1.81.9

package/README.md

@@ -629,7 +629,7 @@ To run a single test file: `pnpm vitest run src/path/to/file.test.ts`.
 - **`ContentStroke.style` (`solid`/`dashed`/`dotted`/`double`) is not written by any vector writer, ODF or DrawingML.** Nothing in this package produces one — `LayoutLine` and `LayoutPath` both carry a stroke of colour and width only (`document-schema.js`'s `layout.ts`), so no reconstruction path can populate it — and `a:prstDash` has no `double` member to map the fourth value onto regardless. A hand-built `ContentVector` setting it consequently paints solid. A real, bounded gap rather than an oversight.
 - **`pdfToOds` recovers what was printed, not what was entered.** `reconstructSpreadsheet` (`src/layout/reconstruct.ts`) tries a real gridline lattice first: it scans the page's `LayoutLine`/stroked-single-segment-`LayoutPath` items (see the `interpret.ts` gotcha above) for enough parallel horizontal and vertical lines at consistent positions to call it a printed grid (`MIN_GRIDLINE_COUNT_PER_AXIS = 3` per axis, i.e. at least a 2×2 grid, and a span-consistency check that rejects a scatter of unrelated short strokes — a page border or a couple of decorative rules — as not a genuine lattice), and uses those line positions DIRECTLY as cell boundaries when found. Absent a lattice, it clusters text into a grid from geometry alone instead: rows reuse `clusterIntoLines` verbatim (a spreadsheet cell's own text is never wrapped across lines, so a text line already IS a row), and columns generalise `clusterIntoParagraphs`'s own single `dominantLeftX` to several recurring x-position anchors, first merging directly-adjacent same-line fragments (`splitLineByLargeGaps`, the same >2em-gap signal `reconstructPresentation`'s own block clustering uses) so a cell whose text arrived as several run-level-split `LayoutText` items isn't scattered across spurious columns. Column widths and row heights are genuinely measured from whichever geometry was used (drawn gridline gaps, or measured text/anchor extents), never invented. Every recovered cell always carries its own extracted `displayText` verbatim, and additionally carries a **heuristically re-typed** `value` wherever `src/layout/cell-typing.ts` finds exactly one defensible reading of that string; a formula is still never claimed. See the dedicated heuristic-re-typing gotcha below and [Fidelity](#fidelity) for the full framing. `buildOdsPackage` (`src/edit/ods/content.ts`) is `pdfToOds`'s own package-building half, mirroring `buildOdtPackage`/`buildOdpPackage`/`buildOdgPackage`'s role for `pdfToOdt`/`pdfToOdp`/`pdfToOdg`.
 - **`OdsSheet.printSettings` (`src/edit/ods/print-settings.ts`) now round-trips every field `ContentSheetPrintSettingsSchema` carries, not just the five it started with.** `pageSize`/`margins`/`gridlines`/`headers`/`pageOrder` resolve through the `table:style-name` → `style:style[family="table"]` → `style:master-page-name` → `style:master-page` → `style:page-layout` → `style:page-layout-properties` chain (`odf.js`'s own exported `findStyleElement`/`resolvePageLayoutProperties`/`parsePageSize`/`parseMargins`); the setter mints a fresh `style:page-layout` + `style:master-page` + `style:style[family="table"]` triple and repoints the sheet's own `table:style-name` to it on every call, the same append-only style-editing convention `src/edit/odg/style.ts` already documents. The remaining, previously-unimplemented fields are now implemented too: `printRange` reads/writes `table:print-ranges` directly on `table:table`; `scalePercent`/`fitToPages` read/write `style:scale-to` and `style:scale-to-X`/`style:scale-to-Y` on the page-layout-properties element; `repeatColumns`/`repeatRows` are read via `scanTableStructure`, a scoped-down mirror of `odf.js`'s own private `readTable`'s table-wide column/row cursor tracking (the same walk that function performs before ever calling its own `readPrintSettings`), and written by moving the real `table:table-column`/`table:table-row` elements covering the given range into a fresh `table:table-header-columns`/`table:table-header-rows` wrapper; `manualBreaks` read/write `fo:break-before="page"` on the named row/column's own style. Writing `repeatRows`/`repeatColumns` required teaching `address.ts`'s row/column addressing that a row/column may now live nested one level inside a header wrapper rather than as a direct `table:table` child, so a subsequent cell/column/row write against a wrapped index finds the real element instead of creating a spurious duplicate outside it; the width/height and manual-break writers all target the same `style:table-column-properties`/`style:table-row-properties` element, so each reads the column/row's current style first and mints a fresh style carrying the merged result, rather than a naive single-property mint clobbering whatever an earlier call had already set. No known gap remains in `ContentSheetPrintSettingsSchema` coverage.
-- **`OdsSheet` now has a real column-width/row-height setter (`setColumnWidth`/`setRowHeight`, `src/edit/ods/column-row.ts`), closing a gap that escalated from cosmetic to a genuine correctness bug once `xlsxToPdf`/`pdfToXlsx` started composing through `buildOdsPackage` internally.** `OdsSheet.cell()`'s own column/row-materialisation (`address.ts`) creates a real, explicit `table:table-column`/`table:table-row` element for any position a caller ever addresses, but previously never gave it a width/height style. This is a genuinely different failure shape from a column/row with NO element at all: `sheets.ts`'s own `resolveAxis` only falls back to `DEFAULT_COLUMN_WIDTH_PT`/`DEFAULT_ROW_HEIGHT_PT` for an index with no `ContentSheetColumn`/`ContentSheetRow` entry whatsoever — an explicit-but-unstyled element reads back at `widthPt`/`heightPt` 0 (`odf.js`'s own `resolveColumnWidthPt`/`readRowLayout`), and that explicit zero wins over the fallback. While `buildOdsPackage`'s own output was only ever a terminal deliverable (`pdfToOds`, or a caller's own `readOdsContent` round trip), this was cosmetic: a real app reopening it would use its own defaults instead of the source's. `xlsxToPdf` (`xlsxToOds` then `odsToPdf`) made it a real bug instead — the intermediate ods bytes get laid out again by `convertSpreadsheetToLayout`, and a zero-size grid collapses every cell onto the same physical position rather than merely losing precision. `setColumnWidth`/`setRowHeight` mint a fresh `style:style[family="table-column"|"table-row"]` per column/row and repoint its own `table:style-name`, the same append-only style-minting convention `writeSheetPrintSettings`/`src/edit/odg/style.ts` already establish; `buildOdsPackage` now calls both for every `ContentSheetColumn`/`ContentSheetRow` a source sheet carries. Column/row HIDDEN state and `ContentSheetImage`/formula `embeddedObjects` are no longer gaps either, closed in the same phase: `OdsSheet.setColumnHidden`/`setRowHidden` set or clear `table:visibility="collapse"` directly on the `table:table-column`/`table:table-row` element — a plain attribute, not a style property, so it never interacts with the width/height setters above — and `buildOdsPackage` calls one of these for every column/row whose `hidden` field is `true`. `OdsSheet.addImage` (`src/edit/ods/floating.ts`) writes a real floating `draw:frame`/`draw:image` into `table:shapes` (the ODF 1.3 content-model container for spreadsheet floating shapes, always `table:table`'s own first child in a package this editor builds), resolving a `ContentSheetImage`'s `anchorRow`/`anchorColumn` plus `offsetXPt`/`offsetYPt` to an absolute `svg:x`/`svg:y` by summing the real, currently-declared width/height of every column/row strictly before the anchor (header-wrapper-aware, hidden columns/rows contributing zero, falling back to the same default column/row size the layout engine assumes once the walk runs past what the sheet has declared) — reusing `addImageMedia` for the binary part and manifest entry, the same mechanism `src/edit/odp/image.ts` already uses for a slide. `OdsSheet.addEmbeddedObject` writes a real embedded ODF formula sub-document for `objectKind === 'formula'` (reusing `addFormulaObject`, the same mechanism `OdtBody.appendFormula` already uses); every other `objectKind` (`wordprocessing`/`presentation`/`spreadsheet`/`drawing`) is left unwritten, a documented, bounded gap mirroring `buildOdtPackage`'s identical narrowing for a `'drawing'` embedded object, since embedding one would mean writing that document's own package as a nested OLE sub-object, which no writer in this codebase implements. `buildOdsPackage` calls both for every sheet's images/embedded objects, after every column/row width/height/hidden call, so an image's own anchor resolves against the sheet's final, real column/row sizing. This is no longer write-only: `odf.js` 2.2.0's own `readOds` reads a sheet's floating shapes and embedded objects back (it previously hardcoded `images: []` and never set `embeddedObjects`), so a written image now verifies as a genuine `ContentDocument` re-read round trip — bytes, declared size, and anchor quartet — on top of the direct written-XML structural checks these tests already made.
+- **`OdsSheet` now has a real column-width/row-height setter (`setColumnWidth`/`setRowHeight`, `src/edit/ods/column-row.ts`), closing a gap that escalated from cosmetic to a genuine correctness bug once `xlsxToPdf`/`pdfToXlsx` started composing through `buildOdsPackage` internally.** `OdsSheet.cell()`'s own column/row-materialisation (`address.ts`) creates a real, explicit `table:table-column`/`table:table-row` element for any position a caller ever addresses, but previously never gave it a width/height style. This is a genuinely different failure shape from a column/row with NO element at all: `sheets.ts`'s own `resolveAxis` only falls back to `DEFAULT_COLUMN_WIDTH_PT`/`DEFAULT_ROW_HEIGHT_PT` for an index with no `ContentSheetColumn`/`ContentSheetRow` entry whatsoever — an explicit-but-unstyled element reads back at `widthPt`/`heightPt` 0 (`odf.js`'s own `resolveColumnWidthPt`/`readRowLayout`), and that explicit zero wins over the fallback. While `buildOdsPackage`'s own output was only ever a terminal deliverable (`pdfToOds`, or a caller's own `readOdsContent` round trip), this was cosmetic: a real app reopening it would use its own defaults instead of the source's. `xlsxToPdf` (`xlsxToOds` then `odsToPdf`) made it a real bug instead — the intermediate ods bytes get laid out again by `convertSpreadsheetToLayout`, and a zero-size grid collapses every cell onto the same physical position rather than merely losing precision. `setColumnWidth`/`setRowHeight` mint a fresh `style:style[family="table-column"|"table-row"]` per column/row and repoint its own `table:style-name`, the same append-only style-minting convention `writeSheetPrintSettings`/`src/edit/odg/style.ts` already establish; `buildOdsPackage` now calls both for every `ContentSheetColumn`/`ContentSheetRow` a source sheet carries. Column/row HIDDEN state and `ContentSheetImage`/formula `embeddedObjects` are no longer gaps either, closed in the same phase: `OdsSheet.setColumnHidden`/`setRowHidden` set or clear `table:visibility="collapse"` directly on the `table:table-column`/`table:table-row` element — a plain attribute, not a style property, so it never interacts with the width/height setters above — and `buildOdsPackage` calls one of these for every column/row whose `hidden` field is `true`. **The "explicit but unstyled" hazard itself is now closed at its source, not just worked around by callers who remember to call `setColumnWidth`/`setRowHeight` explicitly.** `column-row.ts`'s `ensureColumnDefaultWidth`/`ensureRowDefaultHeight` stamp `DEFAULT_COLUMN_WIDTH_PT`/`DEFAULT_ROW_HEIGHT_PT` (matching `sheets.ts`'s own fallback values exactly) onto a column/row the moment any of `OdsSheet.cell()`, `mergeCells()`, `setColumnHidden()`, or `setRowHidden()` individuates it for the first time — but only when it has no width/height style at all yet, never overwriting a width a caller (or a real source document opened via `openOds`) already set. A plain `createOds()` sheet touched only through `.cell()` now reads back with a real, positive `widthPt`/`heightPt` on every column/row it addressed, never the ambiguous 0 that used to require an explicit `setColumnWidth`/`setRowHeight` call to avoid. One narrower instance of the identical hazard remains open, deliberately not folded into this fix: `print-settings.ts`'s `wrapRepeatRange` (the `repeatColumns`/`repeatRows` writer) still individuates its own boundary columns/rows via a bare, unstyled `replaceRun`, and — unlike `cell()`/`mergeCells()` — stamping every position that boundary individuation touches would mean materializing an unbounded range rather than the two boundary positions it is deliberately designed to touch, a genuinely different performance tradeoff this fix does not attempt to resolve. `OdsSheet.addImage` (`src/edit/ods/floating.ts`) writes a real floating `draw:frame`/`draw:image` into `table:shapes` (the ODF 1.3 content-model container for spreadsheet floating shapes, always `table:table`'s own first child in a package this editor builds), resolving a `ContentSheetImage`'s `anchorRow`/`anchorColumn` plus `offsetXPt`/`offsetYPt` to an absolute `svg:x`/`svg:y` by summing the real, currently-declared width/height of every column/row strictly before the anchor (header-wrapper-aware, hidden columns/rows contributing zero, falling back to the same default column/row size the layout engine assumes once the walk runs past what the sheet has declared) — reusing `addImageMedia` for the binary part and manifest entry, the same mechanism `src/edit/odp/image.ts` already uses for a slide. `OdsSheet.addEmbeddedObject` writes a real embedded ODF formula sub-document for `objectKind === 'formula'` (reusing `addFormulaObject`, the same mechanism `OdtBody.appendFormula` already uses); every other `objectKind` (`wordprocessing`/`presentation`/`spreadsheet`/`drawing`) is left unwritten, a documented, bounded gap mirroring `buildOdtPackage`'s identical narrowing for a `'drawing'` embedded object, since embedding one would mean writing that document's own package as a nested OLE sub-object, which no writer in this codebase implements. `buildOdsPackage` calls both for every sheet's images/embedded objects, after every column/row width/height/hidden call, so an image's own anchor resolves against the sheet's final, real column/row sizing. This is no longer write-only: `odf.js` 2.2.0's own `readOds` reads a sheet's floating shapes and embedded objects back (it previously hardcoded `images: []` and never set `embeddedObjects`), so a written image now verifies as a genuine `ContentDocument` re-read round trip — bytes, declared size, and anchor quartet — on top of the direct written-XML structural checks these tests already made.
 - **`reconstructDrawing` maps recovered geometry back onto ODF shapes near-1:1, with no clustering — and every vector kind in this package's own `.odg` fixture now survives the round trip, where a stroked rect, an ellipse, and a line used to collapse to a generic `path`.** Every painted `LayoutItem` maps onto a `ContentVector`/`ContentShape` directly, in the exact z-order it was recovered — `LayoutRect` → `rect`, `LayoutEllipse` → `ellipse`, `LayoutLine` → `line`, `LayoutPath` → `path`, `LayoutText`/`LayoutImage` → `ContentShape` — a fundamentally more tractable problem than `reconstructWordprocessing`/`reconstructPresentation`'s own paragraph/shape geometry clustering, since a drawing has no semantic structure to infer at all. How much *kind* information survives is decided upstream, by what `readPdf` can hand it: pdf-codec's own shape-pattern detection (see the gotcha above) now recovers a rect under any fill/stroke combination, a real ellipse from the four kappa-ratio cubics `writeEllipse` emits, and a real line, so `reconstructDrawing` receives — and therefore emits — the original kind in each case. What still narrows: a rotation that is not a multiple of 90° leaves no axis-aligned pattern to match, so a rect turned by 30° comes back as a `path` carrying its four rotated corners exactly. Position, size, and fill/stroke colour survive regardless of kind (within ordinary floating-point/string-formatting tolerance). A `path` vector's own reconstructed `frame` is a further, separate approximation: it is the *tight* bounding box of every recovered point, cubic control points included (a cubic curve is guaranteed to lie within their convex hull, so this never clips the curve) — which can legitimately be *larger* than whatever frame the original path's own author declared, if that frame didn't tightly bound its own control points to begin with (a real, valid ODF/SVG authoring pattern: a `viewBox`/frame is a declared coordinate window, not a guaranteed tight bounding box). A single original drawing text box that PDF's own greedy line-wrapper split across several lines does **not** reconstruct as one multi-line shape: `reconstructDrawing` maps each recovered `LayoutText` item to its own separate `ContentShape` (the same one-`LayoutItem`-to-one-shape rule every other kind follows), so a wrapped multi-line text box comes back as several small, independently-positioned text boxes, one per original line — confirmed visually against real LibreOffice (see the real-file verification note below); the full text content still survives, just redistributed. `buildOdgPackage` (`src/edit/odg/content.ts`) is `pdfToOdg`'s own package-building half, mirroring `buildOdtPackage`/`buildOdpPackage`'s role for `pdfToOdt`/`pdfToOdp`.
 - **Two real, confirmed-against-actual-LibreOffice-rendering fill bugs were fixed as part of building `reconstructDrawing`/`pdfToOdg`, not by it.** Both are pre-existing gaps in code that `reconstructDrawing`'s own real-file verification exposed, not something the reconstruction algorithm itself introduced, and both apply to every `.odg` this package writes, not only a reconstructed one: (1) `src/edit/odg/style.ts`'s `graphicPropertyAttrs` wrote `draw:fill-color` alone, with no accompanying `draw:fill="solid"` — real LibreOffice 26.2 fills a `draw:rect`/`draw:ellipse` that way fine, but silently renders a `draw:path` with the identical omission as unfilled, even with a fill colour declared. `draw:fill="solid"` is now written explicitly whenever a fill is set, for every vector kind. (2) `writeEllipse` (pdf-codec's own `content-write.ts`) never emitted a PDF closepath (`h`) operator, even though its four Bezier arcs already return exactly to their own starting point — PDF fill operators close every subpath implicitly regardless (ISO 32000-1 8.5.3.1), but `readPdf`'s own general path tracking only marks a subpath `closed: true` when it actually sees an explicit `h`, so a PDF-round-tripped ellipse came back with `closed: false`, which correctly-behaving ODF/SVG consumers then refuse to fill even with `draw:fill="solid"` set. `writeEllipse` now emits `h` before its paint operator, drawing no additional ink (the path was already geometrically closed) but recording that closure explicitly.
 - **A vector primitive's own fill/stroke needed a self-contained graphic-family style writer, not `odf.js`'s own `StyleRegistry`.** `'graphic'` is a recognised `StyleFamily` member (`odf.js`'s `src/styles/registry.ts`), but `StylePropertiesSchema`/`buildStylePropertyElements` (`properties.ts`/`serialize.ts`) only ever model text/paragraph formatting and never emit a `style:graphic-properties` element for any family — extending that shared package for one narrow, documents.js-local need (`draw:fill(-color)`/`draw:stroke` + `svg:stroke-color`/`svg:stroke-width`) would be scope creep into a foreign package for a two-attribute-group writer this package can express directly. `src/edit/odg/style.ts` is that writer: it still reuses `odf.js`'s general append-only style-editing invariant (a setter always mints a fresh `style:style` and repoints `draw:style-name`, never mutates an existing entry — verified by the same `assertAutomaticStylesOnlyAppended` helper `OdpEditor`'s own live-view fidelity test uses) and `src/edit/odt/automatic-styles.ts`'s `ensureAutomaticStyles`/`nextStyleName` (the "find-or-create `office:automatic-styles`, mint the next unused name" logic every other hand-rolled style helper in this package already shares), rather than a third reimplementation of either.

package/dist/edit/ods/column-row.cjs

@@ -8,6 +8,8 @@ let odf_js = require("odf.js");
 //#region src/edit/ods/column-row.ts
 const VISIBILITY_ATTR = "table:visibility";
 const VISIBILITY_COLLAPSE = "collapse";
+const DEFAULT_COLUMN_WIDTH_PT = 64;
+const DEFAULT_ROW_HEIGHT_PT = 15;
 function currentColumnStyleProperties(pkg, columnElement) {
 	const styleName = (0, ooxml_js.attr)(columnElement, "table:style-name");
 	const styleElement = styleName === void 0 ? void 0 : (0, odf_js.findStyleElement)(styleName, "table-column", pkg);
@@ -67,24 +69,34 @@ function writeColumnWidth(pkg, tableElement, index, widthPt) {
 function writeRowHeight(pkg, tableElement, index, heightPt) {
 	applyRowStyleProperties(pkg, tableElement, index, { heightPt });
 }
+function ensureColumnDefaultWidth(pkg, tableElement, index) {
+	require_edit_ods_address.ensureColumnCoverage(tableElement, index + 1);
+	if (currentColumnStyleProperties(pkg, require_edit_ods_address.replaceRun(tableElement.children, require_edit_ods_address.isElementWithTag("table:table-column"), index, "table:number-columns-repeated", () => require_xml_fragment.el("table:table-column"), "table:table-header-columns")).widthPt === void 0) writeColumnWidth(pkg, tableElement, index, DEFAULT_COLUMN_WIDTH_PT);
+}
+function ensureRowDefaultHeight(pkg, tableElement, index) {
+	if (currentRowStyleProperties(pkg, require_edit_ods_address.replaceRun(tableElement.children, require_edit_ods_address.isElementWithTag("table:table-row"), index, "table:number-rows-repeated", () => require_xml_fragment.el("table:table-row"), "table:table-header-rows")).heightPt === void 0) writeRowHeight(pkg, tableElement, index, DEFAULT_ROW_HEIGHT_PT);
+}
 function writeColumnManualBreak(pkg, tableElement, index) {
 	applyColumnStyleProperties(pkg, tableElement, index, { manualBreak: true });
 }
 function writeRowManualBreak(pkg, tableElement, index) {
 	applyRowStyleProperties(pkg, tableElement, index, { manualBreak: true });
 }
-function writeColumnHidden(tableElement, index, hidden) {
-	require_edit_ods_address.ensureColumnCoverage(tableElement, index + 1);
+function writeColumnHidden(pkg, tableElement, index, hidden) {
+	ensureColumnDefaultWidth(pkg, tableElement, index);
 	const columnElement = require_edit_ods_address.replaceRun(tableElement.children, require_edit_ods_address.isElementWithTag(require_edit_ods_address.COLUMN_TAG), index, require_edit_ods_address.COLUMN_REPEAT_ATTR, () => require_xml_fragment.el(require_edit_ods_address.COLUMN_TAG), require_edit_ods_address.HEADER_COLUMNS_TAG);
 	if (hidden) require_xml_edit.setAttr(columnElement, VISIBILITY_ATTR, VISIBILITY_COLLAPSE);
 	else require_xml_edit.removeAttr(columnElement, VISIBILITY_ATTR);
 }
-function writeRowHidden(tableElement, index, hidden) {
+function writeRowHidden(pkg, tableElement, index, hidden) {
+	ensureRowDefaultHeight(pkg, tableElement, index);
 	const rowElement = require_edit_ods_address.replaceRun(tableElement.children, require_edit_ods_address.isElementWithTag(require_edit_ods_address.ROW_TAG), index, require_edit_ods_address.ROW_REPEAT_ATTR, () => require_xml_fragment.el(require_edit_ods_address.ROW_TAG), require_edit_ods_address.HEADER_ROWS_TAG);
 	if (hidden) require_xml_edit.setAttr(rowElement, VISIBILITY_ATTR, VISIBILITY_COLLAPSE);
 	else require_xml_edit.removeAttr(rowElement, VISIBILITY_ATTR);
 }
 //#endregion
+exports.ensureColumnDefaultWidth = ensureColumnDefaultWidth;
+exports.ensureRowDefaultHeight = ensureRowDefaultHeight;
 exports.writeColumnHidden = writeColumnHidden;
 exports.writeColumnManualBreak = writeColumnManualBreak;
 exports.writeColumnWidth = writeColumnWidth;

package/dist/edit/ods/column-row.d.cts

@@ -2,9 +2,11 @@ import { Package, XmlElement } from "odf.js";
 //#region src/edit/ods/column-row.d.ts
 declare function writeColumnWidth(pkg: Package, tableElement: XmlElement, index: number, widthPt: number): void;
 declare function writeRowHeight(pkg: Package, tableElement: XmlElement, index: number, heightPt: number): void;
+declare function ensureColumnDefaultWidth(pkg: Package, tableElement: XmlElement, index: number): void;
+declare function ensureRowDefaultHeight(pkg: Package, tableElement: XmlElement, index: number): void;
 declare function writeColumnManualBreak(pkg: Package, tableElement: XmlElement, index: number): void;
 declare function writeRowManualBreak(pkg: Package, tableElement: XmlElement, index: number): void;
-declare function writeColumnHidden(tableElement: XmlElement, index: number, hidden: boolean): void;
-declare function writeRowHidden(tableElement: XmlElement, index: number, hidden: boolean): void;
+declare function writeColumnHidden(pkg: Package, tableElement: XmlElement, index: number, hidden: boolean): void;
+declare function writeRowHidden(pkg: Package, tableElement: XmlElement, index: number, hidden: boolean): void;
 //#endregion
-export { writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };
+export { ensureColumnDefaultWidth, ensureRowDefaultHeight, writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };

package/dist/edit/ods/column-row.d.ts

@@ -2,9 +2,11 @@ import { Package, XmlElement } from "odf.js";
 //#region src/edit/ods/column-row.d.ts
 declare function writeColumnWidth(pkg: Package, tableElement: XmlElement, index: number, widthPt: number): void;
 declare function writeRowHeight(pkg: Package, tableElement: XmlElement, index: number, heightPt: number): void;
+declare function ensureColumnDefaultWidth(pkg: Package, tableElement: XmlElement, index: number): void;
+declare function ensureRowDefaultHeight(pkg: Package, tableElement: XmlElement, index: number): void;
 declare function writeColumnManualBreak(pkg: Package, tableElement: XmlElement, index: number): void;
 declare function writeRowManualBreak(pkg: Package, tableElement: XmlElement, index: number): void;
-declare function writeColumnHidden(tableElement: XmlElement, index: number, hidden: boolean): void;
-declare function writeRowHidden(tableElement: XmlElement, index: number, hidden: boolean): void;
+declare function writeColumnHidden(pkg: Package, tableElement: XmlElement, index: number, hidden: boolean): void;
+declare function writeRowHidden(pkg: Package, tableElement: XmlElement, index: number, hidden: boolean): void;
 //#endregion
-export { writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };
+export { ensureColumnDefaultWidth, ensureRowDefaultHeight, writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };

package/dist/edit/ods/column-row.js

@@ -7,6 +7,8 @@ import { findStyleElement, formatOdfLength, parseOdfLength } from "odf.js";
 //#region src/edit/ods/column-row.ts
 const VISIBILITY_ATTR = "table:visibility";
 const VISIBILITY_COLLAPSE = "collapse";
+const DEFAULT_COLUMN_WIDTH_PT = 64;
+const DEFAULT_ROW_HEIGHT_PT = 15;
 function currentColumnStyleProperties(pkg, columnElement) {
 	const styleName = attr(columnElement, "table:style-name");
 	const styleElement = styleName === void 0 ? void 0 : findStyleElement(styleName, "table-column", pkg);
@@ -66,22 +68,30 @@ function writeColumnWidth(pkg, tableElement, index, widthPt) {
 function writeRowHeight(pkg, tableElement, index, heightPt) {
 	applyRowStyleProperties(pkg, tableElement, index, { heightPt });
 }
+function ensureColumnDefaultWidth(pkg, tableElement, index) {
+	ensureColumnCoverage(tableElement, index + 1);
+	if (currentColumnStyleProperties(pkg, replaceRun(tableElement.children, isElementWithTag("table:table-column"), index, "table:number-columns-repeated", () => el("table:table-column"), "table:table-header-columns")).widthPt === void 0) writeColumnWidth(pkg, tableElement, index, DEFAULT_COLUMN_WIDTH_PT);
+}
+function ensureRowDefaultHeight(pkg, tableElement, index) {
+	if (currentRowStyleProperties(pkg, replaceRun(tableElement.children, isElementWithTag("table:table-row"), index, "table:number-rows-repeated", () => el("table:table-row"), "table:table-header-rows")).heightPt === void 0) writeRowHeight(pkg, tableElement, index, DEFAULT_ROW_HEIGHT_PT);
+}
 function writeColumnManualBreak(pkg, tableElement, index) {
 	applyColumnStyleProperties(pkg, tableElement, index, { manualBreak: true });
 }
 function writeRowManualBreak(pkg, tableElement, index) {
 	applyRowStyleProperties(pkg, tableElement, index, { manualBreak: true });
 }
-function writeColumnHidden(tableElement, index, hidden) {
-	ensureColumnCoverage(tableElement, index + 1);
+function writeColumnHidden(pkg, tableElement, index, hidden) {
+	ensureColumnDefaultWidth(pkg, tableElement, index);
 	const columnElement = replaceRun(tableElement.children, isElementWithTag(COLUMN_TAG), index, COLUMN_REPEAT_ATTR, () => el(COLUMN_TAG), HEADER_COLUMNS_TAG);
 	if (hidden) setAttr(columnElement, VISIBILITY_ATTR, VISIBILITY_COLLAPSE);
 	else removeAttr(columnElement, VISIBILITY_ATTR);
 }
-function writeRowHidden(tableElement, index, hidden) {
+function writeRowHidden(pkg, tableElement, index, hidden) {
+	ensureRowDefaultHeight(pkg, tableElement, index);
 	const rowElement = replaceRun(tableElement.children, isElementWithTag(ROW_TAG), index, ROW_REPEAT_ATTR, () => el(ROW_TAG), HEADER_ROWS_TAG);
 	if (hidden) setAttr(rowElement, VISIBILITY_ATTR, VISIBILITY_COLLAPSE);
 	else removeAttr(rowElement, VISIBILITY_ATTR);
 }
 //#endregion
-export { writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };
+export { ensureColumnDefaultWidth, ensureRowDefaultHeight, writeColumnHidden, writeColumnManualBreak, writeColumnWidth, writeRowHeight, writeRowHidden, writeRowManualBreak };

package/dist/edit/ods/sheet.cjs

@@ -44,10 +44,10 @@ var OdsSheet = class {
 		require_edit_ods_column_row.writeRowHeight(this.pkg, this.live(), index, heightPt);
 	}
 	setColumnHidden(index, hidden) {
-		require_edit_ods_column_row.writeColumnHidden(this.live(), index, hidden);
+		require_edit_ods_column_row.writeColumnHidden(this.pkg, this.live(), index, hidden);
 	}
 	setRowHidden(index, hidden) {
-		require_edit_ods_column_row.writeRowHidden(this.live(), index, hidden);
+		require_edit_ods_column_row.writeRowHidden(this.pkg, this.live(), index, hidden);
 	}
 	addImage(image) {
 		require_edit_ods_floating.insertSheetImage(this.pkg, this.live(), image);
@@ -56,8 +56,11 @@ var OdsSheet = class {
 		require_edit_ods_floating.insertSheetEmbeddedObject(this.pkg, this.live(), object);
 	}
 	cell(row, column) {
-		const node = require_edit_ods_address.resolveCellNode(this.live(), row, column);
+		const tableElement = this.live();
+		const node = require_edit_ods_address.resolveCellNode(tableElement, row, column);
 		if (node.tag === "table:covered-table-cell") throw new Error(`cell (${row}, ${column}) is covered by a merged range -- address the merge's own anchor cell instead`);
+		require_edit_ods_column_row.ensureColumnDefaultWidth(this.pkg, tableElement, column);
+		require_edit_ods_column_row.ensureRowDefaultHeight(this.pkg, tableElement, row);
 		return new require_edit_ods_cell.OdsCell(node, this.pkg);
 	}
 	cellAt(reference) {
@@ -70,6 +73,8 @@ var OdsSheet = class {
 		const tableElement = this.live();
 		const anchorNode = require_edit_ods_address.resolveCellNode(tableElement, startRow, startColumn);
 		if (anchorNode.tag === "table:covered-table-cell") throw new Error(`mergeCells: (${startRow}, ${startColumn}) is already covered by another merged range`);
+		for (let rowOffset = 0; rowOffset < rowSpan; rowOffset++) require_edit_ods_column_row.ensureRowDefaultHeight(this.pkg, tableElement, startRow + rowOffset);
+		for (let columnOffset = 0; columnOffset < colSpan; columnOffset++) require_edit_ods_column_row.ensureColumnDefaultWidth(this.pkg, tableElement, startColumn + columnOffset);
 		if (rowSpan > 1) require_xml_edit.setAttr(anchorNode, "table:number-rows-spanned", String(rowSpan));
 		if (colSpan > 1) require_xml_edit.setAttr(anchorNode, "table:number-columns-spanned", String(colSpan));
 		for (let rowOffset = 0; rowOffset < rowSpan; rowOffset++) for (let columnOffset = 0; columnOffset < colSpan; columnOffset++) {

package/dist/edit/ods/sheet.js

@@ -1,7 +1,7 @@
 import { removeChild, setAttr } from "../../xml/edit.js";
 import { COVERED_CELL_TAG, resolveCellNode } from "./address.js";
 import { OdsCell } from "./cell.js";
-import { writeColumnHidden, writeColumnWidth, writeRowHeight, writeRowHidden } from "./column-row.js";
+import { ensureColumnDefaultWidth, ensureRowDefaultHeight, writeColumnHidden, writeColumnWidth, writeRowHeight, writeRowHidden } from "./column-row.js";
 import { insertSheetEmbeddedObject, insertSheetImage } from "./floating.js";
 import { readSheetPrintSettings, writeSheetPrintSettings } from "./print-settings.js";
 import { attr } from "ooxml.js";
@@ -43,10 +43,10 @@ var OdsSheet = class {
 		writeRowHeight(this.pkg, this.live(), index, heightPt);
 	}
 	setColumnHidden(index, hidden) {
-		writeColumnHidden(this.live(), index, hidden);
+		writeColumnHidden(this.pkg, this.live(), index, hidden);
 	}
 	setRowHidden(index, hidden) {
-		writeRowHidden(this.live(), index, hidden);
+		writeRowHidden(this.pkg, this.live(), index, hidden);
 	}
 	addImage(image) {
 		insertSheetImage(this.pkg, this.live(), image);
@@ -55,8 +55,11 @@ var OdsSheet = class {
 		insertSheetEmbeddedObject(this.pkg, this.live(), object);
 	}
 	cell(row, column) {
-		const node = resolveCellNode(this.live(), row, column);
+		const tableElement = this.live();
+		const node = resolveCellNode(tableElement, row, column);
 		if (node.tag === "table:covered-table-cell") throw new Error(`cell (${row}, ${column}) is covered by a merged range -- address the merge's own anchor cell instead`);
+		ensureColumnDefaultWidth(this.pkg, tableElement, column);
+		ensureRowDefaultHeight(this.pkg, tableElement, row);
 		return new OdsCell(node, this.pkg);
 	}
 	cellAt(reference) {
@@ -69,6 +72,8 @@ var OdsSheet = class {
 		const tableElement = this.live();
 		const anchorNode = resolveCellNode(tableElement, startRow, startColumn);
 		if (anchorNode.tag === "table:covered-table-cell") throw new Error(`mergeCells: (${startRow}, ${startColumn}) is already covered by another merged range`);
+		for (let rowOffset = 0; rowOffset < rowSpan; rowOffset++) ensureRowDefaultHeight(this.pkg, tableElement, startRow + rowOffset);
+		for (let columnOffset = 0; columnOffset < colSpan; columnOffset++) ensureColumnDefaultWidth(this.pkg, tableElement, startColumn + columnOffset);
 		if (rowSpan > 1) setAttr(anchorNode, "table:number-rows-spanned", String(rowSpan));
 		if (colSpan > 1) setAttr(anchorNode, "table:number-columns-spanned", String(colSpan));
 		for (let rowOffset = 0; rowOffset < rowSpan; rowOffset++) for (let columnOffset = 0; columnOffset < colSpan; columnOffset++) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "js.documents",
-  "version": "1.81.8",
+  "version": "1.81.9",
   "description": "Bidirectional docx/pptx <-> PDF conversion and a read+write editable OOXML document model, built on ooxml.js and Zod 4 codecs.",
   "type": "module",
   "repository": {