js-draw 0.17.4 → 0.18.1

package/src/commands/localization.ts

@@ -1,47 +0,0 @@
-import Rect2 from '../math/Rect2';
-
-export interface CommandLocalization {
-	movedLeft: string;
-	movedUp: string;
-	movedDown: string;
-	movedRight: string;
-	rotatedBy: (degrees: number) => string;
-	zoomedOut: string;
-	zoomedIn: string;
-	erasedNoElements: string;
-	duplicatedNoElements: string;
-	elements: string;
-	updatedViewport: string;
-	transformedElements: (elemCount: number) => string;
-	resizeOutputCommand: (newSize: Rect2) => string;
-	addElementAction: (elemDescription: string) => string;
-	eraseAction: (elemDescription: string, numElems: number) => string;
-	duplicateAction: (elemDescription: string, count: number)=> string;
-	inverseOf: (actionDescription: string)=> string;
-	unionOf: (actionDescription: string, actionCount: number)=> string;
-
-	selectedElements: (count: number)=>string;
-}
-
-export const defaultCommandLocalization: CommandLocalization = {
-	updatedViewport: 'Transformed Viewport',
-	transformedElements: (elemCount) => `Transformed ${elemCount} element${elemCount === 1 ? '' : 's'}`,
-	resizeOutputCommand: (newSize: Rect2) => `Resized image to ${newSize.w}x${newSize.h}`,
-	addElementAction: (componentDescription: string) => `Added ${componentDescription}`,
-	eraseAction: (componentDescription: string, numElems: number) => `Erased ${numElems} ${componentDescription}`,
-	duplicateAction: (componentDescription: string, numElems: number) => `Duplicated ${numElems} ${componentDescription}`,
-	unionOf: (actionDescription: string, actionCount: number) => `Union: ${actionCount} ${actionDescription}`,
-	inverseOf: (actionDescription: string) => `Inverse of ${actionDescription}`,
-	elements: 'Elements',
-	erasedNoElements: 'Erased nothing',
-	duplicatedNoElements: 'Duplicated nothing',
-	
-	rotatedBy: (degrees) => `Rotated by ${Math.abs(degrees)} degrees ${degrees < 0 ? 'clockwise' : 'counter-clockwise'}`,
-	movedLeft: 'Moved left',
-	movedUp: 'Moved up',
-	movedDown: 'Moved down',
-	movedRight: 'Moved right',
-	zoomedOut: 'Zoomed out',
-	zoomedIn: 'Zoomed in',
-	selectedElements: (count) => `Selected ${count} element${count === 1 ? '' : 's'}`,
-};

package/src/commands/uniteCommands.test.ts

@@ -1,23 +0,0 @@
-
-import { Color4, EditorImage, Mat33, Path, SerializableCommand, StrokeComponent, Vec2 } from '../lib';
-import uniteCommands from './uniteCommands';
-import createEditor from '../testing/createEditor';
-
-describe('uniteCommands', () => {
-	it('should be serializable and deserializable', () => {
-		const editor = createEditor();
-		const stroke = new StrokeComponent([ Path.fromString('m0,0 l10,10 h-2 z').toRenderable({ fill: Color4.red }) ]);
-		const union = uniteCommands([
-			EditorImage.addElement(stroke),
-			stroke.transformBy(Mat33.translation(Vec2.of(1, 10))),
-		]);
-		const deserialized = SerializableCommand.deserialize(union.serialize(), editor);
-
-		deserialized.apply(editor);
-
-		const lookupResult = editor.image.lookupElement(stroke.getId());
-		expect(lookupResult).not.toBeNull();
-		expect(lookupResult?.getBBox().topLeft).toMatchObject(Vec2.of(1, 10));
-		expect(lookupResult?.getBBox().bottomRight).toMatchObject(Vec2.of(11, 20));
-	});
-});

package/src/commands/uniteCommands.ts

@@ -1,135 +0,0 @@
-import Editor from '../Editor';
-import { EditorLocalization } from '../localization';
-import Command from './Command';
-import SerializableCommand from './SerializableCommand';
-
-
-class NonSerializableUnion extends Command {
-	public constructor(private commands: Command[], private applyChunkSize: number|undefined) {
-		super();
-	}
-
-	private static waitForAll(commands: (Promise<void>|void)[]): Promise<void>|void {
-		// If any are Promises...
-		if (commands.some(command => command && command['then'])) {
-			console.log('waiting...');
-			// Wait for all commands to finish.
-			return Promise.all(commands)
-				// Ensure we return a Promise<void> and not a Promise<void[]>
-				.then(() => {});
-		}
-
-		return;
-	}
-
-	public apply(editor: Editor) {
-		if (this.applyChunkSize === undefined) {
-			const results = this.commands.map(cmd => cmd.apply(editor));
-			return NonSerializableUnion.waitForAll(results);
-		} else {
-			return editor.asyncApplyCommands(this.commands, this.applyChunkSize);
-		}
-	}
-
-	public unapply(editor: Editor) {
-		const commands = [ ...this.commands ];
-		commands.reverse();
-
-		if (this.applyChunkSize === undefined) {
-			const results = commands.map(cmd => cmd.unapply(editor));
-			return NonSerializableUnion.waitForAll(results);
-		} else {
-			return editor.asyncUnapplyCommands(commands, this.applyChunkSize, false);
-		}
-	}
-
-	public description(editor: Editor, localizationTable: EditorLocalization) {
-		const descriptions: string[] = [];
-
-		let lastDescription: string|null = null;
-		let duplicateDescriptionCount: number = 0;
-		for (const part of this.commands) {
-			const description = part.description(editor, localizationTable);
-			if (description !== lastDescription && lastDescription !== null) {
-				descriptions.push(localizationTable.unionOf(lastDescription, duplicateDescriptionCount));
-				lastDescription = null;
-				duplicateDescriptionCount = 0;
-			}
-
-			duplicateDescriptionCount ++;
-			lastDescription ??= description;
-		}
-
-		if (duplicateDescriptionCount > 1) {
-			descriptions.push(localizationTable.unionOf(lastDescription!, duplicateDescriptionCount));
-		} else if (duplicateDescriptionCount === 1) {
-			descriptions.push(lastDescription!);
-		}
-
-		return descriptions.join(', ');
-	}
-}
-
-class SerializableUnion extends SerializableCommand {
-	private nonserializableCommand: NonSerializableUnion;
-	public constructor(private commands: SerializableCommand[], private applyChunkSize: number|undefined) {
-		super('union');
-		this.nonserializableCommand = new NonSerializableUnion(commands, applyChunkSize);
-	}
-
-	protected serializeToJSON() {
-		return {
-			applyChunkSize: this.applyChunkSize,
-			data: this.commands.map(command => command.serialize()),
-		};
-	}
-
-	public apply(editor: Editor) {
-		return this.nonserializableCommand.apply(editor);
-	}
-
-	public unapply(editor: Editor) {
-		return this.nonserializableCommand.unapply(editor);
-	}
-
-	public description(editor: Editor, localizationTable: EditorLocalization): string {
-		return this.nonserializableCommand.description(editor, localizationTable);
-	}
-}
-
-const uniteCommands = <T extends Command> (commands: T[], applyChunkSize?: number): T extends SerializableCommand ? SerializableCommand : Command => {
-	let allSerializable = true;
-	for (const command of commands) {
-		if (!(command instanceof SerializableCommand)) {
-			allSerializable = false;
-			break;
-		}
-	}
-
-	if (!allSerializable) {
-		return new NonSerializableUnion(commands, applyChunkSize) as any;
-	} else {
-		const castedCommands = commands as any[] as SerializableCommand[];
-		return new SerializableUnion(castedCommands, applyChunkSize);
-	}
-};
-
-SerializableCommand.register('union', (data: any, editor) => {
-	if (typeof data.data.length !== 'number') {
-		throw new Error('Unions of commands must serialize to lists of serialization data.');
-	}
-	const applyChunkSize: number|undefined = data.applyChunkSize;
-	if (typeof applyChunkSize !== 'number' && applyChunkSize !== undefined) {
-		throw new Error('serialized applyChunkSize is neither undefined nor a number.');
-	}
-
-	const commands: SerializableCommand[] = [];
-	for (const part of data.data as any[]) {
-		commands.push(SerializableCommand.deserialize(part, editor));
-	}
-
-	return uniteCommands(commands, applyChunkSize);
-});
-
-
-export default uniteCommands;

package/src/components/AbstractComponent.transformBy.test.ts

@@ -1,22 +0,0 @@
-import { Color4, EditorImage, Mat33, Path, Rect2, Vec2 } from '../lib';
-import createEditor from '../testing/createEditor';
-import Stroke from './Stroke';
-
-describe('AbstractComponent.transformBy', () => {
-	it('should restore the component\'s z-index on undo', () => {
-		const editor = createEditor();
-		const component = new Stroke([ Path.fromRect(Rect2.unitSquare).toRenderable({ fill: Color4.red }) ]);
-		EditorImage.addElement(component).apply(editor);
-
-		const origZIndex = component.getZIndex();
-
-		const transformCommand = component.transformBy(Mat33.translation(Vec2.unitX));
-		transformCommand.apply(editor);
-
-		// Should increase the z-index on applying a transform
-		expect(component.getZIndex()).toBeGreaterThan(origZIndex);
-
-		transformCommand.unapply(editor);
-		expect(component.getZIndex()).toBe(origZIndex);
-	});
-});

package/src/components/AbstractComponent.ts

@@ -1,364 +0,0 @@
-import SerializableCommand from '../commands/SerializableCommand';
-import Editor from '../Editor';
-import EditorImage from '../EditorImage';
-import LineSegment2 from '../math/LineSegment2';
-import Mat33, { Mat33Array } from '../math/Mat33';
-import Rect2 from '../math/Rect2';
-import { EditorLocalization } from '../localization';
-import AbstractRenderer from '../rendering/renderers/AbstractRenderer';
-import { ImageComponentLocalization } from './localization';
-import UnresolvedSerializableCommand from '../commands/UnresolvedCommand';
-
-export type LoadSaveData = (string[]|Record<symbol, string|number>);
-export type LoadSaveDataTable = Record<string, Array<LoadSaveData>>;
-export type DeserializeCallback = (data: string)=>AbstractComponent;
-type ComponentId = string;
-
-/**
- * A base class for everything that can be added to an {@link EditorImage}.
- */
-export default abstract class AbstractComponent {
-	// The timestamp (milliseconds) at which the component was
-	// last changed (i.e. created/translated).
-	// @deprecated
-	protected lastChangedTime: number;
-
-	// The bounding box of this component.
-	// {@link getBBox}, by default, returns `contentBBox`.
-	// This must be set by components.
-	protected abstract contentBBox: Rect2;
-
-	private zIndex: number;
-	private id: string;
-
-	// Topmost z-index
-	private static zIndexCounter: number = 0;
-
-	protected constructor(
-		// A unique identifier for the type of component
-		private readonly componentKind: string,
-		initialZIndex?: number,
-	) {
-		this.lastChangedTime = (new Date()).getTime();
-
-		if (initialZIndex !== undefined) {
-			this.zIndex = initialZIndex;
-		} else {
-			this.zIndex = AbstractComponent.zIndexCounter++;
-		}
-
-		// Create a unique ID.
-		this.id = `${new Date().getTime()}-${Math.random()}`;
-
-		if (AbstractComponent.deserializationCallbacks[componentKind] === undefined) {
-			throw new Error(`Component ${componentKind} has not been registered using AbstractComponent.registerComponent`);
-		}
-	}
-
-	// Returns a unique ID for this element.
-	// @see { @link lib!EditorImage.lookupElement }
-	public getId() {
-		return this.id;
-	}
-
-	private static deserializationCallbacks: Record<ComponentId, DeserializeCallback|null> = {};
-
-	// Store the deserialization callback (or lack of it) for [componentKind].
-	// If components are registered multiple times (as may be done in automated tests),
-	// the most recent deserialization callback is used.
-	public static registerComponent(
-		componentKind: string,
-		deserialize: DeserializeCallback|null,
-	) {
-		this.deserializationCallbacks[componentKind] = deserialize ?? null;
-	}
-
-	// Stores data attached by a loader.
-	private loadSaveData: LoadSaveDataTable = {};
-
-	/**
-	 * Attach data that can be used while exporting the component (e.g. to SVG).
-	 * 
-	 * This is intended for use by a {@link ImageLoader}.
-	 */
-	public attachLoadSaveData(key: string, data: LoadSaveData) {
-		if (!this.loadSaveData[key]) {
-			this.loadSaveData[key] = [];
-		}
-		this.loadSaveData[key].push(data);
-	}
-
-	/** See {@link attachLoadSaveData} */
-	public getLoadSaveData(): LoadSaveDataTable {
-		return this.loadSaveData;
-	}
-
-	public getZIndex(): number {
-		return this.zIndex;
-	}
-
-	/** @returns the bounding box of  */
-	public getBBox(): Rect2 {
-		return this.contentBBox;
-	}
-
-	/** Called when this component is added to the given image. */
-	public onAddToImage(_image: EditorImage): void { }
-	public onRemoveFromImage(): void { }
-
-	public abstract render(canvas: AbstractRenderer, visibleRect?: Rect2): void;
-
-	/** @return true if `lineSegment` intersects this component. */
-	public abstract intersects(lineSegment: LineSegment2): boolean;
-
-	/**
-	 * @returns true if this component intersects `rect` -- it is entirely contained
-	 *  within the rectangle or one of the rectangle's edges intersects this component.
-	 */
-	public intersectsRect(rect: Rect2): boolean {
-		// If this component intersects rect,
-		// it is either contained entirely within rect or intersects one of rect's edges.
-
-		// If contained within,
-		if (rect.containsRect(this.getBBox())) {
-			return true;
-		}
-
-		// Calculated bounding boxes can be slightly larger than their actual contents' bounding box.
-		// As such, test with more lines than just the rect's edges.
-		const testLines = [];
-		for (const subregion of rect.divideIntoGrid(2, 2)) {
-			testLines.push(...subregion.getEdges());
-		}
-
-		return testLines.some(edge => this.intersects(edge));
-	}
-
-	// Return null iff this object cannot be safely serialized/deserialized.
-	protected abstract serializeToJSON(): any[]|Record<string, any>|number|string|null;
-
-	// Private helper for transformBy: Apply the given transformation to all points of this.
-	protected abstract applyTransformation(affineTransfm: Mat33): void;
-
-	// Returns a command that, when applied, transforms this by [affineTransfm] and
-	// updates the editor.
-	public transformBy(affineTransfm: Mat33): SerializableCommand {
-		return new AbstractComponent.TransformElementCommand(affineTransfm, this.getId(), this);
-	}
-
-	// Returns a command that updates this component's z-index.
-	public setZIndex(newZIndex: number): SerializableCommand {
-		return new AbstractComponent.TransformElementCommand(Mat33.identity, this.getId(), this, newZIndex, this.getZIndex());
-	}
-
-	// @returns true iff this component can be selected (e.g. by the selection tool.)
-	public isSelectable(): boolean {
-		return true;
-	}
-
-	// @returns true iff this component should be added to the background, rather than the
-	// foreground of the image.
-	public isBackground(): boolean {
-		return false;
-	}
-
-	// @returns an approximation of the proportional time it takes to render this component.
-	// This is intended to be a rough estimate, but, for example, a stroke with two points sould have
-	// a renderingWeight approximately twice that of a stroke with one point.
-	public getProportionalRenderingTime(): number {
-		return 1;
-	}
-
-	private static transformElementCommandId = 'transform-element';
-
-	private static TransformElementCommand = class extends UnresolvedSerializableCommand {
-		private targetZIndex: number;
-
-		// Construct a new TransformElementCommand. `component`, while optional, should
-		// be provided if available. If not provided, it will be fetched from the editor's
-		// document when the command is applied.
-		public constructor(
-			private affineTransfm: Mat33,
-			componentID: string,
-			component?: AbstractComponent,
-			targetZIndex?: number,
-			private origZIndex?: number,
-		) {
-			super(AbstractComponent.transformElementCommandId, componentID, component);
-			this.targetZIndex = targetZIndex ?? AbstractComponent.zIndexCounter++;
-
-			// Ensure that we keep drawing on top even after changing the z-index.
-			if (this.targetZIndex >= AbstractComponent.zIndexCounter) {
-				AbstractComponent.zIndexCounter = this.targetZIndex + 1;
-			}
-
-			if (component && origZIndex === undefined) {
-				this.origZIndex = component.getZIndex();
-			}
-		}
-
-		protected resolveComponent(image: EditorImage): void {
-			if (this.component) {
-				return;
-			}
-
-			super.resolveComponent(image);
-			this.origZIndex ??= this.component!.getZIndex();
-		}
-
-		private updateTransform(editor: Editor, newTransfm: Mat33) {
-			if (!this.component) {
-				throw new Error('this.component is undefined or null!');
-			}
-
-			// Any parent should have only one direct child.
-			const parent = editor.image.findParent(this.component);
-			let hadParent = false;
-			if (parent) {
-				parent.remove();
-				hadParent = true;
-			}
-
-			this.component.applyTransformation(newTransfm);
-			this.component.lastChangedTime = (new Date()).getTime();
-
-			// Add the element back to the document.
-			if (hadParent) {
-				EditorImage.addElement(this.component).apply(editor);
-			}
-		}
-
-		public apply(editor: Editor) {
-			this.resolveComponent(editor.image);
-
-			this.component!.zIndex = this.targetZIndex;
-			this.updateTransform(editor, this.affineTransfm);
-			editor.queueRerender();
-		}
-
-		public unapply(editor: Editor) {
-			this.resolveComponent(editor.image);
-
-			this.component!.zIndex = this.origZIndex!;
-			this.updateTransform(editor, this.affineTransfm.inverse());
-			editor.queueRerender();
-		}
-
-		public description(_editor: Editor, localizationTable: EditorLocalization) {
-			return localizationTable.transformedElements(1);
-		}
-
-		static {
-			SerializableCommand.register(AbstractComponent.transformElementCommandId, (json: any, editor: Editor) => {
-				const elem = editor.image.lookupElement(json.id) ?? undefined;
-				const transform = new Mat33(...(json.transfm as Mat33Array));
-				const targetZIndex = json.targetZIndex;
-				const origZIndex = json.origZIndex ?? undefined;
-
-				return new AbstractComponent.TransformElementCommand(
-					transform,
-					json.id,
-					elem,
-					targetZIndex,
-					origZIndex,
-				);
-			});
-		}
-
-		protected serializeToJSON() {
-			return {
-				id: this.componentID,
-				transfm: this.affineTransfm.toArray(),
-				targetZIndex: this.targetZIndex,
-				origZIndex: this.origZIndex,
-			};
-		}
-	};
-
-	/**
-	 * @return a description that could be read by a screen reader
-	 *     (e.g. when adding/erasing the component)
-	 */
-	public abstract description(localizationTable: ImageComponentLocalization): string;
-
-	// Component-specific implementation of {@link clone}.
-	protected abstract createClone(): AbstractComponent;
-
-	// Returns a copy of this component.
-	public clone() {
-		const clone = this.createClone();
-
-		for (const attachmentKey in this.loadSaveData) {
-			for (const val of this.loadSaveData[attachmentKey]) {
-				clone.attachLoadSaveData(attachmentKey, val);
-			}
-		}
-
-		return clone;
-	}
-
-	// Convert the component to an object that can be passed to
-	// `JSON.stringify`.
-	//
-	// Do not rely on the output of this function to take a particular form —
-	// this function's output can change form without a major version increase.
-	public serialize() {
-		const data = this.serializeToJSON();
-
-		if (data === null) {
-			throw new Error(`${this} cannot be serialized.`);
-		}
-
-		return {
-			name: this.componentKind,
-			zIndex: this.zIndex,
-			id: this.id,
-			loadSaveData: this.loadSaveData,
-			data,
-		};
-	}
-
-	// Returns true if `data` is not deserializable. May return false even if [data]
-	// is not deserializable.
-	private static isNotDeserializable(json: any|string) {
-		if (typeof json === 'string') {
-			json = JSON.parse(json);
-		}
-
-		if (typeof json !== 'object') {
-			return true;
-		}
-
-		if (!this.deserializationCallbacks[json?.name]) {
-			return true;
-		}
-
-		if (!json.data) {
-			return true;
-		}
-
-		return false;
-	}
-
-	// Convert a string or an object produced by `JSON.parse` into an `AbstractComponent`.
-	public static deserialize(json: string|any): AbstractComponent {
-		if (typeof json === 'string') {
-			json = JSON.parse(json);
-		}
-
-		if (AbstractComponent.isNotDeserializable(json)) {
-			throw new Error(`Element with data ${json} cannot be deserialized.`);
-		}
-
-		const instance = this.deserializationCallbacks[json.name]!(json.data);
-		instance.zIndex = json.zIndex;
-		instance.id = json.id;
-		
-		// TODO: What should we do with json.loadSaveData?
-		//       If we attach it to [instance], we create a potential security risk — loadSaveData
-		//       is often used to store unrecognised attributes so they can be preserved on output.
-		//       ...but what if we're deserializing data sent across the network?
-
-		return instance;
-	}
-}

package/src/components/ImageBackground.test.ts

@@ -1,35 +0,0 @@
-import Color4 from '../Color4';
-import { Path, Rect2 } from '../math/lib';
-import createEditor from '../testing/createEditor';
-import ImageBackground, { BackgroundType, imageBackgroundCSSClassName } from './ImageBackground';
-
-describe('ImageBackground', () => {
-	it('should render to fill exported SVG', () => {
-		const editor = createEditor();
-		const background = new ImageBackground(BackgroundType.SolidColor, Color4.green);
-		editor.image.addElement(
-			background
-		).apply(editor);
-
-		const expectedImportExportRect = new Rect2(-10, 10, 15, 20);
-		editor.setImportExportRect(expectedImportExportRect).apply(editor);
-		expect(editor.getImportExportRect()).objEq(expectedImportExportRect);
-
-		expect(background.getBBox()).objEq(expectedImportExportRect);
-
-		const rendered = editor.toSVG();
-		const renderedBackground = rendered.querySelector(`.${imageBackgroundCSSClassName}`);
-
-		if (renderedBackground === null) {
-			throw new Error('ImageBackground did not render in exported SVG');
-		}
-
-		expect(renderedBackground.tagName.toLowerCase()).toBe('path');
-
-		const pathString = renderedBackground.getAttribute('d')!;
-		expect(pathString).not.toBeNull();
-
-		const path = Path.fromString(pathString);
-		expect(path.bbox).objEq(editor.getImportExportRect());
-	});
-});