jquery.dgtable 0.6.6 → 0.6.8

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "jquery.dgtable",
   "description": "High-performance table View for jQuery",
-  "version": "0.6.6",
+  "version": "0.6.8",
   "main": "dist/jquery.dgtable.cjs.min.js",
   "module": "dist/jquery.dgtable.es6.min.js",
   "broswer": "dist/jquery.dgtable.umd.min.js",
@@ -35,22 +35,22 @@
   ],
   "dependencies": {
     "@danielgindi/dom-utils": "^1.0.8",
-    "@danielgindi/virtual-list-helper": "^1.0.7"
+    "@danielgindi/virtual-list-helper": "^1.0.8"
   },
   "devDependencies": {
-    "@babel/core": "^7.20.2",
+    "@babel/core": "^7.20.5",
     "@babel/preset-env": "^7.20.2",
-    "@babel/runtime": "^7.20.1",
-    "@rollup/plugin-babel": "^6.0.2",
-    "@rollup/plugin-commonjs": "^23.0.2",
+    "@babel/runtime": "^7.20.6",
+    "@rollup/plugin-babel": "^6.0.3",
+    "@rollup/plugin-commonjs": "^23.0.3",
     "@rollup/plugin-node-resolve": "^15.0.1",
-    "core-js": "^3.26.0",
-    "eslint": "^8.27.0",
+    "core-js": "^3.26.1",
+    "eslint": "^8.29.0",
     "eslint-formatter-codeframe": "^7.32.1",
-    "fs-extra": "^10.1.0",
-    "husky": "^8.0.1",
+    "fs-extra": "^11.1.0",
+    "husky": "^8.0.2",
     "pinst": "^3.0.0",
-    "rollup": "^3.2.5",
+    "rollup": "^3.5.1",
     "rollup-plugin-terser": "^7.0.2"
   }
 }

package/src/index.js

@@ -302,6 +302,9 @@ DGTable.prototype.initialize = function (options) {
      * @field {RowCollection} _filteredRows */
     p.filteredRows = null;
 
+    p.scrollbarWidth = 0;
+    p.lastVirtualScrollHeight = 0;
+
     this._setupHovers();
 };
 
@@ -460,6 +463,15 @@ DGTable.prototype._setupVirtualTable = function () {
 
             that.trigger('rowdestroy', row);
         },
+
+        onScrollHeightChange: height => {
+            // only recalculate scrollbar width if height increased. we reset it in other situations.
+            if (height > p._lastVirtualScrollHeight && !p.scrollbarWidth) {
+                this._updateLastCellWidthFromScrollbar();
+            }
+
+            p._lastVirtualScrollHeight = height;
+        },
     });
 
     p.virtualListHelper.setCount((p.filteredRows ?? p.rows).length);
@@ -659,8 +671,6 @@ DGTable.prototype.close = DGTable.prototype.remove = DGTable.prototype.destroy =
 
     this._destroyHeaderCells();
 
-    p.virtualListHelper.destroy();
-
     if (p.$table) {
         p.$table.empty();
     }
@@ -769,8 +779,8 @@ DGTable.prototype.render = function () {
 
         p.virtualListHelper.setCount((p.filteredRows ?? p.rows).length);
 
+        this._updateVirtualHeight();
         this._updateLastCellWidthFromScrollbar(true);
-
         this._updateTableWidth(true);
 
         // Show sort arrows
@@ -1184,8 +1194,7 @@ DGTable.prototype.moveColumn = function (src, dest, visibleOnly = true) {
             this._ensureVisibleColumns();
 
             if (o.virtualTable) {
-                this.clearAndRender()
-                    ._updateLastCellWidthFromScrollbar(true);
+                this.clearAndRender();
             } else {
                 let headerCell = p.$headerRow.find('>div.' + o.tableClassName + '-header-cell');
                 let beforePos = srcOrder < destOrder ? destOrder + 1 : destOrder,
@@ -2278,8 +2287,6 @@ DGTable.prototype.removeRows = function (physicalRowIndex, count, render) {
                 ._updateLastCellWidthFromScrollbar()
                 .render()
                 ._updateTableWidth(false); // Update table width to suit the required width considering vertical scrollbar
-
-
         } else {
             this.render()
                 ._updateLastCellWidthFromScrollbar()
@@ -3453,7 +3460,9 @@ DGTable.prototype._updateVirtualHeight = function() {
         return this;
 
     if (o.virtualTable) {
-        p.tbody.style.height = p.virtualListHelper.estimateFullHeight() + 'px';
+        const virtualHeight =  p.virtualListHelper.estimateFullHeight();
+        p.lastVirtualScrollHeight = virtualHeight;
+        p.tbody.style.height = virtualHeight + 'px';
     } else {
         p.tbody.style.height = '';
     }