job51-gitlab-cr-node-jt-1 2.9.7 → 2.9.8

package/index.js

@@ -81,9 +81,100 @@ class GitLabCodeReviewer {
         debugLog(`========== Diff Block ${blockIndex} 开始 ==========`);
         debugLog(`文件路径：${diffObject.new_path || diffObject.old_path}`);
         debugLog(`line_info: old_start=${diffObject.line_info?.old_start}, old_count=${diffObject.line_info?.old_count}, new_start=${diffObject.line_info?.new_start}, new_count=${diffObject.line_info?.new_count}`);
-        debugLog(`diff 内容：${diffObject.diff}`);
+        debugLog(`is_large_file: ${diffObject.is_large_file || false}`);
+        debugLog(`diff 内容长度：${diffObject.diff?.length || 0}`);
         debugLog(`========== Diff Block ${blockIndex} 结束 ==========`);
 
+        // 处理大文件情况：diff 内容为空，需要读取完整文件
+        if (diffObject.is_large_file || !diffObject.diff || diffObject.diff.trim() === '') {
+          debugLog(`检测到大文件或空 diff，将读取完整文件内容进行审查`);
+
+          // 读取完整文件内容
+          const fullPath = path.join(process.cwd(), diffObject.new_path || diffObject.old_path);
+          let fileContent = '';
+
+          try {
+            if (fs.existsSync(fullPath)) {
+              fileContent = fs.readFileSync(fullPath, 'utf-8');
+              const lineCount = fileContent.split('\n').length;
+              debugLog(`成功读取完整文件，行数：${lineCount}`);
+            } else {
+              debugLog(`文件不存在：${fullPath}，跳过审查`);
+              return {
+                diff_info: diffObject,
+                block_index: blockIndex,
+                review_result: { reportContent: '<REPORT>\n## 🤖 AI 代码审查结果\n\n文件无法读取，跳过审查。\n</REPORT>', lineInfo: '[]' },
+                temp_file_path: null,
+                hallucination_detected: false,
+              };
+            }
+          } catch (readError) {
+            debugLog(`读取文件失败：${readError.message}`);
+            return {
+              diff_info: diffObject,
+              block_index: blockIndex,
+              review_result: { reportContent: '<REPORT>\n## 🤖 AI 代码审查结果\n\n文件读取失败，跳过审查。\n</REPORT>', lineInfo: '[]' },
+              temp_file_path: null,
+              hallucination_detected: false,
+            };
+          }
+
+          // 对于新增文件，全部代码都是新增
+          // 对于修改文件，需要标记为"全文件审查"
+          const prefix = diffObject.new_file ? '+' : ' ';
+          const prefixedContent = fileContent.split('\n').map(line => prefix + line).join('\n');
+
+          // 构造临时文件内容
+          const diffContentWithMetadata = `${prefixedContent}
+
+# File Information
+# New Path: ${diffObject.new_path || 'N/A'}
+# Old Path: ${diffObject.old_path || 'N/A'}
+# New Start: 1
+# New Count: ${fileContent.split('\n').length}
+# Is Large File: true
+# 注意：这是完整文件内容审查，因为 GitLab diff 被截断。所有代码行都应审查。
+# 行号计算：从第 1 行代码开始计数，第 1 行行号=1，每往下一行行号 +1`;
+
+          // 将内容写入临时文件
+          fs.writeFileSync(tmpFileName, diffContentWithMetadata);
+          debugLog(`大文件临时文件已创建，大小：${diffContentWithMetadata.length}`);
+
+          // 审核完整文件
+          const blockStartTime = Date.now();
+          const blockIdentifier = `${diffObject.new_path || diffObject.old_path}#large-file`;
+          const review_result = await this.reviewDiffWithClaudeUsingFile(tmpFileName, blockIdentifier, true);
+          const blockObj = { ...diffObject, review_result, temp_file_path: tmpFileName, is_large_file: true };
+
+          // 记录审查指标
+          const reviewTime = Date.now() - blockStartTime;
+          const hasSeriousProblems = blockObj.review_result && blockObj.review_result.reportContent && blockObj.review_result.reportContent.includes('严重问题');
+          const filePath = diffObject.new_path || diffObject.old_path || '';
+          this.metrics.recordBlockReviewed(reviewTime, hasSeriousProblems ? 1 : 0, hasSeriousProblems, fileContent.length, filePath);
+
+          let hallucinationDetected = false;
+
+          // 检查审查结果中是否包含严重问题
+          if (blockObj.review_result && blockObj.review_result.reportContent && blockObj.review_result.reportContent.includes('严重问题')) {
+            // 对于大文件，发布为一般讨论（无法精确定位行号）
+            const file_path_with_line = `${diffObject.new_path || diffObject.old_path}#L1`;
+            await this.createGeneralDiscussion(projectId, mergeRequestIid, file_path_with_line, blockObj.review_result.reportContent);
+            debugLog(`大文件审查结果已发布为一般讨论: ${file_path_with_line}`);
+            this.metrics.recordCommentPublished();
+          } else {
+            debugLog(`大文件审查未发现严重问题: ${diffObject.new_path || diffObject.old_path}`);
+          }
+
+          return {
+            diff_info: blockObj,
+            block_index: blockIndex,
+            review_result: blockObj.review_result,
+            temp_file_path: tmpFileName,
+            hallucination_detected: hallucinationDetected,
+          };
+        }
+
+        // 正常 diff 处理逻辑
         // 解析 diff 内容，移除 @@ 行，将其信息放入元数据
         // 这样 AI 不会把 @@ 行误计数
         const diffLines = diffObject.diff.split('\n');
@@ -449,15 +540,28 @@ ${allReportsText}
    * 使用Claude对单个diff文件进行代码审核
    * @param {string} filePath 临时文件路径
    * @param {string} blockIdentifier 块标识（格式：文件路径#块索引），用于日志追踪
+   * @param {boolean} isLargeFile 是否为大文件审查模式
    * @returns {Promise<string>} 审核结果
    */
-  async reviewDiffWithClaudeUsingFile(filePath, blockIdentifier = 'unknown') {
-    debugLog(`[${blockIdentifier}] 开始审核文件: ${filePath}`);
+  async reviewDiffWithClaudeUsingFile(filePath, blockIdentifier = 'unknown', isLargeFile = false) {
+    debugLog(`[${blockIdentifier}] 开始审核文件: ${filePath}, isLargeFile: ${isLargeFile}`);
     const startTime = Date.now();
 
+    // 大文件模式下的特殊提示
+    const largeFilePrompt = isLargeFile ? `
+**⚠️ 大文件审查模式**：
+这是一个完整文件内容的审查（因为 GitLab diff 被截断）。
+1. 所有代码行都是新增或修改的内容
+2. 必须审查整个文件的业务逻辑，包括：
+   - 所有方法中的循环逻辑、状态管理
+   - 所有数据库操作和资源管理
+   - 所有框架特性使用（如 @Async、MyBatis-Plus）
+3. 发现问题时，准确报告行号（基于文件内容的实际行号）
+` : '';
+
     const prompt = `请调用 simple-code-review 技能审核代码变更。
 文件路径：${filePath}
-
+${largeFilePrompt}
 **重要审查规则**：
 1. **严格按照 .claude/rules/code-review-rules.md 中的规则执行审查**，该文件包含详细的审查规则
 2. **重点检测以下问题类型**（详见规则文件）：
@@ -613,6 +717,61 @@ ${allReportsText}
    */
   getDiffBlocks(diffObj) {
     const regex = /(?=@@\s-\d+(?:,\d+)?\s\+\d+(?:,\d+)?\s@@)/g;
+
+    // 检查 diff 内容是否有效
+    if (!diffObj.diff || diffObj.diff.trim() === '') {
+      debugLog(`文件 ${diffObj.new_path || diffObj.old_path} diff 内容为空，可能文件过大被 GitLab 截断`);
+      // 对于新增文件，返回一个标记对象，后续会用完整文件内容审查
+      if (diffObj.new_file) {
+        debugLog(`文件 ${diffObj.new_path} 是新增文件，将使用完整文件内容审查`);
+        return [{
+          diff: '', // 空内容，后续会读取完整文件
+          new_path: diffObj.new_path,
+          old_path: diffObj.old_path,
+          a_mode: diffObj.a_mode,
+          b_mode: diffObj.b_mode,
+          new_file: diffObj.new_file,
+          renamed_file: diffObj.renamed_file,
+          deleted_file: diffObj.deleted_file,
+          generated_file: diffObj.generated_file,
+          block_index: 0,
+          line_info: {
+            old_start: 0,
+            old_count: 0,
+            new_start: 1,
+            new_count: 0, // 未知，后续会从完整文件计算
+            firstLineFirstChar: '+'
+          },
+          is_large_file: true // 标记为大文件，需要特殊处理
+        }];
+      }
+      // 对于修改文件但 diff 为空，同样返回标记对象
+      if (diffObj.new_path && !diffObj.deleted_file) {
+        debugLog(`文件 ${diffObj.new_path} 是修改文件但 diff 截断，将使用完整文件内容审查`);
+        return [{
+          diff: '',
+          new_path: diffObj.new_path,
+          old_path: diffObj.old_path,
+          a_mode: diffObj.a_mode,
+          b_mode: diffObj.b_mode,
+          new_file: false,
+          renamed_file: diffObj.renamed_file,
+          deleted_file: diffObj.deleted_file,
+          generated_file: diffObj.generated_file,
+          block_index: 0,
+          line_info: {
+            old_start: 0,
+            old_count: 0,
+            new_start: 1,
+            new_count: 0,
+            firstLineFirstChar: ' '
+          },
+          is_large_file: true
+        }];
+      }
+      return [];
+    }
+
     const diffBlocks = diffObj.diff.split(regex);
     // 过滤掉空块并提取行号信息
     const result = diffBlocks
@@ -623,7 +782,8 @@ ${allReportsText}
         const headerMatch = block.match(headerRegex);
 
         // 取block第一行是否是加号或者减号开头还是没有开头,block需要用.split(/\r?\n/)
-        const firstLine = block.split(/\r?\n/)[1];
+        const lines = block.split(/\r?\n/);
+        const firstLine = lines[1] || '';
         // 取出第一行的第一个字符
         const firstLineFirstChar = firstLine.charAt(0);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "job51-gitlab-cr-node-jt-1",
-  "version": "2.9.7",
+  "version": "2.9.8",
   "description": "GitLab merge request code review tool with AI-powered analysis and project context support",
   "main": "index.js",
   "bin": {