jmapcloud-ng-types 1.1.7 → 1.1.10

package/index.ts

@@ -374,9 +374,10 @@ export interface JAppLayerService {
 export interface JAppDynamicFilterService {
   openPanel(layerId: JId): void
   closePanel(): void
-  openCreateDialog(layerId: JId): void
-  openUpdateDialog(layerId: JId, conditionId: number): void
-  closeDialog(): void
+  // TODO JMAP8-3266 : remove the following methods
+  // openCreateDialog(layerId: JId): void
+  // openUpdateDialog(layerId: JId, conditionId: number): void
+  // closeDialog(): void
 }
 
 export interface JAppLayerEditionInfoService {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jmapcloud-ng-types",
-  "version": "1.1.7",
+  "version": "1.1.10",
   "description": "JMap Cloud specific version of JMap Cloud NG types and interfaces",
   "main": "src/app.ts",
   "scripts": {

package/public/app.d.ts

@@ -1628,49 +1628,51 @@ declare namespace JMap {
            */
           function closePanel(): void
 
-          /**
-           * **JMap.Application.Layer.Edition.DynamicFilter.openCreateDialog**
-           *
-           * Opens the dynamic filter creation dialog for the given layer id.
-           *
-           * @throws if layer not found
-           * @param layerId the JMap layer id
-           * @example
-           * ```ts
-           * // opens the dynamic filter creation dialog for layer id=3
-           * JMap.Application.Layer.Edition.DynamicFilter.openCreateDialog(3)
-           * ```
-           */
-          function openCreateDialog(layerId: JId): void
-
-          /**
-           * **JMap.Application.Layer.Edition.DynamicFilter.openUpdateDialog**
-           *
-           * Opens the dynamic filter update dialog for the given layer id.
-           *
-           * @throws if layer or condition not found
-           * @param layerId the JMap layer id
-           * @param conditionId the JMap dynamic filter condition id
-           * @example
-           * ```ts
-           * // opens the dynamic filter condition creation dialog for layer id=3
-           * JMap.Application.Layer.Edition.DynamicFilter.openUpdateDialog(3)
-           * ```
-           */
-          function openUpdateDialog(layerId: JId, conditionId: number): void
-
-          /**
-           * **JMap.Application.Layer.Edition.DynamicFilter.closeDialog**
-           *
-           * If open, close the dynamic filter dialog (as well for creation or update).
-           *
-           * @example
-           * ```ts
-           * // closes the edition (any tab) panel if open.
-           * JMap.Application.Layer.Edition.DynamicFilter.closeDialog()
-           * ```
-           */
-          function closeDialog(): void
+          // TODO JMAP8-3266 :  refactor this
+
+          // /**
+          //  * **JMap.Application.Layer.Edition.DynamicFilter.openCreateDialog**
+          //  *
+          //  * Opens the dynamic filter creation dialog for the given layer id.
+          //  *
+          //  * @throws if layer not found
+          //  * @param layerId the JMap layer id
+          //  * @example
+          //  * ```ts
+          //  * // opens the dynamic filter creation dialog for layer id=3
+          //  * JMap.Application.Layer.Edition.DynamicFilter.openCreateDialog(3)
+          //  * ```
+          //  */
+          // function openCreateDialog(layerId: JId): void
+
+          // /**
+          //  * **JMap.Application.Layer.Edition.DynamicFilter.openUpdateDialog**
+          //  *
+          //  * Opens the dynamic filter update dialog for the given layer id.
+          //  *
+          //  * @throws if layer or condition not found
+          //  * @param layerId the JMap layer id
+          //  * @param conditionId the JMap dynamic filter condition id
+          //  * @example
+          //  * ```ts
+          //  * // opens the dynamic filter condition creation dialog for layer id=3
+          //  * JMap.Application.Layer.Edition.DynamicFilter.openUpdateDialog(3)
+          //  * ```
+          //  */
+          // function openUpdateDialog(layerId: JId, conditionId: number): void
+
+          // /**
+          //  * **JMap.Application.Layer.Edition.DynamicFilter.closeDialog**
+          //  *
+          //  * If open, close the dynamic filter dialog (as well for creation or update).
+          //  *
+          //  * @example
+          //  * ```ts
+          //  * // closes the edition (any tab) panel if open.
+          //  * JMap.Application.Layer.Edition.DynamicFilter.closeDialog()
+          //  * ```
+          //  */
+          // function closeDialog(): void
         }
 
         /**

package/public/form.d.ts

@@ -3,7 +3,7 @@ declare type JFormDialogParams = JFormDialogLayerParams | JFormDialogTableParams
 declare type JFormDialogLayerParams = {
   layerId: JId
   featureId?: JId
-  feature?: GeoJSON.Feature
+  feature: GeoJSON.Feature
   isReadOnly: boolean
   onSubmit?: () => void
 }
@@ -13,4 +13,4 @@ declare type JFormDialogTableParams = {
   row?: { [key: string]: any }
   isReadOnly: boolean
   onSubmit?: () => void
-}  
+}