jira-ai 0.4.10 → 0.4.12

package/dist/commands/task-with-details.js

@@ -1,37 +1,16 @@
 import chalk from 'chalk';
-import { getTaskWithDetails, getCurrentUser } from '../lib/jira-client.js';
+import { validateIssuePermissions } from '../lib/jira-client.js';
 import { formatTaskDetails } from '../lib/formatters.js';
 import { CommandError } from '../lib/errors.js';
 import { ui } from '../lib/ui.js';
-import { isCommandAllowed, validateIssueAgainstFilters } from '../lib/settings.js';
 export async function taskWithDetailsCommand(taskId, options = {}) {
     ui.startSpinner(`Fetching details for ${taskId}...`);
     try {
-        const task = await getTaskWithDetails(taskId, {
+        const task = await validateIssuePermissions(taskId, 'task-with-details', {
             includeHistory: options.includeDetailedHistory,
             historyLimit: options.historyLimit ? parseInt(options.historyLimit, 10) : undefined,
             historyOffset: options.historyOffset ? parseInt(options.historyOffset, 10) : undefined,
         });
-        const projectKey = task.key.split('-')[0];
-        // Check if command is allowed for this project
-        if (!isCommandAllowed('task-with-details', projectKey)) {
-            ui.failSpinner(chalk.red('Command not allowed for this project'));
-            throw new CommandError(`Command 'task-with-details' is not allowed for project ${projectKey}.`, {
-                hints: [
-                    `Update settings.yaml to enable this command for this project.`
-                ]
-            });
-        }
-        // Check granular filters
-        const currentUser = await getCurrentUser();
-        if (!validateIssueAgainstFilters(task, currentUser.accountId)) {
-            ui.failSpinner(chalk.red('Access denied by project filters'));
-            throw new CommandError(`Access to issue ${taskId} is restricted by project filters.`, {
-                hints: [
-                    `This project has filters that you do not meet (e.g., participated roles).`
-                ]
-            });
-        }
         ui.succeedSpinner(chalk.green('Task details retrieved'));
         console.log(formatTaskDetails(task));
     }

package/dist/lib/jira-client.js

@@ -1,7 +1,7 @@
 import { Version3Client } from 'jira.js';
 import { calculateStatusStatistics, convertADFToMarkdown } from './utils.js';
 import { loadCredentials } from './auth-storage.js';
-import { applyGlobalFilters, isProjectAllowed, isCommandAllowed, validateIssueAgainstFilters } from './settings.js';
+import { applyGlobalFilters, isProjectAllowed, isCommandAllowed, validateIssueAgainstFilters, loadSettings } from './settings.js';
 import { CommandError } from './errors.js';
 let jiraClient = null;
 let organizationOverride = undefined;
@@ -356,8 +356,8 @@ export async function createIssue(projectKey, summary, issueTypeName, parentKey)
 /**
  * Validate that the current user has permission to perform a command on an issue
  */
-export async function validateIssuePermissions(issueKey, commandName) {
-    const task = await getTaskWithDetails(issueKey);
+export async function validateIssuePermissions(issueKey, commandName, options = {}) {
+    const task = await getTaskWithDetails(issueKey, options);
     const projectKey = task.key.split('-')[0];
     if (!isProjectAllowed(projectKey)) {
         throw new CommandError(`Project '${projectKey}' is not allowed by your settings.`);
@@ -373,6 +373,28 @@ export async function validateIssuePermissions(issueKey, commandName) {
             hints: [`This project has filters that you do not meet (e.g., participated roles).`]
         });
     }
+    // Check JQL filters
+    const settings = loadSettings();
+    let project = settings.projects.find(p => typeof p !== 'string' && p.key === projectKey);
+    if (!project) {
+        project = settings.projects.find(p => typeof p === 'string' && (p === 'all' || p === projectKey));
+    }
+    if (project && typeof project !== 'string' && project.filters?.jql) {
+        const client = getJiraClient();
+        const jql = `key = "${issueKey}" AND (${project.filters.jql})`;
+        const response = await client.issueSearch.searchForIssuesUsingJqlEnhancedSearch({
+            jql,
+            maxResults: 1,
+            fields: ['key'],
+        });
+        if (!response.issues || response.issues.length === 0) {
+            throw new CommandError(`Access to issue ${issueKey} is restricted by project filters.`, {
+                hints: [
+                    `This project has a JQL filter that this issue does not meet: ${project.filters.jql}`,
+                ]
+            });
+        }
+    }
     return task;
 }
 /**

package/dist/lib/settings.js

@@ -32,7 +32,7 @@ export function loadSettings() {
                 console.error('Error migrating settings.yaml:', error);
                 const defaultSettings = {
                     projects: ['all'],
-                    commands: ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label', 'delete-label', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
+                    commands: ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label-to-issue', 'delete-label-from-issue', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
                 };
                 cachedSettings = defaultSettings;
                 return cachedSettings;
@@ -42,7 +42,7 @@ export function loadSettings() {
             // Create default settings.yaml if it doesn't exist anywhere
             const defaultSettings = {
                 projects: ['all'],
-                commands: ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label', 'delete-label', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
+                commands: ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label-to-issue', 'delete-label-from-issue', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
             };
             try {
                 const yamlStr = yaml.dump(defaultSettings);
@@ -68,7 +68,7 @@ export function loadSettings() {
             const settings = rawSettings;
             cachedSettings = {
                 projects: settings?.projects || ['all'],
-                commands: settings?.commands || ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label', 'delete-label', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
+                commands: settings?.commands || ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label-to-issue', 'delete-label-from-issue', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']
             };
         }
         else {
@@ -111,7 +111,10 @@ export function isCommandAllowed(commandName, projectKey) {
         return true;
     }
     if (projectKey) {
-        const project = settings.projects.find(p => (typeof p === 'string' ? p : p.key) === projectKey);
+        let project = settings.projects.find(p => typeof p !== 'string' && p.key === projectKey);
+        if (!project) {
+            project = settings.projects.find(p => typeof p === 'string' && (p === 'all' || p === projectKey));
+        }
         if (project && typeof project !== 'string' && project.commands) {
             return project.commands.includes(commandName);
         }
@@ -166,11 +169,12 @@ export function applyGlobalFilters(jql) {
 export function validateIssueAgainstFilters(issue, currentUserId) {
     const settings = loadSettings();
     const projectKey = issue.key.split('-')[0];
-    const project = settings.projects.find(p => {
-        if (typeof p === 'string')
-            return p === 'all' || p === projectKey;
-        return p.key === projectKey;
-    });
+    // Find specific project config first
+    let project = settings.projects.find(p => typeof p !== 'string' && p.key === projectKey);
+    // If not found, look for string match (exact project key or 'all')
+    if (!project) {
+        project = settings.projects.find(p => typeof p === 'string' && (p === 'all' || p === projectKey));
+    }
     if (!project) {
         return false;
     }

package/dist/lib/validation.js

@@ -92,5 +92,5 @@ export const ProjectSettingSchema = z.union([
 ]);
 export const SettingsSchema = z.object({
     projects: z.array(ProjectSettingSchema).nullish().transform(val => val || ['all']),
-    commands: z.array(z.string()).nullish().transform(val => val || ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label', 'delete-label', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']),
+    commands: z.array(z.string()).nullish().transform(val => val || ['me', 'projects', 'task-with-details', 'run-jql', 'list-issue-types', 'project-statuses', 'create-task', 'list-colleagues', 'add-comment', 'add-label-to-issue', 'delete-label-from-issue', 'get-issue-statistics', 'get-person-worklog', 'organization', 'transition', 'update-description']),
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "jira-ai",
-  "version": "0.4.10",
+  "version": "0.4.12",
   "description": "AI friendly Jira CLI to save context",
   "type": "module",
   "main": "dist/cli.js",