jinaga-server 3.5.2 → 3.5.3

package/integration-test/jinaga-test/read-csv.test.js

@@ -0,0 +1,330 @@
+const request = require('supertest');
+const { JinagaServer } = require('./jinaga-server');
+const express = require('express');
+
+const host = "db";
+const connectionString = `postgresql://dev:devpw@${host}:5432/integrationtest`;
+
+// Test model classes
+class Root {
+  static Type = "CSVTest.Root";
+  type = Root.Type;
+
+  constructor(identifier) {
+    this.identifier = identifier;
+  }
+}
+
+class Successor {
+  static Type = "CSVTest.Successor";
+  type = Successor.Type;
+
+  constructor(identifier, predecessor) {
+    this.identifier = identifier;
+    this.pred = predecessor;
+  }
+}
+
+// Helper to create test app
+async function createTestApp() {
+  const { handler, j, close } = JinagaServer.create({
+    pgKeystore: connectionString,
+    pgStore: connectionString
+  });
+
+  const app = express();
+  app.use(express.json());
+  app.use(express.text());
+  app.use(handler);
+
+  return { app, j, close };
+}
+
+describe('Read Endpoint - CSV Output', () => {
+  let app;
+  let j;
+  let close;
+  let root;
+  let rootHash;
+
+  beforeEach(async () => {
+    ({ app, j, close } = await createTestApp());
+    await j.local();
+    
+    // Create test data
+    root = await j.fact(new Root('csv-test-' + Date.now()));
+    await j.fact(new Successor(`csv-successor-1`, root));
+    await j.fact(new Successor(`csv-successor-2`, root));
+    await j.fact(new Successor(`csv-successor-3`, root));
+    rootHash = j.hash(root);
+  });
+
+  afterEach(async () => {
+    if (close) {
+      await close();
+    }
+  });
+
+  describe('CSV with Specification Headers', () => {
+    it('should use specification labels as CSV headers', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  successorId = s.identifier
+  successorHash = #s
+  successorTime = @s
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      // Parse CSV
+      const lines = response.text.trim().split('\n');
+      const headers = lines[0].split(',').map(h => h.trim());
+      
+      // Headers should match specification labels
+      expect(headers).toContain('successorId');
+      expect(headers).toContain('successorHash');
+      expect(headers).toContain('successorTime');
+      
+      // Should have data rows
+      expect(lines.length).toBeGreaterThan(1);
+    });
+
+    it('should include headers even with empty result set', async () => {
+      const emptyRoot = await j.fact(new Root('empty-csv-test-' + Date.now()));
+      const emptyRootHash = j.hash(emptyRoot);
+      
+      const specification = `let root: CSVTest.Root = #${emptyRootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  successorName = s.identifier
+  successorHash = #s
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      // Parse CSV
+      const lines = response.text.trim().split('\n');
+      
+      // Should have headers even with no data
+      expect(lines.length).toBeGreaterThanOrEqual(1);
+      
+      const headers = lines[0].split(',').map(h => h.trim());
+      expect(headers).toContain('successorName');
+      expect(headers).toContain('successorHash');
+    });
+
+    it('should properly escape CSV values with commas', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  identifier = s.identifier
+  type = s.type
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      // Response should be valid CSV
+      expect(response.text).toBeTruthy();
+      expect(response.text.includes('\n')).toBe(true);
+    });
+  });
+
+  describe('CSV Validation', () => {
+    it('should reject nested object projections', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  nested = {
+    grandchild: CSVTest.Grandchild [
+      grandchild->parent: CSVTest.Successor = s
+    ]
+  } => {
+    grandchildHash = #grandchild
+  }
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 400) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(400);
+      }
+      expect(response.text).toContain('not compatible with CSV');
+      expect(response.text).toContain(`Unsupported projection type of field 'nested' for CSV export.`);
+    });
+
+    it('should accept flat projections with multiple fields', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  id = s.identifier
+  type = s.type
+  hash = #s
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      const lines = response.text.trim().split('\n');
+      const headers = lines[0].split(',').map(h => h.trim());
+      
+      expect(headers).toContain('id');
+      expect(headers).toContain('type');
+      expect(headers).toContain('hash');
+    });
+
+    it('should provide helpful error message for invalid projections', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  allSuccessors = s
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 400) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(400);
+      }
+      expect(response.text).toContain('Hint');
+      expect(response.text).toContain('flat projections');
+    });
+  });
+
+  describe('CSV with csv-stringify', () => {
+    it('should handle special characters properly', async () => {
+      // Create successor with special characters in identifier
+      const specialRoot = await j.fact(new Root('special-test-' + Date.now()));
+      const specialRootHash = j.hash(specialRoot);
+      await j.fact(new Successor('test, with "quotes"', specialRoot));
+      
+      const specification = `let root: CSVTest.Root = #${specialRootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  name = s.identifier
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      // Response should properly escape the value
+      expect(response.text).toContain('name');
+      // csv-stringify should handle the quotes and comma
+      expect(response.text).toBeTruthy();
+    });
+
+    it('should handle date values properly', async () => {
+      const specification = `let root: CSVTest.Root = #${rootHash}
+
+(root: CSVTest.Root) {
+  s: CSVTest.Successor [
+    s->pred: CSVTest.Root = root
+  ]
+} => {
+  identifier = s.identifier
+  type = s.type
+}`;
+
+      const response = await request(app)
+        .post('/read')
+        .set('Content-Type', 'text/plain')
+        .set('Accept', 'text/csv')
+        .send(specification);
+
+      if (response.status !== 200) {
+        expect(response.text).toBe('');
+        expect(response.status).toBe(200);
+      }
+      expect(response.type).toBe('text/csv');
+      
+      // Should successfully generate CSV
+      const lines = response.text.trim().split('\n');
+      expect(lines.length).toBeGreaterThan(1);
+    });
+  });
+});