jfs-components 0.1.8 → 0.1.17

package/src/components/CardCTA/CardCTA.tsx

@@ -1,5 +1,5 @@
 import React from 'react'
-import { View, Text, type ViewStyle, type TextStyle, type StyleProp } from 'react-native'
+import { View, Text, type ViewStyle, type TextStyle, type StyleProp, type ImageSourcePropType } from 'react-native'
 import { findVariablesByPattern, getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { cloneChildrenWithModes, EMPTY_MODES } from '../../utils/react-utils'
@@ -8,12 +8,24 @@ import Button from '../Button/Button'
 import Badge from '../Badge/Badge'
 import ButtonGroup from '../ButtonGroup/ButtonGroup'
 import IconButton from '../IconButton/IconButton'
+import Avatar from '../Avatar/Avatar'
 import type { Modes } from '../../design-tokens'
 
-export type CardCTAType = 'cta' | 'rating'
+export type CardCTAType = 'cta' | 'rating' | 'sip'
+
+/**
+ * Accepted `type` values. The canonical (and historical) values are lowercase
+ * (`'cta' | 'rating' | 'sip'`). The Figma variant names are PascalCase
+ * (`'CTA' | 'Rating' | 'Sip'`) — we accept those too and normalize internally
+ * so callers can pass either casing without a breaking change.
+ */
+export type CardCTATypeInput = CardCTAType | 'CTA' | 'Rating' | 'Sip'
 
 const optionalTokenAvailability = new Map<string, boolean>()
 
+const toWeight = (w: number | string): TextStyle['fontWeight'] =>
+    (typeof w === 'number' ? `${w}` : w) as TextStyle['fontWeight']
+
 function getOptionalVariableByName<T>(name: string, modes: Modes, fallback: T): T {
     let isAvailable = optionalTokenAvailability.get(name)
 
@@ -30,8 +42,13 @@ function getOptionalVariableByName<T>(name: string, modes: Modes, fallback: T):
 }
 
 export type CardCTAProps = {
-    /** Visual layout variant */
-    type?: CardCTAType;
+    /**
+     * Visual layout variant. `'cta'` (default) is the horizontal CTA card,
+     * `'rating'` is the rating card, and `'sip'` is the avatar-led card with a
+     * headline/description/subtitle footer. PascalCase Figma names
+     * (`'CTA' | 'Rating' | 'Sip'`) are also accepted.
+     */
+    type?: CardCTATypeInput;
     /** Title text */
     title?: string;
     /** Body / subtitle text */
@@ -50,6 +67,14 @@ export type CardCTAProps = {
     onPressLike?: () => void;
     /** Callback for the default dislike action */
     onPressDislike?: () => void;
+    /** [sip] Headline text shown above the description row */
+    headline?: string;
+    /** [sip] Description text (left of subtitle) */
+    description?: string;
+    /** [sip] Subtitle text (right of description) */
+    subtitle?: string;
+    /** [sip] Image source for the default Avatar */
+    avatarSource?: ImageSourcePropType | string;
     /** Mode configuration for design token resolution */
     modes?: Modes;
     /** Slot: replaces the default icon area (right side) */
@@ -60,6 +85,8 @@ export type CardCTAProps = {
     ratingBadgeSlot?: React.ReactNode;
     /** Slot: replaces the default like/dislike action group */
     ratingActionsSlot?: React.ReactNode;
+    /** [sip] Slot: replaces the default Avatar */
+    avatarSlot?: React.ReactNode;
     /** Container style overrides */
     style?: StyleProp<ViewStyle>;
 };
@@ -75,43 +102,51 @@ function CardCTA({
     showRatingActions = true,
     onPressLike,
     onPressDislike,
+    headline = 'Headline',
+    description = 'Description',
+    subtitle = 'Subtitle',
+    avatarSource,
     modes: propModes = EMPTY_MODES,
     iconSlot,
     buttonSlot,
     ratingBadgeSlot,
     ratingActionsSlot,
+    avatarSlot,
     style,
 }: CardCTAProps) {
     const { modes: globalModes } = useTokens()
     const modes = { ...globalModes, ...propModes }
-    const isRating = type === 'rating'
-
-    const background = getVariableByName('cardCTA/background', modes) || '#ffffff'
-    const radius = getVariableByName('cardCTA/radius', modes) || 12
-    const borderSize = getVariableByName('cardCTA/border/size', modes) || 1
-    const borderColor = getVariableByName('cardCTA/border/color', modes) || '#e3e4e4'
-
-    const leftPaddingH = getVariableByName('cardCTA/left-wrap/padding/horizontal', modes) || 16
-    const leftPaddingV = getVariableByName('cardCTA/left-wrap/padding/vertical', modes) || 22
-    const leftGap = getVariableByName('cardCTA/left-wrap/gap', modes) || 16
-
-    const rightPaddingH = getVariableByName('cardCTA/right-wrap/padding/horizontal', modes) || 16
-    const rightPaddingV = getVariableByName('cardCTA/right-wrap/padding/vertical', modes) || 22
-
-    const textGap = getVariableByName('cardCTA/text-wrap/gap', modes) || 6
-
-    const titleColor = getVariableByName('cardCTA/title/color', modes) || '#0c0d10'
-    const titleFontFamily = getVariableByName('cardCTA/title/fontFamily', modes) || 'JioType Var'
-    const titleFontSize = getVariableByName('cardCTA/title/fontSize', modes) || 16
-    const titleLineHeight = getVariableByName('cardCTA/title/lineHeight', modes) || 17.6
-    const titleFontWeightRaw = getVariableByName('cardCTA/title/fontWeight', modes) || 700
+    // Accept both lowercase (canonical) and Figma PascalCase variant names.
+    const normalizedType = (typeof type === 'string' ? type.toLowerCase() : 'cta') as CardCTAType
+    const isRating = normalizedType === 'rating'
+    const isSip = normalizedType === 'sip'
+
+    const background = getVariableByName('cardCTA/background', modes)
+    const radius = getVariableByName('cardCTA/radius', modes)
+    const borderSize = getVariableByName('cardCTA/border/size', modes)
+    const borderColor = getVariableByName('cardCTA/border/color', modes)
+
+    const leftPaddingH = getVariableByName('cardCTA/left-wrap/padding/horizontal', modes)
+    const leftPaddingV = getVariableByName('cardCTA/left-wrap/padding/vertical', modes)
+    const leftGap = getVariableByName('cardCTA/left-wrap/gap', modes)
+
+    const rightPaddingH = getVariableByName('cardCTA/right-wrap/padding/horizontal', modes)
+    const rightPaddingV = getVariableByName('cardCTA/right-wrap/padding/vertical', modes)
+
+    const textGap = getVariableByName('cardCTA/text-wrap/gap', modes)
+
+    const titleColor = getVariableByName('cardCTA/title/color', modes)
+    const titleFontFamily = getVariableByName('cardCTA/title/fontFamily', modes)
+    const titleFontSize = getVariableByName('cardCTA/title/fontSize', modes)
+    const titleLineHeight = getVariableByName('cardCTA/title/lineHeight', modes)
+    const titleFontWeightRaw = getVariableByName('cardCTA/title/fontWeight', modes)
     const titleFontWeight = typeof titleFontWeightRaw === 'number' ? titleFontWeightRaw.toString() : titleFontWeightRaw
 
-    const bodyColor = getVariableByName('cardCTA/body/color', modes) || '#13002d'
-    const bodyFontFamily = getVariableByName('cardCTA/body/fontFamily', modes) || 'JioType Var'
-    const bodyFontSize = getVariableByName('cardCTA/body/fontSize', modes) || 10
-    const bodyLineHeight = getVariableByName('cardCTA/body/lineHeight', modes) || 12
-    const bodyFontWeightRaw = getVariableByName('cardCTA/body/fontWeight', modes) || 400
+    const bodyColor = getVariableByName('cardCTA/body/color', modes)
+    const bodyFontFamily = getVariableByName('cardCTA/body/fontFamily', modes)
+    const bodyFontSize = getVariableByName('cardCTA/body/fontSize', modes)
+    const bodyLineHeight = getVariableByName('cardCTA/body/lineHeight', modes)
+    const bodyFontWeightRaw = getVariableByName('cardCTA/body/fontWeight', modes)
     const bodyFontWeight = typeof bodyFontWeightRaw === 'number' ? bodyFontWeightRaw.toString() : bodyFontWeightRaw
 
     const ratingContentGap = getOptionalVariableByName('cardCTA/rating/content/gap', modes, 12)
@@ -122,41 +157,108 @@ function CardCTA({
     const ratingFooterPaddingTop = getOptionalVariableByName('cardCTA/rating/footer/top', modes, 0)
     const ratingFooterPaddingBottom = getOptionalVariableByName('cardCTA/rating/footer/bottom', modes, 12)
 
+    // Sip variant footer text block (Headline / Description / Subtitle). These
+    // `ccCard/*` tokens were introduced for the Sip layout — resolve them
+    // optionally so older token snapshots that lack them fall back gracefully.
+    const sipFooterGap = getOptionalVariableByName('ccCard/footer/textWrap/gap', modes, 4)
+
+    const sipHeadlineColor = getOptionalVariableByName('ccCard/headline/color', modes, '#707275')
+    const sipHeadlineFontFamily = getOptionalVariableByName('ccCard/headline/fontFamily', modes, 'JioType Var')
+    const sipHeadlineFontSize = getOptionalVariableByName('ccCard/headline/fontSize', modes, 10)
+    const sipHeadlineLineHeight = getOptionalVariableByName('ccCard/headline/lineHeight', modes, 13)
+    const sipHeadlineFontWeightRaw = getOptionalVariableByName<string | number>('ccCard/headline/fontWeight', modes, 500)
+    const sipHeadlineFontWeight = typeof sipHeadlineFontWeightRaw === 'number' ? sipHeadlineFontWeightRaw.toString() : sipHeadlineFontWeightRaw
+
+    const sipDescriptionColor = getOptionalVariableByName('ccCard/title/color', modes, '#081007')
+    const sipDescriptionFontFamily = getOptionalVariableByName('ccCard/title/fontFamily', modes, 'JioType Var')
+    const sipDescriptionFontSize = getOptionalVariableByName('ccCard/title/fontSize', modes, 14)
+    const sipDescriptionLineHeight = getOptionalVariableByName('ccCard/title/lineHeight', modes, 15)
+    const sipDescriptionFontWeightRaw = getOptionalVariableByName<string | number>('ccCard/title/fontWeight', modes, 700)
+    const sipDescriptionFontWeight = typeof sipDescriptionFontWeightRaw === 'number' ? sipDescriptionFontWeightRaw.toString() : sipDescriptionFontWeightRaw
+
+    const sipSubtitleColor = getOptionalVariableByName('ccCard/subtitle/color', modes, '#707275')
+    const sipSubtitleFontFamily = getOptionalVariableByName('ccCard/subtitle/fontFamily', modes, 'JioType Var')
+    const sipSubtitleFontSize = getOptionalVariableByName('ccCard/subtitle/fontSize', modes, 10)
+    const sipSubtitleLineHeight = getOptionalVariableByName('ccCard/subtitle/lineHeight', modes, 13)
+    const sipSubtitleFontWeightRaw = getOptionalVariableByName<string | number>('ccCard/subtitle/fontWeight', modes, 500)
+    const sipSubtitleFontWeight = typeof sipSubtitleFontWeightRaw === 'number' ? sipSubtitleFontWeightRaw.toString() : sipSubtitleFontWeightRaw
+
+    const avatarModes = { ...modes, 'Avatar Size': 'L' }
+
     const buttonModes = {...modes, AppearanceBrand: 'Secondary', 'Button / Size': 'S'}
     const iconButtonModes = {'Button / Size': 'S', 'Emphasis': 'Low', 'AppearanceBrand':'Neutral',...modes }
     const effectiveButtonLabel = buttonLabel ?? (isRating ? 'Save' : 'Button')
     const nonWrappingButtonLabel = effectiveButtonLabel.replace(/\s/g, '\u00A0')
     const [measuredButtonLabelWidth, setMeasuredButtonLabelWidth] = React.useState<number | null>(null)
 
-    const buttonPaddingH = getVariableByName('button/padding/horizontal', buttonModes) || 20
+    const buttonPaddingH = getVariableByName('button/padding/horizontal', buttonModes)
     const buttonBorderSize = getVariableByName('button/border/size', buttonModes) ?? 1
+    // Small safety pad so sub-pixel rounding between the measure pass and the
+    // rendered glyph run can never clip the final character.
     const measuredButtonWidth = measuredButtonLabelWidth === null
         ? undefined
-        : Math.ceil(measuredButtonLabelWidth + (buttonPaddingH as number) * 2 + (buttonBorderSize as number) * 2)
-
-    const handleButtonLabelTextLayout = React.useCallback((event: any) => {
-        const lines = event?.nativeEvent?.lines
-        if (!Array.isArray(lines) || lines.length === 0) return
-
-        const nextWidth = Math.ceil(
-            lines.reduce((sum, line) => sum + (typeof line?.width === 'number' ? line.width : 0), 0)
+        : Math.ceil(measuredButtonLabelWidth + (buttonPaddingH as number) * 2 + (buttonBorderSize as number) * 2 + 2)
+
+    // ROOT-CAUSE FIX for the Android "jumping button" feedback loop + clipping.
+    //
+    // Previously the *visible* label measured itself via `onTextLayout` and we
+    // fed that width straight back onto the same Button. Because the button is
+    // width-constrained by its parent, Android clamps the overflowing text and
+    // even character-breaks a single word ("Save" -> "Sav"/"e"); the re-applied
+    // width re-triggers layout, producing an endless ~60fps width oscillation.
+    //
+    // We now measure an *off-screen* copy of the label, laid out at an
+    // effectively unbounded width, so its reported single-line width is
+    // intrinsic and constant regardless of the button's applied width — the
+    // measurement can no longer depend on the value it produces, so the loop is
+    // impossible. Crucially the measurer reuses the Button's own resolved label
+    // styles (passed into `renderContent`), so the measured font matches the
+    // rendered font exactly and the width is never an under-estimate. The label
+    // is always a single line that overflows rather than wraps or truncates.
+    const handleMeasureTextLayout = React.useCallback((event: any) => {
+        const line = event?.nativeEvent?.lines?.[0]
+        const width = line && typeof line.width === 'number' ? line.width : 0
+        if (width <= 0) return
+
+        setMeasuredButtonLabelWidth((currentWidth) =>
+            currentWidth !== null && Math.abs(currentWidth - width) < 0.5
+                ? currentWidth
+                : Math.ceil(width)
         )
-        if (nextWidth <= 0) return
-
-        setMeasuredButtonLabelWidth((currentWidth) => {
-            if (currentWidth !== null && Math.abs(currentWidth - nextWidth) < 1) {
-                return currentWidth
-            }
-            return nextWidth
-        })
     }, [])
 
+    // Off-screen measurer wrapper: absolute + opacity 0 + pointerEvents none =>
+    // out of flow, invisible, never intercepts touches, zero layout impact.
+    const measurerWrapStyle: ViewStyle = { position: 'absolute', left: 0, top: 0, opacity: 0 }
+
+    // Renders the visible single-line label (never wraps, never ellipsizes) plus
+    // the co-located off-screen measurer that shares the Button's exact label
+    // styles. `width: 9999` forces the measurer onto one line so `onTextLayout`
+    // reports the true intrinsic width.
+    const renderButtonContent = (labelExtraStyle: TextStyle) => (labelStyles: StyleProp<TextStyle>) => (
+        <>
+            <Text numberOfLines={1} ellipsizeMode="clip" style={[labelStyles, labelExtraStyle]}>
+                {nonWrappingButtonLabel}
+            </Text>
+            <View
+                pointerEvents="none"
+                accessibilityElementsHidden
+                importantForAccessibility="no"
+                style={measurerWrapStyle}
+            >
+                <Text style={[labelStyles, { width: 9999 }]} onTextLayout={handleMeasureTextLayout}>
+                    {nonWrappingButtonLabel}
+                </Text>
+            </View>
+        </>
+    )
+
     const containerStyle: ViewStyle = {
         backgroundColor: background,
         borderRadius: radius,
         borderWidth: borderSize,
         borderColor,
-        flexDirection: isRating ? 'column' : 'row',
+        flexDirection: isRating || isSip ? 'column' : 'row',
         overflow: 'visible',
     }
 
@@ -245,6 +347,53 @@ function CardCTA({
         fontWeight: bodyFontWeight,
     }
 
+    const sipWrapStyle: ViewStyle = {
+        width: '100%',
+        paddingHorizontal: leftPaddingH,
+        paddingVertical: leftPaddingV,
+        gap: leftGap,
+        alignItems: 'flex-start',
+        justifyContent: 'flex-start',
+        overflow: 'visible',
+    }
+
+    const sipFooterTextWrapStyle: ViewStyle = {
+        gap: sipFooterGap,
+        alignItems: 'flex-start',
+        alignSelf: 'stretch',
+        minWidth: 0,
+    }
+
+    const sipDescriptionWrapStyle: ViewStyle = {
+        flexDirection: 'row',
+        gap: sipFooterGap,
+        alignItems: 'flex-end',
+    }
+
+    const sipHeadlineStyle: TextStyle = {
+        color: sipHeadlineColor,
+        fontFamily: sipHeadlineFontFamily,
+        fontSize: sipHeadlineFontSize,
+        lineHeight: sipHeadlineLineHeight,
+        fontWeight: toWeight(sipHeadlineFontWeightRaw),
+    }
+
+    const sipDescriptionStyle: TextStyle = {
+        color: sipDescriptionColor,
+        fontFamily: sipDescriptionFontFamily,
+        fontSize: sipDescriptionFontSize,
+        lineHeight: sipDescriptionLineHeight,
+        fontWeight: toWeight(sipDescriptionFontWeightRaw),
+    }
+
+    const sipSubtitleStyle: TextStyle = {
+        color: sipSubtitleColor,
+        fontFamily: sipSubtitleFontFamily,
+        fontSize: sipSubtitleFontSize,
+        lineHeight: sipSubtitleLineHeight,
+        fontWeight: toWeight(sipSubtitleFontWeightRaw),
+    }
+
     const ratingContentStyle: ViewStyle = {
         paddingHorizontal: ratingContentPaddingH,
         paddingVertical: ratingContentPaddingV,
@@ -294,6 +443,44 @@ function CardCTA({
         flexWrap: 'nowrap',
     }
 
+    if (isSip) {
+        return (
+            <View style={[containerStyle, style]}>
+                <View style={sipWrapStyle}>
+                    {avatarSlot ? (
+                        cloneChildrenWithModes(avatarSlot, avatarModes)
+                    ) : (
+                        <Avatar style="Image" imageSource={avatarSource} modes={avatarModes} />
+                    )}
+                    <View style={textWrapStyle}>
+                        <Text style={titleStyle}>{title}</Text>
+                        <Text style={bodyStyle}>{body}</Text>
+                    </View>
+                    <View style={sipFooterTextWrapStyle}>
+                        <Text style={sipHeadlineStyle}>{headline}</Text>
+                        <View style={sipDescriptionWrapStyle}>
+                            <Text style={sipDescriptionStyle}>{description}</Text>
+                            <Text style={sipSubtitleStyle}>{subtitle}</Text>
+                        </View>
+                    </View>
+                    <View style={buttonWrapStyle}>
+                        {buttonSlot ? (
+                            cloneChildrenWithModes(buttonSlot, buttonModes)
+                        ) : (
+                            <Button
+                                label={effectiveButtonLabel}
+                                onPress={onPressButton || (() => {})}
+                                modes={buttonModes}
+                                style={buttonStyle}
+                                renderContent={renderButtonContent(buttonLabelStyle)}
+                            />
+                        )}
+                    </View>
+                </View>
+            </View>
+        )
+    }
+
     if (isRating) {
         return (
             <View style={[containerStyle, style]}>
@@ -318,14 +505,7 @@ function CardCTA({
                                 onPress={onPressButton || (() => {})}
                                 modes={buttonModes}
                                 style={ratingButtonStyle}
-                                renderContent={(labelStyles) => (
-                                    <Text
-                                        onTextLayout={handleButtonLabelTextLayout}
-                                        style={[labelStyles, ratingButtonLabelStyle]}
-                                    >
-                                        {nonWrappingButtonLabel}
-                                    </Text>
-                                )}
+                                renderContent={renderButtonContent(ratingButtonLabelStyle)}
                             />
                         )}
                     </View>
@@ -368,14 +548,7 @@ function CardCTA({
                             onPress={onPressButton || (() => {})}
                             modes={buttonModes}
                             style={buttonStyle}
-                            renderContent={(labelStyles) => (
-                                <Text
-                                    onTextLayout={handleButtonLabelTextLayout}
-                                    style={[labelStyles, buttonLabelStyle]}
-                                >
-                                    {nonWrappingButtonLabel}
-                                </Text>
-                            )}
+                            renderContent={renderButtonContent(buttonLabelStyle)}
                         />
                     )}
                 </View>

package/src/components/CardFeedback/CardFeedback.tsx

@@ -41,11 +41,11 @@ export function CardFeedback({
         ...propModes,
     };
     // Container Tokens
-    const backgroundColor = getVariableByName('cardFeedback/background', modes) || '#dbf0d9';
-    const radius = parseFloat(getVariableByName('cardFeedback/radius', modes) || '12');
-    const gap = parseFloat(getVariableByName('cardFeedback/gap', modes) || '8');
-    const paddingHorizontal = parseFloat(getVariableByName('cardFeedback/padding/horizontal', modes) || '12');
-    const paddingVertical = parseFloat(getVariableByName('cardFeedback/padding/vertical', modes) || '12');
+    const backgroundColor = getVariableByName('cardFeedback/background', modes);
+    const radius = parseFloat(getVariableByName('cardFeedback/radius', modes));
+    const gap = parseFloat(getVariableByName('cardFeedback/gap', modes));
+    const paddingHorizontal = parseFloat(getVariableByName('cardFeedback/padding/horizontal', modes));
+    const paddingVertical = parseFloat(getVariableByName('cardFeedback/padding/vertical', modes));
 
     const containerStyle: ViewStyle = {
         backgroundColor,
@@ -80,7 +80,7 @@ export function Icon({ children, style, modes: propModes, icon }: { children?: R
     const context = useContext(CardFeedbackContext);
     const modes = propModes || context.modes || {};
 
-    const size = parseFloat(getVariableByName('cardFeedback/icon/size', modes) || '20');
+    const size = parseFloat(getVariableByName('cardFeedback/icon/size', modes));
     // Color for the icon itself
     const color = getVariableByName('appearanceFeedback/cardFeedback/icon/color', modes);
     console.log(color);
@@ -120,7 +120,7 @@ export function Content({ children, style, modes: propModes }: { children?: Reac
     const context = useContext(CardFeedbackContext);
     const modes = propModes || context.modes || {};
 
-    const gap = parseFloat(getVariableByName('cardFeedback/text/gap', modes) || '8');
+    const gap = parseFloat(getVariableByName('cardFeedback/text/gap', modes));
 
     // Pass modes to children (Title, Body, etc.)
     const childrenWithModes = React.Children.map(children, child => {
@@ -145,11 +145,11 @@ export function Title({ children, style, modes: propModes }: { children?: React.
     const context = useContext(CardFeedbackContext);
     const modes = propModes || context.modes || {};
 
-    const color = getVariableByName('cardFeedback/title/color', modes) || '#0f0d0a';
-    const fontSize = parseFloat(getVariableByName('cardFeedback/title/fontSize', modes) || '14');
-    const fontFamily = getVariableByName('cardFeedback/title/fontFamily', modes) || 'JioType Var';
-    const lineHeight = parseFloat(getVariableByName('cardFeedback/title/lineHeight', modes) || '17');
-    const fontWeight = getVariableByName('cardFeedback/title/fontWeight', modes) || '500';
+    const color = getVariableByName('cardFeedback/title/color', modes);
+    const fontSize = parseFloat(getVariableByName('cardFeedback/title/fontSize', modes));
+    const fontFamily = getVariableByName('cardFeedback/title/fontFamily', modes);
+    const lineHeight = parseFloat(getVariableByName('cardFeedback/title/lineHeight', modes));
+    const fontWeight = getVariableByName('cardFeedback/title/fontWeight', modes);
 
     const textStyle: TextStyle = {
         color,
@@ -170,11 +170,11 @@ export function Body({ children, style, modes: propModes }: { children?: React.R
     const context = useContext(CardFeedbackContext);
     const modes = propModes || context.modes || {};
 
-    const color = getVariableByName('cardFeedback/body/color', modes) || '#1f1a14';
-    const fontSize = parseFloat(getVariableByName('cardFeedback/body/fontSize', modes) || '12');
-    const fontFamily = getVariableByName('cardFeedback/body/fontFamily', modes) || 'JioType Var';
-    const lineHeight = parseFloat(getVariableByName('cardFeedback/body/lineHeight', modes) || '16');
-    const fontWeight = getVariableByName('cardFeedback/body/fontWeight', modes) || '400';
+    const color = getVariableByName('cardFeedback/body/color', modes);
+    const fontSize = parseFloat(getVariableByName('cardFeedback/body/fontSize', modes));
+    const fontFamily = getVariableByName('cardFeedback/body/fontFamily', modes);
+    const lineHeight = parseFloat(getVariableByName('cardFeedback/body/lineHeight', modes));
+    const fontWeight = getVariableByName('cardFeedback/body/fontWeight', modes);
 
     const textStyle: TextStyle = {
         color,
@@ -195,7 +195,7 @@ export function Action({ children, style, modes: propModes }: { children?: React
     const context = useContext(CardFeedbackContext);
     const modes = propModes || context.modes || {};
 
-    const gap = parseFloat(getVariableByName('cardFeedback/actionSlot/gap', modes) || '0');
+    const gap = parseFloat(getVariableByName('cardFeedback/actionSlot/gap', modes));
 
     // "Maximise existing component usage" -> Pass modes to children (Buttons)
     const childrenWithModes = React.Children.map(children, child => {

package/src/components/CardFinancialCondition/CardFinancialCondition.tsx

@@ -104,8 +104,7 @@ function resolveCardFinancialConditionTokens(
   modes: Modes
 ): CardFinancialConditionTokens {
   const background =
-    (getVariableByName('financialConditionCard/background', modes) as string) ||
-    '#ffffff'
+    (getVariableByName('financialConditionCard/background', modes) as string)
   const radius = toNumber(
     getVariableByName('financialConditionCard/radius', modes),
     16
@@ -133,8 +132,7 @@ function resolveCardFinancialConditionTokens(
   )
 
   const titleColor =
-    (getVariableByName('financialConditionCard/title/color', modes) as string) ||
-    '#0c0d10'
+    (getVariableByName('financialConditionCard/title/color', modes) as string)
   const titleFontSize = toNumber(
     getVariableByName('financialConditionCard/title/fontSize', modes),
     16
@@ -143,7 +141,7 @@ function resolveCardFinancialConditionTokens(
     (getVariableByName(
       'financialConditionCard/title/fontFamily',
       modes
-    ) as string) || 'JioType Var'
+    ) as string)
   const titleLineHeight = toNumber(
     getVariableByName('financialConditionCard/title/lineHeight', modes),
     18
@@ -154,8 +152,7 @@ function resolveCardFinancialConditionTokens(
   )
 
   const bodyColor =
-    (getVariableByName('financialConditionCard/body/color', modes) as string) ||
-    '#0c0d10'
+    (getVariableByName('financialConditionCard/body/color', modes) as string)
   const bodyFontSize = toNumber(
     getVariableByName('financialConditionCard/body/fontSize', modes),
     14
@@ -164,7 +161,7 @@ function resolveCardFinancialConditionTokens(
     (getVariableByName(
       'financialConditionCard/body/fontFamily',
       modes
-    ) as string) || 'JioType Var'
+    ) as string)
   const bodyLineHeight = toNumber(
     getVariableByName('financialConditionCard/body/lineHeight', modes),
     17
@@ -175,13 +172,13 @@ function resolveCardFinancialConditionTokens(
   )
 
   const nudgeBodyColor =
-    (getVariableByName('nudge/body/color', modes) as string) || '#1a1c1f'
+    (getVariableByName('nudge/body/color', modes) as string)
   const nudgeBodyFontSize = toNumber(
     getVariableByName('nudge/body/fontSize', modes),
     12
   )
   const nudgeBodyFontFamily =
-    (getVariableByName('nudge/body/fontFamily', modes) as string) || 'JioType Var'
+    (getVariableByName('nudge/body/fontFamily', modes) as string)
   const nudgeBodyLineHeight = toNumber(
     getVariableByName('nudge/body/lineHeight', modes),
     16

package/src/components/CardInsight/CardInsight.tsx

@@ -71,7 +71,11 @@ function CardInsight({
     const background =
         (getVariableByName('cardInsight/background', modes) as string | null) ?? '#ffffff'
     const radius =
-        (getVariableByName('cardInsight/radius', modes) as number | null) ?? 16
+        (getVariableByName('cardInsight/radius', modes) as number | null) ?? 12
+    const borderWidth =
+        (getVariableByName('cardInsight/borderWidth', modes) as number | null) ?? 1
+    const borderColor =
+        (getVariableByName('cardInsight/border/color', modes) as string | null) ?? '#ffffff'
     const paddingHorizontal =
         (getVariableByName('cardInsight/padding/horizontal', modes) as number | null) ?? 12
     const paddingVertical =
@@ -79,7 +83,6 @@ function CardInsight({
     const gap = (getVariableByName('cardInsight/gap', modes) as number | null) ?? 12
     const contentGap =
         (getVariableByName('cardInsight/contentGap', modes) as number | null) ?? 8
-    const width = (getVariableByName('cardInsight/width', modes) as number | null) ?? 356
     const slotBackground =
         (getVariableByName('cardInsight/slot/background', modes) as string | null) ?? '#ffffff'
 
@@ -125,7 +128,7 @@ function CardInsight({
 
     const renderSlot = (): React.ReactNode => {
         if (!children) {
-            return <SavingsGoalSummary modes={modes} />
+            return <SavingsGoalSummary label="Credit usage" modes={modes} />
         }
         const processed = cloneChildrenWithModes(children, modes)
         return processed.length === 1 ? processed[0] : processed
@@ -161,9 +164,10 @@ function CardInsight({
         <View
             style={[
                 {
-                    width,
                     backgroundColor: background,
                     borderRadius: radius,
+                    borderWidth,
+                    borderColor,
                     paddingHorizontal,
                     paddingVertical,
                     gap,