jfs-components 0.1.57 → 0.1.58

package/lib/module/components/TextInput/TextInput.js

@@ -143,6 +143,14 @@ const TextInputBase = /*#__PURE__*/forwardRef(function TextInput({
 
   // Convert radius to React Native format (if 99999, use a large value for fully rounded)
   const borderRadius = radius === 99999 ? 99999 : radius;
+
+  // Row height from tokens: vertical padding above/below the text line.
+  // Applied as container `minHeight` (FormField pattern) — NOT as TextInput
+  // `lineHeight` / `minHeight`, which breaks iOS vertical centering.
+  const padV = typeof paddingVertical === 'number' ? paddingVertical : 0;
+  const textLine = typeof lineHeight === 'number' ? lineHeight : 0;
+  const iconH = typeof iconSize === 'number' ? iconSize : 0;
+  const rowMinHeight = padV * 2 + Math.max(textLine, iconH);
   const containerStyle = {
     flexDirection: 'row',
     alignItems: 'center',
@@ -152,7 +160,10 @@ const TextInputBase = /*#__PURE__*/forwardRef(function TextInput({
     borderStyle: 'solid',
     borderRadius,
     paddingHorizontal,
-    paddingVertical,
+    // Same as FormField / SuggestiveSearch: the ROW owns height via minHeight;
+    // paddingVertical on the row would fight that and let the field stretch.
+    paddingVertical: 0,
+    minHeight: rowMinHeight > 0 ? rowMinHeight : undefined,
     gap: 8
   };
   const hoverStyle = isHovered ? {
@@ -163,18 +174,15 @@ const TextInputBase = /*#__PURE__*/forwardRef(function TextInput({
     borderWidth: 1
   } : {};
 
-  // ⚠️ DO NOT change to an unconditional `lineHeight`, and do NOT put
-  // `minHeight: lineHeight` on this single-line input on iOS. Same contract as
-  // FormField / SuggestiveSearch — read before "simplifying".
+  // ⚠️ Same contract as FormField / SuggestiveSearch — do not "simplify".
   //
-  // facebook/react-native#39145 / #28012: on iOS, a single-line RN TextInput
-  // (UITextField) with `lineHeight` > font metrics puts ALL the extra space
-  // ABOVE the glyphs, so placeholder/value sink. Android/Web distribute evenly.
-  // RN's documented workaround (#39145) and #56774: omit `lineHeight` on
-  // single-line iOS inputs — UITextField centers natively — and let the
-  // wrapper (`alignItems: 'center'` + padding/icon) own vertical layout.
-  // Pinning `lineHeight` to `fontSize` is NOT a substitute; it clips custom
-  // font metrics and floats typed text above center.
+  // facebook/react-native#39145 / #28012 / #56774:
+  // Single-line iOS UITextField + `lineHeight` (or a tall field box) puts ALL
+  // extra space ABOVE the glyphs → placeholder/value sink. Documented fix:
+  // omit `lineHeight` on the single-line input; let the wrapper
+  // (`alignItems: 'center'` + `minHeight`) center it. UITextField centers
+  // natively when it is only as tall as its font. Do NOT pin lineHeight to
+  // fontSize (clips custom fonts / floats typed text).
   const textInputStyle = {
     flex: 1,
     color: textColor,