jfs-components 0.0.99 → 0.1.2

package/src/components/FullscreenModal/FullscreenModal.tsx

@@ -1,8 +1,9 @@
-import React, { useMemo, useRef } from 'react'
+import React, { useMemo, useRef, useState, useCallback } from 'react'
 import {
   View,
   Text,
   Animated,
+  type LayoutChangeEvent,
   type StyleProp,
   type ViewStyle,
   type TextStyle,
@@ -16,6 +17,7 @@ import Disclaimer from '../Disclaimer/Disclaimer'
 import IconButton from '../IconButton/IconButton'
 import ActionFooter from '../ActionFooter/ActionFooter'
 import Slot from '../Slot/Slot'
+import type { Modes } from '../../design-tokens'
 
 // ---------------------------------------------------------------------------
 // Forced modes
@@ -71,6 +73,12 @@ export type FullscreenModalProps = {
   heroHeight?: number
   /** Whether to render the floating close button (top-right). Defaults to true. */
   showClose?: boolean
+  /**
+   * Additional vertical offset (in px) applied to the floating close button's
+   * top position, on top of the base inset (`12 + safe-area top`). Positive
+   * values push it further down. Defaults to 0.
+   */
+  closeOffsetY?: number
   /** Press handler for the close button. */
   onClose?: () => void
   /** Accessibility label for the close button. */
@@ -93,7 +101,7 @@ export type FullscreenModalProps = {
    * and `context5` is always forced to `'Fullscreen Modal'` (non-overridable).
    * The resolved modes cascade to the body, hero media, and the `ActionFooter`.
    */
-  modes?: Record<string, any>
+  modes?: Modes
   /** Style overrides for the outer container. */
   style?: StyleProp<ViewStyle>
   /** Style overrides for the transparent body wrapper. */
@@ -112,7 +120,7 @@ type HeroTextProps = {
   headline?: string
   supportingText?: string
   priceText?: string
-  modes: Record<string, any>
+  modes: Modes
 }
 
 function HeroText({ eyebrow, headline, supportingText, priceText, modes }: HeroTextProps) {
@@ -230,6 +238,7 @@ function FullscreenModal({
   heroMedia,
   heroHeight = 420,
   showClose = true,
+  closeOffsetY = 0,
   onClose,
   closeAccessibilityLabel = 'Close',
   footer,
@@ -268,8 +277,8 @@ function FullscreenModal({
   // SafeAreaProvider — every inset is 0, so the layout is unchanged.
   const insets = useSafeAreaInsets()
   const closeButtonInsetStyle = useMemo<ViewStyle>(
-    () => ({ top: 12 + insets.top }),
-    [insets.top]
+    () => ({ top: 12 + insets.top + closeOffsetY }),
+    [insets.top, closeOffsetY]
   )
   // Extend (not replace) the footer's token bottom padding by the bottom inset
   // so the action button never sits under the system navigation area.
@@ -293,11 +302,57 @@ function FullscreenModal({
   )
   const heroTranslateY = useMemo(() => Animated.multiply(scrollY, -1), [scrollY])
 
-  const processedHeroMedia = useMemo(
-    () =>
-      heroMedia ? cloneChildrenWithModes(heroMedia, modes, FULLSCREEN_MODAL_FORCED_MODES) : null,
-    [heroMedia, modes]
-  )
+  // The hero media is a full-bleed background pinned to the top of the modal.
+  // Its wrapper is absolutely positioned (`top/left/right: 0`) so it never
+  // contributes to scroll height. We measure the modal's own width so we can
+  // give the hero media a DEFINITE { width, height } box (see
+  // `processedHeroMedia` below) — relying on the media's own `width: '100%'` +
+  // `aspectRatio` is unreliable inside an indefinite-height absolute box (RN's
+  // `<Image>` falls back to its intrinsic width and leaves a gap), so we size
+  // it explicitly here instead.
+  const [containerWidth, setContainerWidth] = useState(0)
+  const onContainerLayout = useCallback((e: LayoutChangeEvent) => {
+    const w = e.nativeEvent.layout.width
+    setContainerWidth((prev) => (prev !== w ? w : prev))
+  }, [])
+
+  const processedHeroMedia = useMemo(() => {
+    if (!heroMedia) return null
+    // Defer rendering the hero until we have measured the modal width. This
+    // matters for image sharpness: React Native decodes a bitmap once, on the
+    // first render, and caches it. If we rendered the media before knowing the
+    // final box, that first decode would be sized/sampled for the wrong box and
+    // the cached (downsampled) bitmap would then just be scaled up — blurry.
+    // Rendering only once the explicit { width, height } box is known means the
+    // very first decode is already full-resolution for the correct box.
+    if (containerWidth <= 0) return null
+    const withModes = cloneChildrenWithModes(heroMedia, modes, FULLSCREEN_MODAL_FORCED_MODES)
+
+    // Force the hero to fill the modal width edge to edge, top-aligned, with the
+    // height derived from the media's native aspect ratio.
+    //
+    // Why we inject explicit width/height instead of relying on the media's own
+    // `width: '100%'` + `aspectRatio`: the hero wrapper is absolutely positioned
+    // with an INDEFINITE height, and in that layout context React Native's
+    // `<Image>` falls back to its INTRINSIC width (so a 361px-wide asset renders
+    // 361px wide and leaves a gap on the right) rather than stretching to the
+    // parent. By computing `height = containerWidth / ratio` here and passing a
+    // DEFINITE { width, height } box (which makes `<Image>` skip aspectRatio and
+    // cover-fit into that exact box), the hero always fills the width with the
+    // correct ratio-derived height.
+    return React.Children.map(withModes, (child) => {
+      if (!React.isValidElement(child)) return child
+      const props = child.props as { ratio?: number; width?: unknown; height?: unknown }
+      const ratio = typeof props.ratio === 'number' && props.ratio > 0 ? props.ratio : undefined
+      // Only size media that exposes a numeric `ratio` and hasn't already been
+      // given an explicit box by the caller.
+      if (ratio == null || props.width != null || props.height != null) return child
+      return React.cloneElement(child, {
+        width: containerWidth,
+        height: containerWidth / ratio,
+      } as Partial<typeof props>)
+    })
+  }, [heroMedia, modes, containerWidth])
 
   const processedChildren = useMemo(
     () =>
@@ -362,7 +417,7 @@ function FullscreenModal({
   }
 
   return (
-    <View style={[rootStyle, style]} testID={testID}>
+    <View style={[rootStyle, style]} testID={testID} onLayout={onContainerLayout}>
       {/*
        * Layout model:
        *  - `processedHeroMedia` is a ROOT-LEVEL full-bleed background pinned to
@@ -380,7 +435,17 @@ function FullscreenModal({
        */}
       {processedHeroMedia ? (
         <Animated.View
-          style={[heroBackgroundStyle, { transform: [{ translateY: heroTranslateY }] }]}
+          style={[
+            heroBackgroundStyle,
+            // Give the absolute wrapper a DEFINITE width (the measured modal
+            // width) so the media's `width: '100%'` + `aspectRatio` resolves to
+            // a true edge-to-edge fill with a ratio-derived height, top-aligned.
+            // Before the first layout pass `containerWidth` is 0 — fall back to
+            // stretching via `left/right: 0` so there is no flash of a mis-sized
+            // image.
+            containerWidth > 0 ? { width: containerWidth } : null,
+            { transform: [{ translateY: heroTranslateY }] },
+          ]}
           pointerEvents="none"
         >
           {processedHeroMedia}

package/src/components/Gauge/Gauge.tsx

@@ -5,6 +5,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
 import SupportText, { type SupportTextProps } from '../SupportText/SupportText'
+import type { Modes } from '../../design-tokens'
 
 type GaugeBaseProps = Omit<React.ComponentProps<typeof View>, 'children' | 'style'>
 
@@ -32,7 +33,7 @@ export type GaugeProps = GaugeBaseProps & {
   /** Hides default support text when no custom readout slot is provided. */
   showSupportText?: boolean
   /** Design token modes forwarded to token lookups and slot children. */
-  modes?: Record<string, any>
+  modes?: Modes
   /** Slot rendered in the center of the gauge arc. Receives `modes` recursively. */
   children?: React.ReactNode
   /** Container style override. */

package/src/components/HStack/HStack.tsx

@@ -3,6 +3,7 @@ import { View, StyleProp, ViewStyle, ViewProps } from 'react-native'
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { cloneChildrenWithModes, EMPTY_MODES } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 export interface HStackProps extends ViewProps {
     /**
@@ -35,7 +36,7 @@ export interface HStackProps extends ViewProps {
     /**
      * Modes object to override default variable values.
      */
-    modes?: Record<string, any>;
+    modes?: Modes;
 }
 
 /**

package/src/components/HoldingsCard/HoldingsCard.tsx

@@ -11,6 +11,7 @@ import {
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import Radio from '../Radio/Radio'
 import { EMPTY_MODES } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 export interface HoldingsCardDetailItem {
     label: string
@@ -33,7 +34,7 @@ export interface HoldingsCardProps {
     /** Called when the card is pressed (toggles selection). */
     onPress?: () => void
     /** Modes object for design-token resolution. */
-    modes?: Record<string, any>
+    modes?: Modes
     /** Custom style for the outer container. */
     style?: StyleProp<ViewStyle>
     /** Test ID for testing. */

package/src/components/Icon/Icon.tsx

@@ -10,6 +10,7 @@ import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
 import BaseIcon from '../../icons/Icon'
 import type { UnifiedSource } from '../../utils/MediaSource'
+import type { Modes } from '../../design-tokens'
 
 type IconProps = AccessibilityProps & {
   /**
@@ -43,7 +44,7 @@ type IconProps = AccessibilityProps & {
    * from the `icon/size` design token.
    */
   size?: number
-  modes?: Record<string, any>
+  modes?: Modes
   style?: StyleProp<ViewStyle>
 }
 
@@ -53,7 +54,7 @@ interface IconTokens {
   iconSize: number
 }
 
-function resolveIconTokens(modes: Record<string, any>): IconTokens {
+function resolveIconTokens(modes: Modes): IconTokens {
   const iconColor = (getVariableByName('icon/color', modes) || '#ad8444') as string
   const iconSize = (getVariableByName('icon/size', modes) || 18) as number
   const paddingLeft = (getVariableByName('icon/padding/left', modes) || 0) as number

package/src/components/IconButton/IconButton.tsx

@@ -14,6 +14,7 @@ import { EMPTY_MODES } from '../../utils/react-utils'
 import type { UnifiedSource } from '../../utils/MediaSource'
 import Skeleton from '../../skeleton/Skeleton'
 import { useSkeleton } from '../../skeleton/SkeletonGroup'
+import type { Modes } from '../../design-tokens'
 
 type IconButtonProps = SafePressableProps & {
   /** Built-in icon name from the registry (default state). */
@@ -26,7 +27,7 @@ type IconButtonProps = SafePressableProps & {
    * follows design tokens just like a built-in icon. See {@link UnifiedSource}.
    */
   source?: UnifiedSource;
-  modes?: Record<string, any>;
+  modes?: Modes;
   onPress?: () => void;
   disabled?: boolean;
   style?: StyleProp<ViewStyle>;
@@ -96,7 +97,7 @@ interface IconButtonTokens {
   iconSize: number;
 }
 
-function resolveIconButtonTokens(modes: Record<string, any>, disabled: boolean): IconButtonTokens {
+function resolveIconButtonTokens(modes: Modes, disabled: boolean): IconButtonTokens {
   const radiusRaw = (getVariableByName('iconButton/radius', modes) ?? 9999) as number
   const padding = (getVariableByName('iconButton/padding', modes) ?? 12) as number
   const backgroundColor = (getVariableByName('iconButton/background', modes) ?? '#cfa159') as string

package/src/components/IconCapsule/IconCapsule.tsx

@@ -5,6 +5,7 @@ import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES } from '../../utils/react-utils'
 import Icon from '../../icons/Icon'
 import type { UnifiedSource } from '../../utils/MediaSource'
+import type { Modes } from '../../design-tokens'
 
 type IconCapsuleProps = {
   iconName?: string;
@@ -17,7 +18,7 @@ type IconCapsuleProps = {
    * {@link UnifiedSource}.
    */
   source?: UnifiedSource;
-  modes?: Record<string, any>;
+  modes?: Modes;
   accessibilityLabel?: string;
   accessibilityRole?: string;
 } & React.ComponentProps<typeof View>;
@@ -28,7 +29,7 @@ interface IconCapsuleTokens {
   iconSize: number;
 }
 
-function resolveIconCapsuleTokens(modes: Record<string, any>): IconCapsuleTokens {
+function resolveIconCapsuleTokens(modes: Modes): IconCapsuleTokens {
   const size = (getVariableByName('iconCapsule/size', modes) || 42) as number
   const radiusRaw = (getVariableByName('iconCapsule/radius', modes) || 9999) as number
   const backgroundColor = (getVariableByName('iconCapsule/background', modes) || '#cfa159') as string

package/src/components/Image/Image.tsx

@@ -8,6 +8,8 @@ import {
   type ViewStyle,
   type ImageResizeMode,
 } from 'react-native'
+
+type ImageResizeMethod = 'auto' | 'resize' | 'scale' | 'none'
 import Skeleton from '../../skeleton/Skeleton'
 import { useSkeleton } from '../../skeleton/SkeletonGroup'
 
@@ -33,6 +35,21 @@ export type ImageProps = {
   ratio?: number | undefined
   /** How the image is fit inside its box. Defaults to `'cover'`. */
   resizeMode?: ImageResizeMode | undefined
+  /**
+   * (Android only) How the bitmap is resampled when the source resolution
+   * differs from the rendered box.
+   *
+   * RN's own default is `'auto'`, which for large source images silently picks
+   * `'resize'`: a pre-decode software downsample that DESTROYS detail and makes
+   * big hero/background images look soft/pixelated even when the asset is
+   * high-res. To avoid that, this component defaults to:
+   *   - `'none'` when an explicit `width` + `height` box is set (full-bleed
+   *     hero/background usage — full resolution, maximum sharpness), and
+   *   - `'scale'` otherwise (GPU scaling — high quality and memory-safe for
+   *     ordinary aspect-ratio images).
+   * Pass an explicit value to override. No-op on iOS/web.
+   */
+  resizeMethod?: ImageResizeMethod | undefined
   /**
    * Optional explicit width. If omitted and a `ratio` is set, the image
    * defaults to `width: '100%'` so it fills its parent.
@@ -96,6 +113,7 @@ function Image({
   imageSource,
   ratio = DEFAULT_RATIO,
   resizeMode = 'cover',
+  resizeMethod,
   width,
   height,
   borderRadius,
@@ -107,11 +125,16 @@ function Image({
 }: ImageProps) {
   const source = useMemo(() => normalizeSource(imageSource), [imageSource])
 
+  // Explicit { width, height } means a "fill an exact box" layout — typically a
+  // full-bleed hero/background where the asset is high-res and sharpness
+  // matters most. There, default to `'none'` (full-resolution, no pre-decode
+  // downsample) so detail is never thrown away. Aspect-ratio images keep the
+  // memory-safe `'scale'` default. A caller-supplied `resizeMethod` always wins.
+  const isExplicitBox = width != null && height != null
+  const effectiveResizeMethod: ImageResizeMethod =
+    resizeMethod ?? (isExplicitBox ? 'none' : 'scale')
+
   const layoutStyle: ImageStyle = useMemo(() => {
-    // If the caller has fully specified width AND height, they're doing a
-    // non-aspect layout (e.g. "fill the parent") — respect that and skip
-    // `aspectRatio` so it doesn't conflict.
-    const isExplicitBox = width != null && height != null
     const s: ImageStyle = {
       width: width ?? '100%',
       ...(isExplicitBox
@@ -120,7 +143,7 @@ function Image({
     }
     if (borderRadius != null) s.borderRadius = borderRadius
     return s
-  }, [ratio, width, height, borderRadius])
+  }, [ratio, width, height, borderRadius, isExplicitBox])
 
   const { active: groupActive } = useSkeleton()
   const isLoading = loading ?? groupActive
@@ -146,6 +169,7 @@ function Image({
       source={source}
       style={[layoutStyle, style]}
       resizeMode={resizeMode}
+      resizeMethod={effectiveResizeMethod}
       accessibilityLabel={accessibilityLabel}
       accessibilityElementsHidden={accessibilityElementsHidden}
       importantForAccessibility={importantForAccessibility}

package/src/components/InputSearch/InputSearch.tsx

@@ -4,6 +4,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { EMPTY_MODES } from '../../utils/react-utils'
 import Icon from '../../icons/Icon'
 import TextInput from '../TextInput/TextInput'
+import type { Modes } from '../../design-tokens'
 
 /**
  * SupportText component derived from Figma design.
@@ -15,7 +16,7 @@ type SupportTextProps = {
      * Defaults to 'ic_info'.
      */
     iconName?: string;
-    modes?: Record<string, any>;
+    modes?: Modes;
     style?: StyleProp<ViewStyle>;
 }
 
@@ -64,7 +65,7 @@ export type InputSearchProps = {
      * (e.g. 'ic_info', 'ic_cart'). Defaults to 'ic_info'.
      */
     supportTextIcon?: string;
-    modes?: Record<string, any>;
+    modes?: Modes;
     containerStyle?: StyleProp<ViewStyle>;
 
     // Props to pass through to TextInput

package/src/components/InstitutionBadge/InstitutionBadge.tsx

@@ -10,6 +10,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
 import MediaSource, { type UnifiedSource } from '../../utils/MediaSource'
+import type { Modes } from '../../design-tokens'
 
 // Default avatar asset (shared with the Avatar component) so that
 // InstitutionBadge has a sensible visual fallback when no `source` is
@@ -35,7 +36,7 @@ export type InstitutionBadgeProps = InstitutionBadgeBaseProps & {
   /** Slot replacing the default Avatar (e.g. for monogram avatars). Receives `modes` recursively. */
   avatarSlot?: React.ReactNode
   /** Design token modes forwarded to token lookups and the Avatar slot. */
-  modes?: Record<string, any>
+  modes?: Modes
   /** Container style override. */
   style?: StyleProp<ViewStyle>
   /** Label style override. */
@@ -77,7 +78,7 @@ const toFontWeight = (value: unknown, fallback: TextStyle['fontWeight']) => {
 }
 
 function resolveInstitutionBadgeTokens(
-  modes: Record<string, any>
+  modes: Modes
 ): InstitutionBadgeTokens {
   const gap = toNumber(getVariableByName('institutionBadge/gap', modes), 8)
 

package/src/components/LazyList/LazyList.tsx

@@ -2,10 +2,11 @@ import React from 'react'
 import { View, type StyleProp, type ViewStyle } from 'react-native'
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 type LazyListProps = {
   listGroupsSlot?: React.ReactNode;
-  modes?: Record<string, any>;
+  modes?: Modes;
   style?: StyleProp<ViewStyle>;
   accessibilityLabel?: string;
   accessibilityHint?: string;

package/src/components/LinearMeter/LinearMeter.tsx

@@ -4,10 +4,11 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { EMPTY_MODES } from '../../utils/react-utils'
 import MoneyValue from '../MoneyValue/MoneyValue'
 import LinearProgress from '../LinearProgress/LinearProgress'
+import type { Modes } from '../../design-tokens'
 
 type LinearMeterLabelProps = {
     children: React.ReactNode
-    modes?: Record<string, any>
+    modes?: Modes
     style?: StyleProp<TextStyle>
 } & React.ComponentProps<typeof Text>
 
@@ -41,7 +42,7 @@ const LinearMeterLabel = ({
 
 export type LinearMeterProps = {
     value?: number // 0 to 1
-    modes?: Record<string, any>
+    modes?: Modes
     style?: StyleProp<ViewStyle>
     trackStyle?: StyleProp<ViewStyle>
     indicatorStyle?: StyleProp<ViewStyle>

package/src/components/LinearProgress/LinearProgress.tsx

@@ -7,12 +7,13 @@ import {
 } from 'react-native'
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { EMPTY_MODES } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 export type LinearProgressProps = {
     /** Progress value between 0 and 1. Values are clamped. */
     value?: number
     /** Design token modes for theming */
-    modes?: Record<string, any>
+    modes?: Modes
     /** Override container styles (the track wrapper) */
     style?: StyleProp<ViewStyle>
     /** Override the track styles */

package/src/components/ListGroup/ListGroup.tsx

@@ -7,12 +7,13 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
  * This ensures that all child components in slots receive the modes prop from the parent.
  */
 import { EMPTY_MODES, cloneChildrenWithModes, flattenChildren } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 type ListGroupProps = {
   label?: string;
   listGroupSlot?: React.ReactNode;
   children?: React.ReactNode;
-  modes?: Record<string, any>;
+  modes?: Modes;
   style?: StyleProp<ViewStyle>;
   accessibilityLabel?: string;
   accessibilityHint?: string;

package/src/components/ListItem/ListItem.tsx

@@ -14,6 +14,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import NavArrow from '../NavArrow/NavArrow'
 import { usePressableWebSupport, type WebAccessibilityProps } from '../../utils/web-platform-utils'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 type ListItemProps = {
   layout?: 'Vertical' | 'Horizontal';
@@ -33,7 +34,7 @@ type ListItemProps = {
   endSlot?: React.ReactNode;
   /** Whether to show the NavArrow on the far right (Horizontal layout only). Defaults to true. */
   navArrow?: boolean;
-  modes?: Record<string, any>;
+  modes?: Modes;
   onPress?: () => void;
   style?: StyleProp<ViewStyle>;
   contentStyle?: StyleProp<ViewStyle>;
@@ -79,7 +80,7 @@ interface ListItemTokens {
   resolvedModes: Record<string, any>;
 }
 
-function resolveListItemTokens(modes: Record<string, any>): ListItemTokens {
+function resolveListItemTokens(modes: Modes): ListItemTokens {
   // Modes used to cascade into slot children (leading / supportSlot / trailing).
   // We do NOT inject an `AppearanceBrand` default here: slot content such as
   // Buttons or Badges carry their own intended appearance, so forcing one onto

package/src/components/LottieIntroBlock/LottieIntroBlock.tsx

@@ -10,6 +10,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import Button from '../Button/Button'
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils'
+import type { Modes } from '../../design-tokens'
 
 const DEFAULT_MEDIA_SIZE = 117
 
@@ -40,7 +41,7 @@ export type LottieIntroBlockProps = {
    */
   buttonSlot?: React.ReactNode
   /** Mode configuration for design-token theming. */
-  modes?: Record<string, any>
+  modes?: Modes
   /** Style overrides applied to the outer container. */
   style?: StyleProp<ViewStyle>
   testID?: string

package/src/components/LottiePlayer/LottiePlayer.tsx

@@ -4,6 +4,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES } from '../../utils/react-utils'
 import { getNativeLottieView } from './loadNativeLottieView'
+import type { Modes } from '../../design-tokens'
 
 /**
  * A parsed Lottie animation. The JSON object you get from
@@ -39,7 +40,7 @@ export type LottiePlayerProps = {
   /** Loop the animation. Defaults to `true`. */
   loop?: boolean
   /** Mode configuration for design-token theming. */
-  modes?: Record<string, any>
+  modes?: Modes
   /** Style overrides applied to the underlying view. */
   style?: StyleProp<ViewStyle>
   /** Accessibility label. Lottie is decorative by default. */
@@ -51,7 +52,7 @@ const DEFAULT_SIZE = 117
 
 function resolveSize(
   size: LottiePlayerProps['size'],
-  modes: Record<string, any>
+  modes: Modes
 ) {
   if (typeof size === 'number') return { width: size, height: size }
   if (size && typeof size === 'object') return size

package/src/components/LottiePlayer/LottiePlayer.web.tsx

@@ -4,6 +4,7 @@ import { getVariableByName } from '../../design-tokens/figma-variables-resolver'
 import { useTokens } from '../../design-tokens/JFSThemeProvider'
 import { EMPTY_MODES } from '../../utils/react-utils'
 import { getWebLottieView } from './loadWebLottieView'
+import type { Modes } from '../../design-tokens'
 
 export type LottieAnimationSource = Record<string, unknown>
 
@@ -12,7 +13,7 @@ export type LottiePlayerProps = {
   size?: number | { width: number; height: number }
   autoPlay?: boolean
   loop?: boolean
-  modes?: Record<string, any>
+  modes?: Modes
   style?: StyleProp<ViewStyle>
   accessibilityLabel?: string
   testID?: string
@@ -22,7 +23,7 @@ const DEFAULT_SIZE = 117
 
 function resolveSize(
   size: LottiePlayerProps['size'],
-  modes: Record<string, any>
+  modes: Modes
 ) {
   if (typeof size === 'number') return { width: size, height: size }
   if (size && typeof size === 'object') return size

package/src/components/LottiePlayer/loadNativeLottieView.tsx

@@ -14,17 +14,6 @@ const INSTALL_HINT =
   '  npm install lottie-react-native\n' +
   '  cd ios && pod install'
 
-/**
- * Metro resolves `require('lottie-react-native')` at bundle time even inside
- * try/catch, which breaks apps that import `jfs-components` without having
- * the optional peer installed. Splitting the module id into a runtime string
- * keeps Metro from statically linking it — the native module is loaded only
- * when present in the consumer's node_modules.
- */
-function resolveNativeLottieModuleName() {
-  return ['lottie', '-react', '-native'].join('')
-}
-
 function LottieUnavailableView({ style }: Pick<NativeLottieViewProps, 'style'>) {
   if (__DEV__) {
     return (
@@ -75,10 +64,17 @@ export function getNativeLottieView(): React.ComponentType<NativeLottieViewProps
   if (cachedView !== undefined) return cachedView
 
   try {
-    const mod = require(resolveNativeLottieModuleName()) as {
+    // Static require so Metro resolves the module by its build-time numeric id.
+    // A runtime-constructed string path is NOT resolvable by Metro's `require`
+    // (it indexes modules by number, not path), so it would always throw and
+    // fall back to the install hint even when the package is installed. The
+    // dependency stays an *optional* peer: apps that use LottiePlayer install
+    // it; apps that don't simply never import this module.
+    const mod = require('lottie-react-native') as {
       default?: React.ComponentType<NativeLottieViewProps>
+      LottieView?: React.ComponentType<NativeLottieViewProps>
     }
-    cachedView = mod.default ?? LottieUnavailable
+    cachedView = mod.default ?? mod.LottieView ?? LottieUnavailable
   } catch {
     cachedView = LottieUnavailable
   }