jfs-components 0.0.95 → 0.0.99

package/lib/commonjs/skeleton/Skeleton.js

@@ -21,12 +21,20 @@ const SOLID_OVERLAY_COLOR = 'rgba(255, 255, 255, 1)';
 // `pointerEvents: 'none'` lives on the style (not the deprecated prop) so it
 // works on both native and React Native Web without warnings.
 const absoluteFillStyle = {
-  ..._reactNative.StyleSheet.absoluteFillObject,
+  position: 'absolute',
+  top: 0,
+  left: 0,
+  right: 0,
+  bottom: 0,
   overflow: 'hidden',
   pointerEvents: 'none'
 };
 const solidOverlayStyle = {
-  ..._reactNative.StyleSheet.absoluteFillObject,
+  position: 'absolute',
+  top: 0,
+  left: 0,
+  right: 0,
+  bottom: 0,
   backgroundColor: SOLID_OVERLAY_COLOR
 };
 

package/lib/module/components/Drawer/Drawer.js

@@ -1,8 +1,8 @@
 "use strict";
 
-import React, { useCallback, useEffect, useState, useRef } from 'react';
+import React, { forwardRef, useCallback, useEffect, useImperativeHandle, useRef, useState } from 'react';
 import { Platform, StyleSheet, Text, useWindowDimensions, View } from 'react-native';
-import { Gesture, GestureDetector, GestureHandlerRootView, ScrollView } from 'react-native-gesture-handler';
+import { Gesture, GestureDetector, ScrollView } from 'react-native-gesture-handler';
 import Animated, { runOnJS, useAnimatedProps, useAnimatedScrollHandler, useAnimatedStyle, useSharedValue, withSpring } from 'react-native-reanimated';
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver';
 import { EMPTY_MODES } from '../../utils/react-utils';
@@ -40,11 +40,17 @@ function rubberBand(value, min, max, friction = 0.55) {
   }
   return value;
 }
+
+/**
+ * Imperative handle exposed via `ref` for programmatic control of the drawer.
+ * Each method animates using the same spring as gesture-driven transitions.
+ */
+
 /**
  * Drawer component with nested scrolling support.
  * Uses react-native-gesture-handler and react-native-reanimated.
  */
-function Drawer({
+function DrawerInner({
   modes = EMPTY_MODES,
   style,
   title,
@@ -53,6 +59,7 @@ function Drawer({
   collapsedHeight = 200,
   expandedRatio = 0.90,
   initialState = 'collapsed',
+  state,
   contentStyle,
   sheetStyle,
   accessibilityLabel,
@@ -61,7 +68,7 @@ function Drawer({
   showsVerticalScrollIndicator = false,
   bottomInset = 80,
   onStateChange
-}) {
+}, ref) {
   const {
     height: screenHeight
   } = useWindowDimensions();
@@ -123,15 +130,58 @@ function Drawer({
     translateY.value = withSpring(destination, SPRING_CONFIG);
   }, [translateY]);
 
-  // Update JS state for accessibility/logic if needed
+  // Update the JS-side mode. Pure: only schedules the state update. Side
+  // effects (notifying the parent via onStateChange) MUST NOT live inside the
+  // setState updater — doing so calls the parent's setState during React's
+  // render phase, which throws "Cannot update a component while rendering a
+  // different component" and causes an infinite update loop. We report changes
+  // from a dedicated effect below instead.
   const updateMode = useCallback(newMode => {
-    setMode(prev => {
-      if (prev !== newMode) {
-        onStateChange?.(newMode);
-      }
-      return newMode;
-    });
-  }, [onStateChange]);
+    setMode(newMode);
+  }, []);
+
+  // Notify the parent exactly once per settled mode change, after commit.
+  const reportedModeRef = useRef(mode);
+  useEffect(() => {
+    if (reportedModeRef.current !== mode) {
+      reportedModeRef.current = mode;
+      onStateChange?.(mode);
+    }
+  }, [mode, onStateChange]);
+
+  // Programmatic transition (JS thread). Reuses the same spring as gestures:
+  // animates `translateY`, keeps the scroll-gate (`isFullyExpanded`) in sync,
+  // and updates `mode` (which notifies via the onStateChange effect above).
+  const applyMode = useCallback(newMode => {
+    const target = newMode === 'expanded' ? minTranslateY : maxTranslateY;
+    translateY.value = withSpring(target, SPRING_CONFIG);
+    isFullyExpanded.value = newMode === 'expanded';
+    setMode(newMode);
+  }, [minTranslateY, maxTranslateY, translateY, isFullyExpanded]);
+
+  // Controlled mode: react ONLY to genuine changes of the `state` prop, tracked
+  // against its previous value. We must NOT reconcile `state` against the
+  // internal `mode` on every render: a gesture updates `mode` optimistically
+  // one render before the parent echoes it back through `onStateChange` into
+  // `state`, so a `state !== mode` check would "correct" the gesture and fight
+  // the echo, ping-ponging forever (Maximum update depth exceeded).
+  // `applyMode` is idempotent, so re-applying the already-current mode is a
+  // no-op when the parent simply mirrors our own change back.
+  const prevStateProp = useRef(state);
+  useEffect(() => {
+    if (state === undefined) return;
+    if (state === prevStateProp.current) return;
+    prevStateProp.current = state;
+    applyMode(state);
+  }, [state, applyMode]);
+
+  // Imperative API for parents holding a ref.
+  useImperativeHandle(ref, () => ({
+    expand: () => applyMode('expanded'),
+    collapse: () => applyMode('collapsed'),
+    toggle: () => applyMode(mode === 'expanded' ? 'collapsed' : 'expanded'),
+    getState: () => mode
+  }), [applyMode, mode]);
 
   // Gesture policy:
   //  • activeOffsetY: require a clear *vertical* drag (10px) before this
@@ -304,84 +354,96 @@ function Drawer({
     default: {}
   });
   const defaultAccessibilityLabel = accessibilityLabel || title || 'Drawer';
-  return /*#__PURE__*/_jsx(GestureHandlerRootView, {
-    style: [styles.host, style],
-    pointerEvents: "box-none",
-    children: /*#__PURE__*/_jsx(GestureDetector, {
-      gesture: gesture,
-      children: /*#__PURE__*/_jsx(Animated.View, {
-        style: [styles.sheet, {
-          // Constraint the height strictly to the expanded height
-          // This ensures the ScrollView has a finite frame to scroll within
-          height: expandedHeight,
-          backgroundColor,
-          borderTopLeftRadius: radius,
-          borderTopRightRadius: radius
-        }, shadowStyle, sheetStyle, animatedStyle],
-        accessible: true,
-        ...(Platform.OS === 'web' ? {
-          accessibilityRole: 'dialog'
-        } : undefined),
-        accessibilityLabel: undefined,
-        accessibilityHint: accessibilityHint || 'Swipe up to expand, swipe down to collapse',
-        children: /*#__PURE__*/_jsxs(View, {
-          style: [styles.sheetInner, {
+  return (
+    /*#__PURE__*/
+    // IMPORTANT: the host is a plain box-none View, NOT a GestureHandlerRootView.
+    // On Android, GestureHandlerRootView renders a *native* root view that
+    // intercepts every touch within its bounds (to feed the gesture system) and
+    // does NOT honor pointerEvents="box-none". Because this host fills the whole
+    // screen as an overlay, using GestureHandlerRootView here swallowed all
+    // touches to content rendered behind the drawer (buttons, page content).
+    // Per the standard react-native-gesture-handler architecture, a single
+    // GestureHandlerRootView must wrap the app root; this overlay only needs to
+    // let touches fall through where the sheet isn't.
+    _jsx(View, {
+      style: [styles.host, style],
+      pointerEvents: "box-none",
+      children: /*#__PURE__*/_jsx(GestureDetector, {
+        gesture: gesture,
+        children: /*#__PURE__*/_jsx(Animated.View, {
+          style: [styles.sheet, {
+            // Constraint the height strictly to the expanded height
+            // This ensures the ScrollView has a finite frame to scroll within
+            height: expandedHeight,
+            backgroundColor,
             borderTopLeftRadius: radius,
-            borderTopRightRadius: radius,
-            paddingLeft,
-            paddingRight,
-            paddingBottom,
-            rowGap: drawerGap
-          }],
-          children: [/*#__PURE__*/_jsx(View, {
-            style: [styles.handleArea, !title && !header && {
-              paddingBottom: 0
+            borderTopRightRadius: radius
+          }, shadowStyle, sheetStyle, animatedStyle],
+          accessible: true,
+          ...(Platform.OS === 'web' ? {
+            accessibilityRole: 'dialog'
+          } : undefined),
+          accessibilityLabel: undefined,
+          accessibilityHint: accessibilityHint || 'Swipe up to expand, swipe down to collapse',
+          children: /*#__PURE__*/_jsxs(View, {
+            style: [styles.sheetInner, {
+              borderTopLeftRadius: radius,
+              borderTopRightRadius: radius,
+              paddingLeft,
+              paddingRight,
+              paddingBottom,
+              rowGap: drawerGap
             }],
-            children: /*#__PURE__*/_jsx(View, {
+            children: [/*#__PURE__*/_jsx(View, {
+              style: [styles.handleArea, !title && !header && {
+                paddingBottom: 0
+              }],
+              children: /*#__PURE__*/_jsx(View, {
+                style: [{
+                  backgroundColor: handleColor,
+                  width: handleWidth,
+                  height: handleHeight,
+                  borderRadius: handleRadius
+                }]
+              })
+            }), header, title && /*#__PURE__*/_jsx(Text, {
               style: [{
-                backgroundColor: handleColor,
-                width: handleWidth,
-                height: handleHeight,
-                borderRadius: handleRadius
-              }]
-            })
-          }), header, title && /*#__PURE__*/_jsx(Text, {
-            style: [{
-              color: titleColor,
-              fontSize: titleSize,
-              fontWeight: titleWeight,
-              lineHeight: titleLineHeight,
-              marginBottom: titlePaddingBottom
-            }],
-            children: title
-          }), /*#__PURE__*/_jsx(AnimatedScrollView, {
-            ref: scrollRef,
-            style: [styles.content, contentStyle],
-            contentContainerStyle: [{
-              paddingBottom: paddingBottom + bottomInset,
-              gap: drawerGap,
-              flexDirection: 'column',
-              alignItems: 'stretch'
-            }, contentContainerStyle],
-            showsVerticalScrollIndicator: showsVerticalScrollIndicator
-            // Let a tap on an input inside the sheet focus it on the FIRST tap
-            // even while the keyboard is already open (default 'never' would
-            // eat that tap just to dismiss the keyboard).
-            ,
-            keyboardShouldPersistTaps: "handled",
-            animatedProps: animatedScrollProps,
-            alwaysBounceVertical: false,
-            overScrollMode: "always",
-            onScroll: useAnimatedScrollHandler(event => {
-              scrollY.value = event.contentOffset.y;
-            }),
-            scrollEventThrottle: 16,
-            children: children
-          })]
+                color: titleColor,
+                fontSize: titleSize,
+                fontWeight: titleWeight,
+                lineHeight: titleLineHeight,
+                marginBottom: titlePaddingBottom
+              }],
+              children: title
+            }), /*#__PURE__*/_jsx(AnimatedScrollView, {
+              ref: scrollRef,
+              style: [styles.content, contentStyle],
+              contentContainerStyle: [{
+                paddingBottom: paddingBottom + bottomInset,
+                gap: drawerGap,
+                flexDirection: 'column',
+                alignItems: 'stretch'
+              }, contentContainerStyle],
+              showsVerticalScrollIndicator: showsVerticalScrollIndicator
+              // Let a tap on an input inside the sheet focus it on the FIRST tap
+              // even while the keyboard is already open (default 'never' would
+              // eat that tap just to dismiss the keyboard).
+              ,
+              keyboardShouldPersistTaps: "handled",
+              animatedProps: animatedScrollProps,
+              alwaysBounceVertical: false,
+              overScrollMode: "always",
+              onScroll: useAnimatedScrollHandler(event => {
+                scrollY.value = event.contentOffset.y;
+              }),
+              scrollEventThrottle: 16,
+              children: children
+            })]
+          })
         })
       })
     })
-  });
+  );
 }
 const styles = StyleSheet.create({
   host: {
@@ -411,4 +473,6 @@ const styles = StyleSheet.create({
     flex: 1
   }
 });
+const Drawer = /*#__PURE__*/forwardRef(DrawerInner);
+Drawer.displayName = 'Drawer';
 export default Drawer;

package/lib/module/components/FullscreenModal/FullscreenModal.js

@@ -2,6 +2,7 @@
 
 import React, { useMemo, useRef } from 'react';
 import { View, Text, Animated } from 'react-native';
+import { useSafeAreaInsets } from 'react-native-safe-area-context';
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver';
 import { useTokens } from '../../design-tokens/JFSThemeProvider';
 import { EMPTY_MODES, cloneChildrenWithModes } from '../../utils/react-utils';
@@ -212,6 +213,24 @@ function FullscreenModal({
   }), [globalModes, propModes]);
   const rootGap = Number(getVariableByName('fullScreenModal/gap', modes)) || 16;
 
+  // Safe-area insets so the floating chrome clears the system bars: the close
+  // button drops below the status bar / notch, and the sticky footer keeps its
+  // designed bottom padding ON TOP of the bottom inset (home indicator /
+  // Android gesture or nav bar). On web — and anywhere without a
+  // SafeAreaProvider — every inset is 0, so the layout is unchanged.
+  const insets = useSafeAreaInsets();
+  const closeButtonInsetStyle = useMemo(() => ({
+    top: 12 + insets.top
+  }), [insets.top]);
+  // Extend (not replace) the footer's token bottom padding by the bottom inset
+  // so the action button never sits under the system navigation area.
+  const footerInsetStyle = useMemo(() => {
+    const base = Number(getVariableByName('actionFooter/padding/bottom', modes)) || 41;
+    return {
+      paddingBottom: base + insets.bottom
+    };
+  }, [modes, insets.bottom]);
+
   // Drives the background's parallax-free sync with the scroll. The hero media
   // lives at the ROOT (so it is never clipped to the content height and sits
   // behind the transparent footer), but we translate it up by the exact scroll
@@ -311,12 +330,13 @@ function FullscreenModal({
       })
     }), footerContent ? /*#__PURE__*/_jsx(ActionFooter, {
       modes: modes,
+      style: footerInsetStyle,
       children: footerContent
     }) : null, showClose ? /*#__PURE__*/_jsx(IconButton, {
       iconName: "ic_close",
       modes: modes,
       accessibilityLabel: closeAccessibilityLabel,
-      style: closeButtonStyle,
+      style: [closeButtonStyle, closeButtonInsetStyle],
       ...(onClose ? {
         onPress: onClose
       } : {})

package/lib/module/components/Spinner/Spinner.js

@@ -1,7 +1,7 @@
 "use strict";
 
 import React, { useEffect } from 'react';
-import { StyleSheet, View } from 'react-native';
+import { View } from 'react-native';
 import Animated, { Easing, cancelAnimation, useAnimatedStyle, useSharedValue, withRepeat, withTiming } from 'react-native-reanimated';
 import Svg, { Path } from 'react-native-svg';
 import { getVariableByName } from '../../design-tokens/figma-variables-resolver';
@@ -115,7 +115,11 @@ const useSegmentRotation = (clock, index, gravity, spreadMinRad, spreadMaxRad, s
   };
 }, [gravity, index, spreadMinRad, spreadMaxRad, spreadOutFrac]);
 const fullSize = {
-  ...StyleSheet.absoluteFillObject
+  position: 'absolute',
+  top: 0,
+  left: 0,
+  right: 0,
+  bottom: 0
 };
 function Spinner({
   size = DEFAULT_SIZE,